From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7346EB64DC for ; Tue, 11 Jul 2023 16:09:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41C2D6B0072; Tue, 11 Jul 2023 12:09:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A4FC6B0074; Tue, 11 Jul 2023 12:09:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21F176B0075; Tue, 11 Jul 2023 12:09:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 11AB46B0072 for ; Tue, 11 Jul 2023 12:09:43 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D5749140121 for ; Tue, 11 Jul 2023 16:09:42 +0000 (UTC) X-FDA: 80999816604.14.F784923 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 6A76F40040 for ; Tue, 11 Jul 2023 16:09:13 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IQyskvgk; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689091753; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=umkcJ7EHwt2K7xQH+7rgCPxJb1wTiMjAEmnl2Bw6jVc=; b=q4CTg+W8liGxXxaDv4EoFCGj8WNHmAlJT9ctbz6ijOgiJIp/cpsRy5EXjY+epqbEpd0Eqn svJt5AsWeNWzJvTQymSYz1kLyPqFMEfYZifCJ2EuwYPCzX6oVrIITf7y9aRzoBKjOIgTi/ i7lnLWz8EKrzptNTGH8jTCKAT4n2d0E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689091753; a=rsa-sha256; cv=none; b=dCnALguspQIYK8LsRVyJPZ1c6xWWmD88ByOJQ7UuvOCkbyezSw8ohfuCK22rQj5mECgMbO 19ZYl8R4WNK95VTGgG383k6qmhTsrwEUmiJZiVzk427NlIqpsvi9BC1FUAJziadQEJtKDf 9nNMbRRfnm8cmgS5npXPBw4sQLQpE2g= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IQyskvgk; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689091752; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=umkcJ7EHwt2K7xQH+7rgCPxJb1wTiMjAEmnl2Bw6jVc=; b=IQyskvgk+TJ9odBgV4PoS3ih0QTprJsYEJ509jUGy8O6mMLU8MRBZwd77eZApcw8fR5BBW +TL9ij89Mc5ama713T/gVjUea2oALQk3htrcpf5oQBnZTF/auYVkjaDEAcc5xDG+psgf5L OUg/QncWC1o4GRWCyzlfwGJOO9dqLKI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-215-FfvIcG01Ml-3axCa80dc-A-1; Tue, 11 Jul 2023 12:09:09 -0400 X-MC-Unique: FfvIcG01Ml-3axCa80dc-A-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-31444df0fafso3489358f8f.2 for ; Tue, 11 Jul 2023 09:09:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689091748; x=1691683748; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=umkcJ7EHwt2K7xQH+7rgCPxJb1wTiMjAEmnl2Bw6jVc=; b=Y28Vbo3QBahmD0BBFwxey6jUyzaYfVt/541ROdySuvGacYwAd9TJOdWpK6eiAPXoF+ A/Z+82s1FL49er09fvcgvQmHpmjvD5/VYxO6OpsM4P/ClQZMt9S+6AWdME4/zCkhtm4u xfUzjTXXf8T7AugYaGoyR63SXn2EuMStpmD27yH3j+/ou/PEfluMCOLdGLBkm/gBXL+B rwVC2ogS+jKs3XZTNFDVwCpRyNMQMgisvL8EhnHgLLdFBq6l28BZIxkTwhhYUizzERw7 gNwWkynPH2HYDR5iyX+WL50wyIb3h6N3Djlk9TRhewfOa7vFjo5mXl4w1wra6tZbwxJr eElA== X-Gm-Message-State: ABy/qLYtdpFP053XNZhl1wPqToN9Rnwmd/7uH04LIPfjLDD1N8QJzUtn qua+Z/vzpkKPppuwDTJrJvjrZR6GoeO9zoD+xm9cXYDadYAa0J1h8iuKKoxJcJBqjompcwXgFqy 7fSkWqGt2ZXw= X-Received: by 2002:adf:d846:0:b0:314:336e:d4d8 with SMTP id k6-20020adfd846000000b00314336ed4d8mr17240929wrl.8.1689091748184; Tue, 11 Jul 2023 09:09:08 -0700 (PDT) X-Google-Smtp-Source: APBJJlEdPeVjm53/XCqVXuqmk3mM3+L4O8aFXfW45Ayxu4HjfzUDwyCTqA+mWjFo6tMPf1xCqLyyuw== X-Received: by 2002:adf:d846:0:b0:314:336e:d4d8 with SMTP id k6-20020adfd846000000b00314336ed4d8mr17240904wrl.8.1689091747776; Tue, 11 Jul 2023 09:09:07 -0700 (PDT) Received: from ?IPV6:2003:cb:c745:4000:13ad:ed64:37e6:115d? (p200300cbc745400013aded6437e6115d.dip0.t-ipconnect.de. [2003:cb:c745:4000:13ad:ed64:37e6:115d]) by smtp.gmail.com with ESMTPSA id o4-20020a5d4084000000b003142c85fbcdsm2676065wrp.11.2023.07.11.09.09.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jul 2023 09:09:07 -0700 (PDT) Message-ID: <641a4276-cfb9-bd1b-36a8-cb4bcae408f6@redhat.com> Date: Tue, 11 Jul 2023 18:09:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 3/7] mm/hotplug: Allow architecture to override memmap on memory support check To: Aneesh Kumar K V , linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, christophe.leroy@csgroup.eu Cc: Oscar Salvador , Michal Hocko , Vishal Verma References: <20230711044834.72809-1-aneesh.kumar@linux.ibm.com> <20230711044834.72809-4-aneesh.kumar@linux.ibm.com> <6f6764f6-4b5a-dfa8-c409-ba4f2828891f@redhat.com> <176cee16-f926-ab3b-92fe-98bebf79d43d@linux.ibm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <176cee16-f926-ab3b-92fe-98bebf79d43d@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 6A76F40040 X-Rspam-User: X-Stat-Signature: ifzmi4wkytx6muxo1kuur87zqgwdybrj X-Rspamd-Server: rspam03 X-HE-Tag: 1689091753-194781 X-HE-Meta: U2FsdGVkX19yVy2KgoPGFbrtRDsD9YhBDORMSbgy6CehmcMW70aad9/IBTzwIZFHyYk41sV5yrgBIpA1PTtxNjMxLs8O3ZP2OKuxRB2xBRxMW7URVlFL/COpcmXy+RLRhTY1vs5ib7mkD3HQIS0zj7/9UElZ2ioRXLcMkZGte/1dFHnGrH4DY4mps6VHnCleI4lh+6/S/fbUGv0JTUcMI/Ghquaci7FGC3XZ8Stfvda1svZrc4ItpOxZIK553V4yOFEktzlc1sdiceTGD79oGG4IiMN3QaIJt9HtnEiJz6pjmwVcNtEkdf4EkXR+DCVReWMDiG/7XRIEwvoyu+qYt+fj3a9AeQjbXWkw60JkcDI3gJP9l2UH9MFTplU+Ozz27t2Asme07EPF2kP/SyogyWS8oCsT7X8XhXuR+9zfd7/6JrJjISaGacj4av62in3pm23nCjIYUMRLf/XU/mmnu7oWpBkqjbYB83H/se357Mb6+WWtLfaMgLzq/5lM7F1JWcC5BempQbaNAtGwgQJqrkoFYt4nIMaBUlu50/YkebwuDH5q9a6x8IqPo6TxkvZnw9s6G3NK8aLQ7OafGvdP/BopWQ7siCBspo1evumLj1QMXGz1F29GEItnQtz28JtEtmSmRYhJzdtYMQLZKMGS+niWoNo8JKtxtCEvIvq4UfJkU0Hpui/Qq35ZBV14BQHm2ERIVXb9mrjvPKjKVNfkex4QpSaHuwZqaNdl5QbVMcEGKne7GdebtbRmlZzrQMwQO6iZ65YGeF9be0x0vZeWq73sX2jH9zu7edIOBZvXoa3ufjq7BGTvXn+1KkcJv65np9gKhDN04yr4eROTfQBbdDu2x5MkLoH1iALbcNwsmfeaheYSdUct8ip0IE1u1YMNUh84+UQ4jKfZeB7uYW//gY+wee6w9rh6bH4XdlJSjJ4hH/pcItyFebN4xUCAPViVrXuKoA+T+wG24Q7kB1n kGmnhKkH ZLoqbxeDuf2sxFJfvFT0obqp6L0lbcmJnxZH1yWbdYWbnrzcDA/X2eQ++mUvgZxQRrQDp4Dt2Ax/xXQ5097MUmcLr8IbBnpYdg19AQ6GwKtdss8gE/R26CupzTctpbDWxppDhLQxPffvAL1tAIj7uaFoVaJF7HdtHI9Yej9A/xyK//HOtHX7nirqb+xlZnTIuvO9TM0vEmKvyRlioVds1Hd0cFoa4VlbHFAwEarprNzjQCpN/QUbz2NwihjYy5QfFSNeGdMjzjCuQmknoCOCXHQnSXzKNmw3RLc/SZND50a7WbvB/oAr3ByHOiw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.07.23 18:07, Aneesh Kumar K V wrote: > On 7/11/23 4:06 PM, David Hildenbrand wrote: >> On 11.07.23 06:48, Aneesh Kumar K.V wrote: >>> Some architectures would want different restrictions. Hence add an >>> architecture-specific override. >>> >>> Both the PMD_SIZE check and pageblock alignment check are moved there. >>> >>> Signed-off-by: Aneesh Kumar K.V >>> --- >>>   mm/memory_hotplug.c | 17 ++++++++++++----- >>>   1 file changed, 12 insertions(+), 5 deletions(-) >>> >>> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >>> index 1b19462f4e72..07c99b0cc371 100644 >>> --- a/mm/memory_hotplug.c >>> +++ b/mm/memory_hotplug.c >>> @@ -1247,12 +1247,20 @@ static int online_memory_block(struct memory_block *mem, void *arg) >>>       return device_online(&mem->dev); >>>   } >>>   -static bool mhp_supports_memmap_on_memory(unsigned long size) >>> +#ifndef arch_supports_memmap_on_memory >> >> Can we make that a __weak function instead? > > > We can. It is confusing because we do have these two patterns within the kernel where we use > > #ifndef x > #endif > > vs > > __weak x > > What is the recommended way to override ? I have mostly been using #ifndef for most of the arch overrides till now. > I think when placing the implementation in a C file, it's __weak. But don't ask me :) We do this already for arch_get_mappable_range() in mm/memory_hotplug.c and IMHO it looks quite nice. -- Cheers, David / dhildenb