From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B22DAC433F5 for ; Thu, 14 Oct 2021 07:22:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5F9B360FDA for ; Thu, 14 Oct 2021 07:22:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5F9B360FDA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id EF522940022; Thu, 14 Oct 2021 03:22:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA44D94001C; Thu, 14 Oct 2021 03:22:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D93E3940022; Thu, 14 Oct 2021 03:22:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id C9D3B94001C for ; Thu, 14 Oct 2021 03:22:54 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 875B7181BCDBD for ; Thu, 14 Oct 2021 07:22:54 +0000 (UTC) X-FDA: 78694201068.04.B4B19B9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id EDF94B000185 for ; Thu, 14 Oct 2021 07:22:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634196173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kHcFBMxXEj4gQtebrr/FX+9RNlxk3znvBGKf36PqXtU=; b=W9cWnZRiR97LyCI30n9k+c8UwuNoGYzj/QvuqB+/NFCl4fNL0cr1xTy2mD24Awvqotn8uW 8dT6SRwPAmd67A/dRE9/jVZFuU9FtqNbGX30IIQ/ZRmNd4hisHQpnDE8mfllCgwuNx5Kvr FlQRG3NtbkIcNUXSFLwP6R+suy2jF8o= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-57-H6SOmqzENwiWZ9lmXA5i7Q-1; Thu, 14 Oct 2021 03:22:52 -0400 X-MC-Unique: H6SOmqzENwiWZ9lmXA5i7Q-1 Received: by mail-wr1-f72.google.com with SMTP id j19-20020adfb313000000b00160a9de13b3so3847327wrd.8 for ; Thu, 14 Oct 2021 00:22:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=kHcFBMxXEj4gQtebrr/FX+9RNlxk3znvBGKf36PqXtU=; b=7Wy+wEt/UaNAMmZY+isOweRy9tXaTbKAqtRP7MDLZjCL93MTHtZryNX/97WFr3OUAd CJ6iJ6SqVzvh3Lkmgvd637AiJ8//IO2wOJPOTjqwyXw8suUYPmbKHxazytJ+ZjHY074r VU32Jma5pFwAYRT7jDigkK8qoGfnCH567PXFm3rOTppDvRSt6dtCWCV2QbNkfM9hOn9M Xj84AOqHQecVCjZTuPZ2DgHClVnJjFNxcRLGoBuSm30q59Vk6y+AlFAPjNdQZ5mNNse2 Kbm2lOCGkmU56gJlQkzA5NvmRMzAumSVfEPsXisrT5kEXuxXuID2lgQzwGXk4pSm4jY1 Qqqw== X-Gm-Message-State: AOAM530GUXIxjWNXoVuSwPkbJCsbVU0YuxBO+p0PgB7wcj6+b4HilW4G EfnxpyyGDjrkh9Ml/rLq88I6V2z49DHCQ781Bs9YH4Pbxb6CS92j06drV+LFQB0Hzw6V/gv1qJM GrbAjH4idCCg= X-Received: by 2002:adf:a1d3:: with SMTP id v19mr4894551wrv.268.1634196171481; Thu, 14 Oct 2021 00:22:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKgtAl6WuzA6b7U/Gu0v0IdejF+vRj1cUe73lne1ZL1KOhTQKOLLM1jmflLE2twyZP5k+KYw== X-Received: by 2002:adf:a1d3:: with SMTP id v19mr4894528wrv.268.1634196171252; Thu, 14 Oct 2021 00:22:51 -0700 (PDT) Received: from [192.168.3.132] (p5b0c694e.dip0.t-ipconnect.de. [91.12.105.78]) by smtp.gmail.com with ESMTPSA id z1sm1623191wrt.94.2021.10.14.00.22.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Oct 2021 00:22:50 -0700 (PDT) Message-ID: <64195d6f-09e3-9ab6-bcb2-d68a79665fcf@redhat.com> Date: Thu, 14 Oct 2021 09:22:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v3] mm: page_alloc: Add debug log in free_reserved_area for static memory To: Faiyaz Mohammed , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: guptap@codeaurora.org References: <1634195564-14048-1-git-send-email-faiyazm@codeaurora.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <1634195564-14048-1-git-send-email-faiyazm@codeaurora.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EDF94B000185 X-Stat-Signature: b9ka8pgc4hydby338waibaim4mei669r Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W9cWnZRi; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf25.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam02 X-HE-Tag: 1634196172-926868 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 14.10.21 09:12, Faiyaz Mohammed wrote: > For INITRD and initmem memory is reserved through "memblock_reserve" > during boot up but it is free via "free_reserved_area" instead > of "memblock_free". > For example: > [ 0.294848] Freeing initrd memory: 12K. > [ 0.696688] Freeing unused kernel memory: 4096K. > > To get the start and end address of the above freed memory and to account > proper memblock added pr_debug log in "free_reserved_area". > After adding log: > [ 0.294837] 0x00000083600000-0x00000083603000 free_initrd_mem+0x20/0x28 > [ 0.294848] Freeing initrd memory: 12K. > [ 0.695246] 0x00000081600000-0x00000081a00000 free_initmem+0x70/0xc8 > [ 0.696688] Freeing unused kernel memory: 4096K. > > Signed-off-by: Faiyaz Mohammed > --- > changes in v3: > - Update the format specifier. > changes in v2: > - To avoid confusion, remove the memblock_dbg print and drop the > memblock_free string, now using pr_debug to print the address ranges. > > mm/page_alloc.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index b37435c..13adda5 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -8097,6 +8097,8 @@ EXPORT_SYMBOL(adjust_managed_page_count); > > unsigned long free_reserved_area(void *start, void *end, int poison, const char *s) > { > + const phys_addr_t pstart = __pa(start); > + const phys_addr_t pend = __pa(end); > void *pos; > unsigned long pages = 0; > > @@ -8125,9 +8127,12 @@ unsigned long free_reserved_area(void *start, void *end, int poison, const char > free_reserved_page(page); > } > > - if (pages && s) > + if (pages && s) { > pr_info("Freeing %s memory: %ldK\n", > s, pages << (PAGE_SHIFT - 10)); > + pr_debug("[%pa-%pa] %pS\n", &pstart, &pend, > + (void *)__RET_IP_); > + } > > return pages; > } > Acked-by: David Hildenbrand Thanks! -- Thanks, David / dhildenb