From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13C9FC369BA for ; Wed, 16 Apr 2025 18:10:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9C17280001; Wed, 16 Apr 2025 14:10:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A498E6B02BD; Wed, 16 Apr 2025 14:10:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91029280001; Wed, 16 Apr 2025 14:10:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 725106B02BC for ; Wed, 16 Apr 2025 14:10:24 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CFC74120DCD for ; Wed, 16 Apr 2025 18:10:25 +0000 (UTC) X-FDA: 83340696810.04.80C52EC Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf03.hostedemail.com (Postfix) with ESMTP id B543A20008 for ; Wed, 16 Apr 2025 18:10:23 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bGobBPzi; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744827023; a=rsa-sha256; cv=none; b=O1H50t4sSTv7IF9oz5fyeu7b06Whrzvh7MMEVv4o63C1URj7Q8NqdfW2Gq0ucMQqjTeEji 5aGOCzJHHUuFSusdMfGXeA3UYaiC0MsF+DKi+t6W3miTOxuHhOBYvwqKMEQPA1/TQ8caJh OikNjg+7+fQYgQl438vGOLWxIlqCUbo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bGobBPzi; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744827023; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DMwRbk6qG7I8wYVc0AiKcQhWswU6G4m4BqFeblLkQ78=; b=4JQ6hax0pKhbSelKk8IAnFuYNifYYMXot/uND9tC9L6EddTqVm9jkWtu3hO8CLEq1TebqV DWprOI6KE3A89p5sQmNpMABkeESCtDdBeYdB5J3U2ep+/e4RjeG4u5CrDuTo9Dxmqx7wFq oQc4GhsZNlxv6tCUJq74uY4asXvBqgQ= Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-47690a4ec97so68935821cf.2 for ; Wed, 16 Apr 2025 11:10:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744827023; x=1745431823; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DMwRbk6qG7I8wYVc0AiKcQhWswU6G4m4BqFeblLkQ78=; b=bGobBPzi/Oy7Eg9taGQNVUUpaDRC+eaDYDY+BBhCeXE4Y9QudbfIkSeXfX89Ick2/n BoWszLHlA0NTiPLKWkpv50c73Tz+OZS3yRqSdCNvpBNgFpJuGSO1cmF7mhP8caJzE2x8 Vc2AB5psZQUEw/0WyrkMtwutrLYCcEZLxG4a/cQc4tYfEv9RGclOI5mx0MrXke1LPjqz DgsAEA2dcWzJus9PzWFdQpjWQXRhZ1FpzKbdXJe/azJwrkA9zUu7zHpLi1UhgSI4a5P8 XImJMMVyFnOohRXOyneaWdzMdA+0of02l40D4n+edN6c4IST5yqpPjBVcQicD2u4KuTe HsRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744827023; x=1745431823; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DMwRbk6qG7I8wYVc0AiKcQhWswU6G4m4BqFeblLkQ78=; b=a4gK/e89qRT3t00SuGoFjEFKqGk1tulEA6gUlwXjC4k9qsqUTh70fL+v/oIYeXQHRD W/VztF9l728WRqpuczuOwWRKGL6ojb0flBfgSynVfh6rcTnpsQtO5QY2PQQx4SkG+rpr aHiZbLG1uCNvTQFyjkCHOX/FCZJQ3Wpb9aErRfPClCo5ME734y7IBUfyQu35ybS+Qq5L Z4terBZisndhs8BN83uIdvIRhMDtDu7f1NE9vt957yamu4im9ZWn7A1hu7TVOJacBazF QXbJyAxF9kgn4CmjwEBXdgl47gLj+MH2tUmX5t8Hp3IOVkv2EzIDxIUL11JbVGZo5PhN WRew== X-Forwarded-Encrypted: i=1; AJvYcCWVajicO3T+PyVySFxAYAEE7nyGTZL55NzNba3/pZHhCSbFQryyQxs/L0m04qCHLuOAeHI+tInliQ==@kvack.org X-Gm-Message-State: AOJu0YwgYaR5TGXWwlcQ5ujAOwEqv92atrmrcNVSYw5pKfZ3nxfWe0oG yQBIDd7KdTlkFztWE8gZQOueabQT8x+TPDHUVgThhQyI3DMt+Mhz X-Gm-Gg: ASbGncsLzZPiY4W6Qo5cwRzGcjvtJCJ7MJgfbh6dAlGbCxDQ3sApnhquAuPrf/pUdu7 m25ZwPDQCdi7GJlryfu5qKzVXzGCj3mFuwhMs+GSOQDZv2ZqflkiHNxup7Nevm6R2Gbd0yDgkY/ vt9VMHfSpQk5znaZE6Y03H60LHIg/vAN1SRp0i3gDpI+uqXANFSOMQIBanY2Rk33yDQz2aWgfK6 uC8TH/lImPTc0jxHBDPv0pFUr6UQ5pbj19rn7Mr5Pap7aLYBQrtRUx7VOkUB/U50Rs5GVDRsUjR nQ5aLZRPSTNixuNXv9HHA/jJ7IUQ/X1kwJAJrBBphMtCRR/udXx+A96QKIRjydNKek41DInY X-Google-Smtp-Source: AGHT+IEfBviXkm5Cks9CvATvW/KbAuBVk4lIGGFXwJSQGOKXN90TyWTzppAWVlD5oMfgwxhn1r2zoQ== X-Received: by 2002:a05:622a:15d6:b0:477:cb1:ab2a with SMTP id d75a77b69052e-47ad80be77bmr46408951cf.13.1744827022814; Wed, 16 Apr 2025 11:10:22 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1151:15:b31:ddc1:afa7:7c1e? ([2620:10d:c090:500::4:d585]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4796eb2bfa7sm114202281cf.42.2025.04.16.11.10.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Apr 2025 11:10:22 -0700 (PDT) Message-ID: <6409c074-501f-4fe4-826d-5d5004735f00@gmail.com> Date: Wed, 16 Apr 2025 11:10:20 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/5] cgroup: use subsystem-specific rstat locks to avoid contention To: =?UTF-8?Q?Michal_Koutn=C3=BD?= , Tejun Heo Cc: shakeel.butt@linux.dev, yosryahmed@google.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com References: <20250404011050.121777-1-inwardvessel@gmail.com> <20250404011050.121777-6-inwardvessel@gmail.com> <3ngzq64vgka2ukk2mscgclu6pcr6blwt3cwwmdptpdb7l7stgv@vhpyjbzbh63h> Content-Language: en-US From: JP Kobryn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: B543A20008 X-Stat-Signature: pz6cgmw1rws6zpdexyoa5mecmz58r3h8 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1744827023-617650 X-HE-Meta: U2FsdGVkX1/zf9Z//NclKOJYYmS9QPOkeeFJ4wjrYnViCAphfGlq24b+rWU0nK/w2P4Z6Ztl1481HByuy11oBo2bmQ6gD5HkaiYqtQSsvf+ED0zGJe3QXEeuwdKDxH89kdNZOa8b1VUUlPyWV81a72XOSVWXgpfnIPWUUoVdX/6qAkjRlSm+eZAV45JvJqYqNS5NWzVx9jyP6pgHJ/gFjCnG5uOL3epbbX6LEVIxlZzq3uVUPXrNU4T3rzTucneYvDH7KSRdk36gxBMe0R6e3nLqvikP+GQPxwk72jWyFrLtksgwE7uhFQ5y6tOuybTOa+UJrOfIA5GpSZDmDnlCFjqU2EqoqNU+eljL74wJQKWntw2SFsftB+qYjYDo7ERkadffA3J0WyBWk2ZXxdDeqDRKYyYbNgNcDh9GTvNoF+vAhqD8qfi75Z1ItEN2E0s85aMXYd2z3qGJxyOhs1q7AKO6UQF8f+0czS7KNjzjdeA/MCFVK0gA8PE8kkt7R7iz36RdtoJbNw7ssaTMI7g4lD5l/ZSDSh4fs0MZHB6Nfr64i5PuiwECggQ8lO84bw5nsoGrBFdWBxPQHy6iDbUD4tGicGdE1d8ZQq0FDSgOyQmzwPP+MLUqG9jXpdlMoDDsIMpcOWitJ2phZ8XtejNrP4a3ZIwzd27x42mgsspnkEUy7Cj3hBJY3cb1g2sf4nrEbiyossoxDjMRiECBxsUEphiR0V7MdEF7M7cq3AjhRGnuwZG4rFlCKgcNH6fvjZ1R2ufGy4Eyiz3t1Fx1+6QZP5On+3yb6pIyZMvC3lmyzdH5IVSiz0GAgJDjKFg60gU35aPyTJd6+ZBXRfKcwuFlG7ca6yHEmQk793hImrEtRj1578r+EQPyDLPhICf0NkPu4QzBtOLIkkE/g8AfXd/hmHkE7oTCe6MlKF3goUKTk+FnKjqekT+AuwExD59J5w+BrNAMNo8S5SA3bRboal0 Sv8yIBxf 6n8Ovu1kU0wuA9UZyNeyiAnSSk5VxfpKWlmznKD9CIGGdSGQHAbDtiXiJcGLrhd3tzPOdxD+vt3E0ByZLFdBy6e1zaO8ntDpY7zDqbkmG2YP5nw0EcCY9JETshG8nTnx/9/dQ+XtYNn6yt6qtBrxz9MM1sNqkaMzVOeMffQ5lZcrQoMSGeOKdHHtjmZ1/wARufeyXU/IG/22clfEeaTSNJABZHNuo6EjMRqYwBFBPoudA30R+LuFrdFhfrZDW0Tl9DrGvzsQd72PajjKPE75mecSltRJcrOag727icYRsXW+AqRTTlDl8o+jlC1QjaAMrZoj5TFEPbdj02Co4VYpwTC5cQO9DRXa4KufnH/wXjXl2PC11hrfcAi7AdwU5J30xAVio82Xr+gCy5a1Y+k+R8GTU6QPo2cNn4upCVotVE/ySxzhqQsQytCArJWhH9G1gq+xa7j6xeZ7MZNhrrfOXt1KIJSoWrUYk2N8v+X+lwCz4PAXbwMlzEZPUeAiy4IzXCi4xS4lLp4TYaMM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001669, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/16/25 2:50 AM, Michal Koutný wrote: > On Tue, Apr 15, 2025 at 09:30:35AM -1000, Tejun Heo wrote: >> I don't know whether this is a controversial opinion but I personally would >> prefer to not have __acquires/__releases() notations at all. > > Thanks for pointing it out. > >> They add unverifiable clutter > > IIUC, `make C=1` should verify them but they're admittedly in more sorry > state than selftests. > >> and don't really add anything valuable on top of lockdep. > > I also find lockdep macros better at documenting (cf `__releases(lock) > __acquires(lock)` annotations) and more functional (part of running > other tests with lockdep). > > So I'd say cleanup with review of lockdep annotations is not a bad > (separate) idea. Maybe we can keep these intact for now while updating the text within to something more specific like Michal is suggesting? Tejun, let us know if you have a strong feeling on removing them at this point. > > Michal