From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D5ADC64ED6 for ; Mon, 27 Feb 2023 05:47:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D39566B0074; Mon, 27 Feb 2023 00:47:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE6B06B0075; Mon, 27 Feb 2023 00:47:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B38F56B0078; Mon, 27 Feb 2023 00:47:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A4F2E6B0074 for ; Mon, 27 Feb 2023 00:47:14 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 73A56C06C6 for ; Mon, 27 Feb 2023 05:47:14 +0000 (UTC) X-FDA: 80511988788.25.4327BA4 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by imf25.hostedemail.com (Postfix) with ESMTP id D4DD7A000A for ; Mon, 27 Feb 2023 05:47:10 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=er1RIPTA; spf=pass (imf25.hostedemail.com: domain of ira.weiny@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=ira.weiny@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677476831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GmNkuMmPl+1E+E6RZ/KbjG16gvOFAVu8lPd7W8o2z1Y=; b=K4u1+lTqQdnPojlvofNBeAQTCQbGTUfHkOYyiJoCHhZEb7QUwGdHkF/C3Amu6vVm8+eU8k af+7RpVYM1ccyRNeh27US7G5tqeJWEM6NDGXoAHJYxOAoXQtnfryAYX4ypemqwLoHDKvFN guHhFu2D1ZeG+0xrEIUdWEtKB8QrPdU= ARC-Authentication-Results: i=2; imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=er1RIPTA; spf=pass (imf25.hostedemail.com: domain of ira.weiny@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=ira.weiny@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1677476831; a=rsa-sha256; cv=fail; b=NmTh6zzrpwqGVtbiH0emfLxGgkO/EUoOwtUQFFpO3uUBRuBMIc1bP+doAPvtYc1r6vWj16 iatPETcG59ydFOTKU0kJFOS93mSxLjq2YPfRydwZJhalGC/JS20r0OZJJb209A8l77TV+g UFJcqNjaiAOBucZo4X/BQm1AC2LuJ70= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677476830; x=1709012830; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=tG1vz1ghWA7c6m5mSsvThX6nb/v7Cv5d+p9oITBjdho=; b=er1RIPTARlmestc5vUmkZDP/sCB4l57elRZx+mt3ZwZHoqrebwd5CPpf YKugIwi8VuHPmeFXXsivPZ81v11WQTBbW3dN7Q5oPl8pVFD61FshWHkEy xocQyAy1B21p6L4tXs3dXMh2QpfT21+z9vltgVJ2XK5oKGsVgI2PimX0/ 08YCuCJ4m1ou3z1FUkOek8Y4mTLRCPW2a15aiftbE5TCwuJIRqoc3MQvo I+YwC0InV67YjcxH2L9fuY64YCjlb7ClTeqbH2gHyuGO0+eO1ImBqfkSc Zn68TSLJW1ttLxRD32Do51s39FS8rspEQLcB21aDDz1VDTXOS93QNLEGY A==; X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="396332869" X-IronPort-AV: E=Sophos;i="5.97,331,1669104000"; d="scan'208";a="396332869" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2023 21:47:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="1002579777" X-IronPort-AV: E=Sophos;i="5.97,331,1669104000"; d="scan'208";a="1002579777" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga005.fm.intel.com with ESMTP; 26 Feb 2023 21:47:01 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 26 Feb 2023 21:47:01 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 26 Feb 2023 21:47:01 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 26 Feb 2023 21:47:01 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 26 Feb 2023 21:47:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FtR/xXlI/W1yaX0Eed/Fh2yZf6N7IBBk75w/Rdn7gYAGY+pDlT7Wk6LBRZqkJPyR2peGGoh8/EEaWPQ81p2Twdwvc0XSBwJ2Ky/gkObksnlGslgfRW7RQ+mQOAmP+GWlo7sLcQgDnbbIYzyepiJ5qiROxoLGpHpH+rHoikEVsb3nBHvCq6aUb3JOOf8qI9NQK5MEk2adtPAcTO/WQUFDOfTCAilXWrlvBGvBZB4T0PqtwIRM7bSzUeTNR3c0nvRWNl2PAUhCAIZU7CyYD0Fu/+qv4PulMJyyHUh5DJZZY0tmXIRsDDXzx7dfLW1hVGw/rnA9UoxuOfbreT88t4rhtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GmNkuMmPl+1E+E6RZ/KbjG16gvOFAVu8lPd7W8o2z1Y=; b=LgLVRqP1Ad5QWjxdx38Og4eODzXIKilxh9hgGTXAaTSlIu7wt2hT1EaOBhkKm5X04o8a215lf4ikJBmFUcgLODs02cc8R9huHbmPGRKYzcmMVhjZoo3xUfvPlmKeGqwlVajZdyJT3MHEkpylcI4Y/IEQxRpy8gUnI2Un5alcAR0n+x+B9r4cwYNpvOTENfxYYuAYVZBgIDrgUrPrCHRXPOgUg8BxN4f+p6tmY/sxG476SOpZcsoz21+vfE6xjBKcTn4UDEy6rzWTT2oLzxhvpNDeMyc75sS4o5dmKMmocMugMPHE82MGHzTncX2qNoenHICqsCnFR4uxrQrvurYKqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB6733.namprd11.prod.outlook.com (2603:10b6:806:25c::17) by BL1PR11MB5271.namprd11.prod.outlook.com (2603:10b6:208:31a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.27; Mon, 27 Feb 2023 05:46:53 +0000 Received: from SA1PR11MB6733.namprd11.prod.outlook.com ([fe80::84dd:d3f2:6d99:d7ff]) by SA1PR11MB6733.namprd11.prod.outlook.com ([fe80::84dd:d3f2:6d99:d7ff%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 05:46:53 +0000 Date: Sun, 26 Feb 2023 21:46:49 -0800 From: Ira Weiny To: Yin Fengwei , , CC: Subject: Re: [RFC PATCH 1/2] mm: remove duplicated flush_dcache_folio() Message-ID: <63fc43c9a56c1_3fa02943c@iweiny-mobl.notmuch> References: <20230216160528.2146188-1-fengwei.yin@intel.com> <20230216160528.2146188-2-fengwei.yin@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230216160528.2146188-2-fengwei.yin@intel.com> X-ClientProxiedBy: SJ0PR03CA0216.namprd03.prod.outlook.com (2603:10b6:a03:39f::11) To SA1PR11MB6733.namprd11.prod.outlook.com (2603:10b6:806:25c::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA1PR11MB6733:EE_|BL1PR11MB5271:EE_ X-MS-Office365-Filtering-Correlation-Id: 97222984-cbf8-426f-b757-08db1886072c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6n/BpeN2PMiIvunQ9oznG+zY/Ej6Zz0RBc2lAUG3q9vc6DoLl7PMVEsYPHrR+ow5DTzF8H4ELM3TdxP1DWHwh49zKVRbfEuMWvpbB3m1hCdV/vr9m/TIVKPnpPWRFj3V8qwop1E+urDbncqkAW3B5LSaYB6+3g9Keili6vwgVS8f9bwB4v1cYWIpl2TgPYGRQMRYjFxLEq2hQpE5vHIZVyUfWvrX4kPR6CsKl1a7oFJ0rX3Yrd0o9xP/iL1GpQqY64cTQ88dKwb0YzhiXFgiUBwJu/P2a1JMjKuyAUo1XX679yZQw8P2vCu3wIeYOOsRuw7lupNL/PXKzDqfyHthecoGqh7Y8h/RcyhSITUIAVkcqrmoAVlo7Qvt0evNS3HQeZZxtdbOENr+KCgriKYpl95uaZcpxpnau7Lac9qzp3oEOz2B2fPHCvNatOdYA1kWoNk0tl0hpSGJDmtqGsjCppNjj3W2XdvibjTtsKvCyqhcg8RyDqoafB/ADyrxvquRIoQXhABmsGHsEXxqRI3DUYwt0NvwdpeVOPWVa4Mf67K0E0nNk1jELm6KLQ/aZd7i0rhnIh/8/qQViwdGiy7pfsWHDenx5t2OQ/ntde4Z9WBYHkoaLJSFjNtTGrDog9UaX9UnId6c3BApLk/94fnKRQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB6733.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(136003)(39860400002)(366004)(396003)(376002)(451199018)(26005)(186003)(82960400001)(6506007)(41300700001)(9686003)(107886003)(6666004)(6512007)(478600001)(8676002)(4326008)(66476007)(66556008)(66946007)(316002)(6486002)(86362001)(8936002)(83380400001)(5660300002)(38100700002)(2906002)(44832011);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YKq8/a/bbCGs8hOddk1E6smK/8/eCI67FPIb3wdcNTMqobzSB+fBOu1oYHwY?= =?us-ascii?Q?F+kn4syGm8glYMKqyf0oIDpmPORG22D2qn7mKsRY0sNzSEGt9FWv+krgHvQz?= =?us-ascii?Q?j+P3QT/nC5oiUIsRIUZAK2uMmwhYtDdOYOz2WtvKvgXRlm2F0vdtQDLaJG93?= =?us-ascii?Q?a7mwwncfudFKrN2+okFh26ZuP5nLf4z7yGVPmdd9jnlMqfnsVopNPvjDVq5U?= =?us-ascii?Q?TJ3Iu1WqFhI2x5gk042dbcaSUVI0a17kEIYNXd+DdMEH5URJnNw8RkP++UXY?= =?us-ascii?Q?+XRMLxwAQ6z81uB7KG9mIJGaiLSr3asrq2wEg3Z2cd3z7pCz2y8DnS88/N9w?= =?us-ascii?Q?AATfU7TrIDA5MuqCA8Gra0zuxr5uFrP6mABaQtUG5/sKvbF0UJUf5Hd4dNzR?= =?us-ascii?Q?YMGgQw9aUiE9WDtqSn/ChUiYgoktRuXyxL8fIO6LxMwqETfOyrQlbsrNaOPP?= =?us-ascii?Q?j+++otAKYjt7krTPmPyHfvoKwX3kwtUTxOmVYcnZVPtHdR6+648K4LFtI4hf?= =?us-ascii?Q?uXeVXBaZJETcMjm0Pc+GhybhRzhmUDQ1f+pp7LNepiQAkkmSKzXr1s5ZFZ+e?= =?us-ascii?Q?EcV/w6dRGiI6pV50ycpW9I+D4ErIXibq4ZTYNNSzNoWlli+h+EwYY90Mxog/?= =?us-ascii?Q?JgU+CkZx/LlVbEridNhKCcPNfiA4H2LSYFyilPwqPeemaInxFXmNT8bXAoxB?= =?us-ascii?Q?ILORg41ubGPI6iiY9UfgsFeVdnLzHKfvdsIx7tbSB75+gTgLpmnfFprNjKYy?= =?us-ascii?Q?HwTFYbRlzvODFVbxZTKyCWFY5MgI8zYNAk7eEHmWf0g5BA4MudiAkICn8EN7?= =?us-ascii?Q?5v9nYn5uvUgeMyAfkveU0ugklEFcxrsImZIJmZDJ4Apxe5Zc9i2ZvkXBiAP+?= =?us-ascii?Q?IwT+Xw9tfjy6uGFcr0RtLVWT5xU4uJk7NLs0UV5rdRpylD/0+lt6SglZkNA7?= =?us-ascii?Q?vKuzipADUMZnW2gEBDnACmv5eebTfNQv9UaMpBDpnlFXC1p4H7NVbzo8AVrT?= =?us-ascii?Q?ziy3cLEH18WP0UJ8Ke5bIMd+ehD8wMiRf86K2OzjPgAEXIbEqRth+J1mP0uO?= =?us-ascii?Q?25Yn6OpeqSdRPVyBa6SfJI8X3y7PErTEXnmM5Qycljga1xFdrcK4PEaKAd8Q?= =?us-ascii?Q?xx5WSOMttPhOHByGkRGyV18akYYYbCTnRuw0Eo4zX5tz4VqI0QXuug4vCLyb?= =?us-ascii?Q?MkixerzsZ5x/3EfdEuu0BTPLiTIbUyndPU4HX8O82rvXZWxW070jPq/ZdJU/?= =?us-ascii?Q?ydnaobwKuH3kwhh6VSMgqFbZHBtwsmoetQX/yQbUAfsqObx0SfUsN5gd/VmQ?= =?us-ascii?Q?MKmcCJHccd/1cnKdkrs/69fYtuQpjVBdkhfuKtGvI+iWqKzvgnKNrLtd0Zsb?= =?us-ascii?Q?wuaVZy+Ykx++p/Wq8CxeX0QVpKmIYlFxrCpDakIQ75A782eAXGZI3ymN1Rz7?= =?us-ascii?Q?TNvtQLcJJgfXyAPGsdKmSxAMAK6HVnVajVvf2MyV4W0ogSHdwVZRq+qV7aXj?= =?us-ascii?Q?1AhA8zIqjFTJWsmjhqb/RfyMkQlkYpg2lwM6oUthJfzYbXpRMBO9loPPaEAC?= =?us-ascii?Q?+ejzq4NkUKMyJkDxhTelubYi5/6cUUGrQqT4GZ3F?= X-MS-Exchange-CrossTenant-Network-Message-Id: 97222984-cbf8-426f-b757-08db1886072c X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 05:46:52.9518 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bTEcDYkbWyfETAd1ugdRtHXwgqfWbACar0JosV3VY3EnY/IFy/UmsN/M721flu7OtIBVk0WjywszGkMYQ43QNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5271 X-OriginatorOrg: intel.com X-Stat-Signature: cf8pt5hd77dk8kgpxkztd43qk1paein6 X-Rspam-User: X-Rspamd-Queue-Id: D4DD7A000A X-Rspamd-Server: rspam06 X-HE-Tag: 1677476830-112110 X-HE-Meta: U2FsdGVkX19y+KaPIe40l8PKuGo4Ekmjq+gqDBkcAihi/GSKPAA0gnqpXrsEaEyBSnohjIlMU0qb2bTX1B58mY9JNW73q4JBAbWGYXt//2UnOMFf06PzhCP7YtP7CvkXh56Q+1a86g3Py4flAtk4BM6BFuf7Of/Y+3PffKolQtn1DGjbSljlxt6pJWaSV90seUBfVst470QrZmcGGkaLySrqeG6Jc2OnbPXlvgmVJX4Cb28Xw6AgtyVhK1v4kZlB+nxP0MqxJ55VuWSVpbjJLPnV6RnAiihfeJbWfj4M1BKi1fn3wFf1MtOai8ACpo4svaDsmM998rPBUd+H1+0OWMkjxCvCI0GfDi/6Kz7ElhFH1tBnQSKLjWbGjQ3Dkybdn3ZvoPwcOmjJ92SK2smkldvlW/B2hV+PJQ8T/8wqF8THqrWzelvIMU05v+fLyC6fKCH/dsvU1X6swwJiWMOGMP7+AXBrPEDOj3kQl/zRQfBxkpif6shCbU0q3JyhX+2IjaXLnxMFuAnNl13KogfD336yk9ek606o7Fl5Pcv36IIMZQuyNNH7IsVDWhIHgwIkjXIT/sLDCUNLp9z+MFCQdskFg31t4jjb9Rfu71ynnRpDmfyeuOeYbLksbcH1lL0AD2bVtr2YkI4SaAp3aKiw4ZlVJGOg99x87ax7hLBlwW/hesj/OKifaR77R8PTq63P+7wXqXpSsPDb8WBcWGZ0AaZ1yEBsPwcBg7viW4PtB/JcnamPLKeL3X/P/Gm5tyiqK52JuxyuPi64c2Z0xF8Q5/NHw3bgUkOZfQQgRDC9crWR++jdMHeZHT+DhTXM0nX1w6a+9ldlznuywXGsVQKeQtMxlctgrL3SHZw+F67o5nVWAJK9e2NNbUWzb8beEmVkEfRUIzOv8bYdnzPZdV6YOCuTnc0nAv2pGVZlpLTg1pCQFeGIlcjB+FCYTITBBZJAOEukIlYv4LaskrqUpBj SAkVUCIG ejsK3eVHHmgf6cuJfzQbbsSHRpPcR7ejD4e5MTtPYXsxV7zop09vkgkw3Gim4arBXHEMxc711w19YLV0cM7D7ypkrXu+UZbrUihEwKdFISr7KRsyQ3LXUjUNDmnvGorjoEBF6iuLSQekl8aMizJ90RtLi/st88wleO36Bb/74WZH8i1xzmkPldSx/235F1bhzyIubki9SoWHFVD4jDmF0oT5XnKXmdK+f2cBBDMYkVXujT1Zl9KgWkSkHUE03r63enh3S6LjPMx64lEEP8SU5KUkO9euVSj4Rbrz2Kd9NnwVSDXELEXvoRt9daJdy23fJYTR7DS8XDD/+Hhs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Yin Fengwei wrote: > folio_zero_range() calls the flush_dcache_folio() already. Remove > unnecessary flush_dcache_folio() call. The change is probably reasonable but this statement is not exactly true. The detail is that flush_dcache_page() is already called and another loop through the folio pages is unneeded. Not to mention hiding these flush calls is nice because it is so hard to know when to use them. > > Signed-off-by: Yin Fengwei > --- > fs/libfs.c | 1 - > mm/shmem.c | 7 +------ > 2 files changed, 1 insertion(+), 7 deletions(-) > > diff --git a/fs/libfs.c b/fs/libfs.c > index 4eda519c3002..d57370c8e382 100644 > --- a/fs/libfs.c > +++ b/fs/libfs.c > @@ -543,7 +543,6 @@ EXPORT_SYMBOL(simple_setattr); > static int simple_read_folio(struct file *file, struct folio *folio) > { > folio_zero_range(folio, 0, folio_size(folio)); > - flush_dcache_folio(folio); > folio_mark_uptodate(folio); > folio_unlock(folio); > return 0; > diff --git a/mm/shmem.c b/mm/shmem.c > index 448f393d8ab2..66e50f0a15ab 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -1401,7 +1401,6 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc) > goto redirty; > } > folio_zero_range(folio, 0, folio_size(folio)); > - flush_dcache_folio(folio); > folio_mark_uptodate(folio); > } > > @@ -2010,11 +2009,7 @@ static int shmem_get_folio_gfp(struct inode *inode, pgoff_t index, > * it now, lest undo on failure cancel our earlier guarantee. > */ > if (sgp != SGP_WRITE && !folio_test_uptodate(folio)) { > - long i, n = folio_nr_pages(folio); > - > - for (i = 0; i < n; i++) > - clear_highpage(folio_page(folio, i)); > - flush_dcache_folio(folio); > + folio_zero_range(folio, 0, folio_size(folio)); This is a separate optimization from what your cover letter explained. Ira