From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2DA6C7618E for ; Mon, 24 Apr 2023 18:27:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48DD66B0074; Mon, 24 Apr 2023 14:27:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 416636B0075; Mon, 24 Apr 2023 14:27:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B7106B0078; Mon, 24 Apr 2023 14:27:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 185476B0074 for ; Mon, 24 Apr 2023 14:27:43 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CAEEC1A02F9 for ; Mon, 24 Apr 2023 18:27:42 +0000 (UTC) X-FDA: 80717117964.01.C2F5F97 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf03.hostedemail.com (Postfix) with ESMTP id C1F6920011 for ; Mon, 24 Apr 2023 18:27:40 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lxcmhjDi; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="ib/RjeEz"; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682360861; a=rsa-sha256; cv=none; b=ZQOWeoZwuFgJiT+bCjdSQCGBxhNSpkO73i/2LwYq7WqOGRYl2DWOZkyca5+HY73ghjaAFk 0bq5tZOd0b0bFXogePY6Lp/EKDyXdqqgja4UfRqcJQ0sZGB4y5JOTy72dz4lq0pJ/W5hm7 SE9HCwbxam1wO9pN9SFI1T7xc3KWhKk= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lxcmhjDi; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="ib/RjeEz"; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682360861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yCPgtZFEHFdO33L4qW+mtMOH4PY+cCivsZXH++p2zhc=; b=uPjznYkO4IBJtOSYQSA0I18NfHTKF3cY42xDWDEe2xar1x2S9a7v4vK4vAS/pOqxQReuJC w9E2EePaHXiHtmfGU5RdAPsjfn/qWDq/20OgEekwb9KdnVmkbXv0Q912fhfD3zsRIoqu+x MJCWJOrs04Uj9c0nwj93LlswwLdThkQ= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0632D1F74C; Mon, 24 Apr 2023 18:27:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1682360859; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yCPgtZFEHFdO33L4qW+mtMOH4PY+cCivsZXH++p2zhc=; b=lxcmhjDiTbIW82m9qsZg6R8aXN3qWoRtJFAP3N5r8dsqevC0kcW3RmbWzWtFDWCnD/F+AP jpVS76G6R0Mwwzj/NqFJvLdCE01Wbq3ggxN00W0SNAwiqaPkgUt7VYL6yIB/5aVdddIhBD Gcv2qeBmv+hvC7inpjPObdouElyk5KM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1682360859; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yCPgtZFEHFdO33L4qW+mtMOH4PY+cCivsZXH++p2zhc=; b=ib/RjeEzkiWcQFeEWiuV0AMzWF6BtlYYWEXsUUyAiUG8DxklSsm3TEy//IQCZlnZQoKFCo CVNJd+uA3S4iBKBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D728213780; Mon, 24 Apr 2023 18:27:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GdRkMxrKRmQnTQAAMHmgww (envelope-from ); Mon, 24 Apr 2023 18:27:38 +0000 Message-ID: <63f33512-f426-d808-5680-d5dfd8e0c9d2@suse.cz> Date: Mon, 24 Apr 2023 20:27:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 1/2] mm/slab: add a missing semicolon on SLAB_TYPESAFE_BY_RCU example code Content-Language: en-US To: paulmck@kernel.org, SeongJae Park Cc: akpm@linux-foundation.org, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230415033159.4249-1-sj@kernel.org> <20230415033159.4249-2-sj@kernel.org> <21cd0c00-4738-49f7-899f-ec3792520bfb@paulmck-laptop> From: Vlastimil Babka In-Reply-To: <21cd0c00-4738-49f7-899f-ec3792520bfb@paulmck-laptop> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: C1F6920011 X-Rspamd-Server: rspam01 X-Stat-Signature: 8rrt5ye1barje95jdh13o61x7mnuoeep X-HE-Tag: 1682360860-338440 X-HE-Meta: U2FsdGVkX19jtMnxjPQ8c9vqvxvo+deWHtrOC6QvVCjXSnC9nFbMpFFMtTYVGMSS59+vyukDnIy7e6K2SDeM0a/GDmm3n3iAGpdv96p0yAqvZjVJEaZIeQJ4j3Vc+HsEI3Hz7d07U/88+FBKnUQFJfYRHgQG5kgITY5t8Iu7UKGMznyieLGlhNT2bt4nHbVTt8dzxMvJTrf/jposdOX//OEKWulSnG4K19Q4j/+udO/uVolX3Nr/6DPbiDoibbwsHaOtvpDJ7so+YxdcvPxQpIZ0ZBGM12MmKcRr3utenesU6Hl7jeBm1V2S6vg/dBjy6eZRr0JDJEG02N5AaK96FrbSxIBvAC3S4wwTDv7Okj2UgTuAGuqlNPAFNnFg4Zjs3ssBnywwNmcahi2f+Cgd+UToYSs3oSFq3QUJp69r7OFIIgMpTOag/IjwWU1oiPIi2VJNDpur7/gWcrbEToTXzYH7r/aZFy0QATXLYtIPkagMEwNV+d6fXROgHuxvAN5ngfVHV/X9ZUhUvYe0QVaCp3lHjCpXelA5J8M33XahOQQbluElTM/UPE5x5uaqPjQUQjMdn0e6rZyBlBGf/sMVnJ0vgfKAOo2U3NW0mmJapoAWw2Dm60YqGfzhpTpE3YPvcN5Qzcox3M4y7kTora6LRGpvVyK3inxMG6BdO1OtOPimtqLKAzUGR/boCNHzMqEKiu50Z/cX8gveAv5JAr8qgrQsh9Zp25VaqpCt73G49rx52uu8mcM12lD2Qq3TtfQmuqexMA+TpZZo2sCfUQKJK96fl9zAv6TpqCpC2P0QLIojhz5rV8XSIJreQWj23jg0GhWwJzjXsYa9VpFPtOZ/nXTPFF9sGrEJfe5T2TzaatbXyyVDZxyC2IM8jJ+h+6uhMKJmlTMGSMsabG4e+fK2WWuJhSzrCGtBryfxqnpy8bLAREO2pkyLMCZQoya2umpAhsSk1uJ/RjN5OplfmQH hgESjG3K WXzYWvr/aF41yXnOy9ZifYHer1BU494Fsq30POsq6TlkrjnILJ+naavG4zYJvc4478TVrFnkjM3ATZFrx34Q6reQaYiocvIZdlwGuEAvPRsAcsjgrDDW165E+U6g2qZdLiDlazu8vu517U3C9oa5aTbMygOgR0ObpEw2gfsE/R/RWh7tAQeY0/5uNcCeECv3FRpHfq/Aq3GWmJYn75G50FZcS+cBtMwOg1UMmHXcAImlWc5fuJm1GiO/1/H8DP7xR13E7vUpgOTAV06+gEkGf1NuOrRkSvwHjswIRYimRWvdg1Tc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/24/23 19:43, Paul E. McKenney wrote: > On Sat, Apr 15, 2023 at 03:31:58AM +0000, SeongJae Park wrote: >> An example code snippet for SLAB_TYPESAFE_BY_RCU is missing a semicolon. >> Add it. >> >> Signed-off-by: SeongJae Park > > Reviewed-by: Paul E. McKenney > > Or please let me know if you would like me to take it. (Probably better > going up through the usual slab route, though.) Yeah will take it via slab after merge window, but was hoping you'd ack that (mainly 2/2) as indeed the correct example first. Thanks, Vlastimil > Thanx, Paul > >> --- >> include/linux/slab.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/linux/slab.h b/include/linux/slab.h >> index f8b1d63c63a3..b18e56c6f06c 100644 >> --- a/include/linux/slab.h >> +++ b/include/linux/slab.h >> @@ -53,7 +53,7 @@ >> * stays valid, the trick to using this is relying on an independent >> * object validation pass. Something like: >> * >> - * rcu_read_lock() >> + * rcu_read_lock(); >> * again: >> * obj = lockless_lookup(key); >> * if (obj) { >> -- >> 2.25.1 >>