From: Vlastimil Babka <vbabka@suse.cz>
To: paulmck@kernel.org, SeongJae Park <sj@kernel.org>
Cc: akpm@linux-foundation.org, willy@infradead.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] mm/slab: add a missing semicolon on SLAB_TYPESAFE_BY_RCU example code
Date: Mon, 24 Apr 2023 20:27:45 +0200 [thread overview]
Message-ID: <63f33512-f426-d808-5680-d5dfd8e0c9d2@suse.cz> (raw)
In-Reply-To: <21cd0c00-4738-49f7-899f-ec3792520bfb@paulmck-laptop>
On 4/24/23 19:43, Paul E. McKenney wrote:
> On Sat, Apr 15, 2023 at 03:31:58AM +0000, SeongJae Park wrote:
>> An example code snippet for SLAB_TYPESAFE_BY_RCU is missing a semicolon.
>> Add it.
>>
>> Signed-off-by: SeongJae Park <sj@kernel.org>
>
> Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
>
> Or please let me know if you would like me to take it. (Probably better
> going up through the usual slab route, though.)
Yeah will take it via slab after merge window, but was hoping you'd ack
that (mainly 2/2) as indeed the correct example first.
Thanks, Vlastimil
> Thanx, Paul
>
>> ---
>> include/linux/slab.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/slab.h b/include/linux/slab.h
>> index f8b1d63c63a3..b18e56c6f06c 100644
>> --- a/include/linux/slab.h
>> +++ b/include/linux/slab.h
>> @@ -53,7 +53,7 @@
>> * stays valid, the trick to using this is relying on an independent
>> * object validation pass. Something like:
>> *
>> - * rcu_read_lock()
>> + * rcu_read_lock();
>> * again:
>> * obj = lockless_lookup(key);
>> * if (obj) {
>> --
>> 2.25.1
>>
next prev parent reply other threads:[~2023-04-24 18:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-15 3:31 [PATCH v2 0/2] mm/slab: trivial fixup for SLAB_TYPESAFE_BY_RCU example code snippet SeongJae Park
2023-04-15 3:31 ` [PATCH v2 1/2] mm/slab: add a missing semicolon on SLAB_TYPESAFE_BY_RCU example code SeongJae Park
2023-04-24 17:43 ` Paul E. McKenney
2023-04-24 18:27 ` Vlastimil Babka [this message]
2023-04-24 18:35 ` Paul E. McKenney
2023-04-15 3:31 ` [PATCH v2 2/2] mm/slab: break up RCU readers " SeongJae Park
2023-04-15 3:49 ` Matthew Wilcox
2023-04-15 16:27 ` SeongJae Park
2023-04-17 11:05 ` Vlastimil Babka
2023-04-17 17:26 ` SeongJae Park
2023-04-17 17:53 ` Matthew Wilcox
2023-04-17 19:01 ` SeongJae Park
2023-04-17 19:02 ` Vlastimil Babka
2023-04-17 19:08 ` SeongJae Park
2023-04-17 19:31 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63f33512-f426-d808-5680-d5dfd8e0c9d2@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=paulmck@kernel.org \
--cc=sj@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox