From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01A6FC64ED9 for ; Sun, 19 Feb 2023 20:47:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74FA5280002; Sun, 19 Feb 2023 15:47:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FF3D280001; Sun, 19 Feb 2023 15:47:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C56B280002; Sun, 19 Feb 2023 15:47:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4E0F3280001 for ; Sun, 19 Feb 2023 15:47:25 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 156531C0B26 for ; Sun, 19 Feb 2023 20:47:25 +0000 (UTC) X-FDA: 80485226850.17.CAA5024 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf13.hostedemail.com (Postfix) with ESMTP id 3A8202000C for ; Sun, 19 Feb 2023 20:47:22 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=cMqm3sf+; spf=pass (imf13.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.48 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676839642; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EQwHKFAOnqqVUFe2laozm23usPDD0BYqQFbDjsfGGZ0=; b=bKVeNR2tnOy6jVN5qEWaTxl/C6mUxHrCqbKTBMmWKpws5vJsFl85x0OHyf8EkdbATIUlTw HzOeUfg8yr2Ewbt5aSSeE5uaQQFHZA4lbHhgNaIt6kWDaefJGrhlcW8Rx6G/PX675oDBSU RUv4rew5f79GvhaL0v3bfwktznmru5o= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=cMqm3sf+; spf=pass (imf13.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.48 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676839642; a=rsa-sha256; cv=none; b=N+bYF9bjByPR5cOzqCqDF5Ucda22qXI9LkyMNP/AY8dBbFhH11c/TnDXJZQs9MDrIFK66G KLjv2/8TOVyUZF7MWUKFosnrR4Dw2FRU+xhAKj0HaVAKu7EMZ/Di6YWMLQbI7dIDhHT7zT ljli8EL4FrZTlh7HnwNwr2Sf687oe5E= Received: by mail-pj1-f48.google.com with SMTP id x23so1248198pje.2 for ; Sun, 19 Feb 2023 12:47:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=EQwHKFAOnqqVUFe2laozm23usPDD0BYqQFbDjsfGGZ0=; b=cMqm3sf+CmIV57EOrdFSH0Y6quW1uWdpJcrFTd2t38yjyfvYHAp87tnscm0cD4ruFl v7qL2TLj0IqBM7k0klpcJ9znFuXEQiRHtOHi3tlHnL14nRlrX+q4Wk3TqWjm4O4KDzjW jUhoMrl2bUhJOv+E5HJY1Zph4VZoAfhujd/fs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EQwHKFAOnqqVUFe2laozm23usPDD0BYqQFbDjsfGGZ0=; b=ROfVK3adAWG5G2xpQBUOECno2kabL7q/X+l9UPzFVZM1Wa7XdEjoO4yA8/p5TRBGza ITjV6/UMOfaY94wNxOEIf2rZCDPJZb6v1QCzgZy9mnjk/wlwpxgT769ReGNFih7JM/T1 MV2g/ZxPtziu3FSKC6ChAdQ5fPSZSScCgtBAIcy9eFzXdn/ep1pNZm7UhkzsVXSxeCRG a+YpgrT6rR9jDY+WeqtVA5iJVPkcei4NY0O6mmjqnoxqH3Yu8jJR7xRKlZN4N2N6xqjS 4B32PvJFQnk2oBft2OMSVqECGrNo+mv07mPf+m+XXvTzGppnlkDYfGmLOCzDJKDNrece 7y1w== X-Gm-Message-State: AO0yUKUovyKEylasmZ/+gs+urLlp442b8IaplQHZPBxMSDYRstoEFcQw bzI8Vu4Pcq+aj3T7eyszfhFRtw== X-Google-Smtp-Source: AK7set/hFIrWVTPTKDhOCxl9WJjZkcr/+hEi3oT24AxwvFiqzEXI+5JP9z5meWKExDOcc6n6nMbzbA== X-Received: by 2002:a05:6a20:6929:b0:c7:2086:634b with SMTP id q41-20020a056a20692900b000c72086634bmr14963415pzj.18.1676839641160; Sun, 19 Feb 2023 12:47:21 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id 65-20020a630044000000b004f2c088328bsm1020035pga.43.2023.02.19.12.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Feb 2023 12:47:20 -0800 (PST) Message-ID: <63f28ad8.630a0220.b1efe.14e5@mx.google.com> X-Google-Original-Message-ID: <202302191245.@keescook> Date: Sun, 19 Feb 2023 12:47:20 -0800 From: Kees Cook To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, david@redhat.com, debug@rivosinc.com, Yu-cheng Yu Subject: Re: [PATCH v6 37/41] selftests/x86: Add shadow stack test References: <20230218211433.26859-1-rick.p.edgecombe@intel.com> <20230218211433.26859-38-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230218211433.26859-38-rick.p.edgecombe@intel.com> X-Stat-Signature: 4kfw55sno7byezrznmdmehox4dun54s4 X-Rspam-User: X-Rspamd-Queue-Id: 3A8202000C X-Rspamd-Server: rspam06 X-HE-Tag: 1676839642-369157 X-HE-Meta: U2FsdGVkX1/RcehUHc+VPrU7oAr1LRjYxtROEg64O0PJHx9HEwf8avUtQ398hCS6P3u8ba+1xil4OvzAqS03GCJw4cLvoDcpXeTfPsHHnw9WBsn6xMwDajgya/CEjVnlcjGgBTR7fdKJo06JyV+l6PVTu14FATTrtpUYcUUuz5SZb3yJaw/WtR/da2nEx3SjkzO/JJePisYXQYdn5dTlw+PitZOO9pU7IS5/CCnUo1HNo1dAwy1ELvDLwn1CkQWHjhhxY1LxBG+nYuooSZfLbnypjjGUxVUsPIvPetetNFyXRUGYha2GJsWadMlGZ9x8Cw5p1Co38Z7YTD2d/I+1MC6TFEJhD79WY3iGROfPcw7xyyJm6vxIiKUTwO2ZQgxDOyFQOwAI8x+eramOSlUtQYSRwtlbIqUT0f/hGKbn61KkpH+L6z0J9szai38v1r/2sneIlXpVKVcRf3xQ6KJrAlJkO8QBnV3m8w50/NjWqMI0iBFMLbEe/sWXXgECEiQzcSP8O4K3iKSLuu0wjHzmTREct4GvRtEdZzTYF8TVVecAayPF3WdK2UXm/2VXih/i0VyCcFcc7J4dEvbQclSYDdXVCrwMcloW8x7ui6M0FoPvFyauZl/UB3lubhidGs0h0I+Z15l6UUStDZCqgnWC7VV1ZV+UdMZlUxobmIjY3wY9Kqzar8G0pGkMC157tiwxP/MMlLS8Lc+UThNwFPi41Wg/t1WOFBZJg6fNGTTCIcsHSHQkdRijb0jAgd2mfLe5m2SmLpgvURaJNHtEWeEXIr9qGyoCM47ZDBw480ACn6YabIPB3+D6rOBzij8FfDydIPslMHSg13Ox2f1S8fFepU2dljY+em30jKmrHaI22MuEVun2a9WIJCiLUW6fRB99+VSFQ4T8JN75pZWnfv8dcny6QfIrmZwZ8ZrihbCPpC5mGRbITtmpFrzejH9M61KmcVio+6umh7HGvgn45UD F0WizgJH 4bg3rltKyHQQs4gduJzhDc51MCR5RAXP9ku5bEm5yt6No4WnXLvu0xaSql8xospMdHHQeFBZ+waI1k9wFFdsrXKA+umLYXjU0rmIZjC7ItQG5O77LkrAkQZW0bXBfZQdUekr/NxsnKNha9WdbAxJUIxfDxAnfdW/witvtP0ggyVSj0aMC7Ji+SayNhg6pzh2kZb8NJpJDXJ7pDPA/dlaaDwIPf+fHIfEG9beNNaEoyU2EJrv3xvYIg99TUoPLXwdKR9q7SypDkQQlS4QnW6SKpiwAC0eex3bwfS3PwiHwxOwBJiDgTXiHHac9WWBvFa2/L5ls5bYjGt7Q+JlpZh2Wxh3iZgcPQ1p/ynarh7brgq9MD7b2LqjKiRTSuCroXL69asJinYZnwV+itdBZvT9cu56MEQQ7TKraZG/qn35TK0N0yBn/Cae3V7AXNcoMhsn3q8TqNxBgO7mQn/zgUvUVd9ho3xEqdWXKd1CjrVC47CzVLnK53XIMyPPJEMunztkLMZaW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 18, 2023 at 01:14:29PM -0800, Rick Edgecombe wrote: > Add a simple selftest for exercising some shadow stack behavior: > - map_shadow_stack syscall and pivot > - Faulting in shadow stack memory > - Handling shadow stack violations > - GUP of shadow stack memory > - mprotect() of shadow stack memory > - Userfaultfd on shadow stack memory > > Since this test exercises a recently added syscall manually, it needs > to find the automatically created __NR_foo defines. Per the selftest > documentation, KHDR_INCLUDES can be used to help the selftest Makefile's > find the headers from the kernel source. This way the new selftest can > be built inside the kernel source tree without installing the headers > to the system. So also add KHDR_INCLUDES as described in the selftest > docs, to facilitate this. > > Tested-by: Pengfei Xu > Tested-by: John Allen > Co-developed-by: Yu-cheng Yu > Signed-off-by: Yu-cheng Yu > Signed-off-by: Rick Edgecombe I'll get some test hardware and run this myself too, but overall, ignoring the lack of kselftest_harness.h, it looks good: Reviewed-by: Kees Cook -- Kees Cook