From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1D86C05027 for ; Sun, 19 Feb 2023 20:42:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92656280002; Sun, 19 Feb 2023 15:42:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D70B280001; Sun, 19 Feb 2023 15:42:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79EB6280002; Sun, 19 Feb 2023 15:42:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 687E6280001 for ; Sun, 19 Feb 2023 15:42:00 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BA41C1604A2 for ; Sun, 19 Feb 2023 20:41:59 +0000 (UTC) X-FDA: 80485213158.17.54AAEC4 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf14.hostedemail.com (Postfix) with ESMTP id DC603100003 for ; Sun, 19 Feb 2023 20:41:57 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=HRzIL01E; spf=pass (imf14.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.169 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676839317; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+n51xriYqbsbmvYxxt4ftJ/ywsWPB5yxY3XzOVKdQok=; b=HOotBg4buchlNUYVqQeMzMHr128aaBTOKXSKWhYV4uZje0/Ywy8hBk+botrJnJP38JZnYb /h6X4RCTCjYD12XAxV+CRAIize3cASBb68hKgG1xhMF/P1f4V0UYWfuCyrtvgFROka3v0V Qv+HEhSZoOTjKIl3CiFet9kwhxjLDYg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=HRzIL01E; spf=pass (imf14.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.169 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676839317; a=rsa-sha256; cv=none; b=b2kAo+V5fmxBj61k6kTMkkGNRzJ2xT6GBtlk0M2GKaYQyJVwgLpTQXQnKypiE9plCUZkMJ J8wHnD1n+F0h3hNaghaDX6irh7enT22F3AL3xm1VaofbWEYUkI1STgqyY4UexOVaQRSv/X mBH1SMLMOCziGFfLU6h8yFAvemeGPeM= Received: by mail-pl1-f169.google.com with SMTP id w10so1335746ply.11 for ; Sun, 19 Feb 2023 12:41:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=+n51xriYqbsbmvYxxt4ftJ/ywsWPB5yxY3XzOVKdQok=; b=HRzIL01EiKj/B1V4WeH7nE3SXQQTw+bANhZZ8/P4v4m9JiU3rQDUDjq7P6TKtP1rny vCDVBdBy2yNcsh7+DwfKoYd/3bLIxn7mf2cOxU2YAI1Df8480mfwgGzhWANf1AJ1vmBE iifkkTIsXn3XmVPq4cxEpzRJEyv/l4CEuJZOk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+n51xriYqbsbmvYxxt4ftJ/ywsWPB5yxY3XzOVKdQok=; b=IBlByVPnuFS6q9/8eeuzNkCdXeJRHwLja+LAAK2/NY9eZP3FEVBteHoFy1OSijPBiO 0nejXHsgcrGiTea4dYJxxwL7dwNAubioayRCh9PX9d3l+wNncgUEs48c2RV8hgHl7ceK K3xZWXE4Fpb2zWkIN5skPYV5SOZG4E8a1n2M8nJt0Q6UG8qMaTw90NOgce0JVqvV8sY4 ZAhzGUnCxKf+xl3/26hq7me4fTFJWXarJUpfJXUxgckDDsTEzIiqguR7zI1NSNljg0Vf dCVTVgGivG/bjoaXFt8PFR5ps57QPPipMMCBU0WlEUM+NtiiodnRtONves27WsdyAEvM 0k/Q== X-Gm-Message-State: AO0yUKW/ijvhy3Zm8dipfcmeGy372D8PIzOkYtNe3tbdzUfVMae4wXWR yVyD6i9yuQox6h3xYqiuK4iy0w== X-Google-Smtp-Source: AK7set/hmfWCZDm8xxBH1RGSdTrSPtAkyiRqs8cvWgzZE55+0av+de2ucJ0TWqIBTxeOu8W9SRaPTg== X-Received: by 2002:a17:902:d502:b0:196:8292:e879 with SMTP id b2-20020a170902d50200b001968292e879mr3763331plg.1.1676839316745; Sun, 19 Feb 2023 12:41:56 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id a8-20020a1709027e4800b0019a8597788csm829072pln.0.2023.02.19.12.41.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Feb 2023 12:41:56 -0800 (PST) Message-ID: <63f28994.170a0220.e86dc.1134@mx.google.com> X-Google-Original-Message-ID: <202302191241.@keescook> Date: Sun, 19 Feb 2023 12:41:55 -0800 From: Kees Cook To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, david@redhat.com, debug@rivosinc.com Subject: Re: [PATCH v6 20/41] x86/mm: Teach pte_mkwrite() about stack memory References: <20230218211433.26859-1-rick.p.edgecombe@intel.com> <20230218211433.26859-21-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230218211433.26859-21-rick.p.edgecombe@intel.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DC603100003 X-Stat-Signature: sth3an7sixon8uhshdb5hy8q7ybudwub X-Rspam-User: X-HE-Tag: 1676839317-505033 X-HE-Meta: U2FsdGVkX1+oO5aMe7FywcDyBPF+b4xlX0nxdeehsehh3eF95BYAK2dPu5Ad5eDVh1sK0C7asGlhMypB3kSt9yMRaYRHaU1lL73NtPtgl80hLErNveRt/OjT6snBU7xcWwczdAgqrMmbdHvIiCD7meqRAn8UYsDnvfOHPUXpf8P2IZK5rqr6WvSOnWsBweWs4H/SbctYEGzUetRHMVGIjfoOx4lDkuZ8I3THuXU2Oom7UgFe71yzAziPyy7V/E/yqqI9D4toWID0NnZsWf9ltdDUTZ6eKR1s1qey8KAlruCQsL+E7JDObz0NsnaKxNMqf3TCV6SI98LLTaP6DSdl08+Dp+2cR9YiFrWcuUtu3rCtLXMaSNMwkHm0bZyf6CrSZ35GxV6hsdRfYcnBzUjNy44PDjD7o7euGEez7kVGA+Fjkmqn/uTr8q9RBmDPPO5G3xFndulyMHEo0QFw2vK0jUwl2y7sKDzf7yTx3HavZMi0TJ7Vp+NdEPhOyL8FzHCP3DrMj6zNuHGqkBeol2YvGcg7Sk+y2P5aBIZz4MBEAzbiYvQRBAskDh06aylIKKTx6SUJ0SfqEQ4aO2ZwEVwgZ28B6/jKWDM5Stf+CFYvLpG3NDwLZJ1yzsrpjYxYNhYimeH7J59StJywl78XyShv/CXnjyOsgtHHsWOVKR7WeYUq1Q+1HUZ6UrFxrPohhwf/AK4IS8lJkbEqoixnpQVPXSN+6CH12nWDPn4W+HjkQMSAWwMan7/EHQ40xfuKx+aq3gf6XD07eeDgEPlN/9EKAy0VxAKOXV7bzuHrRdrbsN1rG+KbK6QUgxozgXFo5L7k4fNktk3RoIsmUA1fw688rAd06iMk7V12HeFlSwa4Q5T9Bv1pkYR9s2YQE6oo4E09ugFAzctUYLxIMa2BPEV4lHu2eX1J0v+rc6ebM5T3/i0Riw2SNOjeRx+8/bHcjQk3xiIBWYr06q4ZcEe9125 PjDEXhlv oXhAD5/xAN0C49vl5n5eskPSq1Q07vXqJQ46X+6hmlRiHbPYDCPKYpVhNJxkvSZkh4gZYf+3aeyxDzqlPnaynM4UKK6UuP76WbfxXLoHCmI2iLW8YUDibvhc5jLEn9t4gfQrA4s5N2ZvaegRB1NffLCevK/0V/TtE8H9X4gJgpUzhog29fMclwf1oK8i3KbkWW7uDKVwhsbeJz/n3XoSqzh68nRVbBsZtB7RgtK4BFiTuE6WyphZM+FT2wOPwPm9NqlxHHqAaOMEaiafZgFbMqfpxFeJmfFO678/4XlYVYk5B+utXmW49wJX95AIddMkCcvhAVAe3no4hwfwlt7uQBQCPOp2EZjLRyxOf2fyl7NzJoitZsz6AzFGAq2WAwCiVjMUcyVLiUYWE4G3T+V7uSyDQjQ58e8yG0+U8aKKYBmoKDCR33LF5Gy4QUvG9vhYGcgJfNfPI3DEps0dXFsIP59PsHT9GAdbG8oUZkSfQwq9e5E/ppRZfnG/f9grW+UDm+xVKiUW+6y/3WQyVHhNb+Hbi9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 18, 2023 at 01:14:12PM -0800, Rick Edgecombe wrote: > If a VMA has the VM_SHADOW_STACK flag, it is shadow stack memory. So > when it is made writable with pte_mkwrite(), it should create shadow > stack memory, not conventionally writable memory. Now that pte_mkwrite() > takes a VMA, and places where shadow stack memory might be created pass > one, pte_mkwrite() can know when it should do this. > > So make pte_mkwrite() create shadow stack memory when the VMA has the > VM_SHADOW_STACK flag. Do the same thing for pmd_mkwrite(). > > This requires referencing VM_SHADOW_STACK in these functions, which are > currently defined in pgtable.h, however mm.h (where VM_SHADOW_STACK is > located) can't be pulled in without causing problems for files that > reference pgtable.h. So also move pte/pmd_mkwrite() into pgtable.c, where > they can safely reference VM_SHADOW_STACK. > > Tested-by: Pengfei Xu > Signed-off-by: Rick Edgecombe Is there any realistic performance impact from making these not inline now? Reviewed-by: Kees Cook -- Kees Cook