From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D4A4C64ED6 for ; Sun, 19 Feb 2023 20:40:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FFE9280002; Sun, 19 Feb 2023 15:40:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B0B4280001; Sun, 19 Feb 2023 15:40:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 751C9280002; Sun, 19 Feb 2023 15:40:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 682D5280001 for ; Sun, 19 Feb 2023 15:40:53 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 39E181C5D6E for ; Sun, 19 Feb 2023 20:40:53 +0000 (UTC) X-FDA: 80485210386.24.45712C9 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf08.hostedemail.com (Postfix) with ESMTP id 5C6DE16000C for ; Sun, 19 Feb 2023 20:40:50 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=XSbexFaS; spf=pass (imf08.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.45 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676839250; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lqAwlutC29lMR1tf1e4XOcfdxhypv9zb0T2DcQuJ+3c=; b=23mUlOyhsvLvYqD3jbBYwwnsqBAy+H+1/O+pupKJDsyyIsV7zjP8OnoyaQdgXGfHXgdM1F hU7FMXfh7MEWdYWXPM8868X/zZvf+kPfw+tXYyOFQVxYti0ikPfGAEb2NU+Dlo7glEows1 exF5U8qGOJRflB3HNUHq1/Ij4ipp9T4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=XSbexFaS; spf=pass (imf08.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.45 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676839250; a=rsa-sha256; cv=none; b=pgaYIK1YAYQYvFv5gCCE2rMIhQTRClvgVv/f3p8S92FxF3BOzC0qBVC0fvPRLFL7uwMc38 533OeXwYD1pAm8ar4VL1x7eNHHOZv/stpepfwkucfnt9Ktj5OMwwlEocNLSM+pS6w+FRfb OXvuxBY4ITSopnucdU7wEO3UE7LcnRM= Received: by mail-pj1-f45.google.com with SMTP id e13so1284847pjt.4 for ; Sun, 19 Feb 2023 12:40:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=lqAwlutC29lMR1tf1e4XOcfdxhypv9zb0T2DcQuJ+3c=; b=XSbexFaS+Tm+Fh9bIb5+7TsH8cXc/OyRJvw9NZqY53ctg5O6XlonIQ+mSxQEFs9syE lUVQj3khdSe3Fc3LpOxcyIdBOEkgeUJK3z40Fm415uv701QNzTtbevYXP5ioH+guMWrP r7f7SjRms7JvKdWdxLsJL7avrtKIOQCRDQ1xE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lqAwlutC29lMR1tf1e4XOcfdxhypv9zb0T2DcQuJ+3c=; b=UbIQOHQI32cnuW1R4DVtUJh6W2phTcZgKzerfrSLdlbVTAfaeKelsMl+Zae5PqNHcW ac5y+ijqX07msEH7TmwegvFv/ZgzQAbeqieziGpmAzjAnu+lu9PWjiP2rsAIQmrDKVbe ufI45pZ6osL4ZdH5yOn81UbhhP6V/lqVjsGOTo3ZnP2MCNEudn+U6laBKjNSjdlBUpY2 g2JqMZBtzczOLm2UfBCv1ATd4RiIA8Y3NmPB4ruR5gA3SNDwyIJep2z40xUUk8VFHusd Sgxy5B0iJ05Ce7QCKa9zmmB/R3qSJVZJLD+6SwO4FwxCM3zCnFyAIaBqd+JeJ6RzYPok rHiw== X-Gm-Message-State: AO0yUKV3dwcLXszDsGxyNzVz7BUFDquu551D0mmCzK1r7dtVFHG3ijDw /5sbd2m0T4XwXUMHjLT7ebWNnQ== X-Google-Smtp-Source: AK7set8cjnk+CNzhzKm/hjA5DP1TH7rqpGSr8BvS/qmpfvVklVJ20vp+KwvbQWrpg9WzBslEVX8M9Q== X-Received: by 2002:a17:902:d4c8:b0:199:30a6:376c with SMTP id o8-20020a170902d4c800b0019930a6376cmr2895713plg.68.1676839248964; Sun, 19 Feb 2023 12:40:48 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id 17-20020a170902c21100b00199190b00efsm6372235pll.97.2023.02.19.12.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Feb 2023 12:40:48 -0800 (PST) Message-ID: <63f28950.170a0220.3759b.b525@mx.google.com> X-Google-Original-Message-ID: <202302191240.@keescook> Date: Sun, 19 Feb 2023 12:40:47 -0800 From: Kees Cook To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, david@redhat.com, debug@rivosinc.com, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, Michal Simek , Dinh Nguyen , linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v6 13/41] mm: Make pte_mkwrite() take a VMA References: <20230218211433.26859-1-rick.p.edgecombe@intel.com> <20230218211433.26859-14-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230218211433.26859-14-rick.p.edgecombe@intel.com> X-Stat-Signature: f1nxiioyuzmazuuwpronm66kdo9bgnry X-Rspam-User: X-Rspamd-Queue-Id: 5C6DE16000C X-Rspamd-Server: rspam06 X-HE-Tag: 1676839250-836172 X-HE-Meta: U2FsdGVkX19kRVQKlGh7r6Zi06mHQku/E4cVu2j1ZV+2dtTwJ5SdhOqPUr5vqDSEoIFxLHo1Y7r5ryEbf8O2yLlfOIdEWR9//LOjyaGrRUB9q1BnNI/C2WzKMlBRJ5VZkOVjmruAALzxclVIfkPWVTqT8uM3xaUPXwUaugXETE2v8enAct5epMy2Q7HHigQL5R7GTiqMevvmXK2L8gsO9I2NdEFcFXTXNRimADfMslem22to4Pmp+qD5Qyb5YByOoqWgs4PHn5Vocg+Nx1mMfEoM9WgCV7RAZTtJ3Kdgx9S33j+ChEr6GzCGxxK3u9mdkuB8rhb11TXaP1PsoJF7pR6kB9kAQui8YxBR3KM4C1UedS64eHvK/EMdrt2MRLP9szLkl9PQYpcYvkGllb9RkIK4YJpxzKxOhl4SOZZsbYdzNN8ohMNl/Pb6uc7/dtWoW8BwugVlSiqm26pOe0pUjvwj8jiCoi+icxu1GWACvOAFBF/QK+La6feEPt5gQAQUT7fPe7aBadSRYph1VlHtf2Q4qbpp5d3FVdnVXs6WlV7cg9cZ9fkoxW6VXxZOohNmmU+jMhxxOFfMcUe9OCX7fD2PF/6Xl/qsSL4JRV1eYhRmA+rxz3+xflH9NkcpXtSoUd5AkqUPbq17U9+1KJMQM96Ui/Mgpj1lPYeue6s8C2bAHwg3OTCS2Hu9Hz0lFNa78cjb/bsAqEmR9vkM0NTGlAu9YJVyoT7Vc4S4ytUPIwexzA38wwmH2qvYV4YW3wNZ63PQWXyKqrIAKYN6IybqJY9Kfgj+RRsgDQ2sH6kbUA0iocIarEyDhZH1fSH+5OTwb9NrVe335L+ppKpUZEVAzpOMs91l47Z+ZFGjtaueNBojs6BiolNmbz1wHm9C41vCA4isny8TkKrfPu/9qid/bEkXDJ5qM9NsdzXsUCkOHwrH4UXZABMF1AGJsNsjvyV7WAO1YWVts97cgQoLEcZ j2mImjh5 CoKwQ4TLKQ92b8pWB+ugPZL/EMzq1aq2+DhpmXcdH5EGG5BmqmeJI5Z7r0RqyKM5DMKQ5G6m595lmH5pkWc7c+1tr9WjlcnEl3fZPRu54Bsn6E4r10qHlTAnFERzVljREXX/Q6UAIt5yvLBhz/75K35lvwdyQF91voZPgZ5O1jonHQb/FmSgJdLTrK0WWIjuGB/CPeV1B3Ds8lC4buXUeiGw43VssAnnClkWTWDiMui+pqeAL7wbIhheXu2oP0q6hRKUhEajTNjUbz8mxsKg81ZJLaflTtc1xP27xS4GnKl9MQIn27sqPKHYPWqBbTAgt4X+QvnXSPDHBHSUgfnXN/63tTLE86A4mAQAuc6DVzk7QpT/qXnVJ7v0LJWQ4Xvc7hp0rzxDtJbbWAoBWSH469xhyAFHBkT5nKdxQri+7RUz3BiC2DPpSK+KRoJ0sj9YHhEivWSIlVyjdRcN00KhaTiFuNf76+7u7M3raIlrXHJRmCShtiethFTr4c5ZPSCvd/x52lLWX5c0DNGYZO0uyb4r+takx048UIlfS8Pdu4ZcMhWqlw5upE2/RiGwWxht7741aVIL3Ly0tdrBeSPqepZqMRjlWNeGtTuxU5FxT84kMPzYeJE0i7lX0oiEdom355rVgjyBdcsrgda9P1cUq63N20txxVuXZk2WagGdNQtFang7ZpaaBJIj/e+kQX3NlZPKhbYdIz54Ik+EtPH1tFcf45Aua21fGddAGyQTibo8Jo9Kxvn2iIBVi0wjU266J29UiKWPw9e/K7oFEoI3qzPCWbCxM7+sjve4BsxQ2sMjV/P21UDTYDQjq8mBopxvNu9SUWR5J5iY2Ytc4UOnTxzFdFBiurJwKXcAhwDCKG/vO+9+a1vT3JwQUpwyYS2/rMvSb8XVK+6V47V3GuSh8ENiTYe2HBc7bV4LT79iat0TsXzAVqQw5yKDxlD8+3FmziGHGpQXhAlTI4bnCRKCzEtgfcwQI EwoAYHad OwQwO4NVkLRgpWbp7SjkK064Bi/QZn30G36ov6zl28/pcBTX1BOiDw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 18, 2023 at 01:14:05PM -0800, Rick Edgecombe wrote: > The x86 Control-flow Enforcement Technology (CET) feature includes a new > type of memory called shadow stack. This shadow stack memory has some > unusual properties, which requires some core mm changes to function > properly. > > One of these unusual properties is that shadow stack memory is writable, > but only in limited ways. These limits are applied via a specific PTE > bit combination. Nevertheless, the memory is writable, and core mm code > will need to apply the writable permissions in the typical paths that > call pte_mkwrite(). > > In addition to VM_WRITE, the shadow stack VMA's will have a flag denoting > that they are special shadow stack flavor of writable memory. So make > pte_mkwrite() take a VMA, so that the x86 implementation of it can know to > create regular writable memory or shadow stack memory. > > Apply the same changes for pmd_mkwrite() and huge_pte_mkwrite(). > > No functional change. > > Cc: linux-doc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-alpha@vger.kernel.org > Cc: linux-snps-arc@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-csky@vger.kernel.org > Cc: linux-hexagon@vger.kernel.org > Cc: linux-ia64@vger.kernel.org > Cc: loongarch@lists.linux.dev > Cc: linux-m68k@lists.linux-m68k.org > Cc: Michal Simek > Cc: Dinh Nguyen > Cc: linux-mips@vger.kernel.org > Cc: openrisc@lists.librecores.org > Cc: linux-parisc@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-riscv@lists.infradead.org > Cc: linux-s390@vger.kernel.org > Cc: linux-sh@vger.kernel.org > Cc: sparclinux@vger.kernel.org > Cc: linux-um@lists.infradead.org > Cc: xen-devel@lists.xenproject.org > Cc: linux-arch@vger.kernel.org > Cc: linux-mm@kvack.org > Tested-by: Pengfei Xu > Suggested-by: David Hildenbrand > Signed-off-by: Rick Edgecombe I'm not an arch maintainer, but it looks like a correct tree-wide refactor. Reviewed-by: Kees Cook -- Kees Cook