From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE7D0C05027 for ; Fri, 10 Feb 2023 21:35:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5669C6B0075; Fri, 10 Feb 2023 16:35:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5163D6B007E; Fri, 10 Feb 2023 16:35:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38FC76B0081; Fri, 10 Feb 2023 16:35:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 25B766B0075 for ; Fri, 10 Feb 2023 16:35:34 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D73781A0E35 for ; Fri, 10 Feb 2023 21:35:33 +0000 (UTC) X-FDA: 80452688946.07.BCA3006 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf05.hostedemail.com (Postfix) with ESMTP id E373C100019 for ; Fri, 10 Feb 2023 21:35:28 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IQGBvWlk; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf05.hostedemail.com: domain of dan.j.williams@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676064930; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zvMV6R2NEjcC2/OAfNdgjP44M5KXejWi6f7ILS5pfgo=; b=a5Wh13gMm0XR9LPHF+htTc+aI2UUx9vmrkofZXK1Y+Uiz7Pi0jBabta4HR8OD7zoc/G5yZ Nh731TVwUXRC9T7mce7QY+O7O2iMJdI1YF1VoSJ5daYFP9f+oB4NWpCPNFYQpoxMk//Gcj Tm0o7QlqQLhU0I5lumvSviLm9WhjP70= ARC-Authentication-Results: i=2; imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IQGBvWlk; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf05.hostedemail.com: domain of dan.j.williams@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1676064930; a=rsa-sha256; cv=fail; b=TxubsbDpk1mpOqtWMRHlxqao0MRolTIVkMGSzUEsY/NJCOtlRXM4vevTQAfJKkVfYAVfLR CaQwaGTkXTPnC1zbujjCFi1xSgCVHb69PXHTJdYaFF4Ate18U+RXw+u5OF2i/8mO6KN/il yvhr7e2oSRsfPOyWER4oz4Bm4d3OKEo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676064928; x=1707600928; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=eHujy0CDGIHnqpC84TUVLj/84COPnbs2xTP2Pl847d0=; b=IQGBvWlkDaKHvT66b01sPwdgjV5gPwZPqmu1Jno08ht5FKdBdZ5alu2p b+J+5bVpqqgACGz8NEfo2/660+w/g7UxU+n6ph6jrN911n+6REhPOqgTe ffEodNEMeMzyszBrY+y0Vk+kSv88wuNKZ/cx2pjpkUOSsLD9IVjcB34Z6 fdtUE1/QoiHR3qckA5wlR+OjkKHbwUvV2Z5gJax7rwVxCD7LE+rtUcjan oWqIm+x5/Ydz+X4FAGgCRGGyKRsf8jczAnm8QCB3x9Jd3PocVFsh68xk4 8vZiEKORj0EwebomsfRt4aWsGmShigfWR5vgdAzvFZs9aGIfK5ykhIqug Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10617"; a="310162866" X-IronPort-AV: E=Sophos;i="5.97,287,1669104000"; d="scan'208";a="310162866" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2023 13:35:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10617"; a="756923951" X-IronPort-AV: E=Sophos;i="5.97,287,1669104000"; d="scan'208";a="756923951" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by FMSMGA003.fm.intel.com with ESMTP; 10 Feb 2023 13:35:23 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 10 Feb 2023 13:35:22 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 10 Feb 2023 13:35:22 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 10 Feb 2023 13:35:22 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Fri, 10 Feb 2023 13:35:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e/HSBJOd4VpdxpAsSr/LmQKxIyFYQTNSi38JzTZXiQ++Os4K5FqzU1yj4epH/w6HB+DpbaIrlXqyKR8UCjLFnfsX4ghUXNaxbhNfMZS0NfsjTuCRdJRaW+qJqrUBNNsHPGPld6Z1vzlcoP8lLctiBKeoJ/d+LHXldwdBDD+WMVk0npwN0h7VlhxPo4JFRs/8nPBBHsV1UX/GoDBSrhc1WPCAKDbaq88eCvClT4xfshegglNm2/JywYbiy/uDgeWJkKWpDw0qWFqKC4UBDk76WIWnZ/NEqlzhrTfBkRvM569LPsMN+WbgEgviG0QUFLGV6Hv+looALjRT4wXCK+n0Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zvMV6R2NEjcC2/OAfNdgjP44M5KXejWi6f7ILS5pfgo=; b=P0hRSINmue88Mjz5lER55XsCQP/L0Agj2TfaM3RJvpgEv/xPpXKP3PKnnQIEEJJzMJOpHEFJpGnuSE6yxzVe65Z3D1+N5k81VaC/igllx3A2beeCVaXEeHw7gwjMv0YuPdM4kUBJVKVbmzDWQx365O/14R/Z8Mqo/i+J6w/xrQCdAAj/5ETls89x97kdf0R3p8jbCEdg1dU84r8yS9/dPjd6oqnMiF3GaYd81EZQmLg5QdzDos+9q6YL/ybEQB5Z9Qg06hf4WkZI7OgMsk37lY0FVxeBY9oVREVUuX57/biDfnLHGSNROprdANHE519Oxm9r+QVK+ZqGPkmnnS/QqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) by SA0PR11MB4688.namprd11.prod.outlook.com (2603:10b6:806:72::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.21; Fri, 10 Feb 2023 21:35:20 +0000 Received: from PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::421b:865b:f356:7dfc]) by PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::421b:865b:f356:7dfc%5]) with mapi id 15.20.6086.020; Fri, 10 Feb 2023 21:35:20 +0000 Date: Fri, 10 Feb 2023 13:35:17 -0800 From: Dan Williams To: Jonathan Cameron , Dan Williams CC: , Fan Ni , , , , Subject: Re: [PATCH v2 13/20] cxl/region: Add region autodiscovery Message-ID: <63e6b89581c3c_1db5d029467@dwillia2-xfh.jf.intel.com.notmuch> References: <167601992097.1924368.18291887895351917895.stgit@dwillia2-xfh.jf.intel.com> <167601999958.1924368.9366954455835735048.stgit@dwillia2-xfh.jf.intel.com> <20230210180958.00002e5a@Huawei.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230210180958.00002e5a@Huawei.com> X-ClientProxiedBy: BYAPR02CA0071.namprd02.prod.outlook.com (2603:10b6:a03:54::48) To PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR11MB8107:EE_|SA0PR11MB4688:EE_ X-MS-Office365-Filtering-Correlation-Id: 17ac955e-5909-4fa4-a1e0-08db0baeb54e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1/C0KLOC9gzBPsJwoSgUx6tDjN/63BaCAPYahKTzKBVMliAmC40Gn4N5d+waI6xTinz/0m15hFYDiJ7RVxfCg4kb0U/Hji++uzTV36YoNuGb8mtt6v2ePSXnSii4AFy/NpVS4aPjiybIgYwAeWPfWqWAu6vwPESDjd6Mg6QZiBfpS1EGKsQW45gzWlQ8lFoIoWpFtiMkD3o/prctRE+UH9rOYfsrwUSIleujbRIQuacJ+GMnHUynGFTHeTlAMQ2SCR9Ui4tSLcUcvIpyLCv55NfCSsiBbfVidhVHWKpnjSXFHCZz2jFJZ4mA4g5O+e4FK2kf2hUD5ipGRS8uOLKmnEB+Kic6uhcTB56Z8iMAKNbrztKmYRS8rIPaGZw9lZPAkxu12Im1yJtXpu33Iihv2QnKHk33VGQqxLTN2jboj+nT78c01HOOWu8TR6cFbsco+JohK2OufSPIQUMjQn5zuNy/MzmDlDstbi8hLABPAwXUhk+vS/NGEKa91Grz9lWYfK5Je64m8dvxJdcYKpmho6pWiGesw2PZR4BfUn/iRA7uoW+xyBgNwp3VPivwFh6HVTXJbNDhfEFFNiAqE1yVUP3ZeujiK5CnxvPanUiAwZ+QNdYat6dqGBj95gRl4QV3UEQQC6XheP1WUtvVHfZxu5SBcyPsFHzVcHRiVJyyDcM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB8107.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(39860400002)(396003)(346002)(376002)(136003)(451199018)(2906002)(86362001)(82960400001)(38100700002)(6486002)(966005)(186003)(6506007)(9686003)(6512007)(26005)(66946007)(66476007)(83380400001)(66556008)(316002)(110136005)(6666004)(4326008)(41300700001)(478600001)(8676002)(5660300002)(8936002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+BYGcDTXdcJ1l6Rd1YLWf8ERnv9Mk8k+4C6XTVHI/izer2+MQiNWMTpLKT5X?= =?us-ascii?Q?LXVz3KS+Emhtee45YKCm/12Sgez9PY7Ivr1okEcPT61rNxD9ruze3Vsgtvr2?= =?us-ascii?Q?Ix5cjNuQ8i0tZyQJuRCTDM5s1enmefTTEXinu2S+hPR6T7blB9e6FIb6+XwR?= =?us-ascii?Q?RgriAArIAGGcFeeRTLXsczfBRNvzkT6BzwEt8fGxtIInfarDKpDlTigTbrp+?= =?us-ascii?Q?icMPaUswDA+eoGO8qIT8XATSprLisym8kWW60REHeoUnYxkrv2zk44lPptc0?= =?us-ascii?Q?OMxxEBk6e/xWwZOYL58UDpl4/3VsD34besIyUOzI+/qLBdGrq7EnthEoQ9ej?= =?us-ascii?Q?ZnROQ6P2IzPh9Ov8OYtTQL4PVdg8wauoR7MyDT3D7IOkvMxqrtI9rM1unMCA?= =?us-ascii?Q?YLkAvsTVx91uzoIfi3/gvwItcwIPwcp/H7N5Jmp3Sm2MmU4MClXp/2EwIZ/K?= =?us-ascii?Q?Bs6fVW9qEcPzoUdVHtiTJGGk305K0KMqmUwEE/xOQ1f6msE8ngvfLbgjCV3Z?= =?us-ascii?Q?uubQjUfFvkAddu102gM+PGE5VBC1ec9z6hRl8AKggiGfGj8u0gs1poU8xEXY?= =?us-ascii?Q?GZpGoUGesBS0X/iIzG1vvrx5c/CGeraWpm4icL9mhLig1ahR3rs4PZKsff1G?= =?us-ascii?Q?+khieKQuyJJm/GtlLVIw6rOVELl+Se+Cmxbf0uO/Hc3PMd2JxQjdC1wyY6Fn?= =?us-ascii?Q?mq/pD4kZVuo/p53hbGr4aJv37Z9Vf6wmyWhFzLK67k0aDPmJ5iQp1vUKIttW?= =?us-ascii?Q?wTXTe6JB35eXbqCMIfzaxcusOjyHt++7MKKaG0fah29fHqBlKC8QJXfzQA/Q?= =?us-ascii?Q?92n9avTXdeys8VJA0B9mTrwHcBQoX4xbUWK0BkKqBs0tkg1W4U3ygyfNaq4Z?= =?us-ascii?Q?ADJ+y1rM3zojnudsLphluiZadrZ039exsbJUD4ZhcKScOp3AGdEsaqZTbtaw?= =?us-ascii?Q?FuElgY8Hs2lfzHLTPhSPRwGzKtvgaOKiw2VxQ1udQ70PvB3gew9TlGeNuHKs?= =?us-ascii?Q?Fh+tpkxBSnBCL2bq9WIWWOUGT+AZdUp6h+cngLUfuIetbszE3sPJelOr81Z1?= =?us-ascii?Q?fR5FssO9I/unqB2AaWCB7V6Ddm7tqd6HvSTChWBd33CGoJ1UUjGiOiAXGShY?= =?us-ascii?Q?ud/whWk04A++bXEs0J9Li2Gl2LbVro02ic1BJFAeju2WL53YnvobtONrHLZh?= =?us-ascii?Q?cvDa4L1zFRAPjGT7ZXX0H1jfVOiN5azOQw8UKVlTJJLfbXEyK4Ag6EInsEps?= =?us-ascii?Q?RQsi7OWvkheV47j7ZmbOwyxp33d13dGp2yW9r4i21bDNixvZL+dSNDwXIoy7?= =?us-ascii?Q?Dbuzc8D1T6YLlJPl+3+v1jDr2Df0nl4PsvGctiv+h4Njl3HAAbOa9FfGABi6?= =?us-ascii?Q?oNoGUV+rWGrhWKmBpiR2ZMTbz7vPauo0i9cIvgtJtxryZTvhvOSlCd0Oa4TR?= =?us-ascii?Q?xyWBjvDShJfP6wMPZW7IVenDVaGQe5MknMoi6plMphppyKv88krePQmGqTnq?= =?us-ascii?Q?gbRcmrHmk+S5paVdrJiswkFxD64+wy9uTBcET6kpM2e2eztxWbFYDqllGFgR?= =?us-ascii?Q?6M/tsmDAlOx97mweX5Lk8iCqPKhU3/a+k2dX9dKIZxyl1IbUpXnQgS0dXevj?= =?us-ascii?Q?dQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 17ac955e-5909-4fa4-a1e0-08db0baeb54e X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 21:35:20.0070 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qdiXCEjMtiEQyiCbksIb3rTtaYJGS3V1nvLbz3w23ekamg97/0GE3usubV2KdBgUTkke+761DrK/EqDfjHPCkORUVGuoKxCHrzSTGQCCzCg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4688 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 3n1hg41jdy8u1n465dib4j1hiucfyu1u X-Rspamd-Queue-Id: E373C100019 X-HE-Tag: 1676064928-709709 X-HE-Meta: U2FsdGVkX1/fEGXm8W2m5MebXxwlVosyrH7tbkhGG27dQf3oYbsOrISGbnOlUdflpVGcos43Tq1WABaomveHdKYgH6x3KQUHkAaD51VFi8Dd6l3EEPGd2SsjBGzV13QdQZ+W1DVlrmF6DlvdxUKCW3qEhESbJpVShrpYCsJfmVKLAmGD46E8Le+RJpSgO1zKg1NxHcJdeBSUN86tvER63hdinJHuWBnpybFF0xHF0a6xcbCFGWs/5rt6ZOUkqsqXpl7F/MDeeawJrRR/HNhs2Z+2BR21kXETobMyMOjkUscVo8GWU/sTJk77HYfa9V0yft6mUhMx1f0TkbwCQue92NbtstNxDXRXKTyLbPEydqEX5nQimrk/sufNNwXbe4bDyX2DfaDgYhV+qPHbmCBNc8GMrbglUenrGNcmMjtbYTbXJ8WtIbbiZsqqfyL8eEtpl7sNyj/AsNd/e6NpO/zSJcKmOa8Dcz0sRZtJfO1c4KFWc8Os3xRr5Wse8aN7Yns+kWiM5lNDU8+G54xWyF3klWHoQDS1xbusaGAU1d60KlSmmrN4Og+3e3a6k/dEuenNDdX3UN3sN+wHIBrxRTxDSjAF/y7vAU7aWhMVoiw8QAuDY39mubUwL8tFk3RBWVhhAiQ06s6E3/E83EWlgan8v/vyigmAEv7tE1R/BGUGp47e96+OUASrexm7K7BYtJL9R1Ebdw7Ui2mO6FoO9LYUKtEa9d9pIv5oAc4g3Q57Xo//vzBGHkCkyvUXqRddl4Gf6zvnvfxnksrdDubhaY60xaZ3vysaBP+wtJwxsFl8lFQsA2L85cUNV10yWz4Jhm9Y0ReMT1CMWoffS4Jvhjwjpqm46hhx/qnS3LG3Hdp7C1X8pKg6giaccS80ET2zMgQNXiEbuGW5xisETNv7ioLK27FTBj6FlTX2+QX2yVCx7r7Z2+BDZ3KR3qQu3cfD3wkByjfGRKsilq4nHKgdSAv M1BloAX5 c1/QX0EdLWZ1q+qnkZYKT232yhoL7iTJsl7UzvCscT0q5gh9ahp/grjy28JwZ56PoQ26JSqTjFO1GxD4WD+BFVJGIhXkuJFX/joND4jDaUPoxXh8C0k9yKSHvSS0aI7VdcjU3HAnkR8G7d7iq1H6lfEg4edS8LELZSDi+SWdyT3xIrAM+VY66DzgtBUoKGzZ4KRN+2tLqn8HJFtJcMEU4wHBIwiQFu8phPxZA1TSBY44Yq6nYQhRoWehbR5jGFsSE0CbzIo9D/ZNLsG28ogOvE/JmZBAhqB+itZ8JTXkMPh6CE/EKltVA+/3fb4K1w7StPHLyxhKgrt6mIFcdl1+MWMnGVSpWKJIg+pzdVwA0tKTgk4t3fMSFPyN+3UeIojbT9ci4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jonathan Cameron wrote: > On Fri, 10 Feb 2023 01:06:39 -0800 > Dan Williams wrote: > > > Region autodiscovery is an asynchronous state machine advanced by > > cxl_port_probe(). After the decoders on an endpoint port are enumerated > > they are scanned for actively enabled instances. Each active decoder is > > flagged for auto-assembly CXL_DECODER_F_AUTO and attached to a region. > > If a region does not already exist for the address range setting of the > > decoder one is created. That creation process may race with other > > decoders of the same region being discovered since cxl_port_probe() is > > asynchronous. A new 'struct cxl_root_decoder' lock, @range_lock, is > > introduced to mitigate that race. > > > > Once all decoders have arrived, "p->nr_targets == p->interleave_ways", > > they are sorted by their relative decode position. The sort algorithm > > involves finding the point in the cxl_port topology where one leg of the > > decode leads to deviceA and the other deviceB. At that point in the > > topology the target order in the 'struct cxl_switch_decoder' indicates > > the relative position of those endpoint decoders in the region. > > > > >From that point the region goes through the same setup and validation > Why the >? I believe this is auto-added by git send-email or public-inbox to make sure that a sentence that begins with "From" is not misinterpreted as a "From:" header. You can see this throughout the kernel commit history. In this case I pulled the patches back down from lore before editing them to collect review tags. > > steps as user-created regions, but instead of programming the decoders > > it validates that driver would have written the same values to the > > decoders as were already present. > > > > Tested-by: Fan Ni > > Link: https://lore.kernel.org/r/167564540972.847146.17096178433176097831.stgit@dwillia2-xfh.jf.intel.com > > Signed-off-by: Dan Williams > > A few trivial things inline and this being complex code I'm not > as confident about it as the rest of the series but with that in mind > and the fact I didn't find anything that looked broken... > > Reviewed-by: Jonathan Cameron > > ... > > > > > + > > +static int cxl_region_sort_targets(struct cxl_region *cxlr) > > +{ > > + struct cxl_region_params *p = &cxlr->params; > > + int i, rc = 0; > > + > > + sort(p->targets, p->nr_targets, sizeof(p->targets[0]), cmp_decode_pos, > > + NULL); > > + > > + for (i = 0; i < p->nr_targets; i++) { > > + struct cxl_endpoint_decoder *cxled = p->targets[i]; > > + > > + if (cxled->pos < 0) > > + rc = -ENXIO; > > If it makes sense to carry on after pos < 0 I'd like to see a comment here > on why. If not, nicer to have a separate dev_dbg() for failed case nad > direct return here. Ok, I'll add: /* * Record that sorting failed, but still continue to restore cxled->pos * with its ->targets[] position so that follow-on code paths can reliably * do p->targets[cxled->pos] to self-reference their entry. */ > > > + cxled->pos = i; > > + } > > + > > + dev_dbg(&cxlr->dev, "region sort %s\n", rc ? "failed" : "successful"); > > + return rc; > > +} > > + > > > + > > +int cxl_add_to_region(struct cxl_port *root, struct cxl_endpoint_decoder *cxled) > > +{ > > + struct cxl_memdev *cxlmd = cxled_to_memdev(cxled); > > + struct range *hpa = &cxled->cxld.hpa_range; > > + struct cxl_decoder *cxld = &cxled->cxld; > > + struct cxl_root_decoder *cxlrd; > > + struct cxl_region_params *p; > > + struct cxl_region *cxlr; > > + bool attach = false; > > + struct device *dev; > > + int rc; > > + > > + dev = device_find_child(&root->dev, &cxld->hpa_range, > > + match_decoder_by_range); > > + if (!dev) { > > + dev_err(cxlmd->dev.parent, > > + "%s:%s no CXL window for range %#llx:%#llx\n", > > + dev_name(&cxlmd->dev), dev_name(&cxld->dev), > > + cxld->hpa_range.start, cxld->hpa_range.end); > > + return -ENXIO; > > + } > > + > > + cxlrd = to_cxl_root_decoder(dev); > > + > > + /* > > + * Ensure that if multiple threads race to construct_region() for @hpa > > + * one does the construction and the others add to that. > > + */ > > + mutex_lock(&cxlrd->range_lock); > > + dev = device_find_child(&cxlrd->cxlsd.cxld.dev, hpa, > > + match_region_by_range); > > + if (!dev) > > + cxlr = construct_region(cxlrd, cxled); > > + else > > + cxlr = to_cxl_region(dev); > > + mutex_unlock(&cxlrd->range_lock); > > + > > + if (IS_ERR(cxlr)) { > > + rc = PTR_ERR(cxlr); > > + goto out; > > + } > > + > > + attach_target(cxlr, cxled, -1, TASK_UNINTERRUPTIBLE); > > + > > + down_read(&cxl_region_rwsem); > > + p = &cxlr->params; > > + attach = p->state == CXL_CONFIG_COMMIT; > > + up_read(&cxl_region_rwsem); > > + > > + if (attach) { > > + int rc = device_attach(&cxlr->dev); > > Shadowing int rc isn't great for readability. Just call it rc2 or something :) > Or given you don't make use of the value... 0day did not like this either... > > /* > * If device_attach() fails the range may still be active via > * the platform-firmware memory map, otherwise the driver for > * regions is local to this file, so driver matching can't fail > + * and hence device_attach() cannot return 1. > > //very much not obvious otherwise to anyone who isn't far too familiar with device_attach() Hence the comment? Not sure what else can be said here about why device_attach() < 0 is a sufficient check. > > */ > if (device_attach(&cxlr->dev) < 0) > dev_err() > > + > > + /* > > + * If device_attach() fails the range may still be active via > > + * the platform-firmware memory map, otherwise the driver for > > + * regions is local to this file, so driver matching can't fail. > > + */ > > + if (rc < 0) > > + dev_err(&cxlr->dev, "failed to enable, range: %pr\n", > > + p->res); > > + } > > + > > + put_device(&cxlr->dev); > > +out: > > + put_device(&cxlrd->cxlsd.cxld.dev); > > Moderately horrible. Maybe just keep an extra local variable around for the first > use of struct device *dev? or maybe add a put_cxl_root_decoder() helper? > > There are lots of other deep structure access like this I guess, so I don't mind > if you just leave this as yet another one. Yeah, it's difficult to have symmetry here, but I think I'll switch to using an @cxlrd_dev variable so better match the get with the put. > > > > + return rc; > > +} > > +EXPORT_SYMBOL_NS_GPL(cxl_add_to_region, CXL); > > ... > > > diff --git a/drivers/cxl/port.c b/drivers/cxl/port.c > > index a8d46a67b45e..d88518836c2d 100644 > > --- a/drivers/cxl/port.c > > +++ b/drivers/cxl/port.c > > @@ -30,6 +30,34 @@ static void schedule_detach(void *cxlmd) > > schedule_cxl_memdev_detach(cxlmd); > > } > > > > +static int discover_region(struct device *dev, void *root) > > +{ > > + struct cxl_endpoint_decoder *cxled; > > + int rc; > > + > > + if (!is_endpoint_decoder(dev)) > > + return 0; > > + > > + cxled = to_cxl_endpoint_decoder(dev); > > + if ((cxled->cxld.flags & CXL_DECODER_F_ENABLE) == 0) > > + return 0; > > + > > + if (cxled->state != CXL_DECODER_STATE_AUTO) > > + return 0; > > + > > + /* > > + * Region enumeration is opportunistic, if this add-event fails, > > + * continue to the next endpoint decoder. > > + */ > > + rc = cxl_add_to_region(root, cxled); > > + if (rc) > > + dev_dbg(dev, "failed to add to region: %#llx-%#llx\n", > > + cxled->cxld.hpa_range.start, cxled->cxld.hpa_range.end); > > + > > + return 0; > > +} > > + > > + > > Two blank lines? Just stashing this here so I can introduce a spurious whitespace removal in the next patch. Will clean up.