From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F35E1C6FD1F for ; Tue, 19 Mar 2024 16:59:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88AB96B0083; Tue, 19 Mar 2024 12:59:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83A086B0085; Tue, 19 Mar 2024 12:59:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DB596B0089; Tue, 19 Mar 2024 12:59:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5E2E66B0083 for ; Tue, 19 Mar 2024 12:59:52 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E5E944085C for ; Tue, 19 Mar 2024 16:59:51 +0000 (UTC) X-FDA: 81914400582.02.BB879AF Received: from fhigh8-smtp.messagingengine.com (fhigh8-smtp.messagingengine.com [103.168.172.159]) by imf11.hostedemail.com (Postfix) with ESMTP id 39EB84000C for ; Tue, 19 Mar 2024 16:59:48 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=fastmail.fm header.s=fm2 header.b="0u9/fpcI"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="l rNIPM4"; dmarc=pass (policy=none) header.from=fastmail.fm; spf=pass (imf11.hostedemail.com: domain of bernd.schubert@fastmail.fm designates 103.168.172.159 as permitted sender) smtp.mailfrom=bernd.schubert@fastmail.fm ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710867588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cHdFUwNUaNtHseK/mzgvFDOdmo7eBJ0OS3s8iO/q7R0=; b=sIoajl5TM1BbXp+u07/+xEpB10NZJ3uDbiRSjp4T/QK52qwrVdUXWteJ4N+tDCYRpwUAky /eFwoYh2vVF9Dw9yuTYgi541jpueGbYusJu6HZq8dJfAZSvczZaxJuy19ATFbEPyzUR4pI hgqKHpqi6XgL3MiCuum7cb2Vrn0q+uE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=fastmail.fm header.s=fm2 header.b="0u9/fpcI"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="l rNIPM4"; dmarc=pass (policy=none) header.from=fastmail.fm; spf=pass (imf11.hostedemail.com: domain of bernd.schubert@fastmail.fm designates 103.168.172.159 as permitted sender) smtp.mailfrom=bernd.schubert@fastmail.fm ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710867588; a=rsa-sha256; cv=none; b=Fk4LDFRK98oiRPQAKnUHTbS9azRgmL3598cVwEdXMkEHMfEcKdxZ5LY/cU2vpZkZQQFrbG 9U3eXvDqdv7p/lhDe9u+oqR71rpW0ihX+ijFI45jKAIKQrbeb1Qg0X+avxCVctjaJUTExE dyTeaW/vttUtobXlnjF0dK2ru+TVk/c= Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 8750E1140101; Tue, 19 Mar 2024 12:59:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 19 Mar 2024 12:59:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1710867587; x=1710953987; bh=cHdFUwNUaNtHseK/mzgvFDOdmo7eBJ0OS3s8iO/q7R0=; b= 0u9/fpcIJQPoY0zpSCSJ6gTPGTGnlb3KOcQLJQwVoFNWumffgMIIO56GHh0ukM4I PWYbUjIJOaDdaZZ3BKwmOQIybUPlcppqssGdWvfDmEfRO1C+EhqIHG5qLORrYn1o qq6MWOx/cN4EvD9Wu/N9lFNoUoWXO1uo9Aa+Py8FP7yFheRD3pvRA4a6VyaWd+Rb yqy2xrgqf+UftdQXAjWZorzwEthFH1X4bUPGo5GhF13V1yLhgioycWUwQLGTQ1BP E4Jc5iJ4+9kAOv2HXWSWAp1Xxj+FuEJ9YkgfYRN2bwlUe96iq7tSRA01cR+2list hQl6u6AbGGgsmn8nPUK2xQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1710867587; x= 1710953987; bh=cHdFUwNUaNtHseK/mzgvFDOdmo7eBJ0OS3s8iO/q7R0=; b=l rNIPM4xpEKf2RZpW1L6EY8hMPyl0jjOpe1MzAtqVxSww7hjUNwG+igvOnMrB2vKD uk5/6o9swhOhRdTEBhPQFfKaj2tVsMMNPM5/dnt4AMFILolNuIwVeOnWY2ciHnyf WN58rRHTp6Mo14sWlR8R0Yap+DaTkJMfaGFljXx5ENWroxZPgRr3/BmE6e0bNba7 U2BXvYFY+eiV8fi8BFz5gTGNoHm4orSK7Gja3/QQsrhR0aTgZOUVC7b3Yuj2UBry 8bn/qTnv6kojC+Hzm+5xruFjYzL6RIr66kh6rlkc/RP1JlEFJydP1JVI4wkb4yEL 1eKgP3HUkQNAR3pU7X/Cg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrledtgdejtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepuegvrhhn ugcuufgthhhusggvrhhtuceosggvrhhnugdrshgthhhusggvrhhtsehfrghsthhmrghilh drfhhmqeenucggtffrrghtthgvrhhnpeevhffgvdeltddugfdtgfegleefvdehfeeiveej ieefveeiteeggffggfeulefgjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpegsvghrnhgurdhstghhuhgsvghrthesfhgrshhtmhgrihhlrdhf mh X-ME-Proxy: Feedback-ID: id8a24192:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Mar 2024 12:59:44 -0400 (EDT) Message-ID: <63e67db9-7425-4928-afb2-cbe7cc6232bb@fastmail.fm> Date: Tue, 19 Mar 2024 17:59:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm: Replace ->launder_folio() with flush and wait To: Miklos Szeredi , David Howells Cc: Matthew Wilcox , Trond Myklebust , Christoph Hellwig , Andrew Morton , Alexander Viro , Christian Brauner , Jeff Layton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, netfs@lists.linux.dev, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <1668172.1709764777@warthog.procyon.org.uk> <1831809.1709807788@warthog.procyon.org.uk> <651179.1710857687@warthog.procyon.org.uk> Content-Language: en-US, de-DE, fr From: Bernd Schubert In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 39EB84000C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 79xpraw56buhej9yboz8fa47yzhobwck X-HE-Tag: 1710867588-799784 X-HE-Meta: U2FsdGVkX19HuPOL+HPxkmI18Io7Nmen+jjKxfBt4Qg6l7EYIsOSs3rU4TSF/7FyVIX+Zl4dMSXl1b88wwZgF8cmug9X3h0gFPuKZe6ou365i6oncKkFdU/BT7tWaviaBweB+SicHeZcL6RnLVXyF8b53+3mxFTadgLmLT8+/jXD013NrGg1BJKhOnCmaqKoq/8Zb+qGbUXyxT8O/TR+K4q5BfG2/8sON13x09JkkxVeY9VbmmXBlwEcVg9Sm85G5CClkeBtR52St1hvvSqZCDAR5rlZM5BgXpyjVSI07ynZY+hgQaREg2Zj5x1+PySvmnBCxhUJDHtMRvflqc3J6ZXggPKpZwmzm/78RZkqxSskN0SzINAewJ21mby3fCWh6bh3XiFfhtsSh0yGKDH74fsaKDVglTEO0ECe+1BjVtCCnlNqi15/5knkRrStsQZmYI9ltFUjPfoSSS4899ZJs1pLddADk86EEbRXe5EF8wnbaMxH9XvDk8qZJHneqvj5Loak1FgC5RSCJcEy2Nm70FLy7brFw5IQqGDliBYG/xN2DP6ItHxJ15cqfKorvoz7yrwVUGSriuEcjzx5yW5W1/2Yb0C2XEqyuZiLFqI5ZJ343EInPxYFQxshhSDb8Y4suePILhfoX3xpcQyP8G75lbvo0DGSBNdFto2TS/Z8+n9k8ezXfcLZIChbxZRcJhZbREylPH5SYHovWONCBa18RktLXyw1sHtM4+eoOp2lhZ0BrmNVkgcIUym/I3Kf3U2HugQt9KOWv2yMaEdRzxk9kcYI7/DHJDBTWfvNDNTOGtLmWLzVHEFuGVEThhNdTpBdUxZU0NWxihGIRdJKdpJYe9r0fBqozRyuIOqhOu6HgVjURddd85KQSKcAu+MqJXIsoYhmtzhZWPd5zFaaBRKb0TQE2sSI6kmyy69rwINeoLzFLqn+u5DoGlnf95T3d2uHDZvv0EGEdcbl3J0thQA RaSL2OZ4 PeTVk5faSB+fMHQQPfiD112bxpq45FTdlUBTG2C6od0A7zjlUWBVWAGg1OyCTrNOhMg6VrPotSCwj0KXfkJhQ1bJV+mVZAxG2EUl9et8kmksMMCwPSkGmQJhVZ44bdeFzys2aJrcFDeEuz/Yu4PZOhf7iymQgVnbJ2Jb5+UBGncQ7IRwiR5S3SnDhAzNRWnQQqUORlZgf2MYl1umO9nk8vH7k9hj1zxHi+oldmroVxxadoK8DaLLOe7ciFTTB0JcyFd4VyYu7JTq3K40I+iN3xYVr+hzgdx6sqew25M0WUR/08f6rzI11mkg/aeZDjIUyjdhSrBcsOoPZ9Og9zzqJmurdojIWSjPXvj3YuruXSbLdbOrZBtwZ/mRpng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/19/24 17:40, Miklos Szeredi wrote: > On Tue, 19 Mar 2024 at 17:13, Miklos Szeredi wrote: >> >> On Tue, 19 Mar 2024 at 15:15, David Howells wrote: >> >>> What particular usage case of invalidate_inode_pages2() are you thinking of? >> >> FUSE_NOTIFY_INVAL_INODE will trigger invalidate_inode_pages2_range() >> to clean up the cache. >> >> The server is free to discard writes resulting from this invalidation >> and delay reads in the region until the invalidation finishes. This >> would no longer work with your change, since the mapping could >> silently be reinstated between the writeback and the removal from the >> cache due to the page being unlocked/relocked. > > This would also matter if a distributed filesystem wanted to implement > coherence even if there are mmaps. I.e. a client could get exclusive > access to a region by issuing FUSE_NOTIFY_INVAL_INODE on all other > clients and blocking reads. With your change this would fail. > > Again, this is purely theoretical, and without a way to differentiate > between the read-only and write cases it has limited usefulness. > Adding leases to fuse (which I plan to do) would make this much more > useful. Thanks Miklos! Fyi, we are actually planning to extend fuse notifications from inode to page ranges. Thanks, Bernd