From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57881C5AD49 for ; Tue, 3 Jun 2025 12:37:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC7FC6B03C0; Tue, 3 Jun 2025 08:37:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E791D6B0404; Tue, 3 Jun 2025 08:37:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8F956B0410; Tue, 3 Jun 2025 08:37:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BB7C26B03C0 for ; Tue, 3 Jun 2025 08:37:50 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6ADFCBB929 for ; Tue, 3 Jun 2025 12:37:50 +0000 (UTC) X-FDA: 83514041100.17.D2F76FE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id DE23D40003 for ; Tue, 3 Jun 2025 12:37:47 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VKMvvJHN; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748954268; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kHS2t2oaHj5ILyKgrMhDZwz0UVPhJxY3OnyQEFGAuCE=; b=3vH6QhdZ1ZVxNAZMxZlk8hFLc17WbOKCufF1zrsqsZp7sFo3Bhrvtkh6rEKrxiQwahm1be 6ICsSB5VvaxcxNYJOkRCQpAEfOjN1iViLpumln0EldNFvpH59XNjte6f0OcfPqj4eSV6on VZq0+Uk6rd8xSBnxlAdbJ3/yLXXssxs= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VKMvvJHN; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748954268; a=rsa-sha256; cv=none; b=kvo8Xz89PBt7/NMWFxQv3SYuoWujtydt5fy+uGxs2Uh6r9qTXuZbvmRyyCpqaFLQ+x7SOw a6GKKUvGTjqiSQkjL14Vm/y/BCMttLqUTLn8N/Du9XSqNSZRJJ1tVoCp/j17H+qQesFUFR qRLU2mfcKkOgXeyKhsxgrZOXDvhx5Mg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748954267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kHS2t2oaHj5ILyKgrMhDZwz0UVPhJxY3OnyQEFGAuCE=; b=VKMvvJHNO+Rx1kSZvd1NMjsOXNIRdMD1Dw1xadB6s7XVQb23Hkye13WJEcvuwyTUPKLZ0B EV2im1gxwEGx5C0UXnMkR6vbmCKzDRzqZA+um0vC6DZvzVtGqC8OJK5zazZUl5+SJFt4Lw T0L7t1IkPPAE1zpSbesmnruD6Ke45ck= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-531-rZpLt9eKPBut7eCNW1JiHA-1; Tue, 03 Jun 2025 08:37:45 -0400 X-MC-Unique: rZpLt9eKPBut7eCNW1JiHA-1 X-Mimecast-MFC-AGG-ID: rZpLt9eKPBut7eCNW1JiHA_1748954264 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-441c122fa56so28845175e9.2 for ; Tue, 03 Jun 2025 05:37:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748954264; x=1749559064; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=kHS2t2oaHj5ILyKgrMhDZwz0UVPhJxY3OnyQEFGAuCE=; b=aCn+ovu+ouitUkrZhWDyMKZvv3YgJ44BpwapLLsTE9dG8H+yWRwSjCpWQP5yrHHRk1 nsXCvpHy1OV/Df7S2xGm3fvOqCRbxI2OhIzcLZ1dPd800ILevGZwvV6o1Ep+CmRShWtd Sp6PMUTm9XoCTUZbGmb/vcD6C+8eB1VZmI4QGe2GEITrqBD3qPLHzURkOV9fx6gHE3Ni pOUZmHF4IeQinWpsAG8EimyAl+dP8bOSFmmMEve40YCXXpq3cwNA71G1g1H2kAdeWRaP AyThkoERkfHHRMKkR8xjkGpSp1/vFgoT5ygyx/GOfoksOh4f38NgdPpmOVtkN5a3qj9b A7XA== X-Forwarded-Encrypted: i=1; AJvYcCXZdDXLYFr1OYEgVHb9FhNMiSxrbAKNmL9F5Z3oW1+wG9WrVLla+AzYMlKN5NL8o69l8G2Vpg6Lkw==@kvack.org X-Gm-Message-State: AOJu0YxTrUy/zihZdAtHr9iFjmonLV2Zrby0pjVIOQmwEL4wmeBs2cHa AJbTUj9xbI7OPeSD5W8qpm7ag6+PA7RnJ+pHr6Iv6EXmEJDP7XCsvLiRfPfUQOVL3RD6GfEW4XM /52w8iPv5yc442uRXYBeB/93269QR/0B0cDy/YjvcdZdOaODbZXZQ X-Gm-Gg: ASbGncs5tQtLQXsOgiSVryv7pqCCZHEPDLZif+PWNL5V4wHlow/dCVJCJN7kM5T5BBO hDJqYZhS0xh0vDrfe6L1A7tCCBFLkjW6HhCE5tkTrqe6l3Zh4rjj/GXjG/FQxo/s6GhVVaq59pQ Zqdbir4l/ACJ/qbteiV/MITYxmaSmMoYtePHxBCJxsMa/1DgaWmk/8FC7K8CJtyVoO3pEPWQVFa Pe1OShRtHEmAiTJZw9pgqLTtu3wMq/EKrMY9cb0Jo9mc7b2tvlI+8qND1ZBvGUejzFwavBoyE9N 2YZRKCzWtyaSewzFA5va6GLrD57G4rWkz2Ww5D8DmVimepMEqoGX8u5qX8zvlT1hZ/2ITukpcX9 ZKOcRnSkN2/ctUz/8tPl0dpVH8o8BAHUEXf4FG0Y= X-Received: by 2002:a05:600c:3b27:b0:450:d00d:d0 with SMTP id 5b1f17b1804b1-450d6515da1mr135418045e9.19.1748954264352; Tue, 03 Jun 2025 05:37:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF6hOntpImmJhhOr2kc0P39r0QNY5mPbQ/1OxLQCnMbzyUGLdDBvPRo5mvUE9vEi3arTd5ONw== X-Received: by 2002:a05:600c:3b27:b0:450:d00d:d0 with SMTP id 5b1f17b1804b1-450d6515da1mr135417775e9.19.1748954263972; Tue, 03 Jun 2025 05:37:43 -0700 (PDT) Received: from ?IPV6:2003:d8:2f0d:f000:eec9:2b8d:4913:f32a? (p200300d82f0df000eec92b8d4913f32a.dip0.t-ipconnect.de. [2003:d8:2f0d:f000:eec9:2b8d:4913:f32a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d7fb86d2sm161320595e9.30.2025.06.03.05.37.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jun 2025 05:37:43 -0700 (PDT) Message-ID: <63e00cf8-8592-4117-bb27-42bc8c1f8921@redhat.com> Date: Tue, 3 Jun 2025 14:37:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] selftests/mm: Add helper for logging test start and results To: Mark Brown , Andrew Morton , Shuah Khan Cc: Lorenzo Stoakes , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250527-selftests-mm-cow-dedupe-v2-0-ff198df8e38e@kernel.org> <20250527-selftests-mm-cow-dedupe-v2-2-ff198df8e38e@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250527-selftests-mm-cow-dedupe-v2-2-ff198df8e38e@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wg4TSk1InUL6k1IZozuoNvkefTJUMgqvLDY0RuUUDPA_1748954264 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 8437xju34hptfuuj34by3u1ppsp4r9w6 X-Rspamd-Queue-Id: DE23D40003 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1748954267-604795 X-HE-Meta: U2FsdGVkX18sOOfHKMR8ob241eeMvDT/x1KHXeguCYRPlI+YIHP+018uLDqTK9whncm9asSO1LTnaDSQmwHUyXFMF2QMw2P7CbNgW8FYAzCqyyDKsTIFL0eQxp6ZQQJhxLvArYCGX0QVs01zXeRNJThAReh8gYhhaIezzUog5Gjh270j6tFzNtGrxtprlo0HP0kRwm1yRoB+hg6VDtHpP6dAIWmCzYtVGYhm4L0+7n5meW34YEAVLaJ9riy0K8BB7RzHVh3yRPaRFpbs8y/PfQv+YoQ1t3jV33y0pe+HfQ7ht/qDy9e2Txgo/22QD1GpimUbg5wfBIDLY6wmsi5iPeH4xnROW5DdlThGVXnQzsZ+aYYmFs/DumX7APDhq4pawMqOf0KKMfDvUd+j0sYYC0pQnEgCtB50HrBoX8eOwRPxxCyuGxxxpSnu62y8bWXVNykqSAufyLlhq1kdA9nXQsd6twSlvWX+ip/LZnM7lKgtbY9Q7DjfXqkjNIA8olfYD/bHi90MNm90fxRI+5dgJmysjx5KbvESAzVg4m3+DIfIsp5Rc7fXp5xwh/b2Db6tq4E+jiKmMZlTWDnNVuT2tP1bHQj4GFTWkwCRIxQUm7N1egTbozZTDswiciG91wTsLlbusv4Coio4LRZDdl11JzWypgf5U9mBSaFbxBNGpj7J/HYRzJjVvkT1CEKPiTARVYljWj+gjcz+re9hIMXoCyCvLSJfWpT5g7epfMt347CiFQ832G+WS6zoMC0O/Z6DmWzg8BRerEF8UoOJuArNGxvq5V0EOnm71onoQn9kSQMX+MkGx2MAsG8J40K4wdLoRMVFWzO6njcKwcHP/MrT+DvUxBV/k0k++6x93fSmeO/xiU57c58NHD2+nzSMCtRSRMCAcbvW7DUVRtBtybGhxit0W0rdNunUEd+z7K+PEoj+Cbm7Wq6+HpUVZzJHM5reKTxTONy1CTj+3MWCPr/ B+CkfIy4 Nxzl3+233ae8YbZJKYoCfX8k1Liagx3wwzCp0RbDjzkFGNeBYiUwUSavhOz8WUWCpwr1EVlH4BTm/huXln4JmOs5jRCi/vBKJOQF82kyLBz+mYY8z0aWUTi7wJzMcxd+vy5+fJwJBDCSEYK+Un9a650W/zVR0rO0OevlFehLuFFPKzDQ76CWwoIZy5xjdiYje6Kl08W2mHGEC6+hXaLfiogY0qcjRi1RIe682+7plXX+hIZ6kCgnH+Qjl8Kv9EDvWWUDndUZEaS9rHR/NbJ+8FNM88wMpAkDGpBpTtxyb9yh3QvrvFwC85xraBYUXMbvKuIwhm7AEOnmgcUyWBrT6sMMC6wAxCc5TA36NWbfaC00p/kBEhCE1O456xh8JMeyyT4IRIQzn2W3uzQdhdMbXbLZP13rG1K64YyAN/fq9PpAUfXm7fO2wRyC/sGNlRq53dtlK41zvoGjp4EOlrq1/WMuAiQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.05.25 18:04, Mark Brown wrote: > Several of the MM tests have a pattern of printing a description of the > test to be run then reporting the actual TAP result using a generic string > not connected to the specific test, often in a shared function used by many > tests. The name reported typically varies depending on the specific result > rather than the test too. This causes problems for tooling that works with > test results, the names reported with the results are used to deduplicate > tests and track them between runs so both duplicated names and changing > names cause trouble for things like UIs and automated bisection. > > As a first step towards matching these tests better with the expectations > of kselftest provide helpers which record the test name as part of the > initial print and then use that as part of reporting a result. > > This is not added as a generic kselftest helper partly because the use of > a variable to store the test name doesn't fit well with the header only > implementation of kselftest.h and partly because it's not really an > intended pattern. Ideally at some point the mm tests that use it will be > updated to not need it. > > Signed-off-by: Mark Brown > --- > tools/testing/selftests/mm/vm_util.h | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/tools/testing/selftests/mm/vm_util.h b/tools/testing/selftests/mm/vm_util.h > index 6effafdc4d8a..4944e4c79051 100644 > --- a/tools/testing/selftests/mm/vm_util.h > +++ b/tools/testing/selftests/mm/vm_util.h > @@ -3,6 +3,7 @@ > #include > #include > #include > +#include > #include /* ffsl() */ > #include /* _SC_PAGESIZE */ > #include "../kselftest.h" > @@ -74,6 +75,25 @@ int uffd_register_with_ioctls(int uffd, void *addr, uint64_t len, > unsigned long get_free_hugepages(void); > bool check_vmflag_io(void *addr); > > +/* These helpers need to be inline to match the kselftest.h idiom. */ > +static char test_name[1024]; > + > +static inline void log_test_start(const char *name, ...) > +{ > + va_list args; > + va_start(args, name); > + > + vsnprintf(test_name, sizeof(test_name), name, args); > + ksft_print_msg("[RUN] %s\n", test_name); > + > + va_end(args); > +} > + > +static inline void log_test_result(int result) > +{ > + ksft_test_result_report(result, "%s\n", test_name); > +} Won't win a beauty contest, but should get the job done. We could allocate the array in log_test_start() and free it in log_test_result(). Then, we could assert more easily that we always have a log_test_result() follow exactly one log_test_start() etc. -- Cheers, David / dhildenb