From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07248E77180 for ; Mon, 9 Dec 2024 12:54:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12FC18D0054; Mon, 9 Dec 2024 07:54:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F38F28D004C; Mon, 9 Dec 2024 07:54:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C78AC8D0054; Mon, 9 Dec 2024 07:54:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9412C8D004C for ; Mon, 9 Dec 2024 07:54:06 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1941740D6F for ; Mon, 9 Dec 2024 12:54:06 +0000 (UTC) X-FDA: 82875412662.26.4E95CD1 Received: from mout.web.de (mout.web.de [212.227.17.12]) by imf14.hostedemail.com (Postfix) with ESMTP id 4C781100013 for ; Mon, 9 Dec 2024 12:53:41 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b=Kfoh5wVP; spf=pass (imf14.hostedemail.com: domain of spasswolf@web.de designates 212.227.17.12 as permitted sender) smtp.mailfrom=spasswolf@web.de; dmarc=pass (policy=quarantine) header.from=web.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733748828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EAY4q6z526O4TaeuoHU1dkNEk9o9mZuPKG7V1nAVNJ4=; b=eTGtPeuBI7nUL5PYvCkL0kiJEFjcT3k1uBQcZeKo8RRM3TY+zMeM6nIhlvS0ys7f0Kkojv TcDj5KSZto526PpWKazaWLpVlgKs0Sfj7fdT1a0G+9VBQOKp6cDxdJshZCFClexO3fiKTA TSjk+oPAr3085+B+PMnmlL/EBnfhQEA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b=Kfoh5wVP; spf=pass (imf14.hostedemail.com: domain of spasswolf@web.de designates 212.227.17.12 as permitted sender) smtp.mailfrom=spasswolf@web.de; dmarc=pass (policy=quarantine) header.from=web.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733748828; a=rsa-sha256; cv=none; b=DinvSAPzNSPTVZKE5bSBlSIMJcYdSIVI+4jVhSMIAH8WQy20roM553LTi7NT9ae1i7FEA9 If4yT6P8PoKcftHUMZ78ryU+vId9NTYVpcOHy9YG2fGUnYidbscIHTlahD/PxQPzzPN44d oaGOOmOcHEynyQCmUJahfkv739LKK2Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1733748839; x=1734353639; i=spasswolf@web.de; bh=EAY4q6z526O4TaeuoHU1dkNEk9o9mZuPKG7V1nAVNJ4=; h=X-UI-Sender-Class:Message-ID:Subject:From:To:Cc:Date:In-Reply-To: References:Content-Type:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=Kfoh5wVPf2HaxSlR0zhNthgA+cnzi1FjvP6BIcRsvPWwGJj7bc+Ph941RUlpzWpz 6VEdjAfZfGz/DW8K5nKy5prdnr0lXl67RUKmRvJ8Iq42zaaU/dfhvD8995JJ4tI0I GK6SEmpqL3U4R11XTanzSZZinupMTyE5jOERiUkUL4er/hQDFUWN2L6+lm29NZ9K/ rfmLxRgqRztr1cvDVH6xFKN/TL6JsQGtMPezT62AqT/l/40nEbnYTN+BZYsLCLSdb uex60sWhoO1XbqLOCetgQFab4fKAVEALNpEWwkCuQ8nz4QGFXPuZt/dMbN3AdczdN XfoC+DGotGRiL+6itQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.0.101] ([84.119.92.193]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N4N9I-1tj9A91Y5m-011Z1G; Mon, 09 Dec 2024 13:53:59 +0100 Message-ID: <63df45984a1a7fe5998861abd3210b781662d7f9.camel@web.de> Subject: Re: commit 0790303ec869 leads to cpu stall without CONFIG_FANOTIFY_ACCESS_PERMISSIONS=y From: Bert Karwatzki To: Jan Kara Cc: Josef Bacik , linux-kernel@vger.kernel.org, kernel-team@fb.com, linux-fsdevel@vger.kernel.org, amir73il@gmail.com, brauner@kernel.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, spasswolf@web.de Date: Mon, 09 Dec 2024 13:53:57 +0100 In-Reply-To: <20241209122648.dpptugrol4p6ikmm@quack3> References: <20241208152520.3559-1-spasswolf@web.de> <20241209121104.j6zttbqod3sh3qhr@quack3> <20241209122648.dpptugrol4p6ikmm@quack3> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.54.2-1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:0PZnYBU0gg6jmMJSy7XFdM1bYFCaWir11pnGSd+0qH1foI/b0t1 GDeIAizz3oLKWi9wKNQxaEKI2kayoXbER7RErF9XDIK5irM8+Ya2jrAIr+FSHNTBXyjHO85 0XI5NzerNjKfxkeDZbFkS3Gq4ooOZmbxFvqOyCoNgX8SykBXo3bDINc7zMw5R19vKSw8cI+ tWItanavbpwWrfHDmz6yA== UI-OutboundReport: notjunk:1;M01:P0:h6vS82zGca0=;9iPQBgOpwE7+yvBx1nowykpFDhs sL3hd/ksImdUynxocZWcMTayMV+gWBm/4Di2lz+QErGwinZtBSN8NZ7RDi4LWmDy/GfJmTtVJ 539P1Oo2A3Tp+WNTjsZN/a5eE7lVnLOpSpYO6kfPR4V0wNKw3hE7UpDnOe8tVhcNFNw+mTO1g 2TKSg8eikeuGTeu6Ll4JehOdb0ugnJ8QN0jEE9HUjungrHfR7AaNDdmlLJR7vkmvmycSQZI4G nz1hHEJYRhlASziFYxV+g2XaNVlpE7VvvTS6y2XG4IzRyFxVOeKGJCfvQ664eP4bdr+Ppt/7E jguPYfsGn1rewvID6F/X2+bJ0lAQAySpa2F+yL/E3f0+LwrSxNPCDy7PKIZjTTvXN9EnQie6p OEND5v0C9gYpHGlua25BSK3zATJv+9uHAY/w6JBhS7osoYf6uAyDjKsyevhVJiO3iV9Aehk/c wK5uI4dXzhesyQIQyIdX1aaLQupY9NwpJP4K6xNHnNlPzchW1NDaeZDVo0RtRhU1XTg4as8lx 20MseOhPoDHGKDsxuCWALftJtpBgRLzY2iHS+/QfM0t7CoDhgOW5GT0ImgguQ/MwDgFHCQtEX /Z5zYbtDvC3y00wbcrI5uySwwFceiD0yn76grj9/jVSV5v99BtXizARSPaGtdeWXsgdkks40G +r9plqbq4ojzNteeOexaI4M1BGPkux3wJObW5nigGk3Q1hnDIumQyL6rSFI1LruB4Ay8/9Yny 1A7rVbNuVvmg4eM6FqHKC2aPzCel7sdE2duo4GEYlOuI4xZpQgcYPz9qzv6OQ1y7+TDRcdRsB QIu5MzKP9xJG/I04DGrIOrjYWlMXUCcY42JvL5eZGOsBpqOVTISJvX+GQH6TgNvs0fCs84DUi SzXQR0ArNPU0Jbe8PAh4NvIqXM6JDOMnEUYJjcb9+eMhi6sBfdD3itJGokQWi3LaZY6/eaHNT tiK42jl5RgIpajRSdaZoEdwyQeF7AsBfBQPSByzT02Jk2/Ja45qiMe1i11FiNNioJ3wHjlz4m +sNXoOK200618nsA8KvvgE0iCJH6/AAf6U6v6an9hzuVZwWA6IV9yOt60TXS6P9HGbxPKjXEE 5u4TFy2YU= X-Rspamd-Queue-Id: 4C781100013 X-Rspamd-Server: rspam12 X-Stat-Signature: 1uutp9os81hhqxti5mojq8mgaqeeuueg X-Rspam-User: X-HE-Tag: 1733748821-927681 X-HE-Meta: U2FsdGVkX18rLCyWyghj3adWc95ovVEn16u9TLN58MU+F7JnziIzXxkTxORdfbxz5BF5XAcEMnMoR00faEMZ3eACBM8tAgdKJOKrlSje7s4tym9OkDpR6/HTsaM8XB1URvz/OvUqJcL2lsXrzsH+kOb2J6hygKRiGqHyor0C2bMsLFzZpc94Bnp7ypYYQPIbUDdbadwtOPV8f+CApcFnGKu++IMzPq7JyaHpk6KDSjC9LIQsrAn/CNu6c4RaNyrb5CyfxCIGMtfwFXTzzC3IBBZmKnwvtRvcjSCgElfHZ+adcNGmETG20Z9fLDtfxAT6dHj8bjO5JQp23PB3zLEam8Rb9/vzSI28TUsgkGx4DxUavU1t74PFk9J6yv+dwyWO98tjCjkDYxOcwu8K+GIClsgZAw4q97BoEwKrnKGEYhqlcoFVkwMaW0Z2qfpcpkfxtKOk6pZSz2/EtUAACWe2Q13HtYVHCcc7nXVkf9YowC7aiLlEjkOUjsJ/xx8oHtCUs+OkAPrDgoTtKzZpsmD7AZEXfeDCty7DgmR8Dz96qorSBQTevdzMH9nJ0KzpuI+DyNl0gSajshFeyjZdrXHk6+qzk7VqwM+umj5P574EnNtP1Ma4ub0ynhPNq8wMmJxYItOMgUcyvQCYnzpl95skvjDqeyGCa8KJfKhxguF3mCsUlDqrTKPPy4UGXZKmPpCnOGbesjPILnM2Y1FBwNq3HknQSMZzYapl2X9ykGTFnufnLOa0X5TLx6qGouXF5vzIVnMQOFAovAuMar+6UvHgeIyQjPhbEgRCYU0wpL8WKK5wcKcsAiFTbDHZKZAHrqBBowStscZpE08FcBGduzgpHrbRWpSxSWK25kr6ndVMjdnDUbesfsmxLapyuqVtY65wg51/pR+moJ+qv4WcSrgES4QTp1/BAL7sifhj6Ya6y+2pudZ46mxdCFzlxCOFv5VkSNVRCNsBreUAdXiaxcX RNa90Cz8 4v1BovkmkpsgqbhGweGaQoGupjyeIRz06nUiZkslf9UO8lQks981p3hnyobag3aRHC10pLJ2ex6RBO+Ue5F/mYC5ZX+Y6rrL1KG5M9omG+em/rOoCbnNZphd2WWgEIyNxPJ8dDDjwOrSuHXCWpUMU6H3rEb6oV7QkFKC0LW3P1UbO62ZFXiN3uFycxbYyW9RR+GHVnKFIGvrkRyJRz2a6wth0CwPzfg8jNWgY11P1Tn/yGhTxFNkDy+IJEc2bEAeTaWOq17/EDEutjcJyJgMdslSMcy+KVCH5pbcRs/U3FWxY7SAR6NVErHQ76ombAs/yKgy8ENBHUi7tot4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000018, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Am Montag, dem 09.12.2024 um 13:26 +0100 schrieb Jan Kara: > On Mon 09-12-24 13:11:04, Jan Kara wrote: > > > Then I took a closer look at the function called in the problematic = code > > > and noticed that fsnotify_file_area_perm(), is a NOOP when > > > CONFIG_FANOTIFY_ACCESS_PERMISSIONS is not set (which was the case in= my > > > .config). This also explains why this was not found before, as > > > distributional .config file have this option enabled. Setting the o= ption > > > to y solves the issue, too > > > > Well, I agree with you on all the points but the real question is, how= come > > the test FMODE_FSNOTIFY_HSM(file->f_mode) was true on our kernel when = you > > clearly don't run HSM software, even more so with > > CONFIG_FANOTIFY_ACCESS_PERMISSIONS disabled. That's the real cause of = this > > problem. Something fishy is going on here... checking... > > > > Ah, because I've botched out file_set_fsnotify_mode() in case > > CONFIG_FANOTIFY_ACCESS_PERMISSIONS is disabled. This should fix the > > problem: > > > > index 1a9ef8f6784d..778a88fcfddc 100644 > > --- a/include/linux/fsnotify.h > > +++ b/include/linux/fsnotify.h > > @@ -215,6 +215,7 @@ static inline int fsnotify_open_perm(struct file *= file) > > #else > > static inline void file_set_fsnotify_mode(struct file *file) > > { > > + file->f_mode |=3D FMODE_NONOTIFY_PERM; > > } > > > > I'm going to test this with CONFIG_FANOTIFY_ACCESS_PERMISSIONS disable= d and > > push out a fixed version. Thanks again for the report and analysis! > > So this was not enough, What we need is: > index 1a9ef8f6784d..778a88fcfddc 100644 > --- a/include/linux/fsnotify.h > +++ b/include/linux/fsnotify.h > @@ -215,6 +215,10 @@ static inline int fsnotify_open_perm(struct file *f= ile) > #else > static inline void file_set_fsnotify_mode(struct file *file) > { > + /* Is it a file opened by fanotify? */ > + if (FMODE_FSNOTIFY_NONE(file->f_mode)) > + return; > + file->f_mode |=3D FMODE_NONOTIFY_PERM; > } > > This passes testing for me so I've pushed it out and the next linux-next > build should have this fix. > > Honza I had "mixed success" with your first fix, out of 4 boots I got 2 hangs, b= ut the new version seems to work fine (4 boots, zero hangs). Bert Karwatzki