From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96143C05027 for ; Thu, 2 Feb 2023 19:10:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00FD56B0072; Thu, 2 Feb 2023 14:10:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EDA8B6B0073; Thu, 2 Feb 2023 14:10:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D54056B0074; Thu, 2 Feb 2023 14:10:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C02756B0072 for ; Thu, 2 Feb 2023 14:10:04 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 849D112042E for ; Thu, 2 Feb 2023 19:10:04 +0000 (UTC) X-FDA: 80423291928.11.2F1B2A8 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf09.hostedemail.com (Postfix) with ESMTP id 999C2140003 for ; Thu, 2 Feb 2023 19:10:02 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ifBa3W+F; spf=pass (imf09.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.44 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675365002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ei84xjALj/qnZ251dtHcjT7fuwkFwrmIuOWdIaj3IB4=; b=k9fDptscA1S8ynpWoK2aYJvo2hYW0jgWIHSJe/bxJab9llxIGlO4SC8BHqlKFw1nPS2sLL /LFMZqHAA89WFQ0PsOxpJyE7rYzQm6/kpY693e2+0O5pqJyFIwHqyrtjqdCMNPWg4PIJqb 6pmOS6uXmUxwPHzO/+Gbg4D80J6phnY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ifBa3W+F; spf=pass (imf09.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.44 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675365002; a=rsa-sha256; cv=none; b=6P3jNUljQQwejSjkQRU4SqMsJF1BSMw5p/1VtHzwsr99WwUHjbHS2H51aRkBCk0xCsysUg WgXZeOxUHWbBR+Jq+xNAFDV6pdYBSqLBlO+YLdOynHygbZ115yrz6NWe9l56h5/3eJ/Itt ddFgSDgmyUXBUpvEitVzk7Q+4Y/f2YQ= Received: by mail-pj1-f44.google.com with SMTP id on9-20020a17090b1d0900b002300a96b358so2772035pjb.1 for ; Thu, 02 Feb 2023 11:10:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=Ei84xjALj/qnZ251dtHcjT7fuwkFwrmIuOWdIaj3IB4=; b=ifBa3W+FjfUT/jALuyk7vSXJgPyrderSzeCqeUprNB2WEcZ5Cgu0jv05ook+3UnGvo RtCgWWWwBDb7dOQWyuCGRnin3PpUqmpGnFqv5jTK2qZ2wwaTL2B9DzAqWakctSuEbd68 sv1+oh3wKsRHifknwXnc2pr4q1kxywhLR6pyU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ei84xjALj/qnZ251dtHcjT7fuwkFwrmIuOWdIaj3IB4=; b=tOoiwbgDRq5YXLVIReA5d5kHP5eiHrwbfkleWwR2hNJIGTk4CTvXH9Ld7yBqmYYeHg smPblrbsowsTDGNGV0cZTWqa7e6umXhDlYtAwBPJyLHbkJ1xLRsrJJDK2JJShXI86QLN EkYA19p0Ir/fYr/Kd9ctJWQdgwdOmYXeGh96O50Cf39MdJmqP5BgOjYsWIphXEmawEma ReM+Dsbt0tRJKwEhy2E101a2S8dKT5LWGxOd8o3FerWCCtu0T/PwSFDUrt7fvgv56Hm9 97biuISGWgKwPkL2XpD/L2iDqEilU5uef0/EOwoymB2wOu0KhPkQagfeCVXdujk662ls k5fA== X-Gm-Message-State: AO0yUKXDxippyJb/NhYQwJF/YWADhP+kGfkdiJGZptnhgOqvpgcKK5aQ Z6Q76Pl2CLsMLwiJcyFRzOwOew== X-Google-Smtp-Source: AK7set9p/VLscj8lYzuVH+QL97IgWbcWTtlAXemsvo5mM0a99DAyaG7vV23KHqvBlFv4YZ4XzS0krA== X-Received: by 2002:a17:902:ce8f:b0:196:2d55:5b96 with SMTP id f15-20020a170902ce8f00b001962d555b96mr8751901plg.24.1675365001490; Thu, 02 Feb 2023 11:10:01 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id s23-20020a170902b19700b00186b3c3e2dasm14950plr.155.2023.02.02.11.10.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Feb 2023 11:10:01 -0800 (PST) Message-ID: <63dc0a89.170a0220.49507.0091@mx.google.com> X-Google-Original-Message-ID: <202302021904.@keescook> Date: Thu, 2 Feb 2023 19:10:00 +0000 From: Kees Cook To: John Stultz , Sami Tolvanen , Ard Biesheuvel Cc: Yongqin Liu , Vlastimil Babka , Greg Kroah-Hartman , Rasmus Villemoes , Thomas Gleixner , Jason Gunthorpe , Nishanth Menon , Michael Kelley , Dan Williams , Won Chung , David Gow , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Guenter Roeck , Andy Shevchenko , Paolo Abeni , Geert Uytterhoeven , Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, llvm@lists.linux.dev, Sumit Semwal Subject: Re: [PATCH 5/6] driver core: Add __alloc_size hint to devm allocators References: <20221101222520.never.109-kees@kernel.org> <20221101223321.1326815-5-keescook@chromium.org> <63dbf04a.630a0220.2608a.0149@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 6pxo3ydeesz1u3t78tia4774x5u73t35 X-Rspamd-Queue-Id: 999C2140003 X-HE-Tag: 1675365002-305925 X-HE-Meta: U2FsdGVkX18vHWJGl0tnbTVGu1Oba6Wt0htmaqi6IjB/SJHXT/8iaXMvv8ITAVv9pI1x9IWTPO1hze15S0JLWyFlWgLnpkEtFNw/LOvX6bGe8l2EXRUWpOqxpgyxA7Wzt28Rw9TZw6TdNxA7oo59bzUktYEYB1H/3U/Ioza7jI7rVRYuNWd+4Hjc0O7briF4O6ZCLho9Wpr3V3cvXHVXcBGX4o2Uhy46KTKfrddRtCYwkafqeuN8aA6ZmlKgriw6hJUb0+iXwtWYHha34gQBEYXkXa45IL+NPnMmolaF6J2z2ebZjdcjzumebtWAxAzBZgPao2+JQ+dR6p6QiyGcPj8GN2/0K12klC5ya3KvD/+En+JyIFyFtznNWiyZacpFKhEKlf2L32f54q5s4UVb8IdnWMUp3kijHMHM4bIGRoYsSYqUIT5tzKtu7JvqkCnpvpuRKJzOKZtCPCBe82I8/M7EXLQzjpqdIrCBLL+z03a7/aLva+T8Wu4Q4XUNzoDBUC7MWeOqGOYEzZ6OD8VktG2f0A2qSmFBjb7tyXwC1680mpSk0OIm4Fm/kYqlEg/J/Q1fFZEo7culz8tbBKOW4nYuqwLRWRm9pIWmh629nYsrp5neHWczZD/a3UPDhyRhn6p1VZzvtT9iuL1astPFj13SvwsNvz3clgGEC2XuylEFOADlBSRFxCpSqKUJ25niWfKKxDGR1mJebuzMGhcM6Nhi07oBm1QJC1TWHD4ISE4n2JaeVMPL+Qha6xvUo4VLXCA1k2eirPPTA3+lh0+/cPy/cWZIpoS8uixM5gwUyEG97HwzWY/0do5J2Xy4a2hU769dSfMLvukDGcED4eiyGf9B4N9i57KBtQ0tWfFqua1MMgVRU0OhDPaIIcPN5YWBKScfcK9DzzuOP+zyZoAnNyqVMDyKGJoalhQLuxPxgJvMcjUm6lxP9pPvEgiOSAwHWXuNZG/ZQSWYkQR5NrS TkyP1Szn L8l0s+se0XauBun+KuPoyyAsGz+juKqiEVzCJIXxdmSsZdAiyxXpG7dOj737DcHtgBiO6LKmq+c+m6QQEXPoTzb1ZRakJX6JbQXBMKlW17A5CCqhum4jKsIOUrZH4t7qwsUb8ftSWVvL1ZpgI1Vv+kTgGvrdklknwxDL5i6FK10TPGmGoYKsO65FOBfkg9d/rhb54XYccEYGgsLz4aiPZ+cwQ6/lVLElMfWLZCmmQKc6ZODr9aq2lzYuGlerA/Dr3G5DZGJ7+0APysoQpP+tGw8vj6HjnY9ZlxVhQM1Xn6+HYLiNp+Ve2aaNPVsbq4mvBKrW2jv37SPeHXXIB3M2Qc+FOfutdT97/yiTam0tW0USBKgl6lSx3X+IOHhtYGs0TqNNumxYOffbAqm2Eot9v9Ib8/M7efRuhJgDUiMFvPAZN9KQegq2aCz+uTajDd7X6/ZWb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 02, 2023 at 10:56:29AM -0800, John Stultz wrote: > That said, making sense of the error message isn't completely trivial > either. I've been seeing a few cases recently of some of the new > compiler tooling (I pinged you earlier on a CFI one) causing errors > that developers aren't really sure how to address. I know sometimes > it's not easy to surface the errors with context to what was wrong, > but at the risk of intense bike shedding, is there some way to provide > something like "Likely array bounds error" instead of just "BRK > handler: Fatal exception"? Yeah, this is a result of the size trade-off that resulted in config CONFIG_UBSAN_TRAP -- there ends up being no message about what went wrong. I'd really like to have cleaner handling of this -- perhaps what was done for KCFI could be applied to UBSAN as well, though this is an area I don't know well myself. (i.e. encoding "this was a UBSAN trap" in the trap itself.) Sami or Ard, is this something that could be improved for arm64? -- Kees Cook