From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9A90CDB482 for ; Thu, 12 Oct 2023 08:33:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C84D18D0117; Thu, 12 Oct 2023 04:33:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3E3B8D0002; Thu, 12 Oct 2023 04:33:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFE328D0117; Thu, 12 Oct 2023 04:33:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9CB188D0002 for ; Thu, 12 Oct 2023 04:33:12 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 62934B5196 for ; Thu, 12 Oct 2023 08:33:12 +0000 (UTC) X-FDA: 81336144624.12.D723F97 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 1C25C14001B for ; Thu, 12 Oct 2023 08:33:09 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OscqYI3C; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697099590; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tFBAaGNNwzUAKJQrwPFimGzTzmH3Y9stjQwEsidNPuk=; b=SzDWt8qE73o2XdQVoXplbJ4G5ZT6HI5zAUBuiL6i856C/qHfWz8xVFrIvng+aHmATq+IKO Ag0L8xXHKpUXZJhW0iUE9k1Tsa5jrKcSaVLvXKYKjHXkXq9PWwMSAPu8IIciqZIDjRUc0z 6COmvOnhep++ZfN1BftnwTdRb88Dgpg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697099590; a=rsa-sha256; cv=none; b=bgB6sKkRAu6IDVhLRJBCUkndm9UzdJkuTfV/L/rGrVMl3Sf9Xv3N/csP/7uwOyDNMMkEEO TQpSSnZD9s7KtPtBKwpSsWsdQSNJkJ56JYHjIIUhewu8zhfE1e/zACNgR+SG6a/YEE8TuD k6QSCQAsqpgVEDUrdR2nH3rtHYzJfqY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OscqYI3C; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697099589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tFBAaGNNwzUAKJQrwPFimGzTzmH3Y9stjQwEsidNPuk=; b=OscqYI3CkLQJQREaowD6IBH5b8snmxFdDBVBs0OQWGGCDgFnwjMsjSyH3RDbfh5nuLjQof TIehyi6c9tRk/RAKWTxIMnxmIXnkSImEtLrqCKjX7bgnvdNUysqi5qnW291GLQswL/oTFg lk8k4oUQV4ekV9Z4vsFc421GMchsY70= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-562-ewh9eiutOzug4GEdLglH4g-1; Thu, 12 Oct 2023 04:33:07 -0400 X-MC-Unique: ewh9eiutOzug4GEdLglH4g-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2c00cfa81b0so7073441fa.1 for ; Thu, 12 Oct 2023 01:33:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697099586; x=1697704386; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tFBAaGNNwzUAKJQrwPFimGzTzmH3Y9stjQwEsidNPuk=; b=NXDW348MPVwiLxgLyzkZLMFJTzo8ZpbuPYEgsSCNO0GGQFvDubnooF6UOois4hYR0l kTC7bcvvEFFfASH6k23kvxCgFo8eguyCONEGR4h2QwZcK10P4SauX4Q6aFkVVLXXllHE KtN8+1/jF2DIi5XJxQjQ5HEH7NLcmQBsBq1pgPlTE8LXEMaAvdx/Il6rwmQqpTrf/+QU NhOQzNAWzArpt3noSQqIipQv7NgmXa6CZ/xxUM59ZHj375MVbFUAzxanHCfXzH7+r73d h2n7TySuVDcB37Op8kWlS1ae8qYfqtYnnM1y+mPSOSa6GQgn65ptDpkt42qWFUf0iTCj 24Xw== X-Gm-Message-State: AOJu0Yw7FzWx+bpS7T0ablNn5xM6d06jbelig1I60DOBAaCYwrnw0dLN P9t4ze9jkDyjTd/kGFrm0tNhrnS1V1xfOsCaSGTWCJx2W7/K2THMhvmz7J50JGp19CKkAi2zPp0 5VIPXu/PQ2ao= X-Received: by 2002:a05:651c:88:b0:2bc:dd96:147c with SMTP id 8-20020a05651c008800b002bcdd96147cmr20352119ljq.34.1697099585833; Thu, 12 Oct 2023 01:33:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFEP/yCsuTBbRW2UBpXpRJ1WBj8Tdvm+xry9N5pYzpQmfCztnp1gPgIReFyNmdzNKrkEmmgEw== X-Received: by 2002:a05:651c:88:b0:2bc:dd96:147c with SMTP id 8-20020a05651c008800b002bcdd96147cmr20352104ljq.34.1697099585471; Thu, 12 Oct 2023 01:33:05 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:ee00:b271:fb6c:a931:4769? (p200300cbc70dee00b271fb6ca9314769.dip0.t-ipconnect.de. [2003:cb:c70d:ee00:b271:fb6c:a931:4769]) by smtp.gmail.com with ESMTPSA id 9-20020a05600c020900b003feea62440bsm18837414wmi.43.2023.10.12.01.33.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Oct 2023 01:33:05 -0700 (PDT) Message-ID: <63d119f7-5adb-861a-00c2-69a92b19ef9b@redhat.com> Date: Thu, 12 Oct 2023 10:33:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v1 0/5] mm, kpageflags: support folio and fix output for compound pages To: Naoya Horiguchi , linux-mm@kvack.org Cc: Andrew Morton , Matthew Wilcox , "Kirill A. Shutemov" , Mike Kravetz , Miaohe Lin , Vlastimil Babka , Muchun Song , Naoya Horiguchi , linux-kernel@vger.kernel.org References: <20231010142801.3780917-1-naoya.horiguchi@linux.dev> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20231010142801.3780917-1-naoya.horiguchi@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1C25C14001B X-Rspam-User: X-Stat-Signature: kcpfwttxqdemikqy6ifabb5ixdrqcgc6 X-Rspamd-Server: rspam03 X-HE-Tag: 1697099589-873257 X-HE-Meta: U2FsdGVkX19XpnqIgihqstmPNl78xFPVF+djUyL7n9tWbeSOEmn6a59ubderkW0qq2D7XZufx/Cpz126B7xAljpmwHXYbTXnk/FPx8HbMM17krjSebIY2YjjnoItQAoiGNbjbn/sUK5GpjQCgqeDnZFGhlqEgN4oZz8t3hwmuSWJG+ZivLcv2LRaKCs9zBlqTj1TWAUesyOg+j19c4ceqODoPyc0IhF9zGaF7/ePMCrDLrPT/M9W0lMbQgbkoBE9ljDCwF5miQP72+4CpQmxbOBvkh4Cz8t4vWj3L//KmWail9e4XLavEMuZvm1Ia6Ou9vopv+qcDR1CC9YUtOZBeWoSTZhKs+vQhhb71P9GaoS72BjNfZhZ89kvaD35HFBr4VqEOiBnymFm2s+glxZJKzfLFgGLWIHBfvKrrGddh+0XZJ7OkElBQgT4MZig+0fEPY/QqTbWfpWYq9/vS8xdcLAMj0RDVhECbuSzjPlZNNW02E2mAvZBUfZAn7x/lAxtSja6/tanywtS9HFf+Na0AirT70Aw8s/CpFD1zVsl+3qS1ULQFVl3kBAinBVTYACAzNIATkxDMH4bfYWlOJGLoFwpb6BV5NMBvEoPDl2sqfYYCX/Goastu6Bp5GBctqTG0NdBIhVbHnZ+OqOCpl8MATrDpSJu51zQQdVt1/Iu1FwB6EhHZlnbdB6fNxhi3Je+V6AFP9EawA/TOjuGgwwKmFK6u4BZJK70LCnYR6LvrejOTdRWvN27JL+hz6QONhbSTVWRfmOMMzHQQ9mMFdRWXfcOq9ejlIUtX6IlClFonzoFFmJGC7/t4tzvkY6UOr9FzOriiee4YFHuSKKRnOBIbC0DDYtvboCTKCOdd8p/cADrHzgK/WaaArh666200HRQozE1uwxrvL5GEvIpl5MTQqlDGey8tvIniJs8VjUqqFPVFxWCbfDcx0B328wilb+xw+F5Jpml6pn+iCeH3Ph EqaMx3IW AlDWFvi9h4SeaI+xDp4CQjClAysqs/PYQsnvsRJJUlTof8jAp/9nPEuE/JwhmRD7SqHiupPNxoNcfXlGPaNFWfaRu9tLRGJTL/UqvpNpzVv0qeMx/EQWSHqkyvuNZCKuLSO98XQrV3Ze/wOjXhcSKF51kl4G14v0iDIfm/srid7Rwto9x83yIue4dAW3ZxeErS4xetDsMEGZfNp5n0enpm63NSFpadJsgEzDMppZl05QrlHYDptsmggDmVzvtcD55i3Jl5ADetjWS0FaTWRanjTlW1f+U3wQHO8hRm6caT7d0bjDi9SXfEHDRnZfVRalIhBGXlP6HYl9giuVip17NnKNCrLZzgBEkPHPJlKWDL2vkEiWoCD/L5XWuG8psjPekoXMC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10.10.23 16:27, Naoya Horiguchi wrote: > Hi everyone, > > This patchset addresses 2 issues in /proc/kpageflags. > > 1. We can't easily tell folio from thp, because currently both pages are > judged as thp, and > 2. we see some garbage data in records of compound tail pages because > we use tail pages to store some internal data. > > These issues require userspace programs to do additional work to understand > the page status, which makes situation more complicated. > > This patchset tries to solve these by defining KPF_FOLIO for issue 1., and > by hiding part of page flag info on tail pages of compound pages for issue 2. > > I think that technically some compound pages like thp/hugetlb/slab could be > considered as folio, but in this version KPF_FOLIO is set only on folios At least thp+hugetlb are most certainly folios. Regarding slab, I suspect we no longer call them folios (cannot be mapped to user space). But Im not sure about the type hierarchy. > in pagecache (so "folios in narrower meaning"). I'm not confident about > this choice, so if you have any idea about this, please let me know. It does sound inconsistent. What exactly do you want to tell user space with the new flag? -- Cheers, David / dhildenb