From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1848C7618A for ; Sun, 19 Mar 2023 22:28:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4547B900003; Sun, 19 Mar 2023 18:28:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40500900002; Sun, 19 Mar 2023 18:28:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CC69900003; Sun, 19 Mar 2023 18:28:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1EA81900002 for ; Sun, 19 Mar 2023 18:28:22 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C27A71A0125 for ; Sun, 19 Mar 2023 22:28:21 +0000 (UTC) X-FDA: 80587087602.12.14EC6EB Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by imf28.hostedemail.com (Postfix) with ESMTP id 5D593C0005 for ; Sun, 19 Mar 2023 22:28:19 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=aculab.com; spf=pass (imf28.hostedemail.com: domain of david.laight@aculab.com designates 185.58.86.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679264899; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sQPf+kwZ3fJneuh5UX7aUrXOpDX9xv8+4DpgjOAbfBM=; b=PoauNopG1kRYRgGWCA/Pnq/wDYUAHhZit8hGXZnIeBsnGXout3H0b4DWqDVbDTm2fqeWT4 RtgiECUABmImdRddj+OL4f1OlAp2UHZfVjO7m+731DtmztXbJ8AMELG8fJWZnS7QL6nBcq AcqwjxE4mw3MJwxDeFUylmPF0W8CHfw= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=aculab.com; spf=pass (imf28.hostedemail.com: domain of david.laight@aculab.com designates 185.58.86.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679264899; a=rsa-sha256; cv=none; b=2xRaIWNOsyV0EsNwj5H0k0MRGoXqrd+LOwZ5FUTxRVC95B++75qZRp1ZMUPpo6Z1Q/JhAL B6j38CHJeD1bq0s3xdj1zhAYLf7wtMaMhZc4pO7Uszy2zWvDuimElXOYFFJUwQ7N1T13cc /wSqrTJ03L4fZxho0WNcm8NzW/oIQhA= Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-181-_IBSa434P-uLEzTnXolkmw-1; Sun, 19 Mar 2023 22:28:14 +0000 X-MC-Unique: _IBSa434P-uLEzTnXolkmw-1 Received: from AcuMS.Aculab.com (10.202.163.6) by AcuMS.aculab.com (10.202.163.6) with Microsoft SMTP Server (TLS) id 15.0.1497.47; Sun, 19 Mar 2023 22:28:12 +0000 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.047; Sun, 19 Mar 2023 22:28:12 +0000 From: David Laight To: 'Matthew Wilcox' , Lorenzo Stoakes CC: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , Andrew Morton , Baoquan He , Uladzislau Rezki , "David Hildenbrand" , Liu Shixin , "Jiri Olsa" Subject: RE: [PATCH 4/4] mm: vmalloc: convert vread() to vread_iter() Thread-Topic: [PATCH 4/4] mm: vmalloc: convert vread() to vread_iter() Thread-Index: AQHZWg2rkT8MGeJf90mcEtrkYLQB2q8Cr6Jw Date: Sun, 19 Mar 2023 22:28:12 +0000 Message-ID: <63c98c518c1e4bfbb36c5295ba7c959d@AcuMS.aculab.com> References: <119871ea9507eac7be5d91db38acdb03981e049e.1679183626.git.lstoakes@gmail.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5D593C0005 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: nx6op4ty7s5kp1i71um4osugawy9nc6y X-HE-Tag: 1679264899-860968 X-HE-Meta: U2FsdGVkX19UHZsBd3r0M9bDkyW5Ua3h5kLMoJzMYKiyr1SPTAx1bJZtxkST6Cl6/voqaI9q8x+wtsCQMChb8tCfx+i1ipk+Exr1SfptvbTSkc8ZWrDGN2SpZu9GY0hOt5wcgAnQ5BNk9Pmmr+PrRSo1eDqJwIKk+aoqJMinW6/Y5V3yGGt9h0IKgLW3aBVj9exLMXV5gZOVJk4BgSiZ7L1mxTw47L42+IPP28szJZYvH+SBk0bDSe5CNA7JiNrhhSRqII3xNlCLtaxWBbu93AHYxOMJwPvWgCQpdV/tvHzvd2cdGhVrg4whsMJy2leSa0TQAGHm7M1ATwxdTIw6tB1qw6Jlh3PJWqCX5kM5ICCv0aeVbEGsDJgIAyjoIR2bU21yn59i0A8gKSD+S60Y7ZL+pt41abJrj9C1gDQvQuOvFDaiKxaDHqRw8krQ1xvN+gRv7obn18OnTReF4v07v5LoDfIeQv9RFXbnn94c+K7G7xzz3XGtO2EQO/r8B6GLdExrNFZ4SVnErZBU9PduWjcwzJHLW0QxGK7cbcPyyeL856VM7TdAmfg2nWIw4IR+FqeZ1DANKAdGZcu89j6YaQdZTjH/th2YhdJDZbyweukUtivpvdy3au7d0TIeVaenXFyhc9tcJMGj2hiEku6Nu5O99K9FCpBrRhN0wiRo00+2mmUIRE2tP0RDZfjbPTgfI7esIb4623TVl6Q51jdMvUBneVelNPsf48YZTCbkpekdXbRHLOAvzWwr30vmMKYkmxZefTGdTOExeJOzlwmr+7Fh4yLI5wqsUuXgBMywbwCX3sqDYYETnlFik7FJHmxYt68BknhzejeTaemIlPpNJSHb1Eyz+rjzltGKGNu9Gd3G10KsI0j47yJPIJuWB4Au4twLMUahaq/E+qK9ju6oB+1pe3+3Kr39M6eZTnTHtKzveNoZT+0GeZsbQ1xWbRWyOBc/Dv2MyIJMCy5wngv IkAO8u3e Njkg0cbrRagZWl7InqCSP6htV4Vm1/tEz6Zlk+kBYhy3Zqdh6lhKT3ZI8PhCl7OiBeu4/d9FbFKZtTEh0ryx9crztum2rKS13aOmKVkpC6/eTvXS1LImeIX9qw4Cg4XNIjmahgSFJqV53YioLzxopyJLk7Cb93PxH3di2m77fpwx6RYZbfjxVsIv6qjJJSXVF1GCuPhSybxQrsTPnA0ZttMiIx39+7H64SFnoRBDBRmc/814x97drtC7KS4DGAXITDVQu9Ocjy15DU/E5B2r39DIWlQBS0YhemHPmwSbQDABLHIY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Matthew Wilcox > Sent: 19 March 2023 02:51 >=20 > On Sun, Mar 19, 2023 at 12:20:12AM +0000, Lorenzo Stoakes wrote: > > /* for /proc/kcore */ > > -extern long vread(char *buf, char *addr, unsigned long count); > > +extern long vread_iter(char *addr, size_t count, struct iov_iter *iter= ); >=20 > I don't love the order of the arguments here. Usually we follow > memcpy() and have (dst, src, len). This sometimes gets a bit more > complex when either src or dst need two arguments, but that's not the > case here. And, if 'addr' is the source (which Matthew's comment implies) it ought to be 'const char *' (or probably even 'const void *'). =09David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1= PT, UK Registration No: 1397386 (Wales)