From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E99ECEB8FA5 for ; Wed, 6 Sep 2023 08:50:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F3F328000B; Wed, 6 Sep 2023 04:50:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A4348E0014; Wed, 6 Sep 2023 04:50:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66BA328000B; Wed, 6 Sep 2023 04:50:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 569128E0014 for ; Wed, 6 Sep 2023 04:50:57 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2E9091A0CC2 for ; Wed, 6 Sep 2023 08:50:57 +0000 (UTC) X-FDA: 81205552554.13.4B8477C Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by imf30.hostedemail.com (Postfix) with ESMTP id 4021B8000A for ; Wed, 6 Sep 2023 08:50:55 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=HGQ7KCKE; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf30.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.41 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693990255; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=eOVo3ZwDvKArSHES499DNzECR9ZSYSriWYZ+V08m7Fo=; b=nnv17YbnsONPx67pRTAcJQ2bd+4AuSr59zJYfpGQkLCztiE0e2PQbq2JIbIw34ToMeehwS 7bHFxZJb4DCiR3aYhn6yO2s8q+RQpkXpOtpgkia2wLiux0QaU9RluQeDMXAA7V5U0x8hL+ VKFR+bgzFUeor6b3Rg2iDx7QB6uA8dc= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=HGQ7KCKE; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf30.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.41 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693990255; a=rsa-sha256; cv=none; b=A4y78ZT9Dw5lUJc/AlsCacBvt+cor/87REu/pqtq5de6/Z9D8/zZGvNk7WMwJz4SvmVcnK OI6A7Y8ftlCLoAliz+ataa9Kq5LKMwBEvE2KfoY9OyVhDrmVfmRWkVUm72X34RNxOQLQHy IXqdwdajnpfjKIQ2tpmO91PqFIVdaJs= Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-31c615eb6feso2856266f8f.3 for ; Wed, 06 Sep 2023 01:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693990254; x=1694595054; darn=kvack.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=eOVo3ZwDvKArSHES499DNzECR9ZSYSriWYZ+V08m7Fo=; b=HGQ7KCKEy05dmEbgeXZHIxTsp11bTeZlGszSerg3Ai8AwsovnkfI2rkX6GVeo2pZhQ sK2VPgg97QnKrHRB5bTXyo5PqbfaU8HjV1BMoeFBtO7i3lo4I9isCaDe72Pogcwfwxux lOhstUuynpeLZN5cnZSn9eIYk1A+tRx6FKLEfMc7zKOChaCy0DV0Xe4EvpaCJAp5vm7w uD8XrNxeqwWxE4qTkK+AicBjxfl1gKSzRsC88BTaCJvOsBlZnUXmNVcBbBOzst5ia2Y1 2w9sDR9woWUQS6PGbC3+B+rz7yQYkbIOFaWdej06bVbVCKfDfa9GR++XolToC+mLlDnK x5oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693990254; x=1694595054; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eOVo3ZwDvKArSHES499DNzECR9ZSYSriWYZ+V08m7Fo=; b=MTXU3ZlzIvA82+x6fhykUnJrMWtQNyTqp8M6ZZwOBzOE5IilRpb828ZS3EIUHLVhPm g3VVa+9naUY7uvUTtZlyI/uCiPnc5AkKH77AWFFSLKMOi7h4XlWrHDpbqlgWZJmytMQR aDKP1t1/j0dYP1Yx/RTSkzC2gEI2GdgFV4ACKqHEnm1rKe8LmTlTQQYgfz9BsOBVMKAW 0lauA3zAMw8dfehRe40O0KcdmFlE5bpB4KL4xveF015RaJ7qUUKTAuEp/tPjDJdOs+bK bjHWRFJXYNqKFyge5/mQuZE/VExm7lYN58uwTNsd/ieCzfRcR6dMtU9KYDxjOsCMdi7N T+2w== X-Gm-Message-State: AOJu0YymYBPJ/czWyOx8HYJpMv4LkFEq3fOLeUa0TBmdS2Yx/8Br7T7j uVxZVecL0kQleHSNnoDyEdV6Lw== X-Google-Smtp-Source: AGHT+IFYAVIUJmWNHmb4PEL4o8U/ePstlp09xawzES7nEjibffUharmDCiScln3UrEMo1YRaaVIliA== X-Received: by 2002:adf:f144:0:b0:319:8436:d77d with SMTP id y4-20020adff144000000b003198436d77dmr1769783wro.37.1693990253607; Wed, 06 Sep 2023 01:50:53 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id bt12-20020a056000080c00b0031433443265sm14068819wrb.53.2023.09.06.01.50.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 01:50:53 -0700 (PDT) Date: Wed, 6 Sep 2023 11:50:50 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Wenjing Liu Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Alex Deucher , Dillon Varone Subject: [linux-next:master 13273/13985] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c:1756 dcn20_program_pipe() error: we previously assumed 'pipe_ctx->plane_state' could be null (see line 1719) Message-ID: <63b3f332-0682-4d9b-96ae-a5bddb1bc8b4@kadam.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: 4021B8000A X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: mx983wx13yr4146iet5dwtgx4caa8jpp X-HE-Tag: 1693990255-422356 X-HE-Meta: U2FsdGVkX1895akVG+KlyY70EzHLSO0BsSr94YYWKlvItBP4NC3aVO7gavyIx1kOT/4WNJPyU4FomQ1d9IHlVai1/AuFFdPlOObi2WNKH6QEf/nkKRbIySAlADm43P/7iZaJ0yXV4OTCvXWgDMFBRhvGwec4uJYOVl5yYds9ft6MmbAENHxLGLl3qK6WTipP8J9ee2+8z/b5ItGZBidDnNffzS1oOELlx4kVIcf70ejw+o0aJiImXxUa7mh/0Ai0F5kZJoBSQL7gAr0s7+B+6E3aJN9oxFdNgu0rf3cNbGC23BDqqXG+MBw2bHBamSilaqEU51UHJwgPSPOSzX3ByjlNPquLKHJ7RHhMvo9l86lehEh9eZ0YBCR/lswZzOJYZUxflYAlVmg9uf9D7j4fZ75ixtHrqGIvYJv6iAxD1iF1SslXuxOHCTqjT2eMLIpNAUUiiyyQU5V0mScBYWIUrptD6wBXw3nbgBZo4rkI7oNAEoTjAwiHWQSdfd15/e8Qdanboa7EujnC6vOwiFPI9WWISJlxd9leziaGMyz2MI9ZcduW3HqoPf86mTfbVag17RcUlvgc7dARd8NcuAhq56v0KBDi/VtrmlN3OA5tPypG9hbmsw8mCyheFlQHIMR+g6ey1b8W55DBFjQK1v67ekNh3mqi0dsFUz3WoiV1U/h4rFaikZLMRUOFqeQ8et3hhXmDiXn3ooqESVBtxrhQPFdLDEKF8XHeA6PKw1t/p1zryJx9wygRqiM0Q+xWXyMrejL/ozmvU+xJaDgZ9LddP6gIQBjRfDBV41VeuqHNgsPu1tAalNd292NzzrQvFn5lMBkbJyPxgfdxks6Dwu+sqg07Z2X+Im0KTpIcHX88GBA3v226pTQ9orFKg/i3MtPejAxOosBwSNZ3bkq4YwXRL7LRcVPovNUNp5cdhpt1um5mKsu2Heoy+mUKAmbtNgb08h+eHs97i945amkvF0/ xhumF0ij l+T9LRw53sgXqDklOOVJhS4qbdFNji+UoMBC+D+5UvIrbDwPvKv5eBxr+wK1WEC/cv4PBp8FpbY5jh17TXJ9l4kXVp5HNXPcPbBicTDtKt5eHOUfoLMULlX48AMQDLxNXvIxmTzUEIi9CR5EGap3REGoXF5SstP5Bwd9RsrSuhXscBOPtp226uqMAiMs9NB0eMbLda2cia/39j3RvDelS+grKpZLpICIeY6gYqLaGVhDqG7beFQOXZfmpuaFRB7yYmZQytWfDDJoafbe8HtX7awcxTOQjLD+69IAQLJtMVT+e6BjKMrG3/NQyCCO85JNK+4Wy670Dyo+a48IifWB7kX8Q9vmGBcxKFYjikpFnWu2Q8Nayu0VulTiwi/F23y+7FP3AW85e3MGkPkzpk/oW/rCd2ILvX1pYbqI2cm1HTN26w6JdobdPAUdn4/q5Xwi/waOYefw5wUCWAFM5vndUo5Yntu6CSiIhcVtkRjx+alK1zNRaXMV6dFU6WBB154dh0HUaEBIsAdWlUNONNJg+Y8H9xHOb6TiJPntpTu3iNQd5mgxh1kT1QRuj+Ht70F1KmxxeFppB9hJQtWopY7u280YjP/j6Eu56RORb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: c50216cfa084d5eb67dc10e646a3283da1595bb6 commit: 15e6b396f5ac259126f2447fcd2279ed5d3dd14f [13273/13985] drm/amd/display: update blank state on ODM changes config: i386-randconfig-141-20230905 (https://download.01.org/0day-ci/archive/20230906/202309060233.75PHiDL2-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230906/202309060233.75PHiDL2-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202309060233.75PHiDL2-lkp@intel.com/ New smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c:1756 dcn20_program_pipe() error: we previously assumed 'pipe_ctx->plane_state' could be null (see line 1719) Old smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c:815 dcn20_enable_stream_timing() warn: variable dereferenced before check 'pipe_ctx->stream_res.tg' (see line 722) drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c:2016 dcn20_post_unlock_program_front_end() error: we previously assumed 'hwseq' could be null (see line 2010) vim +1756 drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c b6e881c947417e Dmytro Laktyushkin 2019-09-13 1706 static void dcn20_program_pipe( b6e881c947417e Dmytro Laktyushkin 2019-09-13 1707 struct dc *dc, b6e881c947417e Dmytro Laktyushkin 2019-09-13 1708 struct pipe_ctx *pipe_ctx, b6e881c947417e Dmytro Laktyushkin 2019-09-13 1709 struct dc_state *context) b6e881c947417e Dmytro Laktyushkin 2019-09-13 1710 { f42ea55be11147 Anthony Koo 2019-11-05 1711 struct dce_hwseq *hws = dc->hwseq; d3dfceb58de5f8 Aurabindo Pillai 2022-02-23 1712 15e6b396f5ac25 Wenjing Liu 2023-08-14 1713 /* Only need to unblank on top pipe */ 15e6b396f5ac25 Wenjing Liu 2023-08-14 1714 if (resource_is_pipe_type(pipe_ctx, OTG_MASTER)) { 15e6b396f5ac25 Wenjing Liu 2023-08-14 1715 if (pipe_ctx->update_flags.bits.enable || 15e6b396f5ac25 Wenjing Liu 2023-08-14 1716 pipe_ctx->update_flags.bits.odm || 15e6b396f5ac25 Wenjing Liu 2023-08-14 1717 pipe_ctx->stream->update_flags.bits.abm_level) 15e6b396f5ac25 Wenjing Liu 2023-08-14 1718 hws->funcs.blank_pixel_data(dc, pipe_ctx, 15e6b396f5ac25 Wenjing Liu 2023-08-14 @1719 !pipe_ctx->plane_state || ^^^^^^^^^^^^^^^^^^^^^ Can this really be NULL? 15e6b396f5ac25 Wenjing Liu 2023-08-14 1720 !pipe_ctx->plane_state->visible); 15e6b396f5ac25 Wenjing Liu 2023-08-14 1721 } b6e881c947417e Dmytro Laktyushkin 2019-09-13 1722 a71e5529d26745 Aric Cyr 2020-12-10 1723 /* Only update TG on top pipe */ a71e5529d26745 Aric Cyr 2020-12-10 1724 if (pipe_ctx->update_flags.bits.global_sync && !pipe_ctx->top_pipe a71e5529d26745 Aric Cyr 2020-12-10 1725 && !pipe_ctx->prev_odm_pipe) { b6e881c947417e Dmytro Laktyushkin 2019-09-13 1726 pipe_ctx->stream_res.tg->funcs->program_global_sync( b6e881c947417e Dmytro Laktyushkin 2019-09-13 1727 pipe_ctx->stream_res.tg, 5842abd985b792 Wesley Chalmers 2022-11-09 1728 calculate_vready_offset_for_group(pipe_ctx), b6e881c947417e Dmytro Laktyushkin 2019-09-13 1729 pipe_ctx->pipe_dlg_param.vstartup_start, b6e881c947417e Dmytro Laktyushkin 2019-09-13 1730 pipe_ctx->pipe_dlg_param.vupdate_offset, b6e881c947417e Dmytro Laktyushkin 2019-09-13 1731 pipe_ctx->pipe_dlg_param.vupdate_width); b6e881c947417e Dmytro Laktyushkin 2019-09-13 1732 ac84304d68c4b3 Zhikai Zhai 2023-03-02 1733 if (pipe_ctx->stream->mall_stream_config.type != SUBVP_PHANTOM) 203ccaf586446b Haiyi Zhou 2022-10-20 1734 pipe_ctx->stream_res.tg->funcs->wait_for_state(pipe_ctx->stream_res.tg, CRTC_STATE_VACTIVE); a71e5529d26745 Aric Cyr 2020-12-10 1735 a14e9e0292e299 Dmytro Laktyushkin 2019-08-26 1736 pipe_ctx->stream_res.tg->funcs->set_vtg_params( a71e5529d26745 Aric Cyr 2020-12-10 1737 pipe_ctx->stream_res.tg, &pipe_ctx->stream->timing, true); 1caba4e83b9d8a Aric Cyr 2019-09-06 1738 f42ea55be11147 Anthony Koo 2019-11-05 1739 if (hws->funcs.setup_vupdate_interrupt) f42ea55be11147 Anthony Koo 2019-11-05 1740 hws->funcs.setup_vupdate_interrupt(dc, pipe_ctx); a14e9e0292e299 Dmytro Laktyushkin 2019-08-26 1741 } a14e9e0292e299 Dmytro Laktyushkin 2019-08-26 1742 b6e881c947417e Dmytro Laktyushkin 2019-09-13 1743 if (pipe_ctx->update_flags.bits.odm) f42ea55be11147 Anthony Koo 2019-11-05 1744 hws->funcs.update_odm(dc, context, pipe_ctx); b6e881c947417e Dmytro Laktyushkin 2019-09-13 1745 868149c9a072cb Joshua Aberback 2020-03-30 1746 if (pipe_ctx->update_flags.bits.enable) { b6e881c947417e Dmytro Laktyushkin 2019-09-13 1747 dcn20_enable_plane(dc, pipe_ctx, context); 868149c9a072cb Joshua Aberback 2020-03-30 1748 if (dc->res_pool->hubbub->funcs->force_wm_propagate_to_pipes) 868149c9a072cb Joshua Aberback 2020-03-30 1749 dc->res_pool->hubbub->funcs->force_wm_propagate_to_pipes(dc->res_pool->hubbub); 868149c9a072cb Joshua Aberback 2020-03-30 1750 } b6e881c947417e Dmytro Laktyushkin 2019-09-13 1751 ba5a5371812e1f Nicholas Kazlauskas 2021-05-19 1752 if (dc->res_pool->hubbub->funcs->program_det_size && pipe_ctx->update_flags.bits.det_size) ba5a5371812e1f Nicholas Kazlauskas 2021-05-19 1753 dc->res_pool->hubbub->funcs->program_det_size( ba5a5371812e1f Nicholas Kazlauskas 2021-05-19 1754 dc->res_pool->hubbub, pipe_ctx->plane_res.hubp->inst, pipe_ctx->det_buffer_size_kb); ba5a5371812e1f Nicholas Kazlauskas 2021-05-19 1755 747012382937e4 Dmytro Laktyushkin 2019-08-22 @1756 if (pipe_ctx->update_flags.raw || pipe_ctx->plane_state->update_flags.raw || pipe_ctx->stream->update_flags.raw) ^^^^^^^^^^^^^^^^^^^^^^^ Unchecked dereference b6e881c947417e Dmytro Laktyushkin 2019-09-13 1757 dcn20_update_dchubp_dpp(dc, pipe_ctx, context); b6e881c947417e Dmytro Laktyushkin 2019-09-13 1758 b6e881c947417e Dmytro Laktyushkin 2019-09-13 1759 if (pipe_ctx->update_flags.bits.enable 46250a0cba4ce9 Michael Strauss 2019-11-03 1760 || pipe_ctx->plane_state->update_flags.bits.hdr_mult) f42ea55be11147 Anthony Koo 2019-11-05 1761 hws->funcs.set_hdr_multiplier(pipe_ctx); b6e881c947417e Dmytro Laktyushkin 2019-09-13 1762 b6e881c947417e Dmytro Laktyushkin 2019-09-13 1763 if (pipe_ctx->update_flags.bits.enable || b6e881c947417e Dmytro Laktyushkin 2019-09-13 1764 pipe_ctx->plane_state->update_flags.bits.in_transfer_func_change || 2dc84508f8c692 Melissa Wen 2023-05-23 1765 pipe_ctx->plane_state->update_flags.bits.gamma_change || 2dc84508f8c692 Melissa Wen 2023-05-23 1766 pipe_ctx->plane_state->update_flags.bits.lut_3d) f42ea55be11147 Anthony Koo 2019-11-05 1767 hws->funcs.set_input_transfer_func(dc, pipe_ctx, pipe_ctx->plane_state); b6e881c947417e Dmytro Laktyushkin 2019-09-13 1768 b6e881c947417e Dmytro Laktyushkin 2019-09-13 1769 /* dcn10_translate_regamma_to_hw_format takes 750us to finish b6e881c947417e Dmytro Laktyushkin 2019-09-13 1770 * only do gamma programming for powering on, internal memcmp to avoid b6e881c947417e Dmytro Laktyushkin 2019-09-13 1771 * updating on slave planes 7ed4e6352c16fe Harry Wentland 2019-02-22 1772 */ bb622e0c004404 Dillon Varone 2022-11-17 1773 if (pipe_ctx->update_flags.bits.enable || bb622e0c004404 Dillon Varone 2022-11-17 1774 pipe_ctx->update_flags.bits.plane_changed || bb622e0c004404 Dillon Varone 2022-11-17 1775 pipe_ctx->stream->update_flags.bits.out_tf || bb622e0c004404 Dillon Varone 2022-11-17 1776 pipe_ctx->plane_state->update_flags.bits.output_tf_change) -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki