From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31DC5C2BBCA for ; Fri, 28 Jun 2024 03:32:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABFE76B00C7; Thu, 27 Jun 2024 23:32:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A6F846B00C8; Thu, 27 Jun 2024 23:32:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9370E6B00C9; Thu, 27 Jun 2024 23:32:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 741136B00C7 for ; Thu, 27 Jun 2024 23:32:33 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 24BC2413A5 for ; Fri, 28 Jun 2024 03:32:33 +0000 (UTC) X-FDA: 82278874986.09.473E9A2 Received: from out30-99.freemail.mail.aliyun.com (out30-99.freemail.mail.aliyun.com [115.124.30.99]) by imf18.hostedemail.com (Postfix) with ESMTP id DAFBA1C000D for ; Fri, 28 Jun 2024 03:32:29 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=b5HClanP; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf18.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.99 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719545531; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dDK6XfqdElW0YhTqpgvd5sdP3jB1jBOHpdWdxJ3BtW0=; b=X1rCVzEWpeltVINxN0QwCunF8utrPfwUskDN+re10tGCYGTiNXxUyRSG8Z9YadXm3W1fMu xAGR634jvSxevaX0gkuwpG+Ij3XV1qp3Mkkd00ZcIIL/WlOlIQyJfZwkSs2p3h72KO3uFB ufIq8GtjC0fMNoGtlkqN8wCHv+xSfXg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719545531; a=rsa-sha256; cv=none; b=5PshGjeVu1Fdp+5RCyFjoD9u3HDm+FswZgbASpjccqwEip7FL1rcRu/gMryn9j9UlLU2l4 u0/gfK1wsyNFDzO7n7/Yq6a8Q2epPqoKb48ZAODcbqOliXs82HnLwlUHVHUiG6ozqjbUTp vJeK3jax5neqFT3xJabLpwosEI1ovZI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=b5HClanP; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf18.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.99 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1719545543; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=dDK6XfqdElW0YhTqpgvd5sdP3jB1jBOHpdWdxJ3BtW0=; b=b5HClanP72yPxHWcFNAflw2+28JaZKk0Nc2sDkkzCegjeZ527ITlR1hqjApQrAMMtePKuHnKiu8PlJW45Atq7WP8p8Ar9Ss6vRLDNImAgSbRT8BOnWGR3OXTxPi+t4Qi7kvsqBE0iEl8rltq8Jf0oXleeDE/8+mH9K0wsPX4jdQ= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033023225041;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0W9Oogpa_1719545542; Received: from 30.97.56.65(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W9Oogpa_1719545542) by smtp.aliyun-inc.com; Fri, 28 Jun 2024 11:32:22 +0800 Message-ID: <63aed837-21ae-4bc3-b327-ad2a005e6e4f@linux.alibaba.com> Date: Fri, 28 Jun 2024 11:32:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/shmem: Fix input and output inconsistencies To: Bang Li , hughd@google.com, akpm@linux-foundation.org Cc: david@redhat.com, ryan.roberts@arm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240628032327.16987-1-libang.li@antgroup.com> From: Baolin Wang In-Reply-To: <20240628032327.16987-1-libang.li@antgroup.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DAFBA1C000D X-Stat-Signature: rc75cqht8j41ewesrqgzx4o9sgtefnz5 X-Rspam-User: X-HE-Tag: 1719545549-75282 X-HE-Meta: U2FsdGVkX1/Xd44/eNiVo5xJuzYMXxSAX20nmcJwBEYFytCczdF4BTkBuZZMD90pzypFYhSxH/+85sTaiqDgTwiVxg4pUD9nIIau09ha8YCGca31cg16gKsDfVCqJz+XVLHDx8/Ib2/9ty8iz0vVZ51hWghhI0h0kjTkByjLQsSlIZSELJRAtEq9068iiStH4otFWfacmLzI9Da5mLNt9V6hMRxiZTNrb29LqB9HnIAEOaYTdd4p2yax1PywCESlIyMyay0a3K17qQJb63ZnA67yFkYllE1s/oBnct1sIJDXAR11BfGgGd/neXDGdHQQ/fzgfWiyipFF2SJcV5dP4/xSNo2LYLpfosYY9Zd/2Of2ZYVZYV6dRHHZI7t6IZdDjWigN+nNgPuhzh0mmG+ABsGfQknRixVX5iYg1rwo3m32QyMMJBfeXw7boXmIBg93NvcQ5z1ys72lHROm6PV1CBQm2KC2zfxsSR2Tgi1Ovd5MPrU1x94qIKsU8n5urbA9He6U5iWJuX5J4yQ+d4OGkV1LLxxbTpUGTn/v3Kf7NMdv9WdnUvpoh6523HeZp375+9aUHuLkom9EqCfuPXqsKXzd0vIqVJZ159/jCN65U9zYX84zk7ctACkr3kanhOkhiWmbIrNX+nX43eauzhDBQEWEJ5tSE4MtET/YbtQU5lZrt4gQic3Y1J8FpC91r7HHSp9oICgKnTo+LGLMSskwSdLKdPTUusc0AJ3ABKYZlbgIjYLWJ0TSqVWr+1FaKT1pfGBWspte47gnNkzjBH5Km8+wm5EIqb6u+C280eB/yK+3E3XOSsGJyhW9bTYOk2NCiFsxkYzwRngKs6MTohipRNT4Ccr6bsBWUrr3qafN5Jxx4Q2SQ2Jj56ReDtzks+xWTx6K8vBbu+7ANA2mizvGKAHv6BqKMJWz0vh+afFtUmp7CTTv9XebHpr2M6Tu+4vlow74c2oBLGQrE/iZ/Xb toxVqm4H ZZzH2h4YrFwie7Bl7odEoGSwfLVEzRVNtYs+r9j3FvvBiUX8JPq1hORJNxjz5l29EPJ9SCL2Upw+a64dboMKGIcY9VWw2CWsquxMll9/Qx7M2NKwSIvapjgWcuylJcpVnApxIBEBnef4qAwQkoKp16qd0sW8+tJTBcDijB138Ag+U1m9lMwl+goIynDJRc5f9kgqSkgEa18a9n+oPpxkWsc3HFfOrbwxIhvezAZTzfQFyFFBcG0N/V1RcPbHNrjwTusILC2vZpon0PbF8fRys+wZCdweyVgZrT2DkTNQqEKNkU5ow0tR3u/JAmkNRGO+vtKHSABsmUsjmzpSE36UzTRRIevvlnS5G/jimGl14/Q4znZkNFdPfima82Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/28 11:23, Bang Li wrote: > After the commit 19eaf44954df ("mm: thp: support allocation of > anonymous multi-size THP"), add mTHP support for anonymous shmem. > We can configure different policies through the multi-size THP > sysfs interface for anonymous shmem. > > But when we configure the "advise" policy of > /sys/kernel/mm/transparent_hugepage/hugepages-xxxkB/shmem_enabled, > we cannot write the "advise", but write the "madvise", which is > unreasonable. We should keep the output and input values consistent, > which is more convenient for users. > > Fixes: 61a57f1b1da9 ("mm: shmem: add multi-size THP sysfs interface for anonymous shmem") > Signed-off-by: Bang Li Good catch. Sorry for my typo. Thanks. Reviewed-by: Baolin Wang > --- > mm/shmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 13d139abe69a..d495c0701a83 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -4983,7 +4983,7 @@ static ssize_t thpsize_shmem_enabled_store(struct kobject *kobj, > clear_bit(order, &huge_shmem_orders_madvise); > set_bit(order, &huge_shmem_orders_within_size); > spin_unlock(&huge_shmem_orders_lock); > - } else if (sysfs_streq(buf, "madvise")) { > + } else if (sysfs_streq(buf, "advise")) { > spin_lock(&huge_shmem_orders_lock); > clear_bit(order, &huge_shmem_orders_always); > clear_bit(order, &huge_shmem_orders_inherit);