From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A67BC369C2 for ; Mon, 5 May 2025 07:01:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E48D36B0088; Mon, 5 May 2025 03:01:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF8046B0089; Mon, 5 May 2025 03:01:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C71F16B008A; Mon, 5 May 2025 03:01:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A4B666B0088 for ; Mon, 5 May 2025 03:01:33 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A5A93BEEC3 for ; Mon, 5 May 2025 07:01:34 +0000 (UTC) X-FDA: 83407958508.16.185F852 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 44DD11C0004 for ; Mon, 5 May 2025 07:01:32 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EYFIAaY6; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746428492; a=rsa-sha256; cv=none; b=Rs3dKgHQiYCVimOJZJnbaRSJP9MIh9vXkY97nBA+8dgyQnBdeov4/R0UMXNsxAFW38mhao 3GWvuyFsgz7y1lOPvXxRvgFQCNOEIixs4a15RpfbDgbm6nPFLUjpVzY/ojOeRdY0rhoeHu l7aQIMfXEed/PgqOM7juQJQpcTQJAV8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EYFIAaY6; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746428492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RhhfHcsYwpjxeDwjBj3ZnCOvnYbVlwVS0EYs91oxcrY=; b=zhBS/e6YZjW5geWHmsTvxrWUT+PLwjq6eKU7e3X0Kwd+l0DrBWI0DJNJDFKhKHgTWxf/2B poFmNPNsOqZuThxeridD8Lw8yovGSXMEmTrhJ5HcsHonMN47Yi7EuQgaOhDlCqbhAZmvhC 5kS5qistTW/NI4yxSEHjzXkGOxm3VyU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746428491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RhhfHcsYwpjxeDwjBj3ZnCOvnYbVlwVS0EYs91oxcrY=; b=EYFIAaY6OkXzPZSLeU43DWMjxkf7JTS+HP5zSrv8Q+bzIh/H2qtrfGRSFi2R3Oy/pECiSM wTnohXq34iOmP1p7BYt9koQy6x8dOSIsWe6WKAB6TQASd27ZT13sHAgvZXjMdxvH/ZvpwP RPchbvEArWfHE0TcUPO5JZxshKSJoU4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-pohpieAaPqySq1yyucC2sw-1; Mon, 05 May 2025 03:01:29 -0400 X-MC-Unique: pohpieAaPqySq1yyucC2sw-1 X-Mimecast-MFC-AGG-ID: pohpieAaPqySq1yyucC2sw_1746428489 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43d08915f61so20609875e9.2 for ; Mon, 05 May 2025 00:01:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746428488; x=1747033288; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=RhhfHcsYwpjxeDwjBj3ZnCOvnYbVlwVS0EYs91oxcrY=; b=aSJBIkivtwPRaLJ9e++0l30fpduVQ0A1eC+/1XQosby/98UiodeTGFYAWAYED3ynch PdYmA7l7BoCNmiMb8ZiDh0Tr4CLbWVvI+eQwFa18MmAmW4O6MSilpWsftxxhoTsvtif2 t5TffvNp+CxqNUr70XqspCpUH+m6nSNVC4gN+OPkYZ9ss8SLvNSd+fA5PlmMuIJOludH bKeMerkRTYJNQTNWyNFu5qUjgJOnA0bKu+lUpva1kKfaA4IqJ/hMZH4SvrWtXbbGDYzn gC7EGIoEqLKL84SmVtImn9H0WPutSZyZlVvrAsmD3ft6UvmyAoczWMUYCT0cq3zXGBVv Zu9g== X-Forwarded-Encrypted: i=1; AJvYcCVgzKf44moLOzmVkexSI4ol3m26jlFpmL8YAjQI6JPm9m9FpYbC4vV/QOVaBt99Q4/r4tLIDHaVog==@kvack.org X-Gm-Message-State: AOJu0YyYxwFNfB2iMqmFVCfuXIDgZNaEiXcAFxjw2RbjNFqk7tfxnOpU yRfUS+dapSwa+xAFyPH4CjhU/lvJFjNHVAfUtTKdSnJBhOsaXG+c8j/R4/GGJzfk82U9hu8ePqU amVTt2ogBf7jlGqriA3VUNDZkwRpJhwHhrT9G2UlgjS4kUQ9y X-Gm-Gg: ASbGncu9iVm4Y7dNVRaFwjY8u8D8HMdn49ti1jTZPdKLjxHE8I3enRXBAAocOQoglfS MPmg8N6r5F6NKQUmzth8hAWckssR79uRYBSOrtiQ/6bsB2QytMnCiUu+fbhMOAY+oEGBwEA1xkI 4/yp0egxUrg955VNbhizygzA45o7pUI2KyRTK/hhrqT9qkftlSThiHxPV2hkCyTqZnqGI/kvm86 TQVoNB7+53mV1JnKBWuhDfdkqkddZhSWLtBaJfgPW/fankMQTb1CTIKTboWa7GB1g7QcBxugqrI VPI+1qD1c+RQLPnLHGA1GrChbwhrDsTCh3Jog1nZrCfW1XirM6PTgUZLC88cYzvAmV0fBbepwsb mBcO1807AorGAqfiepsE8bW5SM9nZLR68ghDniqU= X-Received: by 2002:a05:600c:1d9e:b0:43c:eec7:eabb with SMTP id 5b1f17b1804b1-441c48bc8f0mr46800765e9.8.1746428488651; Mon, 05 May 2025 00:01:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFhpv+nKKZWl5dr3iD1RZGtma0FOL/sFOuS9BaYW0RupdfMgHSdX729belBTdnHfdl04v6LmQ== X-Received: by 2002:a05:600c:1d9e:b0:43c:eec7:eabb with SMTP id 5b1f17b1804b1-441c48bc8f0mr46800535e9.8.1746428488347; Mon, 05 May 2025 00:01:28 -0700 (PDT) Received: from ?IPV6:2003:cb:c73d:2400:3be1:a856:724c:fd29? (p200300cbc73d24003be1a856724cfd29.dip0.t-ipconnect.de. [2003:cb:c73d:2400:3be1:a856:724c:fd29]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b2b287desm169126605e9.38.2025.05.05.00.01.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 May 2025 00:01:27 -0700 (PDT) Message-ID: <63aec3cb-60a8-4f30-9b12-3ee19c6c14f3@redhat.com> Date: Mon, 5 May 2025 09:01:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] mm/hugetlb: Refactor __unmap_hugepage_range() to take folio instead of page To: Fan Ni , Oscar Salvador Cc: muchun.song@linux.dev, willy@infradead.org, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250428171608.21111-3-nifan.cxl@gmail.com> <20250428171608.21111-6-nifan.cxl@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KN5dsN_TwoR3m2-aFYHyCorxgsP5OI-vuTW1vJcA1ks_1746428489 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 44DD11C0004 X-Rspamd-Server: rspam04 X-Stat-Signature: oudes4hn7m47p4d1y4r1rmi35xnkxgsa X-HE-Tag: 1746428492-78759 X-HE-Meta: U2FsdGVkX192fuyqT+v6+aW8bD3JYkQZwfzHzr8HWX2Ac8oLs6zouou7ryohgNVV6Cdu0+XjUbLCYXup6LJmSui3edW4h1+chSTdwIkefsU67I9wgNm5KIrqcJj/wPBnAuYrAvs/73d2h00xfGdog43HULpZ8UM4b6ujYrr4wYOv8Vzl3Ntu1i7pMejA4bX6be8svKEm/0lI6oplYUzDRR3VMxF1ff7zzm2yXTwp2MBxnLKVgdxOpXL6uudCklmoA9krHbBNS/DaC+m9fB3GSpcaZPZV/GZZbTVbtZHAZ4LjFc8xD9HbYQsULdw13TlHaiHKnxJbaFna+iZCVO/sRVTOV5A6p1VaHG6/iTH8iAW3kFPGXNfkYnf5oMWjA7xIJvSQWGMYfSo5xKY5LZD4CJRiVqH4z/4v6gqeNPmsqb/FuhDHt8wT0sWhg1QbJBh5HVqKfHAD5du/xHuwXoKKTAFQUT1Juyvw42P4BEaM84hPXQPF12jW5OQxcyJhTuGlcgqg661no62I9AH0DdpN7A0fdCh4y3rGpKEcOuuHEeHf+pyga+O6nml0VI7lCDhHnYZLx0t8ncUlXGE1uUPAl0fsAwz0ae19HR8xPrAJxqFynqUCOOBghf79uja2Q8fYZUKglE5wCGPHd/w7o0K0s34S91a9L7qqHTnmD0TpUTe5UiYYaU9hQAlnS+56ipKFqMDh+5LsPGELKKfu5Sm0MCZzx6ZceepChok7fShSXizid8WVG5jMTuh8TIVVuLnEoPOei9IbRWt2vi/mkQNfQGMid9h1z+EKNTvn9sy/M9WuerSsQq9k0m3AMZsrv/jbD6mBj/6INzItFLvdrxk+k0IWP6k+AEMo2PtHbAwng4aqhblQJfPB0eBSGguXe/WDC4XktlttwTerhEsNRNigD5/hXKm9kclSVdbGHseQl+2UbG4UxSC8aaAxHMgNiu8E7g46ztpUb4FCdQgqBVW MmRJAxtJ 2AWdY094vEN/M/7XT//1kJ5OxZ/Sh/AB7nkY61zBVxpkAuXs/Tp3FAdZANWlpHW5NCwPGBn25m5PDTen2darhhFekLqwY0zolD3Hdv78artSZGnf5xfMuyPnd8rk9M217w0D0WOCVFjIWdFIb14/RIqDnba++v+zqUEMd7m77nBglGOogiyIPAGqLW4gIOILNrNdDJ5FFaHeJNRoTumBISF4Oj5XG6GCWNgOmnJcnhwz8Fjc1/ZW1uL2Ztec4kH51mNZFCbm3q1e+DuKNdkVbg77jBzBp2WZcnEnrB1HDspw3VMpIiH8HYObHR2To8PCssAidWBZG0QmnbM1AOK/f/UcvVZDpPHjU0HH7eWYbn8f1EcunvUbSyJ05GNGQcikoZJPau0/W6l7RNvQkR8di6HBr62mo7ALZgBsS69KDVCkX9GeQEkyUiqkkLWrbz9O6XWoky7LAXbCgSOzEqqlnhff8kBqiA8kagUXGI6y00MtgHLSYdt5N9zPT5gsIiGsFLYrlIpns4LlyJU248Woczopt9rD5xX4EplL86XIiubZRcdIoGSpEtDTPyU5tK+pq1u+FlA3rmwYwc7d2T+AC9pl7c6BciWuBOfj6WDew6ECzL6g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.05.25 23:35, Fan Ni wrote: > On Wed, Apr 30, 2025 at 09:58:35AM +0200, Oscar Salvador wrote: >> On Mon, Apr 28, 2025 at 10:11:46AM -0700, nifan.cxl@gmail.com wrote: >>> From: Fan Ni >>> >>> The function __unmap_hugepage_range() has two kinds of users: >>> 1) unmap_hugepage_range(), which passes in the head page of a folio. >>> Since unmap_hugepage_range() already takes folio and there are no other >>> uses of the folio struct in the function, it is natural for >>> __unmap_hugepage_range() to take folio also. >>> 2) All other uses, which pass in NULL pointer. >>> >>> In both cases, we can pass in folio. Refactor __unmap_hugepage_range() to >>> take folio. >>> >>> Signed-off-by: Fan Ni >> >> Reviewed-by: Oscar Salvador >> >> But: >> >>> void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma, >>> unsigned long start, unsigned long end, >>> - struct page *ref_page, zap_flags_t zap_flags) >>> + struct folio *folio, zap_flags_t zap_flags) >> >> I think we are kinda losing information here. ref_ was a good hint >> and... > > Hi Oscar, > > Thanks for the feedback. > Since the sugguested change here is minor and does not affect the > function, and we do not have a aligned opinion here. > https://lore.kernel.org/linux-mm/b23ef51b-1284-4168-8157-432c3e045788@redhat.com/ > I will leave it as it is until there are more pushes for the change. I don't think we're losing any information. :) Especially if nowhere else in the kernel we use the term "ref_page" or "ref_folio". And things like put_ref_page(), free_unref_folios() ... talk about dropping references not "this is the reference folio". "folio_to_unmap" might be clearer, but then, I think we should just use a single folio variable in that function. This function might benefit from kerneldoc, though :) -- Cheers, David / dhildenb