From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4745E77180 for ; Tue, 10 Dec 2024 21:44:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71D7D6B01A6; Tue, 10 Dec 2024 16:44:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A5FF6B01AB; Tue, 10 Dec 2024 16:44:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D2686B01B1; Tue, 10 Dec 2024 16:44:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2C9006B01A6 for ; Tue, 10 Dec 2024 16:44:06 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9D3854268E for ; Tue, 10 Dec 2024 21:44:05 +0000 (UTC) X-FDA: 82880376978.26.09221C0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 825051A0005 for ; Tue, 10 Dec 2024 21:43:39 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Ic7oX/Ov"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733867032; a=rsa-sha256; cv=none; b=H0owkjqn+B4U/yeTUJmIhK4EOgNJfLgn3AnzSS6p0iRSaCX0zjbvCtI8+G/fUBXzoWfgPd QxqkrD4B3OOVWZ7BCYGFfhFsImbmqjNSmVfCwTuefW7S8mrZin2FYulPF0dX14vYl8+hz9 MP95pVDfecQR0e5D/6dK/GijjBi6bwk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Ic7oX/Ov"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733867032; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tP1MjT4qda+yWrKqxPuVRXu+p9J5U29ZhaYXhXN3XqQ=; b=ltyH0VNcFPuVTazyYvLLct/v4L9vQ8DLT4fulj8sPvKPnkjEHSQ9PqCH/jQQVqHpHhbJEp v3KSuDNSYusclb1QaOkC/wX6x74fjkMaHEJxSqa0hzwQWV1gnQkW7HeuOytKih4q1TJoTF ldyAas281bHF5fnvUCY3Pag2CF8zchY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733867042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tP1MjT4qda+yWrKqxPuVRXu+p9J5U29ZhaYXhXN3XqQ=; b=Ic7oX/Ovbfw3Leem3Xi3zhhOykXc+mRsnXuC48v/X6qBhy191F9hfp0Jv7q8JfOmIi8PrI S2Pkr9xIG9eML9ziNPXpnCRlqdZOlGG/H5euXm4c9Hk8Dq50ZFIiASoiS//jhwA/FpBy1N Tfkpu36Z6Dn3ZoJBGJ5usBgsTwbbXTw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-44-3NuCpw_tN0GXHJ_RYeIYnA-1; Tue, 10 Dec 2024 16:44:00 -0500 X-MC-Unique: 3NuCpw_tN0GXHJ_RYeIYnA-1 X-Mimecast-MFC-AGG-ID: 3NuCpw_tN0GXHJ_RYeIYnA Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-385d735965bso3499905f8f.1 for ; Tue, 10 Dec 2024 13:43:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733867039; x=1734471839; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=tP1MjT4qda+yWrKqxPuVRXu+p9J5U29ZhaYXhXN3XqQ=; b=iW8H6Tl71cymL7z+iRn33llz4osaMVST1l6RgmrVp54Dn1FP9Zjz02btArwiwvgqdE e36CM7cJ9FR67PHTeiI7VIpf7n7vg2CuFlJXCCy7dScikT2sOYm5W0YIqPKyWamMXQgP ydK/AEOWgI8QOA+j0Ch5zKpidj4yREV6/pUprXoUYjQ61yapU30C9o3N29xLIQXdVOj2 3jyHfLJmzrd2o3VSmEfvPhFVuzTAgEqOXlBUZDNm1DbtUQzRQrD6k3267QX6fcFynU2D xEXpLnPZH7sFN2V6q75GN3JJhH2YOyr5S6RDI38zP3WdVPPAGGCUTdjA3qvFFKv5YIi3 oiQQ== X-Forwarded-Encrypted: i=1; AJvYcCUqAkTB+rg/EoAoJA5TOolZ7jz+g5/P68k2RpO08pudTGxvquJSjcx2EVKU40ezPFpNaZgPBCfq+w==@kvack.org X-Gm-Message-State: AOJu0YzCk6s2l1vg0+oiEAZuoWJYdMZbPJ2TF6mvn2yZtmjj0fEZ1Qey lvgwVHu3z/myQC5jFP7cu3/Q/2QAlkQI3sI+X9mhTwJEvGzsdHA972dP2sDDApwgjoLWR3dyrFx xr/jRtSbyw9PKFGAXDaY4IQrL+witYg0JA183fP3LBywUtdwt X-Gm-Gg: ASbGncuglIOd5qNxzx28Z/07eAe6nBLynefBcnmP3BQeq1eIOynlyzUSZE5PQ/pV3q+ 2Aip9O3GQqaTpyZDLYw73bsXuUBwNnmvMH3MAiBTliBSn2XVSYZ4CPt7pqJ/FTbsc8SVJEfJOoj vaQ18e7biR8hDe+qcD4gTPsMmh4TFShU32yi8xoSfKyy807kwKIpMP/5r0Uj+N0AeLy7aWSnRu0 vQq4i5GSJI0+wraSMROOdgm/zTOSM9m6kIC/RiM1RBCV3AMUdjbSAXcuSJVDOUOnPrbAU2TsUmu s/jM310= X-Received: by 2002:a05:6000:178b:b0:385:faaa:9d1d with SMTP id ffacd0b85a97d-3864cea04aamr426988f8f.35.1733867038819; Tue, 10 Dec 2024 13:43:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IHBntV1r1V7qqw90fwsLljHpEimdBIKjwkwSqRAQs8sHJ14VdSz0YmnkZwq+Lk4qViVzkpGhA== X-Received: by 2002:a05:6000:178b:b0:385:faaa:9d1d with SMTP id ffacd0b85a97d-3864cea04aamr426978f8f.35.1733867038413; Tue, 10 Dec 2024 13:43:58 -0800 (PST) Received: from [192.168.3.141] (p5b0c61ad.dip0.t-ipconnect.de. [91.12.97.173]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4361b09fec0sm12034785e9.4.2024.12.10.13.43.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Dec 2024 13:43:57 -0800 (PST) Message-ID: <63ae2ae4-b023-4802-9b34-a2c0d272f6d7@redhat.com> Date: Tue, 10 Dec 2024 22:43:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] fork: avoid inappropriate uprobe access to invalid mm To: Lorenzo Stoakes Cc: Peter Zijlstra , Oleg Nesterov , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Masami Hiramatsu , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, Peng Zhang , syzbot+2d788f4f7cb660dac4b7@syzkaller.appspotmail.com References: <20241210172412.52995-1-lorenzo.stoakes@oracle.com> <3bd43f87-571a-4bc6-b068-69056ec18d85@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Nu845WZ8HrXxtGv1jhmHwUr4U8AhDTv9HTLenkTHeQQ_1733867039 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 825051A0005 X-Stat-Signature: jm7hb8qizusqtqqxmx896ea1nrcsyjso X-HE-Tag: 1733867019-538353 X-HE-Meta: U2FsdGVkX1/uByI62riPKEHiXxVm21T9LrPND7j1xnvHjN2Rw8aBAuzT5A2QnAJpqj3TazQ5CcZF+Fqz4OUCsvPWy+GtBPuRDELn5wPUiKIV8GQn5a/+vqhcWuZ3PrtfHf5J24v4zg6iI19s1stOBm1fgGDR1DRqssjB+9vy3nl+EVn2873C13e0iS7kRLAK0zYFtX7u1yFxhpFXvfySvZZqt4ha9PrU1IVrfckCxE5f6/a2sIqTe6p4cANloXER+4DoXaVsxSxva5zTGpeB8iAmdYH+zsy1SMu4FparJWdpY3wMUIqB9JUXoPgZT0kdag1QgaugIMfkPAcjCIiRw6Cw8yaSG4HpjaE/xm0cPE1p2FwBvqMcXTOj5G3KppxtDLctKaMrRG/xVWI/mYFpvoUlIWjqBN7RKO+T6HPsoP2SE2bIn6ZabYGoj4ce91kOoLlb8EVnIjD3+iQ0+foPBcTE5Rqzoki0NctIvADD+9s5aOlkMip0gc1ICWEuaF9b/EvSIHm+1An/vwoH8FJ3+Sn53LzzJkAidkVjj3idJ80dikl6/KgJJXzCzG7nGEQwxR8rccC8cAozh2y97JOVNQQETF6c1jB+ODfstvzOR4PfXcXVauJx4Lz/AIcCmZz+BkRBRTuT/Ymz5CXB/UuJRHGsHb+AB5Pe0TXvdnfzw3lWPOTytIigAQS2Un1YYE7uA31SxdjpJkI4gWs/YplhD8VFhxGOa+xw9JsR3dBZocrU/B0w2FUHnb4O3ADc5aCgtD9jkwgAiPg82u5VmddY7C6pbKlBLDsS0s+l0Cq2OErZXLA5hAeCo2n9aPz84j1iEPredwiZ4+bczPAlFOHZahipIkSkFlah7heIUNNj6WXSXQTkNdiDmRNmc+bHXWGtXudUfW0HyYobE/pmTPxDtu+MKb2Z9gBVWwh4fTU/D+8LGCWNdRSbWXzHIZN/Rtq3RlzB4nfZRSK77ec7YMO 5CVLe+gZ qCds3fjNL3zRS5pGFkAjRgYU+diV8K6OZLewHqM5CM9/XLyomxM1x6XQp5QwJGaF3wPJbEC2lZgbOBee3EWFir4q9zjF6xQ6OpJJnrZnUFxfX68YoaFnkG1Fz92l03KkuBmhWVxgIrYsfznUvE35yAtIIwALZLm2DfdN+vmB5eFudxlCxoHskEQSuKSsN536FgoMwGI+tgV0amtYDgHmxD+zMRsSAyf0wwkxV0sPEiCb91r1i8tadFgOtlaJYgv6dCelm7RHs57+xBFbjlizYj8zc/1hh2LOP+KfgalwceFVGBJ7G68tgWuZpIIONpsVmaX4OgPG3ZYERfiEUx24XyJeYxLUBsunR6Tn96PPmo5pGWtG4DaCDR2XJLEoY6JEJej2+o22PpXly0yFjfpl7CDsH9e5NYa0z6DZMjeDgOqrMjKayJNaTtRvCQ6e32zh7O2WT6s9DdAfVoBXwiEI8LD4RQUw5qhl/bqrRJcW+IcKGNf4SbtgM31Dr95+xJSyIi9SV X-Bogosity: Ham, tests=bogofilter, spamicity=0.121949, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.12.24 21:59, Lorenzo Stoakes wrote: > On Tue, Dec 10, 2024 at 08:35:30PM +0100, David Hildenbrand wrote: >> On 10.12.24 18:24, Lorenzo Stoakes wrote: >>> If dup_mmap() encounters an issue, currently uprobe is able to access the >>> relevant mm via the reverse mapping (in build_map_info()), and if we are >>> very unlucky with a race window, observe invalid XA_ZERO_ENTRY state which >>> we establish as part of the fork error path. >>> >>> This occurs because uprobe_write_opcode() invokes anon_vma_prepare() which >>> in turn invokes find_mergeable_anon_vma() that uses a VMA iterator, >>> invoking vma_iter_load() which uses the advanced maple tree API and thus is >>> able to observe XA_ZERO_ENTRY entries added to dup_mmap() in commit >>> d24062914837 ("fork: use __mt_dup() to duplicate maple tree in >>> dup_mmap()"). >>> >>> This change was made on the assumption that only process tear-down code >>> would actually observe (and make use of) these values. However this very >>> unlikely but still possible edge case with uprobes exists and unfortunately >>> does make these observable. >>> >>> The uprobe operation prevents races against the dup_mmap() operation via >>> the dup_mmap_sem semaphore, which is acquired via uprobe_start_dup_mmap() >>> and dropped via uprobe_end_dup_mmap(), and held across >>> register_for_each_vma() prior to invoking build_map_info() which does the >>> reverse mapping lookup. >>> >>> Currently these are acquired and dropped within dup_mmap(), which exposes >>> the race window prior to error handling in the invoking dup_mm() which >>> tears down the mm. >>> >>> We can avoid all this by just moving the invocation of >>> uprobe_start_dup_mmap() and uprobe_end_dup_mmap() up a level to dup_mm() >>> and only release this lock once the dup_mmap() operation succeeds or clean >>> up is done. >> >> What I understand is: we need to perform the uprobe_end_dup_mmap() after the >> mmput(). > > Ack yes. > >> >> I assume/hope that we cannot see another mmget() before we return here. In >> that case, this LGTM. > > We are dealing with a tiny time window and brief rmap availability, so it's hard > to say that's impossible. You also have to have failed to allocate really very > small amounts of memory, so we are talking lottery odds for this to even happen > in the first instance :) Yes, likely the error injection framework is one of the only reliable ways to trigger that :) > > I mean the syzkaller report took a year or so to hit it, and had to do > fault injection to do so. Ah, there it is: "fault injection" :D > > Also it's not impossible that there are other means of accessing the mm > contianing XA_ZERO_ENTRY items through other means (I believe Liam was looking > into this). > > However this patch is intended to at least eliminate the most proximate obvious > case with as simple a code change as possible. > > Ideally we'd somehow mark the mm as being inaccessible somehow, but MMF_ flags > are out, and the obvious one to extend to mean this here, MMF_UNSTABLE, may > interact with oomk logic in some horrid way. > >> >> -- >> Cheers, >> >> David / dhildenb >> > > So overall this patch is a relatively benign attempt to deal with the most > obvious issue with no apparent cost, but doesn't really rule out the need > to do more going forward... Maybe add a bit of that to the patch description. Like "Fixes the reproducer, but likely there is more we'll tackle separately", your call. Thanks for the details! -- Cheers, David / dhildenb