From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE431C48BC3 for ; Mon, 19 Feb 2024 08:35:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DC1C6B008C; Mon, 19 Feb 2024 03:35:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 78BC08D0001; Mon, 19 Feb 2024 03:35:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 606B16B0092; Mon, 19 Feb 2024 03:35:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4FBD46B006E for ; Mon, 19 Feb 2024 03:35:15 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1DE8CA029D for ; Mon, 19 Feb 2024 08:35:15 +0000 (UTC) X-FDA: 81807893790.03.11ABAAD Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf28.hostedemail.com (Postfix) with ESMTP id B241DC0009 for ; Mon, 19 Feb 2024 08:35:12 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="jk6S1oc/"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf28.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708331712; a=rsa-sha256; cv=none; b=HaNz8R+VniAh8USqWZ3oNT+HR9ZM8sRNpfd44owjv0H7GcR4OFRij8yBQAwtwulOuNkjPM C4qzb4oP+Qt6WoIZMlhWx+G+2cPV7OPj0PgMXFbY9+TXjJS1LRvrvvWSYMDGmqhyKexDbh ei0NCDVPdnhTt3qLAbpMlVeNTKpSsSI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="jk6S1oc/"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf28.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708331712; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W+DlIcgGzAZl3NaBK8gp9F/M4NDAB6yQAnUg1uqgJSI=; b=Sje8br7st0He01yBJwwozbdjZ4TDJ+kOh6BzjwwmYHn6rwL4wGMmy59vOKeLzomVZMMsYQ PPd78Ey5lbNQFAhNSi2GxllhyMx380nFsbUnS9Zee6/KgDP5ECdORiTmizE3th0AVBB1J3 tbMqfwgTUwI2LJKdow2DPF/7hnSon40= Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41J7HrJ1015351; Mon, 19 Feb 2024 08:34:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=W+DlIcgGzAZl3NaBK8gp9F/M4NDAB6yQAnUg1uqgJSI=; b=jk6S1oc/QppIW6bPUVZqW+zCfehnok3b3tO+XA+2KUPSXxX4nvuu4dpi2KRs01XNT+CJ FudN5AUUrh99QYip96lO11F5GxHkQ7bu0vU3nJhXz+HSjBCPZBfthQu8isqGYFGY4ojQ dTNGz+9uhUFw/x3oLVzCqWGNbKyZQnp3rHU5QZy6YjwUwExdoJZvZzNDsjuaSbeSwZF5 8uT5CK6Vp2bo/ujFazaaOaWQ9iYvM9FBVKVESTLAVjKsnsxqBlm01mJjEsAMPU47DYk0 b5xOwK8f3OeV8RIwSRBpFstCWfQypOEBG1LKAqfpC3vMY4LC3LLu5k3xWF629DO28IT0 oQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wb3w79juj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 19 Feb 2024 08:34:42 +0000 Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 41J8B5xS023389; Mon, 19 Feb 2024 08:34:41 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wb3w79jub-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 19 Feb 2024 08:34:41 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 41J6UYcZ031118; Mon, 19 Feb 2024 08:34:40 GMT Received: from smtprelay02.dal12v.mail.ibm.com ([172.16.1.4]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3wb9bkfktg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 19 Feb 2024 08:34:40 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 41J8Ybll21037570 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Feb 2024 08:34:40 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AA0D458064; Mon, 19 Feb 2024 08:34:37 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3802758066; Mon, 19 Feb 2024 08:34:30 +0000 (GMT) Received: from [9.109.245.191] (unknown [9.109.245.191]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 19 Feb 2024 08:34:29 +0000 (GMT) Message-ID: <63a0f7c4-3c3f-4097-9a24-d1e3fc7b6030@linux.ibm.com> Date: Mon, 19 Feb 2024 14:04:23 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] mm/mempolicy: Use the already fetched local variable Content-Language: en-US To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Aneesh Kumar , Huang Ying , Dave Hansen , Mel Gorman , Ben Widawsky , Feng Tang , Michal Hocko , Andrea Arcangeli , Peter Zijlstra , Ingo Molnar , Rik van Riel , Johannes Weiner , Matthew Wilcox , Mike Kravetz , Vlastimil Babka , Dan Williams , Hugh Dickins , Kefeng Wang , Suren Baghdasaryan References: <9c3f7b743477560d1c5b12b8c111a584a2cc92ee.1708097962.git.donettom@linux.ibm.com> <20240218133851.22c22b55460e866a099be5ce@linux-foundation.org> From: Donet Tom In-Reply-To: <20240218133851.22c22b55460e866a099be5ce@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: JdZqDiB5eVcS1JeYf3jBi_8uBg7XTy8o X-Proofpoint-GUID: VtJweGyLEc8FaQ0QA9ztAUpcNFKPxVNa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-19_05,2024-02-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 mlxlogscore=999 spamscore=0 clxscore=1015 phishscore=0 suspectscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402190063 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B241DC0009 X-Stat-Signature: rzq4u4rehssucc4gjo8hy1qkn9djxrgc X-HE-Tag: 1708331712-608457 X-HE-Meta: U2FsdGVkX1+VvASDwSkKj5Jf2p0GZ0RENpio5Z2olfP5jYw6rve4VTQ1K4kX2sPM/6BN8wN5cXqEd10pgbOdixPn2rCEdxWdZtI5PPci+JZ89Zurvt+2xwydOhPWr31TmV7SLYZMhLhOKXg4cDTAJofi4SJcHNC8pr0BiFdp3IZYpfniMfl8kMBCIafbGZSNC1jEKM9M+VIL6jSmMHQgvRE8Pu6lw1fmOfLGKsBSqd4yYLEUQtC9K/XjgVeKXyyE8cyMuGJl5n4B2F7sNfk/rU8vFjl7OZtu5MhPr47ZQLxltYrxUqJln0qB64bt4UYSxOykmjQZ1VtoiRhaXkF9afYex1Ulk/vdZ6bkD7a+IF5sy/av8K6IO88sHvczcJizuR9af6nH8ct03jUeU5cjpYoPKuYsnU7nFCbJ//9mH3IP2r1MSWJOFffmYhLe17BWPLI9XLjZ1KTyidVkMSXh2tYbWgpHgNJJIX0sBGc13vUUXoOGSG9I2pW+Ie5u09+hDWjvcEVl60pWy0j1oTqtey4ohx0xl1Zk2yH5v7hmdgLe0T02uhSLMcLH8VjUjYaN4YfrmaMfTgA3ltTNCytuX01hZuUuyKnvRnnR7pN0A/rPzUDKhfCbpgWB3I5rwsEfY/luiqff44fiyQK6aW9Pz6IOSWRcYokMxpZ5ExpWDPTiD/IiS1htklu1MqoK79Th7TQGg+Gic7rjZK3sCC1ZmuAKCHZR6gqm5h5N5R84O627NshSttvxdPZvMcOLn4Y7hvpwc86esNaKhEKOKlouYN5bdzeysihyCX21nZVyXg9XTy1nNr+AoxGzHOs+tk2WN9BnWz3ILdzFuILho+sZitYLAPW22tdwWyYlUmh6Zh4+0gWTxgsV4hUXwx1EH5Cqda5zf15abj8xX73aQwEAdxILhQOmgMLH94wPg4ifEn/ljv75nSDVTv/YHydNaQHWS1Kdm+QjS7oJh4hu06A XYbk2boQ SroG3arpWvtVi5Tx0fo3vLbWtyLMABipwKfhL5aurddhbRLDFEiSUEnCyxtFkvNgscEFnubLVCZrSrLZr3Q2RiYrgEjJ9WkE+M7Anbjr0Lip4T63qrMAKS5+BmuM3dQasMNBtzpaUQfop3YtioyJHHHfsOHnXegrWB/fwyiICp1FJcyzVDsxUeu/muKxPKtJ0/yW0UjIZHrEcZGB/OMaNY8goeYbXeNb1GmJbFbfBf+Vnn8mIEO9Zt+d7xUSiS82sh2xhcn9FInbGWhlrvbzsHT3WhjfhnqAJAu7w X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/19/24 03:08, Andrew Morton wrote: > On Sat, 17 Feb 2024 01:31:33 -0600 Donet Tom wrote: > >> Avoid doing a per cpu read and use the local variable thisnid. IMHO >> this also makes the code more readable. >> >> ... >> >> --- a/mm/mempolicy.c >> +++ b/mm/mempolicy.c >> @@ -2526,7 +2526,7 @@ int mpol_misplaced(struct folio *folio, struct vm_area_struct *vma, >> if (node_isset(curnid, pol->nodes)) >> goto out; >> z = first_zones_zonelist( >> - node_zonelist(numa_node_id(), GFP_HIGHUSER), >> + node_zonelist(thisnid, GFP_HIGHUSER), >> gfp_zone(GFP_HIGHUSER), >> &pol->nodes); >> polnid = zone_to_nid(z->zone); > int thisnid = cpu_to_node(thiscpu); > > Is there any dofference between numa_node_id() and > cpu_to_node(raw_smp_processor_id())? And it it explicable that we're > using one here and not the other? Hi Andrew Both numa_node_id() and cpu_to_node(raw_smp_processor_id()) return the current execution node id, Since the current execution node is already fetched at the beginning (thisnid) we can reuse it instead of getting it again. Thanks Donet Tom >