From: Changwei Ge <ge.changwei@h3c.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Vitaly Mayatskih <v.mayatskih@gmail.com>
Cc: "mm-commits@vger.kernel.org" <mm-commits@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
"mhocko@suse.cz" <mhocko@suse.cz>,
"broonie@kernel.org" <broonie@kernel.org>,
"ocfs2-devel@oss.oracle.com" <ocfs2-devel@oss.oracle.com>,
piaojun <piaojun@huawei.com>, Joseph Qi <joseph.qi@huawei.com>,
Jiufei Xue <xuejiufei@huawei.com>, Mark Fasheh <mfasheh@suse.de>,
Joel Becker <jlbec@evilplan.org>,
Junxiao Bi <junxiao.bi@oracle.com>
Subject: Re: mmotm 2016-08-02-15-53 uploaded
Date: Wed, 11 Oct 2017 00:48:34 +0000 [thread overview]
Message-ID: <63ADC13FD55D6546B7DECE290D39E373CED68187@H3CMLB14-EX.srv.huawei-3com.com> (raw)
In-Reply-To: <20171010123749.2c59f3b762b3c0b33e80a67d@linux-foundation.org>
Hi Andrew and Vitaly,
I do agree that patch ee8f7fcbe638 ("ocfs2/dlm: continue to purge
recovery lockres when recovery master goes down", 2016-08-02) introduced
an issue. It makes DLM recovery can't pick up a new master for an
existed lock resource whose owner died seconds ago.
But this patch truly solves another issue.
So I think we can't just revert this patch but to give a fix to it.
Thanks,
Changwei
On 2017/10/11 3:38, Andrew Morton wrote:
> On Tue, 10 Oct 2017 14:06:41 -0400 Vitaly Mayatskih <v.mayatskih@gmail.com> wrote:
>
>> * ocfs2-dlm-continue-to-purge-recovery-lockres-when-recovery
>> -master-goes-down.patch
>>
>> This one completely broke two node cluster use case: when one node dies,
>> the other one either eventually crashes (~4.14-rc4) or locks up (pre-4.14).
>
> Are you sure?
>
> Are you able to confirm that reverting this patch (ee8f7fcbe638b07e8)
> and only this patch fixes up current mainline kernels?
>
> Are you able to supply more info on the crashes and lockups so that the
> ocfs2 developers can understand the failures?
>
> Thanks.
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-10-11 0:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 22:54 akpm
2017-10-10 18:06 ` Vitaly Mayatskih
2017-10-10 19:37 ` Andrew Morton
2017-10-11 0:48 ` Changwei Ge [this message]
2017-10-11 2:01 ` Vitaly Mayatskikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63ADC13FD55D6546B7DECE290D39E373CED68187@H3CMLB14-EX.srv.huawei-3com.com \
--to=ge.changwei@h3c.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@huawei.com \
--cc=junxiao.bi@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=mfasheh@suse.de \
--cc=mhocko@suse.cz \
--cc=mm-commits@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=piaojun@huawei.com \
--cc=sfr@canb.auug.org.au \
--cc=v.mayatskih@gmail.com \
--cc=xuejiufei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox