linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: sxwjean@me.com, 42.hyeyoo@gmail.com, cl@linux.com, linux-mm@kvack.org
Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
	roman.gushchin@linux.dev, corbet@lwn.net, keescook@chromium.org,
	arnd@arndb.de, akpm@linux-foundation.org,
	gregkh@linuxfoundation.org, quic_jjohnson@quicinc.com,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Xiongwei Song <xiongwei.song@windriver.com>
Subject: Re: [PATCH v4 2/4] mm/slub: unify all sl[au]b parameters with "slab_$param"
Date: Wed, 10 Jan 2024 16:03:25 +0100	[thread overview]
Message-ID: <639c0b0a-dfbc-4612-aeaf-460a68c9e6a0@suse.cz> (raw)
In-Reply-To: <20231215034150.108783-3-sxwjean@me.com>

On 12/15/23 04:41, sxwjean@me.com wrote:
> From: Xiongwei Song <xiongwei.song@windriver.com>
> 
> Since the SLAB allocator has been removed, so we can clean up the
> sl[au]b_$params. With only one slab allocator left, it's better to use the
> generic "slab" term instead of "slub" which is an implementation detail,
> which is pointed out by Vlastimil Babka. For more information please see
> [1]. Hence, we are going to use "slab_$param" as the primary prefix.
> 
> This patch is changing the following slab parameters
> - slub_max_order
> - slub_min_order
> - slub_min_objects
> - slub_debug
> to
> - slab_max_order
> - slab_min_order
> - slab_min_objects
> - slab_debug
> as the primary slab parameters for all references of them in docs and
> comments. But this patch won't change variables and functions inside
> slub as we will have wider slub/slab change.
> 
> Meanwhile, "slub_$params" can also be passed by command line, which is
> to keep backward compatibility. Also mark all "slub_$params" as legacy.
> 
> Remove the separate descriptions for slub_[no]merge, append legacy tip
> for them at the end of descriptions of slab_[no]merge.
> 
> [1] https://lore.kernel.org/linux-mm/7512b350-4317-21a0-fab3-4101bc4d8f7a@suse.cz/
> 
> Signed-off-by: Xiongwei Song <xiongwei.song@windriver.com>

Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Thanks.


  reply	other threads:[~2024-01-10 15:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-15  3:41 [PATCH v4 0/4] supplement of slab allocator removal sxwjean
2023-12-15  3:41 ` [PATCH v4 1/4] Documentation: kernel-parameters: remove noaliencache sxwjean
2023-12-15  3:41 ` [PATCH v4 2/4] mm/slub: unify all sl[au]b parameters with "slab_$param" sxwjean
2024-01-10 15:03   ` Vlastimil Babka [this message]
2023-12-15  3:41 ` [PATCH v4 3/4] mm/slub: replace slub_$params with slab_$params in slub.rst sxwjean
2024-01-10 15:06   ` Vlastimil Babka
2023-12-15  3:41 ` [PATCH v4 4/4] mm/slub: make the description of slab_min_objects helpful in doc sxwjean
2024-01-10 15:08   ` Vlastimil Babka
2024-01-10 15:12 ` [PATCH v4 0/4] supplement of slab allocator removal Vlastimil Babka
2024-01-11  1:32   ` Song, Xiongwei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=639c0b0a-dfbc-4612-aeaf-460a68c9e6a0@suse.cz \
    --to=vbabka@suse.cz \
    --cc=42.hyeyoo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=cl@linux.com \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=keescook@chromium.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=quic_jjohnson@quicinc.com \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=sxwjean@me.com \
    --cc=xiongwei.song@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox