From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55C0DE71094 for ; Thu, 21 Sep 2023 16:28:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D50296B0186; Thu, 21 Sep 2023 12:28:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D00A86B01B1; Thu, 21 Sep 2023 12:28:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC8B26B0207; Thu, 21 Sep 2023 12:28:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ADC226B0186 for ; Thu, 21 Sep 2023 12:28:35 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 892BC1A090D for ; Thu, 21 Sep 2023 16:28:35 +0000 (UTC) X-FDA: 81261137790.11.1DF6F83 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf01.hostedemail.com (Postfix) with ESMTP id CBFED40010 for ; Thu, 21 Sep 2023 16:28:33 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf01.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695313713; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ExlFo5Bt6+1yQY8ziWIXuqCEqRWbdwhybuE54J6pUFw=; b=NWaPvzY/dwfA48xnIAo5NBOOs6K4c3ty6HT00lEm0Zkd8Mq9bCANoFnKFKHXk+eW754MME veZYIY61Mlp97gcJ6IrNo2pTu8mIhe4Dl4kcJMzbtqg0Cofv01Z4IRyVUCYs12IuGbs8Gg F24GmpaKWQvSNdr2pxWvp0cepC7xerA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf01.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695313713; a=rsa-sha256; cv=none; b=aTEJrPHG0/iBlXtwZeqd44/lkhceK2Vw0D9egJYbk3MFHGQyWj9W6mw4M166/+bCVP3jep H3SfWLW8InttsbRePnLG7Vhf25MtIyEGpk0+LAyGRLHOfXX6D7OIONDs7brOpW44t5SCv2 KaBdQ9RyFrlO+H08lhM6N13QDX/IxiE= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 23993176B; Thu, 21 Sep 2023 09:29:10 -0700 (PDT) Received: from [10.1.34.154] (XHFQ2J9959.cambridge.arm.com [10.1.34.154]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3FD333F59C; Thu, 21 Sep 2023 09:28:29 -0700 (PDT) Message-ID: <637361bb-dd56-4085-a427-86fd76480de5@arm.com> Date: Thu, 21 Sep 2023 17:28:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 8/8] selftests/mm: add uffd unit test for UFFDIO_POISON Content-Language: en-GB To: Axel Rasmussen , Alexander Viro , Andrew Morton , Brian Geffon , Christian Brauner , David Hildenbrand , Gaosheng Cui , Huang Ying , Hugh Dickins , James Houghton , "Jan Alexander Steffens (heftig)" , Jiaqi Yan , Jonathan Corbet , Kefeng Wang , "Liam R. Howlett" , Miaohe Lin , Mike Kravetz , "Mike Rapoport (IBM)" , Muchun Song , Nadav Amit , Naoya Horiguchi , Peter Xu , Shuah Khan , Suleiman Souhlal , Suren Baghdasaryan , "T.J. Alumbaugh" , Yu Zhao , ZhangPeng Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20230707215540.2324998-1-axelrasmussen@google.com> <20230707215540.2324998-9-axelrasmussen@google.com> From: Ryan Roberts In-Reply-To: <20230707215540.2324998-9-axelrasmussen@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CBFED40010 X-Stat-Signature: exs7za54xyzy711qf4n9o8fwtyi9mcgp X-HE-Tag: 1695313713-334083 X-HE-Meta: U2FsdGVkX1/YWckvlnH/r9H3sto/hlntG0VTA0ikG+wquTARO0x5+/fvO1qOriLCveUWpAZFr3Sp+/pIoqw+BqPvR7Zpt2Of0LVO4QDQtHtFOJNLeLmPwxAwngg1gTqDRbIignAas2S7dayNPc0JADYd7g9YOxehy8teISlyNQusEfjKpS/FAOodC0IyYFeU2UzrHCzgBSNbZH24zDhE5Aa9xjsUO9sIZ+j4jXus+4EG6C1s1WFdD1pzcnVF4TtEtP6/jVOxvbEBhpM8TZ6EljRMTLituJrWcov/w+uYbxq3JQURkiCpNzCWNfpezawrT7n4HpqDj1agDhnhJ6kbaqeK8S+mrvFjL2duW0keGUBw1qOEUGlOD1/iIgFxdpexhqbVY0rnmpAuWpFpHnmKKMvk3BhMRgGnDlB9cOBrHJCIkS9LGhqIzW7WPYgaSpFzF4qzKBFb/OY0SF0bQ07W64pIDNvvPUThbDn3Q2UnVrzKTuZFhb2hflvmTXbBLBL+Cp0JXHbBDgxKY7ot+6tXyzs+Pdl7y5xZjBJTuksf6wc7tI7YuQDMNREgkrFCcb0QTucLzDJLsEp7rgaqABmjf8VQySh62IZuxX284UVmkZ5wRJOmgjGjQ3w6vkQ+QU88ntpxsuY6E8ClGwLJ5uMwmob8ySFz7Ii5w0dPqpagphFVkUoVvqruXZis+P03uKBYjSvJFB0YEv499hei4Rs9GdG/fvk2B4fvO63OrnvuE85hpFI++eObz7QXOAsCxU+Hp9HSVNSnHXXArm/kO2Q5nF6bIA225rW7+TOvHW03m6Jg4ZECVhTT8xhrEXoA9T/gN2YpqJhAujAxRKQFtD4g7Z3iFuAcdOCcdguBsns8Z9YxWJDiYjTNdnZY4VoKlX2ak4OhZMfNFf1XdZFedDOsxlC5CtB5a3zXR5xCzJaNEG/fb/JOrm1J1Y/TVKM0pkhtvUMQtsNwrP2AnbTAqck loF5q4iN VA7ghTDP5S1AyedM945tw1SrC0pluPHaDz8fCEmpMwFwEnSLN/4uDw6YzGon/Xxr+qaKhpKb0hg5p5mUb4q2jTQVqXZib018fuRrfJf0E0gH+lMdR5Ktf5ydlZpQ/85DIztfXXHyaC231edsT5F0Yf7ff3SrEVuCcbkP+wfJmN26YiMymDgdISOUW7QdS9D7tBGt9e52yRaPOVDvSe31VVZcjvGssVCcdMw/nnbyHwgb6fzqmEM92ZN/kL0Q1849CYbI1m5RKhtpI2vzmG1aAh6sXdN4DKc4d12CI0q8KTVmjekkFLWkhuVtGkMEXKLNdcuIEVc5zlLFo9sTVrcSimwl8CPlVLZRDWz/LIhOaknBAEww= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07/07/2023 22:55, Axel Rasmussen wrote: > The test is pretty basic, and exercises UFFDIO_POISON straightforwardly. > We register a region with userfaultfd, in missing fault mode. For each > fault, we either UFFDIO_COPY a zeroed page (odd pages) or UFFDIO_POISON > (even pages). We do this mix to test "something like a real use case", > where guest memory would be some mix of poisoned and non-poisoned pages. > > We read each page in the region, and assert that the odd pages are > zeroed as expected, and the even pages yield a SIGBUS as expected. > > Why UFFDIO_COPY instead of UFFDIO_ZEROPAGE? Because hugetlb doesn't > support UFFDIO_ZEROPAGE, and we don't want to have special case code. > > Acked-by: Peter Xu > Signed-off-by: Axel Rasmussen Hi, FYI, when running this test on arm64 it provokes a kernel panic. I've posted a fix along with a detailed explanation at [1]. [1] https://lore.kernel.org/linux-arm-kernel/20230921162007.1630149-1-ryan.roberts@arm.com/ Thanks, Ryan