From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92452C48BC3 for ; Wed, 14 Feb 2024 15:14:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F0416B0087; Wed, 14 Feb 2024 10:14:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 19F1C6B0088; Wed, 14 Feb 2024 10:14:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F324B6B008A; Wed, 14 Feb 2024 10:14:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DFC316B0087 for ; Wed, 14 Feb 2024 10:14:01 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BBB364047A for ; Wed, 14 Feb 2024 15:14:01 +0000 (UTC) X-FDA: 81790754682.28.DCA96ED Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf02.hostedemail.com (Postfix) with ESMTP id 83E1F8000B for ; Wed, 14 Feb 2024 15:13:59 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gU3rk2X2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=IhXF164r; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gU3rk2X2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=IhXF164r; spf=pass (imf02.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707923639; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tikF5ShYKbO2WOghBk9vtGAaaUgiPj3VsQTjyNrj1PE=; b=Axkc2N+d7xfdPY0NT1T+TdN3o1WDaZmb5ShXGDSrMGds9BUaKwpRKV6dNSodtaQrnntzVv LJkdHpntfg+p7tukQ3chXuDTPRAkRsrO8WJmAOw3II6OMpUSyPCtTpr9+TA2Nj0oH5KMbo IVmBbh4ZXmY6W+LrPWRRWQy+an+YfEc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gU3rk2X2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=IhXF164r; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gU3rk2X2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=IhXF164r; spf=pass (imf02.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707923639; a=rsa-sha256; cv=none; b=fXpEh/cLY0ACcKN8wdxRYB0RACZb5m1yn7/mX1VWmWr+b20o+B5AbqbcR7g+qzRheM4fyI 7tSptd2FLlz/fO+7Sym+Hq7NTsEyjbgTSxKsxJ6XRe3kGOREricO8T2jGbq55ITlQYCOvK NoOhcU11FneyP1AnNXxrb8h3EFI3egU= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5DB891F801; Wed, 14 Feb 2024 15:13:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1707923637; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tikF5ShYKbO2WOghBk9vtGAaaUgiPj3VsQTjyNrj1PE=; b=gU3rk2X2NEJX4Fh9fwdAFML7uiHJwPY6ADIvA28KKNY/2Z7m2rh+DZBQYUGyaSSqjBp0Nk j9kuonCsfIAslBIukjceFCBUO5tqnhYhJHks6m+XMV8pC11+/ehOtDt2i/K1HEEXk/7AwU Cka2ujVNvF+539lMChG2VJsssRfRCPQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1707923637; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tikF5ShYKbO2WOghBk9vtGAaaUgiPj3VsQTjyNrj1PE=; b=IhXF164rhLv5W/+NathAC18BJymcHAqy5xAL15E8/dUk8X8AocBsujmKILSINsYmD8QYgi +u8unfWWkL1AV6BA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1707923637; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tikF5ShYKbO2WOghBk9vtGAaaUgiPj3VsQTjyNrj1PE=; b=gU3rk2X2NEJX4Fh9fwdAFML7uiHJwPY6ADIvA28KKNY/2Z7m2rh+DZBQYUGyaSSqjBp0Nk j9kuonCsfIAslBIukjceFCBUO5tqnhYhJHks6m+XMV8pC11+/ehOtDt2i/K1HEEXk/7AwU Cka2ujVNvF+539lMChG2VJsssRfRCPQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1707923637; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tikF5ShYKbO2WOghBk9vtGAaaUgiPj3VsQTjyNrj1PE=; b=IhXF164rhLv5W/+NathAC18BJymcHAqy5xAL15E8/dUk8X8AocBsujmKILSINsYmD8QYgi +u8unfWWkL1AV6BA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 352AA13A6D; Wed, 14 Feb 2024 15:13:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id BizkC7TYzGVnIQAAD6G6ig (envelope-from ); Wed, 14 Feb 2024 15:13:56 +0000 Message-ID: <6370b20f-96fb-4918-bef0-7555563c9ce2@suse.cz> Date: Wed, 14 Feb 2024 16:13:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 23/35] mm/slub: Mark slab_free_freelist_hook() __always_inline Content-Language: en-US To: Kent Overstreet , Kees Cook Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-24-surenb@google.com> <202402121631.5954CFB@keescook> <3xhfgmrlktq55aggiy2beupy6hby33voxl65hqqxz55tivdbbi@j66oaehpauhz> From: Vlastimil Babka In-Reply-To: <3xhfgmrlktq55aggiy2beupy6hby33voxl65hqqxz55tivdbbi@j66oaehpauhz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 83E1F8000B X-Rspam-User: X-Stat-Signature: qhq84xuxepoupiihx5ij6xbn5t1bjjux X-Rspamd-Server: rspam01 X-HE-Tag: 1707923639-570704 X-HE-Meta: U2FsdGVkX1+qz74MCCBy0jsGGE3BrXPyxt/8dH4tusYD2LCRIWABCb+j/xSBj7vPtX+hF4rxIxWEh28q4KrgC7UGXISnugrUzEkTfz/pLpVXn7P8eQvFtFuv3ihsEZYtSz1pQD/z8S5H0ptcOiLxPXTDTtwCEgzI6srye88JbWKBPoYnCE945ofRX1CY1XON7EgvTZBv+55LVl3lo1bGIQoZso5TuCr1zthSQcP0I9RkFXml0DJ5dn7ooAIThqs4tW9yZDPCtYyluUcn0g4c1NUoOiLIPvbswXhYOchZm0cSyVdpT4OJlBQkY0GAi8J/1+MIfIu34fhEh5CcH+GkSGprcZzQdqnHLoCZgpEsxtHFuNx2hdCU2LSdKRX8OLWst7hQT+4M7A0Sl+hIlyYhws1Ce7Tt7poBSp4PmqLi8CIf5qI0zXnUl3YS7i7r7U8HclxJP6Wy9SD+ZHcdvYetpQcxhIt4cc8x+ry32/XQdDNicuxmbCTfEpdPiJe1H+sCpsEKbQ6kamSyRnd8dkjL0xSFRuM1LcT3xyWtB43OCbDSCf9HwooSBXUM7n6D4mitoaDvlGfIdZj/owiLbCG7R/+wP+tJkBAg9ST/r8LVhgnbl+liwb9sX6SHY7SsBQ5HytDzNQWTpG+Q5EyISB4TpOYpHqtq0dj8WTAdClgAf/REIcYKQKzz4nrA6xUvusV0DHuuM0BqCd3YDYd2orR9+bOqcR6QYt0OBqSNWz1v9oIb8x//IiTlSEfA5B8ptd2GTko8RNVrhS/m6NL+CkH8A8KXShQPOW9dxHN+mWXw8fg0P6SScrIUAb7LG60bKUZRkH9LqjUjMHyT5JYiPBBAxOu0nM9jrVoYfK13EJhpcJDCFEiOj9QiNLrJKD515AYVSAiH4OZy2Xv4QLqDjVVyknNDljRW04sd97sFXuZs5u4O6fCnlpcO2CG7gJf6fJG3ScDxRfzvcXq9wNSl2cH VgQyRoDx 1ue+BjUNUx1rScC0e2yajuc6QbbduEN6DZk62eVvp0Mrnbw6RMTbOAGet4yB1vAiiv2rt0AcBWMrTwCs2HmQspahzjg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/13/24 03:08, Kent Overstreet wrote: > On Mon, Feb 12, 2024 at 04:31:14PM -0800, Kees Cook wrote: >> On Mon, Feb 12, 2024 at 01:39:09PM -0800, Suren Baghdasaryan wrote: >> > From: Kent Overstreet >> > >> > It seems we need to be more forceful with the compiler on this one. >> >> Sure, but why? > > Wasn't getting inlined without it, and that's one we do want inlined - > it's only called in one place. It would be better to mention this in the changelog so it's clear this is for performance and not e.g. needed for the code tagging to work as expected.