From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7A4AC4167B for ; Mon, 4 Dec 2023 12:44:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70AB96B02C6; Mon, 4 Dec 2023 07:44:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BA246B02C8; Mon, 4 Dec 2023 07:44:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55AF56B02C9; Mon, 4 Dec 2023 07:44:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 47D196B02C6 for ; Mon, 4 Dec 2023 07:44:02 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 265F91C045C for ; Mon, 4 Dec 2023 12:44:02 +0000 (UTC) X-FDA: 81529103124.05.28D1302 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id DB29D12000A for ; Mon, 4 Dec 2023 12:43:59 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hPRJye9q; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701693840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5JxMYP8OfSesQLX1q9G3uaPEX2MmHHO3AMt7LXXXPw8=; b=ddcYxOQQ6Hed10mHfjVVG6DHkyTlMxikujzuGoWk1B4WcH1qHXh8Dge5gOoB/gRuunsqLj S0QgAm7exEKt4CwqTifAZH5klMCuUkx1LPK5OsDzZPVFpD+PNBFRz+eEMkZ3NCwSngpzH6 o785WLy8fnGHkVTAWhB5G7RZDJOV4+A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701693840; a=rsa-sha256; cv=none; b=aPuN/lDCTyCDFa+q2Ii1g6zZlwHGnVAGKpmbXf9RDrvggnUrKG1co7eyuqzLgFL6sGyh82 hx8xPFWtpROJn6BtHt1GzqWeFh9mF4SuEmorI4pPnvHsQVX/QuaSsy9FNlzcQhVZF5y8SC rLiEfackTMNqIAk8k8NeTUSRYGFVDEk= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hPRJye9q; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701693839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5JxMYP8OfSesQLX1q9G3uaPEX2MmHHO3AMt7LXXXPw8=; b=hPRJye9qrJZDmNrZVZ7Ua/7GP/HbhNUouSMVvUTtbZEDvgLpCsAhy/1REx+6rZ/VigKpAG l0YReJ3cvPEbuzcSFgs4bP0TA+X6vH/SU9F2E8g98k1Rkm/0G7lFNwQ2/xV8YGNLLGp8wo Awytf6FH3L8emK7NFZeksonU47wUMSA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-520-JBtUROdoPMyDSNEzYcjTTg-1; Mon, 04 Dec 2023 07:43:58 -0500 X-MC-Unique: JBtUROdoPMyDSNEzYcjTTg-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-33349915da5so906103f8f.3 for ; Mon, 04 Dec 2023 04:43:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701693836; x=1702298636; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5JxMYP8OfSesQLX1q9G3uaPEX2MmHHO3AMt7LXXXPw8=; b=ULN0DSDcnFM+xcowr9atgm4UuGAMR2DHqCixN70bhPyZO9I73JhWbIdTCqbS7V0Qzv vJrLNMUiH7wkPLbd5vH5yM87diC9DC6uuIfW+vcwsmlbWF/p+mxfJjywD4TxbKG2X+l5 +y3PtQovhARrkk5XgZLMgSyuLw5LaJw/i6C26pL4mBvMBbnuNka00YWFYrKQMi3+t5wK DgLkfy/EP9gYybywxzZ+I6dnUwGaaZKcBbxr30Lkoh0BLqqlm1YsjbxVPBpYt2IvpPSl BnO4OAmuC4uurvNbE9PaLzXR8YP1x6srzy29zEePS0Ya5UQ5f7fZhtRLqNzm2SxSl45d KzUQ== X-Gm-Message-State: AOJu0YxR03pItkfCz729Jk2uIjh4WuU8sVx0Z/erhCP2w8tTr7yWH//T FdOxNnC7b+r92b71zUtaeNud7HkFptWmOM4wjpEgZaFcD3Jp7CtEAu4joGIbrYEcc7HetUXE0BW eR+E4/U/XLho= X-Received: by 2002:adf:f802:0:b0:333:3db2:c3e1 with SMTP id s2-20020adff802000000b003333db2c3e1mr1686050wrp.111.1701693836677; Mon, 04 Dec 2023 04:43:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IF8bQGn0Ci/jT8fvChhmMRFkq2R14onpDlkODa7S2MKJpWX2RD36i4HlpUxaXE7Yj94jnoVEQ== X-Received: by 2002:adf:f802:0:b0:333:3db2:c3e1 with SMTP id s2-20020adff802000000b003333db2c3e1mr1686032wrp.111.1701693836317; Mon, 04 Dec 2023 04:43:56 -0800 (PST) Received: from ?IPV6:2003:cb:c722:3700:6501:8925:6f9:fcdc? (p200300cbc72237006501892506f9fcdc.dip0.t-ipconnect.de. [2003:cb:c722:3700:6501:8925:6f9:fcdc]) by smtp.gmail.com with ESMTPSA id a4-20020a056000050400b003334675634bsm3683249wrf.29.2023.12.04.04.43.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Dec 2023 04:43:55 -0800 (PST) Message-ID: <635de797-1219-40b0-b4b2-7eba758749a5@redhat.com> Date: Mon, 4 Dec 2023 13:43:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 4/4] mm/mmu_gather: Store and process pages in contig ranges To: Ryan Roberts , Zi Yan , Matthew Wilcox Cc: Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Christian Borntraeger , Sven Schnelle , Arnd Bergmann , Yu Zhao , "Kirill A. Shutemov" , Yin Fengwei , Yang Shi , "Huang, Ying" , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230810103332.3062143-1-ryan.roberts@arm.com> <20230810103332.3062143-5-ryan.roberts@arm.com> <800937DA-BAD0-4C60-B155-AECCA21E955E@nvidia.com> <1a0f5cb8-421c-4f28-a986-f3c381406e81@arm.com> <90EC4C0D-0254-4B93-AFD5-3C09580A77DE@nvidia.com> <6dd6164a-1dd5-46e7-bcf7-b62ff5c6e8ec@arm.com> <890f4455-bf1b-437b-a355-7895e4dd3085@redhat.com> <52b042b9-ec95-4db0-b38a-f7f1cea0b90c@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <52b042b9-ec95-4db0-b38a-f7f1cea0b90c@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DB29D12000A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: owerk7y1bu9bnrzxguscmnixggkyowaq X-HE-Tag: 1701693839-775047 X-HE-Meta: U2FsdGVkX18vxrWT+A364KnViRa8E/KDahL0w2839/LGDrbn912fRF7LtGpuIlkSecxS/fIkCCEZMhqEUxSv8Qg/cRR0DOR/j7ChQG/0qj1MNv9JoklHfVruzyShtjYCSe+q2qdYJAGO6VisXrbGDzdPXg7sM7CvnPAYRYZPeo+rOJo9mYjGgoMakwI5jIVEWK9GbAtz+/pOzPPG0UnWMNZzkixrWgXgqAuM+BBDJRKIYD1bOFdEX+5iR4i+mG1vv+hd0q3nKqX2VFH9z3Bo1sXJJvk/c4JNEqTEPmla9n3IOpy843L6+Iwx9OKJDTXrvsspTb1GIEk6oaQeFPdje+MAEXoYTzkkxga9sqf0++ARUjBidJR/akFRpEsWuWjWIogijWryQ1HK2DxEIQOhS3oC3ZdHhfCosVM/NDrFu8M579oDBaD/45OyEtkRHRunRV3tBr9w56tqvFo4FTqfYfXcZgEVWKstqHsn5yo2ZP+6rlv8id4kjGbLxT6eJNtBEGKYXwTlOfMddHLtNcSeUELq2SfVK3c2CDsXCvNCVER8tr5yZiYvm91eSCHhvnJRRT+6f9IfmMv9KE0U0R/DqSfKPPO7gKk3Rg6AfvkZgkMPTqVgFtttv2nQTHC4p/6VCewTgouPKH9RYbxJlJe318GsjDP2KLaHegewN/sygWbJrXD0+WTuiM7kb1gjXl3xyXs0zgnnhAuyyoIUCvRRo68k9AGz1/Ae4A5xi0LY7PmAad+WXCjGNTlps56nfEGdfxEqS8GfmBUwnSDuLy83gvGri/YbJEH43/hvxTKcqCUyD8ZaSTNHZ00TzHUn6/ZgEHoEIu5Pif0HXFpu+PSH2PIzi3L+IQyBD2Tz14/la0KFhynSb43Kcg8eX1OVeRBPcETFD6Zu9UKVPSCrJ5EBylKN2JIPVXUPxTOZUPEQd/82ddppYL6PwwmuZyHVvUV3RtVZHJF455EGDlEf2tB cuRnf7QV EoFMppEeDfuKYCNEq5BbXjrsjEt/NGLMZKK/NuHqjH2VsaPhNRAZzagGi1hZd2rZYKT/tm3PGN/kbolQ7rVnxqBjJvR/7umj2AqzSjfg59pTlhCx0JvcgYsidqd91ja7vLfTIcHC/WNl7/6i0GuqEMCO1lF63tQsFT9opyiB3uAxujyWATHEAkeCKGK0szJa9ptAiEgl1fO/Z62KaNfcRQOynQBSCqcMhzZBMVZ6rpmAx8pePRKARuGo6rR63oRF+rraLtaob5fKEfNiG0s2GwP9DlPc5nvmicW2P3lJrTD440cmByx4Jqx40RgeWM1x42A19wj1OReRoxtfleN4VCt02k5Feifp/UlzttMOLjEnuQ3UEtCSREUhkuqD1/y5HTezLks7rkbsk2+zuPChb77Eq4t323GgkCv8lLPreLhMACdWFvNhYFTn+XJ+5+qRond+QG3fPllMj/XCgJrBfxM/gKw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.12.23 13:39, Ryan Roberts wrote: > On 04/12/2023 12:28, David Hildenbrand wrote: >> On 04.12.23 13:26, Ryan Roberts wrote: >>>>>> >>>>>> Also, struct page (memmap) might not be always contiguous, using struct page >>>>>> points to represent folio range might not give the result you want. >>>>>> See nth_page() and folio_page_idx() in include/linux/mm.h. >>>>> >>>>> Is that true for pages within the same folio too? Or are all pages in a folio >>>>> guarranteed contiguous? Perhaps I'm better off using pfn? >>>> >>>> folio_page_idx() says not all pages in a folio is guaranteed to be contiguous. >>>> PFN might be a better choice. >>> >>> Hi Zi, Matthew, >>> >>> Zi made this comment a couple of months back that it is incorrect to assume that >>> `struct page`s within a folio are (virtually) contiguous. I'm not sure if that's >>> really the case though? I see other sites in the source that do page++ when >>> iterating over a folio. e.g. smaps_account(), splice_folio_into_pipe(), >>> __collapse_huge_page_copy(), etc. >>> >>> Any chance someone could explain the rules? >> >> With the vmemmap, they are contiguous. Without a vmemmap, but with sparsemem, we >> might end up allocating one memmap chunk per memory section (e.g., 128 MiB). >> >> So, for example, a 1 GiB hugetlb page could cross multiple 128 MiB sections, and >> therefore, the memmap might not be virtually consecutive. > > OK, is a "memory section" always 128M or is it variable? If fixed, does that > mean that it's impossible for a THP to cross section boundaries? (because a THP > is always smaller than a section?) Section size is variable (see SECTION_SIZE_BITS), but IIRC, buddy allocations will never cross them. > > Trying to figure out why my original usage in this series was wrong, but > presumably the other places that I mentioned are safe. If only dealing with buddy allocations, *currently* it might always fall into a single memory section. -- Cheers, David / dhildenb