From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19932C38A2D for ; Mon, 24 Oct 2022 20:36:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C7F1940008; Mon, 24 Oct 2022 16:36:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97711940007; Mon, 24 Oct 2022 16:36:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F136940008; Mon, 24 Oct 2022 16:36:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6F03C940007 for ; Mon, 24 Oct 2022 16:36:05 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4BC351A0CF5 for ; Mon, 24 Oct 2022 20:36:05 +0000 (UTC) X-FDA: 80056999890.13.770FFA3 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf26.hostedemail.com (Postfix) with ESMTP id 50460140036 for ; Mon, 24 Oct 2022 20:36:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666643764; x=1698179764; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=skOZWB6id/22e1zurCE3AQG6nbV5pyvT6nRDINsuXTI=; b=AJw+DC2Cw6vupTZkDcjDk/MwYrGyKwDb/46LY0zFxB8I8SEAUJiw74bU 5hFjxmtGoTyDJglScnkCNWoGuB9ccVMYUdQ6wZourO9RhLJPCnMm8czSb AXnjeBHI/5rso35Z+9rV9Qu2wpS9h2RZB61GfYK2F95AnDlFqbuhve0ox o/i79Wjb2qllD/E0yBH/qHjQ6kqNiPnt4R4clLotHfANyp+GvTssamjcq wgNET8q9LvBSHpv5J/uND7emmDbQPr1LHeGnMH8Hi36gQo0s36X1Z32LN EWjSWWcGPn14tWbwHI6hjM4balvFfHr595/iKPhZoeMCy2v/FFlGrFfYW w==; X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="371732832" X-IronPort-AV: E=Sophos;i="5.95,210,1661842800"; d="scan'208";a="371732832" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 13:36:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="633837811" X-IronPort-AV: E=Sophos;i="5.95,210,1661842800"; d="scan'208";a="633837811" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 24 Oct 2022 13:36:01 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct 2022 13:36:01 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct 2022 13:36:01 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 24 Oct 2022 13:36:01 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 24 Oct 2022 13:36:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NtcBAbMCwY7iNpBpcgisOP6R6MXZImbd5yERV6SiLmNSRDz5dfKDk46bCkgzg0XU6uA+GUJ0LMNMZndut1viCcc6o+hR3xmlLpxQETfJa3f7O89jJQH06QihPb8SA4HKbZPNS6t7WOvTRDUdOxL1JnwIZbaunqMC3YCi9ynGBCBC96D3AMt9bAqWaFc82nRiys35DvO7jC59d16c9APcisKsywckKAKzycfMfOgghD7FcaPm25LwejAPx1/ziwFvQtE91H11pG0CX6JZW+8lQ5JZ7FzgoyO2Mn1VFO3a5XoI6GMDReh0oQUhYv2EV0LBC6bH5EXrQ9YHQZNHT30Lfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HOuVhPKGD6u67jMApf4nfC3oWOWDfK7XnkGTak8qOIw=; b=Xgl/xMrmKJBmOXh3vZTK+WSDEgMqre4hTFmgBwv9O1FQdtawiPCajtraswXR3QJzW5GFLIJGEtS44g30lcYJsiMP+B3r1HKdhmtTyoszF5XGR4zsCzXkyuzhRaAs40yCUNNk/7E9v7byggNigiVwtQTWkahLqkanA4V+KDJRqNM/wl8e98mQtN64PEPDu4rrHU7JSzwNVtzxthoxjgD7avXNG1KsGOYdqHbGnS1b8Z6b9nFGgT9JQXO/jfddHooAzui1/JG39zMo7Lhwf803ZlLk0DjBVCxuRFKoKfaEpeOuHy8ZSIDq7WDcT1sZgB523yqutZh4CMO0dn1GajzjaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR1101MB2126.namprd11.prod.outlook.com (2603:10b6:301:50::20) by PH7PR11MB6748.namprd11.prod.outlook.com (2603:10b6:510:1b6::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Mon, 24 Oct 2022 20:35:59 +0000 Received: from MWHPR1101MB2126.namprd11.prod.outlook.com ([fe80::7d5a:684d:99f7:4e83]) by MWHPR1101MB2126.namprd11.prod.outlook.com ([fe80::7d5a:684d:99f7:4e83%12]) with mapi id 15.20.5746.023; Mon, 24 Oct 2022 20:35:59 +0000 Date: Mon, 24 Oct 2022 13:35:56 -0700 From: Dan Williams To: Linus Torvalds , Dan Williams CC: Matthew Wilcox , Brian Foster , Linux-MM , linux-fsdevel , linux-xfs , Hugh Dickins , , Subject: Re: writeback completion soft lockup BUG in folio_wake_bit() Message-ID: <6356f72ca12e0_4da32941c@dwillia2-xfh.jf.intel.com.notmuch> References: <6350a5f07bae2_6be12944c@dwillia2-xfh.jf.intel.com.notmuch> <6356f1f74678c_141929415@dwillia2-mobl3.amr.corp.intel.com.notmuch> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BY3PR04CA0019.namprd04.prod.outlook.com (2603:10b6:a03:217::24) To MWHPR1101MB2126.namprd11.prod.outlook.com (2603:10b6:301:50::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1101MB2126:EE_|PH7PR11MB6748:EE_ X-MS-Office365-Filtering-Correlation-Id: 4795ceee-c8e0-426f-3345-08dab5ff5bd6 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H9ai+QtAHhXOkIZnFiwWd5fko49GrQMb7H4s1//rbhy9BZHoQBcY2zoWSdhgf8g/RID2BmMQbhK0YnA1tdVklF7GV8v4q96AAuy6E4oBIk4oqtt2wRZbIFnkc3usH28uBMz++KvajFv5VoJyTgsftrSU28nM4JymxOLjKBjIYBgAR9VhhVqhK/ebEKAbY1LvxrFLQvRKJzhbe/qBf3oEpUfATF39VXuZnzo5yQZrPYg0JYsZRqt21VTuyg/eASrhfw+atFsq9I/Fx1WQd51YESlMv2KI3PVC462PtmcsfFUC2L/Yb2+GlcTG9Xd+EYnmPr4k4WZnJjKmdoDYkQS1UCMvuIOxRGhuORvHix0PrZeKlfdtmC9wZq2S9gQVT5MgHk2tEOkGqtZMfTbR0Ys8uy9iyDoga5kv0Qvou48vlljlympETbcnQGBfT6vbHHogirBygNe7HK4PNfNdNO5uwpXT4bXOr9mv/JNjlILelHs/0+pFJKZGgpQYvNwPjur7A8ENnNu/Ujb3MK90/Tgtw5CcBBD49je9G5xzDP+YX8qDHJqHkKqG/jSdD9lJuyWCFQ7LWGeVnTJ/VLHeedHcn9s8ZpLPVB1Y/txegrqzgjV9D89iQqGbkz1c2lRlyUKS8bto96okf22tN/XcD+vE7tYyOHA9yk3Cqcsnq0WCGP7h2zJ6c+5gGB0wGabn/XO/NJ4A0OwV0zdF+96fOkjN+A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2126.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(346002)(366004)(376002)(39860400002)(451199015)(186003)(5660300002)(83380400001)(6486002)(86362001)(38100700002)(41300700001)(82960400001)(2906002)(54906003)(8936002)(26005)(9686003)(6512007)(6506007)(6666004)(8676002)(66556008)(66946007)(110136005)(478600001)(4326008)(316002)(53546011)(66476007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6BwjGZIj0WgeEtB7ZWGe/PUFolaE3ZRVsOIILZjl3HSNJkkUcyM09O48jE0e?= =?us-ascii?Q?tTZJyQHuhurdP/0L4CiqU5nR3Kwu8rebFXNedCeTSGOxnzwopOsheWDyuXeg?= =?us-ascii?Q?Ety1/fQdimLLOD79y0FgSckgrgRQKjrOw82q9lgMZe65CYo1x+HTC+1utYGL?= =?us-ascii?Q?5DhzAXGHlGU1GM4Ka1KZKF0IJRhHrw2xUQuLjwOYnrE7C3yA9WRKPtdFEP8H?= =?us-ascii?Q?x1um3CpweHwBKivqIJWaD9PbjDMINpcijKPQLR9rMJ2K7egIHmFmIXGf6TGQ?= =?us-ascii?Q?M2qe4OGq827AU3xFTQdhUcHW3wLkW+hV2SVHadmzjeJzShMrY7Jmc/ntxGJS?= =?us-ascii?Q?7nZ2Djc/FTjem5TFVuLrBwSMsz81TBj245g5B5qOf3DqcTWrWRReo+b4KLS1?= =?us-ascii?Q?0Ftzs4p4zeuNGwhRML5R8WE/Fx4J+BKGgE5pHgTuNAb4SAwKSjz20w7z2L86?= =?us-ascii?Q?HzXGJjb4OEkcvQSsW8KCV3/9RrI+0yB2jlsWQ994roafKB+VdndTTU1ZByMG?= =?us-ascii?Q?q5gsRi6wsS+k4YsgQ65K1iXFcrSQDANpUH9Ymm8qYdRLGSSFnaGS251oc2V8?= =?us-ascii?Q?kC032CyFO9pNI5Q0ruDGxCOpU/Vyf1RrmAeHBQB3rjFndR/KtNrauJTGfF9C?= =?us-ascii?Q?K/swwPYmUw7EkaUclGhj+2LuzON9aY8T0GBo+iBzNStIZ+a4OGnLq4VnAAnb?= =?us-ascii?Q?mHhyEODHsaVU9iUnEzNBN5iks9/8wkCr30+w8jxMio3Vzkls3Ja6vvUQxy5Y?= =?us-ascii?Q?CntSVsvGEYy7QOJ482Uamx4JGAONKcu0XF/fcmrg3zB93fIA/ZtPsRwFxm6F?= =?us-ascii?Q?N8KIBtHNZtbk0TIVfXq6zvAR63Y26K7ak/PA77LMW6ycCxjLF4cOKN2aQAlh?= =?us-ascii?Q?GkDISueGHujJT9DP2OZB05WvqWyUJILWOVvvfm0ml1nXzT8B2xRWv7XwOb0I?= =?us-ascii?Q?uPLG1wnmDlLm7ywau+yzaFcqxO9R42KT4+V8dcj2HUmf0HlHqv7pgG/Exmdo?= =?us-ascii?Q?BfkD1yeXGOMU6FRmnLtT7texB5cjOChQQuyJ4HUSSbLZ5BP8vkMqtz3PpQJq?= =?us-ascii?Q?T2wplu71rnFqUOAVUfbIgeFVC4r4S3EEuNJwd24QhOS32ca5kF6P1q4s2n+y?= =?us-ascii?Q?2/Z7BTAKXS+tufjoJ+vm4Z8QpPD7Pjdee7Owhu4wwbLriffVNZPac+q6kIvx?= =?us-ascii?Q?2I91BFrSN9Aw5TpsK1vEck7i+/ZEHH9EUGLUhAC8PAad2msCy8K5aB48VCrV?= =?us-ascii?Q?NZysPwcqMKBWjy0RS4lskhhk4L4RiEux2s5dEzatB/BCh8dm+PRSa6fzDKKQ?= =?us-ascii?Q?h5Kb5NOd5kxmAftGCyKemrMiRR8MKnzrErnYFCNkheBPXfYo0EZqme9nzOp/?= =?us-ascii?Q?H31FHnjX+RKK/QeSVbO7FySzOXJEln5atLxaAACk07gXjWLnK9JOlp9l1rv8?= =?us-ascii?Q?XuoEQHd21qX6yFSQaXmz1SsAeC/08Q6utERndYpw2SxkLtEoOcTqDYpLeGNx?= =?us-ascii?Q?sh2hFQBOMOnfiZmdai66mSmqda+B7lUSvtI+DWfEK+OfZIj4jXF8arr079L3?= =?us-ascii?Q?iznWi7n2gTB6AXwrjj79StFJ2WlOZ7Hd5wtpGywtHnqT4HLZliEB7qINHfDW?= =?us-ascii?Q?0w=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4795ceee-c8e0-426f-3345-08dab5ff5bd6 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 20:35:58.9805 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vyK8VwYuqRGH3Pt2TmXY8fV4XTxMv+PoB8zJcxmRhmOb11iyeI8b2cJfPkrZa0OYBBC8st43CEvaGfxxGM9ORLlnYVlbgwdKEWLLrA9LZ7Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6748 X-OriginatorOrg: intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1666643765; a=rsa-sha256; cv=fail; b=WJPHPIA70GHqhxHe1beVTLD5+Ar3A3lEaxpXhgqy2szROJjcwUWq5fIQWftT4QnGhP/EWM lK7EuErAOFX/2mq5DIWBGESkoOvYUs1FlaOG8Bm+6I6ZpSYUfTw4ssVbeDIFgYpt85KklG EgdjDGUs8coMMshmbLe40l+AeBj+NlY= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=AJw+DC2C; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf26.hostedemail.com: domain of dan.j.williams@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666643764; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HOuVhPKGD6u67jMApf4nfC3oWOWDfK7XnkGTak8qOIw=; b=oL11JNiwU5ZEzz5q8GnC0mSdWlbae9n1/vhnyHw0X75w9CEKO+Mn+2AuywxhchN3gm47s/ t7V7w/iUiMtXpnA6Fg4j+bMY0DfgrG2Q/Wm/rf0GAAYz31qnGDfnbOEARl4WJ9bjCeu2sm TlNAiLBiD8huLPpsyWrc+HPq/CCYbSY= X-Stat-Signature: eimjmr1fdzmuo7xaeneqq8at59wx8s9w X-Rspamd-Queue-Id: 50460140036 Authentication-Results: imf26.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=AJw+DC2C; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf26.hostedemail.com: domain of dan.j.williams@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1666643764-866646 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Linus Torvalds wrote: > On Mon, Oct 24, 2022 at 1:13 PM Dan Williams wrote: > > > > Arechiga reports that his test case that failed "fast" before now ran > > for 28 hours without a soft lockup report with the proposed patches > > applied. So, I would consider those: > > > > Tested-by: Jesus Arechiga Lopez > > Ok, great. > > I really like that patch myself (and obviously liked it back when it > was originally proposed), but I think it was always held back by the > fact that we didn't really have any hard data for it. > > It does sound like we now very much have hard data for "the page > waitlist complexity is now a bigger problem than the historical > problem it tried to solve". > > So I'll happily apply it. The only question is whether it's a "let's > do this for 6.2", or if it's something that we'd want to back-port > anyway, and might as well apply sooner rather than later as a fix. > > I think that in turn then depends on just how artificial the test case > was. If the test case was triggered by somebody seeing problems in > real life loads, that would make the urgency a lot higher. But if it > was purely a synthetic test case with no accompanying "this is what > made us look at this" problem, it might be a 6.2 thing. > > Arechiga? I will let Arechiga reply as well, but my sense is that this is more in the latter camp of not urgent because the test case is trying to generate platform stress (success!), not necessarily trying to get real work done.