From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05231ECAAA1 for ; Mon, 24 Oct 2022 16:37:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3EF49940008; Mon, 24 Oct 2022 12:37:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 39F2D940007; Mon, 24 Oct 2022 12:37:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 219F2940008; Mon, 24 Oct 2022 12:37:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 14050940007 for ; Mon, 24 Oct 2022 12:37:36 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DA0D2A09C1 for ; Mon, 24 Oct 2022 16:37:35 +0000 (UTC) X-FDA: 80056398870.26.DD97E3E Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf22.hostedemail.com (Postfix) with ESMTP id 28135C000A for ; Mon, 24 Oct 2022 16:37:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666629455; x=1698165455; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=wP7GcARxnBDRGVQtKaGTP/lRpE9CMir6AoJ6BmEdSMU=; b=SsVOseT/RGyteWHGjSuWpi6ag+IL09PaCVxvFSIo5xvJX4vCHW6Cr0O1 mg0Widfgf2EdInCEqFRp9W1DTtwgDTeAMItvLpLMdZDFzW5ICKHsNLTA8 I2jEi9QBX1vcYseZvmblr06kxXcsG4JYYU7zCP9Zx9QmpblJ+yJNeGYUm LaDVHC+M0BVx8Z42xX89EidDm82Re5ql9AFxCy0DcPj+kqCl6nfx1WOQ8 eAHoZ81iZumr0EfXe18/hYU/QDMyxx9tHKu8vgJTc4RjjQRu1lgN6ibQF JFnsZOotTmApb4oXlsHJFOn0dCoGXzbyHh8QF/buZOKmvOw1BBKeNOlUL A==; X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="308559666" X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; d="scan'208";a="308559666" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 09:37:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="609257578" X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; d="scan'208";a="609257578" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga006.jf.intel.com with ESMTP; 24 Oct 2022 09:37:32 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct 2022 09:37:32 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct 2022 09:37:31 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 24 Oct 2022 09:37:31 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 24 Oct 2022 09:37:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i7FX4Dcys7KpARIYeWgyTQ3TzEZx5iP3Z/6yAc9vd22xEoYBYTxLhGwAfBmYO8vMTC3k2C8v6CFaf0d/1Is1EJvbZ1eS6YxhCjZGuiGlH+IPNQetfnxgNb/YGzEUNfJn+9sgrue0mK6bsjnN/YzR9sfpePAICp2KlJCf+H1sf9q6BEHuPrJRMG2qDzEFFA6Wk2OJA40q9TIwjvVFwS/3/NdyOBqTchOlGX/sZMr8uMKgtQhUuYgVwUB9vFjHG08BOmkojf4/NQx9hh3Ba+EBx76bp+EbAC0IG1qwr9vytXua77tch6AoZcUNEXiia5c1mVTOyYkQzUxemsz3vB3vbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K9IfnsDeFwVQ1W1jxqWlUVBS49FENYsoTk2vabXknpU=; b=ZOu26kWe1vDtw4SlNbsttoHt2lIun0ywDQklibf4IjwyKuNoao1Ye7FYvMFFNsi4ARxcIOGDcBpgxnRxa5uFo3qlvlMmC9zvm5DuI4LtgPQybvFcm4VFZ6byy4cS4Va1XBuxAba6Ics8oMNvM8macorqyXnIhB5Hc+J1tVTy6SBba/lL2Zv9FkGqPkFWJVWPZe0xCXgyfF9gp19DNpU89Mk+HQTnFL1Gwc1XBeBObgi2TfjrDRlCgiZH58htWMor0m1/9RR/WBV08188gekW/i4Qj/P+jGEq6ykfKz2+I0WTiGtosg5KKBiIFDONR1Kpi1dV3eHxKzxY5EeE3fCLfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR1101MB2126.namprd11.prod.outlook.com (2603:10b6:301:50::20) by SA2PR11MB4809.namprd11.prod.outlook.com (2603:10b6:806:112::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Mon, 24 Oct 2022 16:37:30 +0000 Received: from MWHPR1101MB2126.namprd11.prod.outlook.com ([fe80::7d5a:684d:99f7:4e83]) by MWHPR1101MB2126.namprd11.prod.outlook.com ([fe80::7d5a:684d:99f7:4e83%12]) with mapi id 15.20.5746.023; Mon, 24 Oct 2022 16:37:30 +0000 Date: Mon, 24 Oct 2022 09:37:25 -0700 From: Dan Williams To: Logan Gunthorpe , , , , , CC: Christoph Hellwig , Greg Kroah-Hartman , Dan Williams , "Jason Gunthorpe" , Christian =?iso-8859-1?Q?K=F6nig?= , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Minturn Dave B , "Jason Ekstrand" , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy , "Martin Oliveira" , Chaitanya Kulkarni , Ralph Campbell , "Stephen Bates" , Logan Gunthorpe Subject: RE: [PATCH v11 1/9] mm: allow multiple error returns in try_grab_page() Message-ID: <6356bf459ba_1d21294c1@dwillia2-mobl3.amr.corp.intel.com.notmuch> References: <20221021174116.7200-1-logang@deltatee.com> <20221021174116.7200-2-logang@deltatee.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20221021174116.7200-2-logang@deltatee.com> X-ClientProxiedBy: BYAPR01CA0040.prod.exchangelabs.com (2603:10b6:a03:94::17) To MWHPR1101MB2126.namprd11.prod.outlook.com (2603:10b6:301:50::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1101MB2126:EE_|SA2PR11MB4809:EE_ X-MS-Office365-Filtering-Correlation-Id: 33c2f555-6dbe-46f3-d38f-08dab5de0ae5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1Z744B31IQuppiOaAxweFV3XWQ7kvsJFgEfcqO/QcIdusmJvXlPXdfY/HooYiq52kFjjAOTmRrmrh5instDnoEB3TT+ToN5Vm6rpzhXhpgYN3ieVMZ9Fl4pdLgDXzIjml3HiIzASnB2qJCswfYCFE3EVFilfoyY9LQSK26LGhP7vxJ8aYR8qPyz5Of/RDZk68pe61LiC8qqUY6dlFT2WWIm2NCLCOJNhnznq4JgSEqRyw4dyMTh/gi2wxbY+cqTEaELWnY7nWGucNKcB9wKJs+ync+fLkhgFMX7KRDquFmF25uIaFtR0m3eobQ9XayBkTEpbu9AlXIXM/bnM8osM1zjbjupC9C7GfuWSAH2DknC5DKKD+LK6fY0aJjeUgHQgU1wFp5Ua6Ap6oFNj/kXDg3kvZNvUuMQEcxnrdlKnj87t8k4aQ+V2IFh06UYmgA8mFz7eYyR7nbeQ1d8yRVjSf095jiURcLbHsnor6U3zMECYKznPI2ZzHIiu7fvmEwOI4B95LBExmRJq3ypmxwx3vP89qQeUrhCmzX5AMnyhOMUD48S1/0C6OTrP9oz1tiauJCNPdBjJ34zKNs97iTs1lUWia5qAxe3dPbRAruWuXfmd4eoW95kEE7CNBJqiCs2k9jJcvq/oSH7Y4070N2cQHoKawp3dr4PlGJETI8kbRcatOwH7oA1kDYhzKjACioeYYQkKpKdECZ70pbBKTyB6ig== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2126.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(39860400002)(396003)(366004)(376002)(451199015)(6512007)(6666004)(6506007)(478600001)(9686003)(26005)(6486002)(2906002)(86362001)(82960400001)(38100700002)(5660300002)(186003)(83380400001)(316002)(41300700001)(66476007)(4326008)(8676002)(54906003)(7416002)(4744005)(66946007)(66556008)(8936002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?A/YEdXvkRo4OLxjovpCuZZ1rvAKwZKXrEfiFOUqsIuwidQY3/Y9PnFZKBbD4?= =?us-ascii?Q?RQXwB3qiNlrNwPX6361tgPhv7LpaWlWPZcEUX+bW3/pWjyymk8P9xS3Z3dG+?= =?us-ascii?Q?a6ptj+qmKhAcYK3tCeG8FQwhNmplXAGnXZ9cBfmlKbwMNia4ToZoBlFQQ+lX?= =?us-ascii?Q?yT3CzIKfrT8Q3FHEG9HIkrgOIM/k6M3pauxVZzFgetp6oEU+QzpR32IQisey?= =?us-ascii?Q?K03ljkff3mALZuqfHGwYb3ID1nDvywGkuibbHfCb2nAS4720mAeWgJhQYH68?= =?us-ascii?Q?LbJCmewlYfrtZkd4IkQqReZXk0EK07f0yiLKThxLCr5/UQswV8ubpbb4UvSq?= =?us-ascii?Q?biYQsRlKqK/UOy6it/BbuzFaRIBTCDtn380qauCirmrv9ycnp8nU8OVXAHqb?= =?us-ascii?Q?sLU5OjML1H1Xj2RNzT+Wu8OOVNo+SqnQoO8TE14kS51t1uLwTo9r1y3WUcfo?= =?us-ascii?Q?iw9WFzeZoWqqwx/CvQKYL+5nCErgDI/pXgCR9ybICzcgEYO6/IDX2PlO3MEy?= =?us-ascii?Q?yXag91hQ3ik63Kzf3seuRfDeBXk2rFoOcZ/cyeUl4+0ZsaY2nz0B1LKGWcLn?= =?us-ascii?Q?96WNNtP1yQRSXJRkQgiwzWHortzfFa8ILWxMugcVxEVhjo6aDdNS00//U7FV?= =?us-ascii?Q?yj1VRsY1VRwuqXovZsTtSdTpfa81lto0S6hUMKay6G1yAw+XrNY5cWCEx9hK?= =?us-ascii?Q?MglZTfSeY3iOruAr8/xTJWlLLtd0EqMU36v5W5+xRS1ESkRWndSg/wbyLdlI?= =?us-ascii?Q?THm/gTOQuvJ+IPIhUN4adE/MCAx0dCMnzgSFmYDtBNT1dZiSW6CzbFzS1LGJ?= =?us-ascii?Q?0VhArncRQMKEvRirpUlFOk0+1wss8Z/0cLreTKGKWtGI6p4vgoXRelpjU1Qn?= =?us-ascii?Q?5nPlIjYPNrAba1yzauYyPFw7ptxe371p+0ydV7RVrGAooZp5UEIwp6VlFenH?= =?us-ascii?Q?VxLZjm8LBVX7nUlHmgoc2n/dP792hSz/HULKNRJ/VnmVovtxqXaIc2UOSaNy?= =?us-ascii?Q?v9lErrAWMujpd/mEUjLeOjDSfBfSG3tM5bBwzhzyZWK++WWhfI/S2ls+zEVF?= =?us-ascii?Q?CaSSULy/SnO8GnbCTzLSve+a4eIJxk1cdFLk5IQbxGg7cS0E1HsjbGbWEdd7?= =?us-ascii?Q?gjWKkH9x6afVQVQ9y16d8KyUVehgp06e79cPGqf60cRHRPgMc7SUL8h9KXFZ?= =?us-ascii?Q?2tj3GP+QkJ9182OMPz9T2Af0ywHf22vdNnY814FnOFEeKfqPDiehOkzTagkT?= =?us-ascii?Q?xvvEWaJuLRFJiQt8CN+Ftyb2LAOleISKBm+hBWYrfVgrtx2o5J22d3janyj4?= =?us-ascii?Q?unpE1pOGC04Mt7zVBXytqsQQmphKHzCEUkzUPun4iUOALUITclhYbDuZGkYu?= =?us-ascii?Q?LybaLSy8/C/S3ogiPZL+4GlHT7DdvAQ4aKb5hIzrY66km+yG0fssMO+9r5lu?= =?us-ascii?Q?2XzYDdZdK+R7ttqnr0SF2GDC/CKZG+AtnXjZlWvhQE41FtE2bZNeKM2K9Qda?= =?us-ascii?Q?IcJv4x5AMaU1is4tGjAd+FVJCuz6lryN0Bg7wZIlMdiFrWs9NQLnRVtLV+fB?= =?us-ascii?Q?pY4AYRmI1Ew8j1sT9xgo9wLmYBTPPaHp7VgRMYFEumy29dYGFe37ydQ2YDAS?= =?us-ascii?Q?hw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 33c2f555-6dbe-46f3-d38f-08dab5de0ae5 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 16:37:29.8891 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DsIbt8jTlFMhASR125g7PbjVuzmPvjXaWjvWFg2AiW5OOZO9zxOPUFG2JR9l0yl3nfuZcM+eAHTEeN+3WdLywCmGN6ZNxUCEAVnSaAjBIjY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4809 X-OriginatorOrg: intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1666629455; a=rsa-sha256; cv=fail; b=igMtIXqB27M0BtRHAAyLKeyDlfhOx9gmmetfDXaYUxorNFqZYuuG5zZXauil9ps2VKwqQA uiCu5oWYHU3p4IKSjmWzK7+spteLlrdbjYN17nB1BaEFzL6qz23B8sr+5ZjUub0RmoZwY5 u/fLTPKMdlIoyaRA2QoOwGMWVecuG08= ARC-Authentication-Results: i=2; imf22.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b="SsVOseT/"; spf=pass (imf22.hostedemail.com: domain of dan.j.williams@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666629455; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K9IfnsDeFwVQ1W1jxqWlUVBS49FENYsoTk2vabXknpU=; b=0cl8nSWuR4cWd+XFcYVd3uB6UkPeThmfm7MCzpMt+U7rO25vg67MNkeA57032Vg5r0+nJG ks1KtOXFn0vzr/qufWtoePg9QbJKQggTj3Dh+oRu16WVozg83wLryVeznACjwdUU5bQh/n DeqDHRLYnKYhyDgL+wSmGQuQazjzl8E= X-Rspam-User: X-Rspamd-Queue-Id: 28135C000A Authentication-Results: imf22.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b="SsVOseT/"; spf=pass (imf22.hostedemail.com: domain of dan.j.williams@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") X-Stat-Signature: spx871ee9y5okyb66y8wh7qpiz3a6q1o X-Rspamd-Server: rspam03 X-HE-Tag: 1666629454-912553 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Logan Gunthorpe wrote: > In order to add checks for P2PDMA memory into try_grab_page(), expand > the error return from a bool to an int/error code. Update all the > callsites handle change in usage. > > Also remove the WARN_ON_ONCE() call at the callsites seeing there > already is a WARN_ON_ONCE() inside the function if it fails. Looks good, Reviewed-by: Dan Williams