From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF441C43334 for ; Fri, 10 Jun 2022 03:59:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0EA008D0073; Thu, 9 Jun 2022 23:59:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09A018D0064; Thu, 9 Jun 2022 23:59:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA3D18D0073; Thu, 9 Jun 2022 23:59:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D6A3B8D0064 for ; Thu, 9 Jun 2022 23:59:00 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A69BB34DD4 for ; Fri, 10 Jun 2022 03:59:00 +0000 (UTC) X-FDA: 79560970440.06.5B8EEC9 Received: from out199-2.us.a.mail.aliyun.com (out199-2.us.a.mail.aliyun.com [47.90.199.2]) by imf29.hostedemail.com (Postfix) with ESMTP id AED5A120049 for ; Fri, 10 Jun 2022 03:58:59 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R861e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0VFxazjx_1654833523; Received: from 30.0.143.52(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VFxazjx_1654833523) by smtp.aliyun-inc.com; Fri, 10 Jun 2022 11:58:44 +0800 Message-ID: <6351ead6-b4b8-dc43-2c1d-c099094cadc9@linux.alibaba.com> Date: Fri, 10 Jun 2022 11:58:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [mm] 9b12e49e9b: BUG:Bad_page_state_in_process To: Matthew Wilcox Cc: kernel test robot , 0day robot , LKML , linux-csky@vger.kernel.org, openrisc@lists.librecores.org, linux-arch@vger.kernel.org, lkp@lists.01.org, akpm@linux-foundation.org, linux-mm@kvack.org References: <20220608143819.GA31193@xsang-OptiPlex-9020> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654833540; a=rsa-sha256; cv=none; b=fMduIBOYLyhkcd4q6DLvLrZfYfk4z+srWZ/QSYVSDXZstC3zrELgbu+zhnx7pA/EXf2xQ+ nh4n1K5cOsFowP7+g6OYhF28kvbRkNXW2u3mi09M70dSskAIZFLpiHErSTGnYMnzaXFuJS Caw6wa965KXAucbpRKTLV7vyz5Fo0nE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 47.90.199.2 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654833540; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8mq78KgNUL1o/LoRDwg4C41Vd5CATK8kfCF4aI0DymQ=; b=7YSpZIzaSJVp4krsI8mNaQp30JXWaxHBZaxLWbFcTOAPGET/+nA/yvIyt0EYYiVYWqsDqq ClDm39ooqIiE/q+GypS9y+89Zmr1y5VKrGxcDJpPp51ryJVyKuzdLFFey/Jb6WziiN2bMe NcjgcCN5R03Y/i0ufrEQLOKsSK39Z0Y= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: AED5A120049 X-Rspam-User: Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 47.90.199.2 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Stat-Signature: ahmbq577ganxgjdq8rrhystrato1zbmk X-HE-Tag: 1654833539-443603 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/9/2022 8:18 PM, Matthew Wilcox wrote: > On Thu, Jun 09, 2022 at 12:42:16PM +0800, Baolin Wang wrote: >> diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c >> index 6cccf52e156a..cae74e972426 100644 >> --- a/arch/x86/mm/pgtable.c >> +++ b/arch/x86/mm/pgtable.c >> @@ -858,6 +858,7 @@ int pmd_free_pte_page(pmd_t *pmd, unsigned long addr) >> /* INVLPG to clear all paging-structure caches */ >> flush_tlb_kernel_range(addr, addr + PAGE_SIZE-1); >> >> + pgtable_clear_and_dec(virt_to_page(pte)); >> free_page((unsigned long)pte); >> >> return 1; > > If you're going to call virt_to_page() here, you may as well cache the > result and call __free_page(page) to avoid calling virt_to_page() twice. Right, will do in next version. Thanks.