From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44F88C433F5 for ; Thu, 27 Jan 2022 12:50:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4CBD6B0071; Thu, 27 Jan 2022 07:50:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CFB446B0072; Thu, 27 Jan 2022 07:50:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC34F6B0073; Thu, 27 Jan 2022 07:50:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id AD8016B0071 for ; Thu, 27 Jan 2022 07:50:40 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 662E294FC9 for ; Thu, 27 Jan 2022 12:50:40 +0000 (UTC) X-FDA: 79076051040.13.660B71E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id EB4064002B for ; Thu, 27 Jan 2022 12:50:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643287839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N4n2fN70c2o+w/iLcI21Ax2ko496ej/NQO3wKSvR4ZI=; b=aDnTc0MSF3RE8BzuVcDR6fcXGvvf5U4irhDw5lHXYmpVsZJf0t2t5TdNSBg7K87hLezsMm Mx3E7WC/2NJZPsqoyU8x99VuZvP8fkikZbJrkYJL5jGKAGbsGkMHdiU7ho2/JbOXpE88qb zpCYjHCJvrEq83gEEapuOFcIgD4d6YM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-288-Fuc22RYYPc-J_ALvjOEkHw-1; Thu, 27 Jan 2022 07:50:36 -0500 X-MC-Unique: Fuc22RYYPc-J_ALvjOEkHw-1 Received: by mail-wm1-f72.google.com with SMTP id i26-20020a1c541a000000b0034dc8bd7078so610305wmb.8 for ; Thu, 27 Jan 2022 04:50:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=N4n2fN70c2o+w/iLcI21Ax2ko496ej/NQO3wKSvR4ZI=; b=vcN4wcjyS6Fd5VJMQth+dNMjz/vFVzbmHg6TI4A9TCUDxIdzTTp7F+h3s/lq/hjrev wV5fTsFup+PiIsH6w+IxktBm8+ZdzWDNsdK2K/4ZSdOMqN8bKH3kdXF2ftl9eR2gQ1l2 a1JPB0gOoKmn2rAi6fPF2UX5wpS3okAggomysXATxwcEL8YHgJgmWKYtrqaLul9tYskY 7sme/LkkMbE4hQYxGwmJFnWtPU5fzGUuFjjwKEYl89XtQBRmhiw3j5zKh856wNmRLnsJ CTDowIlyjQo3J609LSWFLlLqISVnUHWA8zSsMHcc/WsPCdMCRuJO3yTUWawwridnlkKy icZg== X-Gm-Message-State: AOAM533rKz1a8PAH7Kh4TTMM5mxLdgcvpH5oF8ebqBGLzLw4navpQfnW D65Y4o787c/uNXSQRbBfUC6edQQGR6uPnl8ayrFfuBghjlSu7YwKa+plbrNDbwq5e6oUTL5D1Cu T3F3Idh91pdE= X-Received: by 2002:a05:600c:40b:: with SMTP id q11mr11452751wmb.43.1643287835155; Thu, 27 Jan 2022 04:50:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJyvEqG4sn9O9VkUMDlKL4v2sNRnP1uIUhjD+T7OfJkd/BnNRup3Dkx6tYN+Zd6MBIkEdiQ4iA== X-Received: by 2002:a05:600c:40b:: with SMTP id q11mr11452739wmb.43.1643287834948; Thu, 27 Jan 2022 04:50:34 -0800 (PST) Received: from ?IPV6:2003:cb:c70d:8300:4812:9d4f:6cd8:7f47? (p200300cbc70d830048129d4f6cd87f47.dip0.t-ipconnect.de. [2003:cb:c70d:8300:4812:9d4f:6cd8:7f47]) by smtp.gmail.com with ESMTPSA id k12sm2208835wrd.110.2022.01.27.04.50.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jan 2022 04:50:34 -0800 (PST) Message-ID: <634987e7-27c0-bca5-30cd-de7a5ede30cd@redhat.com> Date: Thu, 27 Jan 2022 13:50:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 6/6] memcg: do not tweak node in alloc_mem_cgroup_per_node_info To: Michal Hocko , Andrew Morton Cc: linux-mm@kvack.org, LKML , Alexey Makhalov , Dennis Zhou , Eric Dumazet , Oscar Salvador , Tejun Heo , Christoph Lameter , Nico Pache , Wei Yang , Rafael Aquini , Michal Hocko References: <20220127085305.20890-1-mhocko@kernel.org> <20220127085305.20890-7-mhocko@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220127085305.20890-7-mhocko@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EB4064002B X-Stat-Signature: bo5r3ynbbpajqnjhuphed3z8awc3816n X-Rspam-User: nil Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aDnTc0MS; spf=none (imf11.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1643287839-5869 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 27.01.22 09:53, Michal Hocko wrote: > From: Wei Yang > > alloc_mem_cgroup_per_node_info is allocated for each possible node and > this used to be a problem because not !node_online nodes didn't have > appropriate data structure allocated. This has changed by "mm: handle > uninitialized numa nodes gracefully" so we can drop the special casing > here. > > Signed-off-by: Wei Yang > Signed-off-by: Michal Hocko > --- > mm/memcontrol.c | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 09d342c7cbd0..8b3f9eef4c65 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5067,18 +5067,8 @@ struct mem_cgroup *mem_cgroup_from_id(unsigned short id) > static int alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node) > { > struct mem_cgroup_per_node *pn; > - int tmp = node; > - /* > - * This routine is called against possible nodes. > - * But it's BUG to call kmalloc() against offline node. > - * > - * TODO: this routine can waste much memory for nodes which will > - * never be onlined. It's better to use memory hotplug callback > - * function. > - */ > - if (!node_state(node, N_NORMAL_MEMORY)) > - tmp = -1; > - pn = kzalloc_node(sizeof(*pn), GFP_KERNEL, tmp); > + > + pn = kzalloc_node(sizeof(*pn), GFP_KERNEL, node); > if (!pn) > return 1; > Acked-by: David Hildenbrand -- Thanks, David / dhildenb