From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68B43ECAAD4 for ; Sat, 27 Aug 2022 00:48:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE318940007; Fri, 26 Aug 2022 20:48:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C90116B0074; Fri, 26 Aug 2022 20:48:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE286940007; Fri, 26 Aug 2022 20:48:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9F3B36B0073 for ; Fri, 26 Aug 2022 20:48:32 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 72D88ABAAB for ; Sat, 27 Aug 2022 00:48:32 +0000 (UTC) X-FDA: 79843536864.21.12A90B0 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf20.hostedemail.com (Postfix) with ESMTP id 157301C002E for ; Sat, 27 Aug 2022 00:48:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661561311; x=1693097311; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=y3ITA2Rbit/zpacOwb90gFKz8cQx8gyNTNSVVgwJnJk=; b=eYedqbBp+rSAZB7AatxI76Bjt0KRSSKcJAE4Qa5ILDTwWdoKUOWC65jQ sP/rCOukeiZOX0mECWzbBHLhYd5T7j0v9y7c9VHpn3lwaunL8+mnf6prd zufmvn2x9c3h8HXRYRW5NL2yOyxoL8TyV6lFR8peVsE2aMvb71dYjgQ6W wCpalXwESdvBNdk8jCtHfIoK4/DKyW3RaJQmhoP8mYBCKEu3SGgT55OAc 2loj59EEmUwo2BwLXIA5NthDN6mP5EUaa8zoQMohuSdOl7YPPkEiWii6e yzM/MFLYvBsoHviMKoyRpiya6RCrsZZ1IfHfmS24jZ2wsA2zg+g7D5Pke Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10451"; a="294628885" X-IronPort-AV: E=Sophos;i="5.93,266,1654585200"; d="scan'208";a="294628885" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2022 17:48:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,266,1654585200"; d="scan'208";a="714164759" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga002.fm.intel.com with ESMTP; 26 Aug 2022 17:48:29 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 26 Aug 2022 17:48:29 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 26 Aug 2022 17:48:28 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 26 Aug 2022 17:48:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TZtE23JmyQdZwWt0YxeA220BErq31JaoS8WAslFGCifmb0hyiEFXpi+1gq1pcR4NgctPQHWBbDj2594WYEo4uY1/DRJtQIggA9B8kHjPj1Sp7Ojl7mWUR4Mvr4bwKi7spWUUWD8oBVebLxvevj+XdIPpGWDsrfPy9h/6FhfdwHFdpVn93ZCBGul14/Nq2pwrOnBOQXoc8wka3le5x71NmqpoGI/iGRk3DjbY6Yg9Dz1YN5cs8CpLNfCokyHdQPKRl7cMYXwXPHP/9hsouajP77xjvw0GB6yD+gIduaj53tdWCtkNDlW2AWW4w3vf2pmXuCYFfWAjY7sf8eL6F137UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dh8m0cUXSBidAbYA/4YrsHmdaN/L1gyvG78CFd1RCd4=; b=nn5QysQtHTGz5tlGXxuIYKlQG3xYObVHla5ktTG04D4ElvkOLxO1dvfZLPl36ft2gAKOi75hajCE/Mjy0Tr8ssDvZNJs6rv2+P1D/2nucQA2190x6tzBsvw6ZsTatmfB77ZTT2T07wrRBJ0Mwo5qxzpbhS8gs1oMSQ32ESKz4nMkltLwm98B4MS4GjbumUPHYY8UwJcEXd+fwF1ioOAdznDAcFecfSRbA3Nz15UM9I0qZwV6vmZ/fGih24yFonezmOpkH0dwcKwQfCgkZ3P72s6K8O398NR5w/bSJWD/fbnEEpgXLsAl81lMzK6tGjN5L1od/2j0q/gKxnxBRiF8Jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by SJ0PR11MB6767.namprd11.prod.outlook.com (2603:10b6:a03:47e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Sat, 27 Aug 2022 00:48:25 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::8845:e130:6f6e:ac66]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::8845:e130:6f6e:ac66%5]) with mapi id 15.20.5566.019; Sat, 27 Aug 2022 00:48:25 +0000 Message-ID: <63495a94-fa2e-af21-8710-4be5f3c7767b@intel.com> Date: Sat, 27 Aug 2022 08:48:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.2.0 Subject: Re: (resend)WARNING: trying to isolate tail page in isolate_lru_page Content-Language: en-US To: Minchan Kim , "Yin, Fengwei" CC: Matthew Wilcox , Yang Shi , "Yu Zhao" , Andrew Morton , Linux-MM , =?UTF-8?B?6Z+p5aSp56GV?= , mawupeng References: <485f8c33.2471b.182d5726afb.Coremail.hantianshuo@iie.ac.cn> From: "Yin, Fengwei" In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR02CA0022.apcprd02.prod.outlook.com (2603:1096:3:17::34) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6e5f64e1-4e4a-4b28-1f25-08da87c5d9b3 X-MS-TrafficTypeDiagnostic: SJ0PR11MB6767:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1UpIfwmnIhwDqBuiF6XV0y4bb6ZOM5LEN72GLAkKYwyGMzJJoXQetAPOe20wa//Fb+KSZha4CNoT9uP7GoRONdV5csTc/xf6w7sb+eHh7FSGxU90rUF1xQOQpQMxpLJN0vJJnRHv++VD8fS5cWjlz2Oz+FJ280VAKrq4k2kSZ0ecVnZ4udbTOqnE3Qpsa1bKeuwtrb7qjdKUc9Ldv9D1DekXl6C6JKThBM9JwEvkYBOQbDdinQUL7fo0rvo3Gw+MhwdLhVl4tZCJdLj07Uy/YSG+WgNhznXl41Gwu0IrHV8hPsz7Zn9iSkqX+44E+A9/p7ekO5hkM+gwr4LGD1GL5I/37PTY5alFu85qO/H9MaWvGLSRuRQ3/Ve11Alpoqw+7EJmirxGFnQPQ50YpsqFjS5EiKob9K0Pn4oYpkZ5ku6xFYq1X02/QNhWFB0lNNoYgWzh0N7oUirYfMfQptSWFG9rz20y3z2IhKEPUc4zm4IIK/ma+SB0bt7m3wPdNy7RqKQVKidZfAdPUqt1n26XEdPhpGdj1I1F0DHjrEWugiyy44BHLfcp6gGdGCy63b7fJb46JlKP/OED5o53tss7GxCjOSAXxHKUiNldm0tTPRkWpfktBpNyE0Rk5VjLWy2EMBVdEu89AiymIwQ+dyFwm/Semo/mBX/rnI0qgJ8NfkE9RBwJ1hKoqH6Xff3szQkBiRM0IKeL/GEMqvScH9lXqkyZFRBThlYtskcqH20eSo0I4qC/6DsAvN/HpXpFhR/C416mmqKgVUz246OXl8cyRcsjmp+UbjCNdcRCEEti3v4A4l1yODtlsesY+CqBgCzvdp5BbCDGZlZcJzNoghxD6Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(346002)(39860400002)(136003)(396003)(376002)(8676002)(2906002)(110136005)(54906003)(66476007)(4326008)(316002)(66946007)(38100700002)(5660300002)(8936002)(86362001)(31696002)(36756003)(82960400001)(6512007)(66556008)(45080400002)(26005)(53546011)(6666004)(478600001)(2616005)(186003)(83380400001)(6506007)(966005)(6486002)(41300700001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEpkNjRRbURHQnZKa0NTR0wxNk9tMkZMYXUrdlNxMUEzZ2U2UFcvakJwUkth?= =?utf-8?B?Z0RKSjg5alJ2OHFvUVMzdDExNE5yREM0dlZ3TkNEVDRhc0ZyTWZzcUdTTE9l?= =?utf-8?B?S0luSFR6aytZUmttNE5MMzZ5OGhwbUt2aUcweDd3WVZ2bGNKNEd6aHZLQUhM?= =?utf-8?B?bkVvWGJjSituWlMvQk9FNjJlOHFYZTdmZGsyeVpYWnpRRXZQdE9yUDdDcDd5?= =?utf-8?B?TmtCWFdyWGFVZitWdjF1TzNMSFREeVF4VllieEUvalMxRFN2QzR1YWFHWG5O?= =?utf-8?B?NkxNSUFJLzRVMkVTUmRYak5zK3pyYzM1bEFueUFZM2g0NGswTE43dUVCYnB3?= =?utf-8?B?dzA0Z0JZWGhPTlAyeWxRbXg0c0cxRlpuelljZk11WlNxZllpanRMZUxjaFc1?= =?utf-8?B?d1cxQXhlempYd0pTODcyUjhwM3NBblVyUmc5NFlnd09rdjFKTlBFNDZSMWdQ?= =?utf-8?B?bW16TElzQ0JLcTFlU2k4RllaQjVrbWNTOW1qVzRPdnJtUW9vL1RVZDFBcmk2?= =?utf-8?B?OVBrNEg3MlBZTnI2R2cxZ0Nub3l2c1J2MWgxV1M2cU53MFY1V1haSkZ5ZTFj?= =?utf-8?B?Y2QxcTRqZmZTMDJmeWRFU2paWDFCSE80TS9lS3VKYkcvNzVYQ2dhSS8xcmpt?= =?utf-8?B?YmJTZnZiczZ0bk9YMU9sWnhhTE91U0ZzSURHRVNSdmVYcDFCN2dFME5YN0Jv?= =?utf-8?B?Smpad1E3WndKZkdyR1AvdXJFUFc3K01mdTB2R21NT1BQV3V5enhqMWlhalE0?= =?utf-8?B?WUlzNzA0bEV2dmNnbVNhcmRxSzY4NEczamoycnJEV1J4YlZ4ODRHS2g2RGo0?= =?utf-8?B?RjJKWThWNlJZWmJxU0NQM0tYRFVqTjUvckxwUFYwdi9Sd1M1eXE5T3VwMklv?= =?utf-8?B?VERTMksxOHlGeTBlU3diSFdtbktFb2pyMmVaMndNTHR1eW1XNENZQVA1TU5Y?= =?utf-8?B?UkdDL05GRXlvbU5LOFZRTDdmYVJSdjIvd0Q5cTE3Q205TStqeTBQV2Jrcyt1?= =?utf-8?B?MExIMXNXamVlLzNhN3Q1QWxzTjZjWGdmL0F2T1JnUE9NWnJMdkdXbU1wOTBa?= =?utf-8?B?dzdzVnVienBrWTh3b3NZbWJQNTBpcWtTdjlDY3pJSldkS2VrNk9uK05CT1JV?= =?utf-8?B?SXd3UWphNEdkWnNIbzhidUdsVWtsVUcwT3JJVkE5cm56bzNScFBTMm1BZk9o?= =?utf-8?B?YjdUdTVORzlKcDBBMEl1cjFlOSt5bDg1NkdCMmhGaHFpRlRpZ2dUZFZlM2Qv?= =?utf-8?B?RXVQNUlWbXBpcEdpWUh6eExIbXFKcmxpdkdRM0xRL29wdmZWeUtlcXJyRlVN?= =?utf-8?B?NUN6RWtXU3FuWWpSVFA1QzJ5T2U3Q3VuYkJ6RXRtZFFBempaWjJjb2Z1ejhr?= =?utf-8?B?eG5NbWtySjM3NGFyMUdDT0t3REJtRWtFazVXL2J5QlFSb3NQYjg3TGNMZVB2?= =?utf-8?B?RjRxK240OFdIeFFRcTJXdzF3VDFWb2E0UWR3V25XaTlLYWQvWVhjYlI1ckh4?= =?utf-8?B?WnVKYVR1QXByZXJTNHJrdmFaUUlmMHFNbkdNb3hSVmVZWE1vYitYdzZzRnBY?= =?utf-8?B?bmRRTm92a0hwcWpZOTl4OHN4WE1rY3BRSFQ1QVdXbGorY3h6MURmbmpybk9n?= =?utf-8?B?ZmQvVmJleTRUNjl4QmQ4cWFEZVJNeEU2R2NtQUtnOGZZSUttbG1iQm9PbnJJ?= =?utf-8?B?VEh0ZG14aU45RzNSR1BCMlFxdGhlTStVLzJ0aFhiVWZXNndBNUFpSjRKb05q?= =?utf-8?B?UTNJZzNWeC9rM2JRc2VhcldIaWZ0Mmh5aGRxQTdZTWYwdFQ0NTJ4WEdTTFZK?= =?utf-8?B?N2F1VFdJdFNpbWZ6blllb3hMS0FiaVZ4RmQ3OTFlZVJGcXVWNjFkbXZaVlFG?= =?utf-8?B?R0ZsdjM5UTNiRi9ZMDhCZHhoUVJXSlBFc2FXK0Y4b2VBc0lVNllqeVk1SGRi?= =?utf-8?B?a3lMMnZuVkRPb21rYjY0cERXbmdjOVptY0hiemNtVno2ZHk0cDZPQm5HMmlw?= =?utf-8?B?dE9WZDcya2NuVzNxb21LYzY4S1lDWGdWSjZZcEVRZFhreTBWQXY5WTJUeTVI?= =?utf-8?B?RVZuY3RpSVFzQ0M0Rm90bUZIN3JhclpCQUpmVHJxaGZ0T1liZ3EzTERUQUE5?= =?utf-8?Q?K7t5cDJ5JmjlToi5JLimCD6jx?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6e5f64e1-4e4a-4b28-1f25-08da87c5d9b3 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2022 00:48:25.8298 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dXXo2yteZbjUW8PEbcosMGruZIA++ZALvye5Seo2zGXPdc0ZnUadJ0uihbARknh3nOi54bhzXL72RsFPmzVkNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6767 X-OriginatorOrg: intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1661561312; a=rsa-sha256; cv=fail; b=v5YEuUA7b9y3ZvPXIEem3mUrRQxN9jKiexl2FQBXz/1qDY5wM5FDwMgKm9YECW8easncre kqECRsdF5Vn/YAfZOIaN7jMFjorUJPr1HHsdzG9h5lPwZDO/XtAA6xALh53k6fLLLWCDe3 gkfQXnNV0YxhyzeNEn0osWn2eeGaMa0= ARC-Authentication-Results: i=2; imf20.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=eYedqbBp; spf=pass (imf20.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661561312; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dh8m0cUXSBidAbYA/4YrsHmdaN/L1gyvG78CFd1RCd4=; b=TMcsXQOSd7zpPXT2+9sX7JF5M8nKOUOmFgidmh/7VxIN1gKGw7HmhAvbOkq/ZOPlSRzHwv HfND9dATOisybxjL2thWFpkrZz9PQYQHDB0lyQI6GxzZHK2ta17ptpgkKZKAC/wYTdkf6Z xRLQtczRFbXYH5bGVZgAHLlrc0h0rRs= X-Rspam-User: Authentication-Results: imf20.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=eYedqbBp; spf=pass (imf20.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam10 X-Stat-Signature: 4f9qr669769mhbzfqrjgyxptwgjq4shy X-Rspamd-Queue-Id: 157301C002E X-HE-Tag: 1661561310-715049 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/27/2022 12:56 AM, Minchan Kim wrote: > On Fri, Aug 26, 2022 at 11:20:58AM +0800, Yin, Fengwei wrote: >> >> >> On 8/26/2022 2:46 AM, Matthew Wilcox wrote: >>>>> Looks like my analysis from yesterday was dropped: >>>>> >>>>> : This all seems quite plausible. The reproducer seems to (correct me >>>>> : if I'm wrong) create an AF_PACKET socket and mmap it. af_packet.c >>>>> : seems to create compound pages and mmap them. This isn't folio-related >>>>> : at all; I just moved the code that warns about it from mm/vmscan.c to >>>>> : folio-compat.c. >>>>> : >>>>> : Looks like a long-standing bug in MADV_PAGEOUT to me. >>>> Such page should never be on lru, right? We could test lru before >>>> calling isolate_lru_page() for this case? I know isolate_lru_page() >>>> does the check, but the tail page warning is raised before the check. >>>> >>>> Could the tail page warning be moved under the lru flag test? Seems >>>> possible, but it should need extra handling (re-set lru flag). Seems a >>>> little bit overkilling. >>> There's a number of ways of solving this. I'm interested in seeing >>> which one Minchan thinks is best. >>> >> >> My understanding is: >> PageTransCompound() return false for compound page if THP is disabled >> in kernel config. Replacing PageTransCompound() with PageCompound() >> could work here. But for the long term, folio should be the answer. :). > > Thanks for reporting and analysis, folks, > > I agree with Yang since the MADV_PAGEOUT should work with only > LRU pages. Yes. Yang's suggestion has wider coverage. I am still wondering whether we need change the PageTransCompound() to PageCompound(). large folios depend on THP now: commit 421f1ab48452af48b64e205de1caca3d1ba415f4 Author: Matthew Wilcox (Oracle) Date: Sat Jan 15 23:27:08 2022 -0500 mm: Make large folios depend on THP Some parts of the VM still depend on THP to handle large folios correctly. Until those are fixed, prevent creating large folios if THP are disabled. Another thing: maybe move the !LRU(page) check before PageTransCompound() check? Avoid trying to split the page if it's none-lru page? Just one thought. Thanks. Regards Yin, Fengwei > > From 0a43ac31c903bc23299a868a6d6724ff5b807e3d Mon Sep 17 00:00:00 2001 > From: Minchan Kim > Date: Fri, 26 Aug 2022 09:37:34 -0700 > Subject: [PATCH] mm: fix madivse_pageout mishandling on non-LRU page > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > MADV_PAGEOUT tries to isolate non-LRU pages and get the warning > from isolate_lru_page below. > Fix it with checking PageLRU in advance. > > ------------[ cut here ]------------ > trying to isolate tail page > WARNING: CPU: 0 PID: 6175 at mm/folio-compat.c:158 isolate_lru_page+0x130/0x140 > Modules linked in: > CPU: 0 PID: 6175 Comm: syz-executor.0 Not tainted 5.18.12 #1 > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1.1 04/01/2014 > RIP: 0010:isolate_lru_page+0x130/0x140 > > Link: https://lore.kernel.org/linux-mm/485f8c33.2471b.182d5726afb.Coremail.hantianshuo@iie.ac.cn/ > Reported-by: 韩天硕 > Suggested-by: Yang Shi > Fixes: 1a4e58cce84e ("mm: introduce MADV_PAGEOUT") > Cc: stable@vger.kernel.org > Signed-off-by: Minchan Kim > --- > mm/madvise.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 682e1d161aef..a3fc4cd32ed3 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -452,8 +452,11 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, > continue; > } > > - /* Do not interfere with other mappings of this page */ > - if (page_mapcount(page) != 1) > + /* > + * Do not interfere with other mappings of this page and > + * non-LRU page. > + */ > + if (!PageLRU(page) || page_mapcount(page) != 1) > continue; > > VM_BUG_ON_PAGE(PageTransCompound(page), page);