From: Lance Yang <lance.yang@linux.dev>
To: Chen Ridong <chenridong@huaweicloud.com>
Cc: linux-mm@kvack.org, david@kernel.org, shakeel.butt@linux.dev,
zhengqi.arch@bytedance.com, linux-kernel@vger.kernel.org,
lujialin4@huawei.com, chenridong@huawei.com, hannes@cmpxchg.org,
yuanchu@google.com, weixugc@google.com, axelrasmussen@google.com,
akpm@linux-foundation.org, lorenzo.stoakes@oracle.com,
yuzhao@google.com, jaewon31.kim@samsung.com, mhocko@kernel.org,
ioworker0@gmail.com
Subject: Re: [PATCH -next v2] mm: vmscan: correct nr_requested tracing in scan_folios
Date: Thu, 4 Dec 2025 21:35:53 +0800 [thread overview]
Message-ID: <6320fb67-4ed7-43c4-a4b6-48ebed2b473f@linux.dev> (raw)
In-Reply-To: <20251204122355.1822919-1-chenridong@huaweicloud.com>
On 2025/12/4 20:23, Chen Ridong wrote:
> From: Chen Ridong <chenridong@huawei.com>
>
> When enabling vmscan tracing, it is observed that nr_requested is always
> 4096, which is confusing.
>
> mm_vmscan_lru_isolate: classzone=3 order=0 nr_requested=4096 ...
> mm_vmscan_lru_isolate: classzone=3 order=0 nr_requested=4096 ...
> mm_vmscan_lru_isolate: classzone=3 order=0 nr_requested=4096 ...
> mm_vmscan_lru_isolate: classzone=3 order=0 nr_requested=4096 ...
> mm_vmscan_lru_isolate: classzone=3 order=0 nr_requested=4096 ...
> mm_vmscan_lru_isolate: classzone=3 order=0 nr_requested=4096 ...
> mm_vmscan_lru_isolate: classzone=3 order=0 nr_requested=4096 ...
>
> This is because it prints MAX_LRU_BATCH, which is meaningless as it's a
> constant. To fix this, modify it to print capped valued.
>
> Fixes: 8c2214fc9a47 ("mm: multi-gen LRU: reuse some legacy trace events")
> Signed-off-by: Chen Ridong <chenridong@huawei.com>
> ---
LGTM, feel free to add:
Reviewed-by: Lance Yang <lance.yang@linux.dev>
prev parent reply other threads:[~2025-12-04 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 12:23 Chen Ridong
2025-12-04 12:42 ` David Hildenbrand (Red Hat)
2025-12-04 13:35 ` Lance Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6320fb67-4ed7-43c4-a4b6-48ebed2b473f@linux.dev \
--to=lance.yang@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=chenridong@huawei.com \
--cc=chenridong@huaweicloud.com \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=ioworker0@gmail.com \
--cc=jaewon31.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=lujialin4@huawei.com \
--cc=mhocko@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=weixugc@google.com \
--cc=yuanchu@google.com \
--cc=yuzhao@google.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox