From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E08C1C6FD1C for ; Wed, 22 Mar 2023 16:18:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45EB26B0071; Wed, 22 Mar 2023 12:18:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40E396B0072; Wed, 22 Mar 2023 12:18:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FD606B0075; Wed, 22 Mar 2023 12:18:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1C7E26B0071 for ; Wed, 22 Mar 2023 12:18:12 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BD8D5A04B5 for ; Wed, 22 Mar 2023 16:18:11 +0000 (UTC) X-FDA: 80597041182.10.5584356 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf15.hostedemail.com (Postfix) with ESMTP id 7FF37A0025 for ; Wed, 22 Mar 2023 16:18:09 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=QA0QnQzG; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf15.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679501889; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dKvGFXxQbgZov/LC7oDjKUyAov+EoM1va45YOWfX6RE=; b=52i/ILn8P3FIGRQv0wMOBWI9qJj4/TGKI2ZR+ePSZ89QK0KVIFJiMAcNNuApT4j3s9GV9Z OMDa8BulRB0KFgT1Jv/mms/PX9/ZY6YoNR2xwVBfFnpH5VsLsBy8FhU/5iYZuKHKHPnh1a P7UoiVsIATJVvrZTCydTIWjC3UTCQ7o= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=QA0QnQzG; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf15.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679501889; a=rsa-sha256; cv=none; b=NcTwrC4A4zFWZJ2z2Gfa38AVhyydaqxaukbcn5SOgKsWalqVY3NtwA0xD5n8IRvNxpiWU1 kkfShPdaJZrWOGdjga7Aal9ksAdD3pUVuVe6/WtN68FvsK08TPi/OVkEQxuA6fZwiVUWof Abq/HTtmt6RaPBG5GBL/KGAHBeCkKeU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679501889; x=1711037889; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=GxnyaeprblyISryT2qF5P+Px8gWsxIIA48GZP8Apwvg=; b=QA0QnQzGQBiLzyZubHtUMu/JlOQhClC996ofYLD/6BWRKfGCqHtIdo1z 88Eug+FzX9T7AuncTnNrr4HLO1h4z3YgK8L9QrQIFWfOKsiJz8ar3uRlJ IwwpjqawdqlQVrBN2EBibcQJ4FQdD9wLEOIELaScehcd8Evk2F4EehgZW n3MquvdOkLgZhz/+Gjhjo9qdHtWo7ICnlmsMm1mUkGCFtyDnzppQ2Zjfe Pzk6QhzJsJY3tS3TPgM7/MjjkgbGq+Gg2ooN4YYLWKslQocDljIH6Xn63 Hs8KdzYKqdEPPrEEpyCepP1gplVAeMsBq3HDI8rAXAa/wlpJ3Ht20+tcQ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="425547450" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="425547450" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 09:16:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="675344533" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="675344533" Received: from mtfreder-mobl1.amr.corp.intel.com (HELO [10.209.35.23]) ([10.209.35.23]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 09:16:55 -0700 Message-ID: <6320abf6-0898-361b-d5f6-bcc58306f55c@intel.com> Date: Wed, 22 Mar 2023 09:16:55 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] mm/slab: Fix undefined init_cache_node_node() for NUMA and !SMP Content-Language: en-US To: Matthew Wilcox , Geert Uytterhoeven Cc: Dave Hansen , Arnd Bergmann , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, John Paul Adrian Glaubitz , linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Randy Dunlap References: <67261c513706241d479b8b4cf46eb4e6fb0417ba.1679387262.git.geert+renesas@glider.be> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7FF37A0025 X-Stat-Signature: 5mwi74h3otmm1okba87ku45os8scbjxc X-HE-Tag: 1679501889-744724 X-HE-Meta: U2FsdGVkX1/nSrhIOsu2Ht2x3Z/e0gUe6SuLJ9H1pzTlolCxa+wdtGF8KWLhAugS6JlHnNB4MuJIPIerPdfbBPpljZRGhOrob1iyjimiG903LXKyNABkyal65RAOG9HkfIEz52Tbr2znZE8vZOT9OA726mAyJ8Ofv6klaoWuvNGcu3HF1X23olsg/bs363mHrqU6Lk2q9s66KSmFFQfrL3SB+lY3H7U7J8k7zHgbcPQqbOmoN2eZLl+zyICWnMV8Vl/jdF6HZFmpx5GNzH7XQ0qvKBLZprlPhGnTbUXArg/wYAWv28dAYakePLsZwiF4Ouf7KSMOnC+iPgm2gipt2Ee3xtG+WRFaMLn3QxDiMLBvQUK/5Euux4XPZaMBwdZNE1TloYXeomFFJoI94IasZ5T4o/gP2//CkOXtxXpxn7b6aW6FZYNur3MWh8pBdHuqbUr7H/DRef/kifjzE4POTHzKtAWYHbJwOtUvICh3mcpDQ6yU0bxy18OA0sBt5NdKKaCMemnsNvvfqhY1/xbVmdRMvPGgpzTuW+XjKihqzYekJSASjiXiRw2jKWwDFvWqD2pHXLBYdPJHWbR5yh8imwWMHS/+2Jp9SEkibmtiwaGV7U89KeM5TDhCdAfp/i/VAlOwZS2KvYpPF8hNCTJ1XcbiXws7D2fBh6gUZt837qNC1WpiJ2uFZxlgO3WDeom8URWpjcLQsWbzVakTYwohbAKLzaObdwDhp6EnedSqr4MLG2Hu+Vt/bb5QLKN9/mYszqRcDkL4wTWxAB3R8LtE/WyIm8my0Pg+3/QiBzNjyV7sVaVcjU4ge1Cc9LEaffqXuN7g82GVwmBRwfcpUZ5BYfzsrK35cckfxvkUGO+yu84sQQUPgAaBFiHBKVbkOl/LaFMofaBXJoS1+IGuZMJFoKDnJ4w5fzL8qnTY7yS1j25qTiIGbNNg2QjqCGQYH2r5nnQzrsNNG57rZc1pdSo Wdd/0KKX kqIhnnf09A3+3UW9CKeS6xxIAHWbHqtGEwfe+lkf7vWR35z6HjPzyRBVv6eJc2VWYbtlN4AqAQONXaTUQsdEWFwG2Qq8kwvow28/6+Xh/Z/miQLrrVAoXzfUGFB7V26SxmfCngeJByLy/smaOJCtK7PVFUGQKIg4LpUhYOpeUBlZvRsBkMrmLaTdkVD9GXsfDwIKyew5FXgXS+Ra7kNenwAHwROt9jG3YgHASfc/4aGnjOt0ddGnsmP4XjUBy3LYEsTYn3N/lSdEo+iIytslxsgXOUAVlVmhW8/bjDEs46ITFnj7cxHyfewEzJZ0slq9yXNTYlGByX99e/WM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/21/23 09:40, Matthew Wilcox wrote: > On Tue, Mar 21, 2023 at 09:30:59AM +0100, Geert Uytterhoeven wrote: >> -#if (defined(CONFIG_NUMA) && defined(CONFIG_MEMORY_HOTPLUG)) || defined(CONFIG_SMP) >> +#if defined(CONFIG_NUMA) || defined(CONFIG_SMP) > I'm amused by the thought of CONFIG_NUMA without CONFIG_SMP. > Is it possible to have one node with memory and a single CPU, then > another node with memory and no CPU? It's _possible_ for sure, just unlikely. The most likely place these days is probably a teensy tiny VM that just happens to have some performance-differentiated memory exposed to it for some reason. Maybe it's got a slice of slow PMEM or fast High-Bandwidth memory for whatever reason.