From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC76DD1170E for ; Fri, 25 Oct 2024 07:27:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 142466B0082; Fri, 25 Oct 2024 03:27:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F2A66B0083; Fri, 25 Oct 2024 03:27:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E86DD6B0085; Fri, 25 Oct 2024 03:27:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C96C96B0082 for ; Fri, 25 Oct 2024 03:27:03 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 55C571C5680 for ; Fri, 25 Oct 2024 07:26:41 +0000 (UTC) X-FDA: 82711292664.05.0438676 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf17.hostedemail.com (Postfix) with ESMTP id 38CD540018 for ; Fri, 25 Oct 2024 07:26:45 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=gfqBmrWp; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=XJKu+9iT; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf17.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729841168; a=rsa-sha256; cv=pass; b=H08aip4MkkpNxrFFsGzKgYb7mmUKYx39vC+n/nFQVHofoeNi0nxrmCIxpatexFuCMDvWhf 5OhUr4je3V+epRVnEvi7rfTKlMTaOjZR+0d1GVEpj0uOOT2Thtxg8PFNPXnv+Wr4QcXj30 jExkbd57vwyL2Du37z35ktFabbN3WPM= ARC-Authentication-Results: i=2; imf17.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=gfqBmrWp; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=XJKu+9iT; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf17.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729841168; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LajDXgjGKUmEXMjlHU7MPH1l6wH9jp8lRs92jrvSPVo=; b=f/ZRpr3HppZAiOkIX1HTGcsa/5nBogiVRzMSOvgKvRs/YvBOdEIVtGHBlIBIe7W+wp11rn 7fNADdcOpupAOTi37BZHP7lEPoEfggW1Xz8lbPkXmg6musJhRNSM5d3bPp8epH4EjqtdpM sS5Srx8XcY7fwsXOqGugT74/8jCM0YM= Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49P2fbLi008944; Fri, 25 Oct 2024 07:26:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=LajDXgjGKUmEXMjlHU 7MPH1l6wH9jp8lRs92jrvSPVo=; b=gfqBmrWpVhXyAr1lrDGSXwZQkTJT61nyYq tB7yrR8OmfnzJLfzvFrPwdS/EbC008oyu3tFI4r0k//p4ZvQuuwBVPnvZgJ0TECY ctBvQWTbJzTkWz8UNOeOs/itTGzHtHGfNBhsIf0toB7LgkExMFRutiA8KI4IKcpv LNUVmUqd08M2EvQe9AJU10shJXbGHYT+Pmt+gM+B9WmZzGZq+hMkG4cHceeX0Fho vSgN8AeyKoK1BlorKQ7lSKMXlnKjKGmni+U0RMTKA0mnpt6cEb7ykPcaoPN4K61F 7QjqTR7yI8ADwNRPnlQPZtIGsb4BWAh4JkMb/K57/fFqwG0ntRdQ== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42c545cfk2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Oct 2024 07:26:57 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49P63ivi001472; Fri, 25 Oct 2024 07:26:56 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2176.outbound.protection.outlook.com [104.47.57.176]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 42g36a6ab6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Oct 2024 07:26:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=e+uzXEEXeAx0s4HQWed7JE0JG7x/SWQrc5fugIeMnIaLroepBCnSabpgxkJBEbF4xOzCe/BaaTaxOxv5PEhfmTQgXji+p586TjbhJpQOFYOeGu6tE8sodz2cCHXMcF3v+zGukfwdSXDFLINA0rePjRQx5mdDQ/V5wTuIiVNGRJQNjPaxCnFKdDRyBMbyKSAQpiMT3ghs7GPGoUbrbicihgPnoDYR9h0UUQrgwS0Tg6L2AR7aNUlvKEzIfDmZKR41Yz7WlQ92/yXHkpyN4B0QtlAucvRAPicdCwUcvqIONyd7DPwKildVqz6SdRZbw/OdiA/EaqUX8wOZdTbMjfLpNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LajDXgjGKUmEXMjlHU7MPH1l6wH9jp8lRs92jrvSPVo=; b=CQ0b+UfgOgq+UPcCEWVjjjQR8EWiaC5lkKknJmFaWJl7PeoWQdUaRltFfSqceFx/M4bDgqkyPCrj5Du1BweL4+VMgQgf8iNIJTwwKrYGWJ4OHKtU1MNjIQZkYJceThwL5NVhKNmYmmGejK+8gEMcYZareSQg9r5mAkcys3uzjB0XULM6iVcmsMaiZzSQN1/HUl2raA6XWnZ7NSPEIYQDJtRxPt2Q2Jy4FDZBQT7oX9czB0w7Dr20O+M5g/glyqnL7DZF2cmPix4AHns8JbLxRW+Hi53J6hW2g63wm2jlOear1LFwOF09K5vsOk2zwWcCye/Bqwock8D4DipkFtDUTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LajDXgjGKUmEXMjlHU7MPH1l6wH9jp8lRs92jrvSPVo=; b=XJKu+9iTiY5bZX837y8iueRflG+7KAcl6wYieCy34U71BnRmHIvG9QapNN3bNgVRoTP6gKpga02Om06W3nebLJQTUOq2jOVeM5+MOTrshkpOP2U+D0shJhSS2BFiInNfBtpvKSZkiyhvn4BWWlPYBajfYI6bll1FgYc9X/jJTe8= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by PH0PR10MB5628.namprd10.prod.outlook.com (2603:10b6:510:fb::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.18; Fri, 25 Oct 2024 07:26:54 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%6]) with mapi id 15.20.8093.014; Fri, 25 Oct 2024 07:26:54 +0000 Date: Fri, 25 Oct 2024 08:26:50 +0100 From: Lorenzo Stoakes To: Wei Yang Cc: akpm@linux-foundation.org, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org Subject: Re: [PATCH v2] mm/vma: the pgoff is correct if can_merge_right Message-ID: <631d0e29-1c32-46db-9074-c945713465e4@lucifer.local> References: <20241024093347.18057-1-richard.weiyang@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241024093347.18057-1-richard.weiyang@gmail.com> X-ClientProxiedBy: LO4P265CA0109.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c3::13) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|PH0PR10MB5628:EE_ X-MS-Office365-Filtering-Correlation-Id: bf577687-0964-4cf0-7830-08dcf4c66683 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Iz3fQhVLRJ5T4g98HLrmxHHCMSOZUmxbUfTBlBHhtk45g8gafFDhIzmvYzop?= =?us-ascii?Q?/HdXMuyPx5zJaAggBoDUbWnOg4HqffcKpx2K+NMMAu7ye3Pyucl78u7nlVmV?= =?us-ascii?Q?u+siXggYVOcGo/Po+5HGbqMWuouz3aCH7NPlL95VBWPCx6pcPe927qhwS6oO?= =?us-ascii?Q?LKD3a+2rs4xmPZgjyl8yaByo0LJAcwR1OCCYjRnJVBITPPKiNWa6MAwnDpk9?= =?us-ascii?Q?pjqxC+I/g/v36wBVfPxyHBU3gNem9n56cMul18ibyZsL54Ocr3PHRwnketR/?= =?us-ascii?Q?tMg2coq7SB3Y86QNAdnk/q75QxPbBG2Bgy0e2QyHVmFAle5n/UbZZZ+kquhr?= =?us-ascii?Q?wGV5oG8xHG652meSb6J2j4CBJd9YyvoTtBP5cEeCu9KGGRA3fnpAA5VFvPw5?= =?us-ascii?Q?5i9lwU9FmHlKl8nDRMwZRqLbO3b2D3gE8Ui8coTsGaMj3bQjT8nzd42q7DSJ?= =?us-ascii?Q?X2lcs32y3sFcSwiLi19eoioOpwh8jQ1OUjUkCZOtZwuk5tgLoPhPU6hmyckx?= =?us-ascii?Q?xhCO3JQu2LFX+PHGwl3A7K6CCDidCg1wBPoHrNvUx5R/rZwZIEHN0dpPHd4Q?= =?us-ascii?Q?Pa62xSVk0XS7gfTXAZCLBFKF4XUZIAeM5UTMWHvokco1EtINWqS3G/DNrcvp?= =?us-ascii?Q?CtLOuIzms/2KeuklawJ/QhN7CfagWAWobfak371aPN/cgRG4yjFIMrm2wsq+?= =?us-ascii?Q?pt+HHtv39oMN45G9dQxlh67j371TK3SlzsWRLu6xPyy/eW0YejU/zwhfrxlk?= =?us-ascii?Q?eZH4B05EVNSGLyf2tUyQDmLciO/J8n2V6iIPJo42gEfLtQYH73Kh8t0xGZoi?= =?us-ascii?Q?RkqdZ4wZWnbABgbrsnggawXWMtcMJE993eNmR6aNXTKj5TWXrt4Lcq6HTvlf?= =?us-ascii?Q?+RU23yel50fHLiQG6a6RABt48xoYqD6tuTqWBo+hkG8qA6TGl3mRVNS6PueC?= =?us-ascii?Q?NezUm2Slbnyr+Y7nFYUZKtKlaz9pryobdpe0JjfjyVPOvJVPmb9QWr9zndUn?= =?us-ascii?Q?eg7Jmc3CN0S/zAMxtuj/YRkXCxtjqEK/b3ka8hxJ5cj+tg1IbPMzhlVeKY7y?= =?us-ascii?Q?gKmM5758EU8ZuxYMRIJ5tRy5L3WcMTiPhANfBrwLigcvvtL3oqETajIxPrGm?= =?us-ascii?Q?RyfQTvPzIh1S0JjlpnsZh9IfCCPeCioxt3tZu0lcrZDmXsvfU++J1Gm2w6D9?= =?us-ascii?Q?G+RzlSfQYEPZ1bPd7/r1YQKptVn62YE7Pd0W7S26hV/e6KudGuuI0VZ0ZF6B?= =?us-ascii?Q?BK+R8Iwr0ODU1NgCLyc13nHxL+3Rf4rKye/YCrYKndhv+by72LpQEgphb1WC?= =?us-ascii?Q?H344uE+WqTotTpYkb2BlBrNZ?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?um0ZdEyliZSms+yKpQmpoCwWIFD59XYFWA+omgeGnvb+dbBeRn5z+qcl/n2w?= =?us-ascii?Q?gJUZh1vGU5LmlKwLWIekMX/tdDHU137lf891gD/T0kIzsYHHPCgerfipBXlm?= =?us-ascii?Q?AGS92h7TbTJIP/Y2XP6/jccP6+4s7vzoRUkQ2fMIcLJQ6lsuM1n6fT8n7Abj?= =?us-ascii?Q?BiABYCgswUj+SPxGP+TY2v7xmtwkfUxHawILfEXGyYfo/7VPomI4OoHwzhYe?= =?us-ascii?Q?ZJvgb2zjFkDKhveyowo/UE1TsNyffSq0kchAOlKI9HAhXZ7v0yWBqY88qqnP?= =?us-ascii?Q?g1zajk5+p7RpLdHJ8kKXqhbrE6YbMSyybGqErUEcoC9Ls9SpcNGgawp7wnsD?= =?us-ascii?Q?CY9HGkFqGRU8i5OEKUwb/30SkXI0X/TN3rtT8MhFldM4NIPKbJGpr/7Ggo+i?= =?us-ascii?Q?Ype4hDF4z/XYc938P6YcYlY9LcSTMRI9FjUZkTy6XDvoIVc/Z91VOwiL5Tbw?= =?us-ascii?Q?ZeYF3NbkkCaZTIgwbJzfS6LDM5iI+FxHKiqdyaYnZifmyxqXr4LMumjyCzWM?= =?us-ascii?Q?ZyXCjXPwvjhnxExma6mV6pjWFO2BHA4F9C0WDnfk9RA/DzkL0j7t4Omi7Fcn?= =?us-ascii?Q?F1MiBPOFydWNAz+k4eaqhKnj4kY/Mff8V5kRw1gLHNcu66slVSu0GyHyBpKK?= =?us-ascii?Q?vDC3WjhWI2iEhVJfsS6V1e1TdJVb0Pinu6S/hpDHEjozRteDIhAxMTG5/6J4?= =?us-ascii?Q?t/wJ7rs+2h8znnvf5z/GZ5V+nDQDm3xgoBsXfq2k73g7xgbvSnRV+3IawfiK?= =?us-ascii?Q?c0antayau8Qfvxj2TccoLmyQYXSJRU+LDcejdNQwlMCA+1lq948dcRDk3U4L?= =?us-ascii?Q?A9yQSpLDPunxOB0lSo+mDuZkBipPwH/F5Tkqi4QFZmQ6+7JofflptfZ5PlQc?= =?us-ascii?Q?1u+7NSsfvW/UHXh7qYFdiJNkv6jOjLUCvWGjoem735f43SUmU1Xr8K8ObomS?= =?us-ascii?Q?WIM6SBjiAYMXLWZtlE5bgR9qvkVw0dH4hQXX4/VV24iCWk+V5mBH54QUzms3?= =?us-ascii?Q?aLDLUyxJGOj8uBwBUnGi/PN20pyfIibKVEN5VJbzq1xWy+fKgphnt/mHBM5I?= =?us-ascii?Q?/IRrN/vq+13wvePdAD6yOyRPtClLFfBiESg4kdGYThZcCuFhkURHL4hpozQH?= =?us-ascii?Q?wY4dm4FHck4FdXZh+ODc5hM7YwKRAb0INl9cHAp8+J1S/rZh0ITNBtG5tuG/?= =?us-ascii?Q?VS+k0gohW3VyS/oo6h98nmmpFuT1aqvFKW/MtyCCYt+gzz5bdoAfWsO+ST41?= =?us-ascii?Q?TJ0bNqhGKY2AHbKN86p/8q6JqZ9HX3OpENjXE54aT8ACYYprTCwCGfefuO38?= =?us-ascii?Q?eEc4TRKkYSq+bFc3Z66WM+3w3s7Y76VYtAGkwGRR8/bMLda4+g17Og3PPe1w?= =?us-ascii?Q?0v7/iVI7TGbd5342DV4mfv11uZzVoYpbPjYCge98SssCQPCQS7wRIPZxG7dO?= =?us-ascii?Q?h6ox/CjQM5NUNSRzJWk5kQhlEZNOR7AXBWv5WM1CVjj5BZ6cltxeqwwxKtMp?= =?us-ascii?Q?Wr2QO/4NmZf7fb/3v2psiUHLz+djvDLJSWKiXLnWgTTr/ydzqNX5kdUYWdfC?= =?us-ascii?Q?U6HMARChlO76UPdFa/h6tZ+nzHUlhGvBP142dl1mTR0PHDvDmjvlBI2pPQAK?= =?us-ascii?Q?Qg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: F9+jqx6M4S16nqbRbWvcX1VAm4E3g2OwqbgtOycvKf/LrrfvK2s3CNFow80iwkRM/VEMeowH/ZLYHe6v4GYOQer6E79SRmSuomlIDD31E+tFXT+1bftH2QB6oc1Xdbpeex+EQxNOGr7o+Qm8GMfCLa/lfxpwvnG37ahWBxpTpa4wV5eWTdW32Ono56YSvHDEnT4ojet5zp91BVlykOxN85ClGqwRuoEYVNN7zrnrnMkTunZj9y4rNmpZeE9kvsu7yMeZ/KF+izGb420CxDcGoW+bJyR+QIIh3rkMLLERfSQ0PDgF6lBH9j+dvgdeJ5hudRrovLv2B+UowKhQnB4VQPIceaLnDQv7Q/xnNpSmoRR+8fMrtqSSwz/gmRNJj3Vqp6R2HpE2qC+lLANvBi6uMjhztwGg4/GGa1sadfghMIpqTNJmhOxejWGJbLscFTvYbM7CNspV5aRS/lC+5jVrKdGvgK9VQ1BuxZXk9zm9EeVqUXikI8UDKv26Gy2EGr9vwcBBjabKtfMU5LDaalGa88Wzmw5DoUKelR5hYEwbXKKBBpMUJm5PMq7wkX1mUTIFRO6Cmg1tYPoFmfxPGB8JEzn5Jari+SqyBdz7Z425xts= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf577687-0964-4cf0-7830-08dcf4c66683 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2024 07:26:54.1497 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F5nTHYK9J3baXBAbZhMb9E5UOKNmhb00xFv13TEqjt8EMt8M8gQnvVnW1vNnszOZ1U0viYL1Z1CDARCW8neCzicUrPHR3B59oHyuv3fIrVI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5628 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-25_06,2024-10-25_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 malwarescore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410250053 X-Proofpoint-ORIG-GUID: gyLSV2AlrqiCnjNhD96Tsb37ZPprM7eG X-Proofpoint-GUID: gyLSV2AlrqiCnjNhD96Tsb37ZPprM7eG X-Rspam-User: X-Rspamd-Queue-Id: 38CD540018 X-Rspamd-Server: rspam01 X-Stat-Signature: oay4ewuo1uanq9gpkf5aq1djjggxckoh X-HE-Tag: 1729841205-426436 X-HE-Meta: U2FsdGVkX19PukZfTRwhR+NWLPL9BPVvIEgkKeC/5kJK90Wxm+ktQT+ujf+pVQNzXzj1fj4fY8AAVnydzC6lVruKX4ZvwUYkdXBcIrRq/GwdD0YuyuuWTkFPWeP7i0llTH2HZMzb8It/sK+8XmwNlGk90kZBkZuHKb45CUdYli51Mvk4+1/dE31Aemn1sV5POvbw/nl1dQk1i6Jc8g0kxqgw2NQllPcmzu/cA5pkBKmzk8Vyk3PxA2EquMk6cbpZdag+wrXwU1aeKU/feBhtbddHxBPc27NIPA09eB7eyG78RIyyk1wtuO8wr5r5Kf1mucgTCiFzq39/fvN3vACEPYtzvgzqb6JEpc+md9Zqd15pF/U+DId8omKVHHwvTSg8JLQ40Xy/qKliroJCSZgwpUJt8hzr3JmdaxgSLWs+LYXcY3DM3zjnOKIZB9g6X+SSsHmCYXeIf/0nI82UDSGzfqkoYBBhz7ejSYqOSZRE/qPNEdflS2jY5D4n6++v7jkdXDYv9/FrBIwbFgR2yfCjbfK933geoEW7Jtgf95oKtoc8bqeAc+/bUh3fUboLtCjG7DKK3iaSXyKmcUH1VcvNpI+BYe9Uyte150gyUautHgIR1+ag8NxtKP5qkpchaTxpV55eoOLsA2QAGo5RfM1AAxS3JGImDlg2KgbVfFRu8sAr76QOoOVR4LJ9S/D5BkaqS9Zoozd5bZ26uBGm2E3SMwX/rg0JX2bVMAjluYAV3Xe43a2CdcH2DFfYOF+45cnm9stmtIuR5xjI8WKnapxtJgCsPaffNJ3JupqF14zAfdxlm/irHN0Mquu8gRYb6/FKug91wh6x2JDpl4KOLsAxpTsd6/0OLxV8FsPIzfz1b/ytSRELWQV5GKt3aix5K4HnfRT+kf5msiFq0E6mWBJdN46gx92ENBFUV6c3zAZfv9rQQEcx+JQlyAiCPyM/t+4ADnNTvLEhR8eChJvRLMK UWZTiV5v KaeujPpT/kUUER9eKjHD0FCOSxDwCQpdzBMJy5tGjiw+lygGVp7rx6xgJ5tMAG9dfNtEKde4y/2wgw+EEBqrZNWG2bv0IoHf48LNhvTyDczEfcDK7exy+/P09+sLzVj+MXzU00KOF8xtlTl2Apo6A8fiwEeG8QJyTneiHB3Km6NsZ2xVHyArAkoFlXTeMD4BmLcWXyxk+ZL6FfLOsBU8endGRplVN73phuNVOKGQaoV9Ne7YhghtCNCGn+h9rYnv8z9iy4hdnsgYe2NzcTMNzcYPOWuPu/aGXIVfgTX4JdSj7qGFsLS00NE9rziXe1EHDkZNpzOpFEul8kiRQCcFhXBFEILu3f9Hu5nqp23XL9xvQ8KWvY48DSaSVTdGPjCty0hKGQCPEt9omeeUt7FRk5sYWf/bB2/DwOafFSNVvFhpnm4E68eHzbA3jyGTmGPc3+OiXmPJEqRTYY1X7dQREUCAvzZWsYsYmvNsqGdW1rqgs7u1l3YBydXQQpMTfrzW+dpJhynholpL/nxJN7Hq1uH8up0AzuO4s/ozn17zmD/OjhV9KY4NBQkE2J/L/apVnIfbmZTwP0lZ+ockOAaloSIhST6drgl7FvF4k91UDBgkrpBPQ7R5C2R4tZo4YHK1eDzV/7nlAZJo//2MAKwXKI2Edew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 24, 2024 at 09:33:47AM +0000, Wei Yang wrote: > By this point can_vma_merge_right() must have returned true, which implies > can_vma_merge_before() also returned true, which already asserts that the > pgoff is as expected for a merge with the following VMA, thus this > assignment is redundant. > > Below is a more detail explanation. > > Current definition of can_vma_merge_right() is: > > static bool can_vma_merge_right(struct vma_merge_struct *vmg, > bool can_merge_left) > { > if (!vmg->next || vmg->end != vmg->next->vm_start || > !can_vma_merge_before(vmg)) > return false; > ... > } > > And: > > static bool can_vma_merge_before(struct vma_merge_struct *vmg) > { > pgoff_t pglen = PHYS_PFN(vmg->end - vmg->start); > ... > if (vmg->next->vm_pgoff == vmg->pgoff + pglen) > return true; > ... > } > > Which implies vmg->pgoff == vmg->next->vm_pgoff - pglen. > > None of these values are changed between the check and prior assignment, > so this was an entirely redundant assignment. > > [lorenzo: rephrase the change log] Thanks for this, LGTM! > > Signed-off-by: Wei Yang > CC: Lorenzo Stoakes > Reviewed-by: Lorenzo Stoakes > > --- > v2: rephrase the change log per Lorenzo's suggestion. > --- > mm/vma.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/vma.c b/mm/vma.c > index 4737afcb064c..fb4f1863f88e 100644 > --- a/mm/vma.c > +++ b/mm/vma.c > @@ -915,7 +915,6 @@ struct vm_area_struct *vma_merge_new_range(struct vma_merge_struct *vmg) > unsigned long start = vmg->start; > unsigned long end = vmg->end; > pgoff_t pgoff = vmg->pgoff; > - pgoff_t pglen = PHYS_PFN(end - start); > bool can_merge_left, can_merge_right; > > mmap_assert_write_locked(vmg->mm); > @@ -936,7 +935,6 @@ struct vm_area_struct *vma_merge_new_range(struct vma_merge_struct *vmg) > if (can_merge_right) { > vmg->end = next->vm_end; > vmg->vma = next; > - vmg->pgoff = next->vm_pgoff - pglen; > } > > /* If we can merge with the previous VMA, adjust vmg accordingly. */ > -- > 2.34.1 > >