From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4A75C00140 for ; Wed, 24 Aug 2022 12:52:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DDA9940008; Wed, 24 Aug 2022 08:52:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48CDE940007; Wed, 24 Aug 2022 08:52:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 354EC940008; Wed, 24 Aug 2022 08:52:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2615F940007 for ; Wed, 24 Aug 2022 08:52:34 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F33B6A0252 for ; Wed, 24 Aug 2022 12:52:33 +0000 (UTC) X-FDA: 79834474986.27.7FE96D9 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf27.hostedemail.com (Postfix) with ESMTP id 9AF574004C for ; Wed, 24 Aug 2022 12:52:33 +0000 (UTC) Received: by mail-pl1-f180.google.com with SMTP id p13so4215053pld.6 for ; Wed, 24 Aug 2022 05:52:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc; bh=5O3gTjJ6ltESJu4SxsjjXpoC0Bt2krGALe8GcvjbeUE=; b=HLYiwRQ+t6O0/pYgS00yvAvHCwRFVdo5Tb7FTroITP/O4/ldOnAGfw3FMlDbjrBst4 ARZwHKGk4FGWj8W9KD5X42N944kctOYpeyG/i2skmEaP3OMNLANHai7aZcibKMMBY/gt 7Afw0AI33uxnlUL4D5M/ZS8WFyZ6E/K4Nz1esGkHMR3CevDpFUuzQCWEVwP8HmttbASA +lEoAVulQhISYuNDz+lgYXEZfrjivRMSa4Ka2G6e8jvBkYAztdgPg2yhr9mwlD3hSzXG JM+v7o6OM4gHovO3ksIs9Bs7F233hJJ2WKdrzOsBdMS68ZENGLf8W+0gFJ8TXib81Y2i zLSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc; bh=5O3gTjJ6ltESJu4SxsjjXpoC0Bt2krGALe8GcvjbeUE=; b=pYA+wv6h0Gv7yFl4KDURFF7VhIKT750gB48LAcowgctO4oy4a8WHEhi6POlHDQGclv Lim27g53alfpWBXMBbDamW7JjE9vC+W1KpomV5rU+ashTFGxI8UfM8Km1OUvo59u8mNl CDhwYT2ouCdyzxkbABQ+iJA+Tj2gZFgzlsfcoLUIIgcs2kwvKIN0BcYTx6yKogSmMwLl nwmAGOFrRqssY820R72SgyDW+DmqqYLIVG3jnZidzqPXJX/6gcnfd2PvkcsibkyWKN+U Bt68CucvraP1V2YI788MZm0HzGMEiyLs5HrWZ5zPVV6AMKp7+dgVVvMDka6G0ltDIMVW WASw== X-Gm-Message-State: ACgBeo1xaJzpRHo1Z8i3m0yQXwc31UTxdl6dzfqgv7btYjeZ/cEgOlKN 8bUgW3hk95qWw82vC9pneAs= X-Google-Smtp-Source: AA6agR7VeoI9bAfrXnsrK3q8Q/YUUr4MtVN8Zgon5ypoNWyE7BzC1S5bW/PptzbL6/wjOHzZVB1k2Q== X-Received: by 2002:a17:902:bf06:b0:172:cf73:df43 with SMTP id bi6-20020a170902bf0600b00172cf73df43mr20369846plb.13.1661345552656; Wed, 24 Aug 2022 05:52:32 -0700 (PDT) Received: from localhost ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id z24-20020aa79f98000000b0053627e0e860sm10190811pfr.27.2022.08.24.05.52.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Aug 2022 05:52:32 -0700 (PDT) Message-ID: <63061f10.a70a0220.a807f.203f@mx.google.com> X-Google-Original-Message-ID: <20220824125231.GA223481@cgel.zte@gmail.com> Date: Wed, 24 Aug 2022 12:52:31 +0000 From: CGEL To: Bagas Sanjaya Cc: akpm@linux-foundation.org, corbet@lwn.net, adobriyan@gmail.com, willy@infradead.org, hughd@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, xu xin , Xiaokai Ran , Yang Yang Subject: Re: [PATCH v3 2/2] ksm: add profit monitoring documentation References: <20220824070559.219977-1-xu.xin16@zte.com.cn> <20220824070821.220092-1-xu.xin16@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661345553; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5O3gTjJ6ltESJu4SxsjjXpoC0Bt2krGALe8GcvjbeUE=; b=si1VjqW0G+Xr3kZemfKKcakxhy2ssBDSbFMJGc7fIRmbEMvpyDCeejPKRlXi1frlSrJIOM NlsK0zfeG+F83uRE2YooUTHKNPFv5yBd4t0jdA6SCmz8NWrozIcNXs8l6pVls8/dWmv65f LudtgE+0S60ES1LMvlHsyxkgL2nbt2w= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HLYiwRQ+; spf=pass (imf27.hostedemail.com: domain of cgel.zte@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=cgel.zte@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661345553; a=rsa-sha256; cv=none; b=iC6WTiEnQoYoT+P7Ih6dkl+elHTfaSDoeDVMD9KVxJ987xYLaMO1Kgfvl7gSPzpovjjMF6 X4EiU2jFExolOqNROoeaWwkvvakAfEgVP09lxwYY7P5ZoKfXtoDFpS9lWbA7JvESUigaZz 6sbdo5k/UBTF3UeE2YcryHepd5ps2tM= X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HLYiwRQ+; spf=pass (imf27.hostedemail.com: domain of cgel.zte@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=cgel.zte@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9AF574004C X-Stat-Signature: orj86n9xd1i4msnm9x1yyf91rsmbxbac X-HE-Tag: 1661345553-2232 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 24, 2022 at 04:38:26PM +0700, Bagas Sanjaya wrote: > On Wed, Aug 24, 2022 at 07:08:21AM +0000, xu xin wrote: > > +1) How to determine whether KSM save memory or consume memory in system-wide > > +range? Here is a simple approximate calculation for reference: > > + > > + general_profit =~ pages_sharing * sizeof(page) - (all_rmap_items) * > > + sizeof(rmap_item); > > + > > +where all_rmap_items can be easily obtained by summing ``pages_sharing``, > > +``pages_shared``, ``pages_unshared`` and ``pages_volatile``. > > + > > +2) The KSM profit inner a single process can be similarly obtained by the > > +following approximate calculation: > > + > > + process_profit =~ ksm_merging_sharing * sizeof(page) - > > + ksm_rmp_items * sizeof(rmap_item). > > + > > The profit formula above can be put into code blocks. Also, align the > numbered list texts, like: Thank you for corrections, done. > > ---- >8 ---- > > diff --git a/Documentation/admin-guide/mm/ksm.rst b/Documentation/admin-guide/mm/ksm.rst > index 40bc11f6fa15fa..7e3092fe407e37 100644 > --- a/Documentation/admin-guide/mm/ksm.rst > +++ b/Documentation/admin-guide/mm/ksm.rst > @@ -194,22 +194,22 @@ be merged, but some may not be abled to be merged after being checked > several times, which are unprofitable memory consumed. > > 1) How to determine whether KSM save memory or consume memory in system-wide > -range? Here is a simple approximate calculation for reference: > + range? Here is a simple approximate calculation for reference:: > > general_profit =~ pages_sharing * sizeof(page) - (all_rmap_items) * > sizeof(rmap_item); > > -where all_rmap_items can be easily obtained by summing ``pages_sharing``, > -``pages_shared``, ``pages_unshared`` and ``pages_volatile``. > + where all_rmap_items can be easily obtained by summing ``pages_sharing``, > + ``pages_shared``, ``pages_unshared`` and ``pages_volatile``. > > 2) The KSM profit inner a single process can be similarly obtained by the > -following approximate calculation: > + following approximate calculation:: > > process_profit =~ ksm_merging_sharing * sizeof(page) - > ksm_rmp_items * sizeof(rmap_item). > > -where both ksm_merging_sharing and ksm_rmp_items are shown under the directory > -``/proc//``. > + where both ksm_merging_sharing and ksm_rmp_items are shown under the > + directory ``/proc//``. > > From the perspective of application, a high ratio of ``ksm_rmp_items`` to > ``ksm_merging_sharing`` means a bad madvise-applied policy, so developers or > > Thanks. > > -- > An old man doll... just what I always wanted! - Clara