From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10A07C0015E for ; Mon, 24 Jul 2023 09:44:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 770778E0002; Mon, 24 Jul 2023 05:44:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 720CA6B0075; Mon, 24 Jul 2023 05:44:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60F638E0002; Mon, 24 Jul 2023 05:44:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4B0B66B0071 for ; Mon, 24 Jul 2023 05:44:34 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 13E0B160A16 for ; Mon, 24 Jul 2023 09:44:34 +0000 (UTC) X-FDA: 81046020468.09.FDAB297 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 300E71C0023 for ; Mon, 24 Jul 2023 09:44:32 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UUtOQjkU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690191872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lcc0VwYrlT1E7PEgvFDL6PneMWy9XGB7K8wngN/IhDY=; b=H3J31Gu5yTnCwsp0gXtPbRbLLmOLe7AUpmM0lXKgIarVP7N3c3NtIraQxqb6meiprmhx0p r+8bNFEChmVvyeJG4MSFlZKI/ZYjVMQLdPSCe/hDkQI4nFYGymPijDK/6g8h9hPliZsz1s 1ErxtGSLnb1RF8ZeKxRjMN3kXRHvUh4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UUtOQjkU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690191872; a=rsa-sha256; cv=none; b=0s145WraF+h9IMqSCjHRmEKAU3WLog3i2wWkIf3/2/Vk3Yey/wabGQbQr43LV6I7lhzRUH vKJlH0ipLXS5BS/AbKjA7646GrbJZ5FzgcEJc6pv6zS8H9yZNQwF9rUncSJdc/GzGPZEo3 guc1le8PqK15gTuvt8MMs7K4ybHM1IU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690191871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lcc0VwYrlT1E7PEgvFDL6PneMWy9XGB7K8wngN/IhDY=; b=UUtOQjkUPPCrL+16AX2FWjWs5aRm1kx9iGWa5UnEbpJpk08fCkC7ARh7GR0ne8SEuvwGs6 WaJEOLuVuxg68UiW2SO4FpU095lWqDd8NVVbW5C/1Jtqnt2tzYuHssFGlnm6FAAzFr+dxU IYgwG46lKX1tiMKlxCvNBU0fed+HUN8= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-474-zUuadyWlPVCQ0U_JCQHkbQ-1; Mon, 24 Jul 2023 05:44:27 -0400 X-MC-Unique: zUuadyWlPVCQ0U_JCQHkbQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1E1493806703; Mon, 24 Jul 2023 09:44:27 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.116]) by smtp.corp.redhat.com (Postfix) with ESMTP id 734FE1121315; Mon, 24 Jul 2023 09:44:25 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230629155433.4170837-1-dhowells@redhat.com> <20230629155433.4170837-2-dhowells@redhat.com> To: Linus Torvalds Cc: dhowells@redhat.com, Matthew Wilcox , Miklos Szeredi , Matt Whitlock , netdev@vger.kernel.org, Dave Chinner , Jens Axboe , linux-fsdevel@kvack.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-fsdevel@vger.kernel.org Subject: Re: [RFC PATCH 1/4] splice: Fix corruption of spliced data after splice() returns MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <63040.1690191864.1@warthog.procyon.org.uk> Date: Mon, 24 Jul 2023 10:44:24 +0100 Message-ID: <63041.1690191864@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Rspamd-Queue-Id: 300E71C0023 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: mozzk6b5ff1bpf9eqzxd6earux1cq51z X-HE-Tag: 1690191872-470805 X-HE-Meta: U2FsdGVkX18MnwZuS5nbZwDxdWbZimIOk0jsE9gS3ULMgEqEGpV1CPkzJDVwK5j7e/vQ+FAlMigvDuCoFvIKQLE+v6/FxMiuNRu2dxq/Zj1I65klJjCvzNqsB3HwrxcKs8cgqICgPB7zqN1gn5suImYrLwLOok5FTabrdCyvl0Z3g8VvDrraIYpwsWb0wpaVN1dQ4bxjKCzBT8YdHAaRNKTMAqyvaHAjgadf933XM6Qr6cp5UIQaChDIoOX11CkZlj8I7jW2X+9klJ4h7Pcv3pKimvm4uBhXD+1OWLtgF07eNQphQZ5KBHz3AEYfqk27DwkSgaILj+3fUZ8mQyGWRFCe0vxsGCG+rYsQy5T2lR31fselcqsbmVjb9JRtPpPXvg0LoW2CKTcSz1cNsqp7io1McfSZu7RK9MoIIVxqSuQKLX/S61l3eRapf0oXeYe4miEauE07zFybJNHVVo39kiDs2Jjum1H8HkE+cEE8M2xn6djZ0b/dzirmkV1Z4PdBt0sIRYL1yZy20QsU1WW5gm+cngH1vj3a/hTAzYfde5vOOJ6yJNT/KKAZb5tTMooHkOO9Fbz88f6A2PFUN/kUp/eV2kXBnoQuYarslK6ryxE27kghv7cZ1pcqH9b4emVF2XQSg3/fFqTLDECxxbqY1HJJLdfiHXh3KO2lOv22yFONYU/wloI3MHz6jVT+IcHDeqZjHqchmVzCTucQrmoVT2xg5ZDDia7o4LodY8lnD8Tyz7AQS03knAV33Wru1U0hRw2JVnZYB3Irt9C159/RND59e98IOoDOHQ5gRWUCpL8Scwk498HTR1N+vbhEmtIW04dNAgqkUQLNxeZpuT124kWGKMUgMdfKS4mIDZt6UmjDXE09dEFcqFGVUWq2KMPaw1jNqYe4B+vH2DoHirSkiDUTBWTNSd9739PWdtWAe0HTAn6rcFTlnAzoaKYU05TgUeedMAr21BYK2cRDgkw zyMmyCsK z9TV0m8kBit3keofWBaLg7aA+kqO5KSA77tgwuV3yxOYubVRijD2BArTZmA21xuRlyN4n2NhBGOtb/6/yZI2KXL/voKjrvB3oV74vr7XPLjzfZSMU/GV67VvdioyMBrqgugtSVPg8gvK9/kFLA9872qV01qUphZdfjPfcNkPSOWXZELRnj34Ugrd1XHoDPPzo40AIJzL7/KakeUKixuYff7SY8A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Linus Torvalds wrote: > > So what's the API that provides the semantics of _copying_? > > It's called "read()" and "write()". What about copy_file_range()? That seems to fall back to splicing if not directly implemented by the filesystem. It looks like the manpage for that needs updating too - or should that actually copy? David