From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 771F9C19F32 for ; Wed, 5 Mar 2025 19:48:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 94E3428000F; Wed, 5 Mar 2025 14:48:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FC4F28000A; Wed, 5 Mar 2025 14:48:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 752A428000F; Wed, 5 Mar 2025 14:48:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 55C8D28000A for ; Wed, 5 Mar 2025 14:48:05 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6F84F160A7C for ; Wed, 5 Mar 2025 19:48:05 +0000 (UTC) X-FDA: 83188533330.13.E59513F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 16B15A000A for ; Wed, 5 Mar 2025 19:48:02 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JAYKCEAE; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741204083; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eGWydqnoXIhCLQqdot4fyHdmsRNksb4I77lqc7a9rY0=; b=VewrfGP+D4GLnOuujoht41Swa/EP630nh9EFUT35XEBWO8/u20zHJ/ycrd/iOru+OHT2QW yFiYfATgApsaXt+VtJjNk0Jv3p3c1lcZBXLjPPUaWNnNy0DCDn8QBCEPUynSxuKYJrMmc2 oZBN1W2++qIS8b7RPqZ+iHg57hlT4H0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741204083; a=rsa-sha256; cv=none; b=sP49tHksiZk0nq233+42pffhmzLypKw/ZJ3AGQerYqiuEtGYvY5a9OHn0TbnTTx8pnW0oK fKTW72c4rwQ9Q8FFc6Z3QjQeUYxqi5Vg9zRaIWuXZDUSL5afqwO1bQGgu+U/dhrd5Fb5TT loRIWDWh+P1BiOpjwki9QqzxYtN+AWg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JAYKCEAE; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741204082; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eGWydqnoXIhCLQqdot4fyHdmsRNksb4I77lqc7a9rY0=; b=JAYKCEAEYv9Ox5U2BzFPuQeXoSYfoWRsMdgT6K7hvcjYEY97hFhhYSaIRilkicNy2n3vHf xVHVl2O9NnXnbfXrt7yMWEPs17VOj0srS3e8W23Kd04aFBUR8bsL9qbF0lJs4H3mHhh3fQ SEFpFT+oKH4iAjGsLri8kfnJz/JlZN0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-396-uho8Gb0QN6yFzPXALQC7tw-1; Wed, 05 Mar 2025 14:47:56 -0500 X-MC-Unique: uho8Gb0QN6yFzPXALQC7tw-1 X-Mimecast-MFC-AGG-ID: uho8Gb0QN6yFzPXALQC7tw_1741204075 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43bd92233acso4656805e9.1 for ; Wed, 05 Mar 2025 11:47:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741204075; x=1741808875; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=eGWydqnoXIhCLQqdot4fyHdmsRNksb4I77lqc7a9rY0=; b=eeBXmySN1u/ZOKWhLC6XnUxt0ml94n3/yi0OBtCXn/KWelwkavmfV0tlDoWCd3aZBb vyBc6BW/eeJenRTLKUzc/ZZFzckQli8kUToEet3p+nUgGartQcJJiw9R3JmUXI0Yq9iN 2Qkc99eRvmySKdXNiIG0XqpRTZsrKB0tKnkXBsJyGXEQC0j3VfqZG7kABinJ4HsVpf7Z ExcMglJNVnI0N0KLXgk9/y82G+fLN96txzhkLLQyWXehqkFia6ThzRpNq2IsSuB5nSdo X4gvF86Tpn72v4AXpvPYPJm8l0pM5kIHe3YYj3qnxmzH2NDOc3fSy7yRzYbROvJLd4kA HDPQ== X-Forwarded-Encrypted: i=1; AJvYcCVQbRXy9CBbfcuOOjj58Y4e13pVDzU+9wOgbS/jFINTn8zcHgcOrjiZH2nl4zKblL5e27RnaYgi3g==@kvack.org X-Gm-Message-State: AOJu0YyncShttImeO7UkwyNhemjHjOe/Y09fjPVao67s2sqNRkInX7Kk md3SROvwEZ1nmu+sfA9YpRVI5wgjtxvzORlTXdL3iS+AtPi8cBtIpx6tG1KAgXlQy1drPcbJpSk qCcOCzw7qNpdByIF+RtpwYchwhiTu6Je7kjGOQL8nAg7RCya0 X-Gm-Gg: ASbGncuIiB86YInB6fioeoj7KjaEIdREmTI83FfY3qsp5uwfYNNEudLGos+dVF1kTS5 9WZxcUEU5VPNeNsPMvFHgvhflpOR4GYUDidqebnvxVr0aDl9JNlJW7r10ISvn+RZ/VhhupFEon1 f2XwJq+Nd4zL3axMYvitLMyUWO37PQaE2x67BYZqiNcsd9c6KJu2ocTYGb16q0siMG6siSQ4eVV 8WzlFy/L+SpYF4nbw+gvRUmezCIO5N9PHS7nsOG6jh8fJMNi2Fwpcr+ccto1Wk/kOSVI8Lqtwqp aJDl8JHPLDrgfEYshQUMxrnhxyxYbWMiS9b1vdU1xWlcpjYUAn4YY4K/9ivgGSbvn379SGabr7T le+9lsMvVJx0hGNrYgL9bn2rvb00bL60c1UKlpnTWZPo= X-Received: by 2002:a7b:ca48:0:b0:43b:d6ec:3d57 with SMTP id 5b1f17b1804b1-43bd6ec3de3mr31096875e9.15.1741204075050; Wed, 05 Mar 2025 11:47:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IE0XZGZCIlmOlRS0LbFcH+/JVJl+ID+X2yGng1e5xV1yy07EP7WWTcYimXXucuhZJRVuD//ew== X-Received: by 2002:a7b:ca48:0:b0:43b:d6ec:3d57 with SMTP id 5b1f17b1804b1-43bd6ec3de3mr31096645e9.15.1741204074608; Wed, 05 Mar 2025 11:47:54 -0800 (PST) Received: from ?IPV6:2003:cb:c739:5b00:84f2:50f3:bdc8:d500? (p200300cbc7395b0084f250f3bdc8d500.dip0.t-ipconnect.de. [2003:cb:c739:5b00:84f2:50f3:bdc8:d500]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43bd426d34csm27332645e9.5.2025.03.05.11.47.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Mar 2025 11:47:54 -0800 (PST) Message-ID: <62f93f79-a8d4-44a5-b276-3ac5af4ab25c@redhat.com> Date: Wed, 5 Mar 2025 20:47:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next v1 0/3] kernel/events/uprobes: uprobe_write_opcode() rewrite To: Andrii Nakryiko , Oleg Nesterov Cc: Andrii Nakryiko , Jiri Olsa , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrew Morton , Matthew Wilcox , Russell King , Masami Hiramatsu , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Ian Rogers , Adrian Hunter , "Liang, Kan" , Tong Tiangen References: <20250304154846.1937958-1-david@redhat.com> <20250305152055.GB28112@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -kEZkXyvlnL0OKQhhNZ_w_v2ftRZqK3Qvw4KL3nDc80_1741204075 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 16B15A000A X-Stat-Signature: 1nku5ew667hjjehd6u9w4i74k44barmr X-HE-Tag: 1741204082-896607 X-HE-Meta: U2FsdGVkX18N61OkgtX48ZRyeMPweN/s2PbruLUHz8Yd3fdLq2j6UblrgvkNqq3adJVyQxUinltNfC4OAEXWFqxY9oTxzu2xo80Qga00xaEepia5XrhVRvCXQSm3zPsTCKTlt7v2qVnJbnpuaQuRjeDj2ROggsKLbaAQd8aI8cSynMSmodDhZ4nS7lUgW2JmWcGfRnQbTr8EW+Le7HQcdCnqK0sYIdrCDTY2Rd8Wr20WFb70cKslmeH5g8Ac1M0sJpvjnexKRJuag8RbHMXxePjbI0iL449iFO8tf993IMtcLRaOh4/DmnPKli7g7fXvhIaRs2JxY0GcPiDHw/jQOYhlfEsVb/TOdKKlMXikP/OdMUlMAxCPhlDSVUhqT/7WHwf7t0RGbXd+qGy4QzuBGJV0r25OE0OsqCqKT27TqiMRkFf0u098Gru9wRT0Mw9l5DARfB7ALClwf479AdjyxQJNOuCjL4Amyqn4wlmpShHnjk1BmJp+8PJ9+QaXg00BDMWroQ/C6tXl2ujsNC0ZIG16i16H4wSBHcZuT3mNzdbOmHCTTNqB7PyyL2wbTK1Oj+bK92zOq1N6BsinjkLT1B5uqSV/b9hKufHJsZOxxERBQVy2b1NbgV0qvKvvuf7mvvFqphw+Dpc/3JwSx341wyXHZ2MshEvEIQaLfB/g0485BNcFaA5Bgs+Cl14BZNApcibALczKZMcX87A9zgfzIUqxtvJzqKam2zqTGCZQ4F7QGvBshf5Wrc+OgqFxFqJMdzpgUaEt9fO8OFRxrYugrTLNr8cQf3aqKzIP4P37vkOLk4eUFft+Y2AB8cl8veo7sSJLcoXOobhsI19Ab98SzbTkwobR92g8/322ro48TRsjFrVvVN/PtjL0M/x5oV06dK5MvsuhBwQSU5HCipj6NqBYdBGX77RIAxbVRQncdVt6i6HjmGn3feb1jTkMvjYmXFJS9Oqkliav077Gw/W +bnyS4Pj NIJv845EkrA2wXreZ0349BYAiXVuAB3dFAJFeX1TTgYjc76dAucVUNNdutqa1YluH4tzhyE7pRF7vErzGt/Gt17oh35ceP2w1C6+hBa0eQ0aPmXa7RYtEeqbMmMb+HqIwFB3taJydHWHgmdI2jESXxXFj1bGuMqBPmg4gRR8Qsws+rctXi8aHrN5ltLp1D9zdSFYh9hRVXf60ri4MOEfSkCagpE2jyTPBRopLawdcT+KKzc2oAvXzDNUpyi9Im7vi53efwQE9K83ns3kRvU/A+1iOgMLy6tWg2ZdZVJrMsZvqsD2BhyKoPCYLSbwmJMAx+8bg8236i2jW6hTyhAga+eULmN3XIMvoFA9FQ4i+cxwQZEpeNL/ysYf+K2h+sfMne3v2hmMV0GZuHnCZdU7i5nTSEhL9u9COMdiG0XRFWP/f795QVsiBh4fRCQ4iSV79V79UazAHHHwN7lFmjQ0dltJ3fhkWRudNhyZXcft6pbbP6LGY9V7Qfbf9shhZgO0jDJyiWRjSIVzNeSFw3MF7YzDoLFKivu+utdMKBWIvpBIq2HdlDHPSastIa+8RIOi/qGs0OtWhJbUDBoc5HLxdPx+tKhZj/DbGRWEYgzh5euEvSKx6dRqPDimeV/QytqQEy8ZF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.03.25 20:43, Andrii Nakryiko wrote: > On Wed, Mar 5, 2025 at 7:22 AM Oleg Nesterov wrote: >> >> On 03/04, David Hildenbrand wrote: >>> >>> Currently, uprobe_write_opcode() implements COW-breaking manually, which is >>> really far from ideal. >> >> To say at least ;) >> >> David, thanks for doing this. I'll try to read 3/3 tomorrow, but I don't >> think I can really help. Let me repeat, this code was written many years >> ago, I forgot everything, and today my understanding of mm/ is very poor. >> But I'll try anyway. >> >>> Are there any uprobe tests / benchmarks that are worth running? >> >> All I know about uprobe tests is that bpf people run a lot of tests which >> use uprobes. >> >> Andrii, Jiri, what you advise? >> > > We do have a bunch of tests within BPF selftests: > > cd tools/testing/selftest/bpf && make -j$(nproc) && sudo ./test_progs -t uprobe I stumbled over them, but was so far not successful in building them in my test VM (did not try too hard, though). Will try harder now that I know that it actually tests uprobe properly :) > > I also built an uprobe-stress tool to validate uprobe optimizations I > was doing, this one is the most stand-alone thing to use for testing, > please consider checking that. You can find it at [0], and see also > [1] and [2] where I was helping Peter to build it from sources, so > that might be useful for you as well, if you run into problems with > building. Running something like `sudo ./uprobe-stress -a10 -t5 -m5 > -f3` would hammer on this quite a bit. Thanks, I'll play with that as well. > > I'm just about to leave on a short vacation, so won't have time to go > over patches, but I plan to look at them when I'm back next week. > > [0] https://github.com/libbpf/libbpf-bootstrap/tree/uprobe-stress > [1] https://lore.kernel.org/linux-trace-kernel/CAEf4BzZ+ygwfk8FKn5AS_Ny=igvGcFzdDLE2FjcvwjCKazEWMA@mail.gmail.com/ > [2] https://lore.kernel.org/linux-trace-kernel/CAEf4BzZqKCR-EQz6LTi-YvFY4RnYb_NnQXtwgZCv6aUo7gjkHg@mail.gmail.com > >> Oleg. >> > -- Cheers, David / dhildenb