From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05681C04A68 for ; Tue, 26 Jul 2022 17:46:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 351F88E0002; Tue, 26 Jul 2022 13:46:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 301738E0001; Tue, 26 Jul 2022 13:46:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C92E8E0002; Tue, 26 Jul 2022 13:46:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0BC708E0001 for ; Tue, 26 Jul 2022 13:46:34 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D856D1C6C7E for ; Tue, 26 Jul 2022 17:46:33 +0000 (UTC) X-FDA: 79729980666.11.8A074F4 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf05.hostedemail.com (Postfix) with ESMTP id 8289B100090 for ; Tue, 26 Jul 2022 17:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658857591; x=1690393591; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Jfn73eb1NtC5hyzz5MoImvxl+iN6nGyp06TBHbGvRKk=; b=FwoGy1xoiQMnat0MtocACLW0mY/W9OvX5WbEy5Vz+GBLiy4uxhYxulLF emsmftnE/OoCTVhl1iiwBHLnhT5GQtTN5c6Q/88Oq2dGBjQ8TVfGCJfiD syPDBgt3oab/oJBESzmNz1chN7U8ShQW4CyhTP02aAS7a3ICz4VaJoIsV Ilpbfjtgr0b6rCO3RfE5kQ4EbXYzct0trj0fDS/AgHoYxk77Br+Hh89v8 9NvgT6meIIQbSB/a61SSp6z48UVJbzztCLDFQlwb4n+J9DvMMCTjKfDc0 yf7d3+qXXr8HfnhR6nMzM0atxn/yrnHA/v6RGgh4j4tNEjo7fPQbItKE1 Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10420"; a="268403619" X-IronPort-AV: E=Sophos;i="5.93,194,1654585200"; d="scan'208";a="268403619" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2022 10:46:29 -0700 X-IronPort-AV: E=Sophos;i="5.93,194,1654585200"; d="scan'208";a="658790289" Received: from mcrowelx-mobl.amr.corp.intel.com (HELO [10.255.229.9]) ([10.255.229.9]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2022 10:46:28 -0700 Message-ID: <62f37ed4-eac5-250e-3056-dea2d0039b02@intel.com> Date: Tue, 26 Jul 2022 10:46:27 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCHv7 10/14] x86/mm: Avoid load_unaligned_zeropad() stepping into unaccepted memory Content-Language: en-US To: Borislav Petkov , "Kirill A. Shutemov" Cc: Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Varad Gautam , Dario Faggioli , Mike Rapoport , David Hildenbrand , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220614120231.48165-1-kirill.shutemov@linux.intel.com> <20220614120231.48165-11-kirill.shutemov@linux.intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=FwoGy1xo; spf=pass (imf05.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658857592; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UO72TIay3a3a3D1s3pXCqDP/uDf6SlzddYKh1qo77/Y=; b=rtRNRJri24WXccegkj9GE2pC32BImYEi2y8048aV+7W9w3H0H8dw4jNpKiGfcK81F7b/NA RPIlztgP9iai65JrRP1qyQAwNheP/+McHb7/bmNwhC009CoH5UWKLw+++EbGChD5sQ/giA v0eR5Vr/AgVnVRh9Izuapxtv+kqAoWQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658857592; a=rsa-sha256; cv=none; b=XA8ZjRnabtMEaJmWytcRODse+DOjSsdft8jVDqKfcVnj5lTR46si4eIFFUV9sS/pXIQaEq f2oi2HNVrRV/nGpNKyV3Is086KLAZFMFPFBb74Y2qXdIb5+JWSmq3B3VPOHd0BMOZTDLsf dl0wif8ntaiECSfdNfViNvBUm3ehNk0= Authentication-Results: imf05.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=FwoGy1xo; spf=pass (imf05.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam05 X-Stat-Signature: izp1dncemsuj9mxroy3j5gyqygjtasiu X-Rspamd-Queue-Id: 8289B100090 X-Rspam-User: X-HE-Tag: 1658857591-739346 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/26/22 10:25, Borislav Petkov wrote: > Why do we need those unicode quotes and backticks in there? > > verify_diff: Warning: Unicode char [“] (0x8220 in line: + * “guard” page is accepted in addition to the memory that needs to be > verify_diff: Warning: Unicode char [‘] (0x8216 in line: + * checks up to end+2M if ‘end’ is aligned on a 2M boundary. > verify_diff: Warning: Unicode char [‘] (0x8216 in line: + * 2. Implicitly extend accept_memory(start, end) to end+2M if ‘end’ is > verify_diff: Warning: Unicode char [‘] (0x8216 in line: + * needs to be done to make ‘page’ usable. That work might include > verify_diff: Warning: Unicode char [‘] (0x8216 in line: + * accepting pages in addition to ‘page’ itself. I've been encouraging folks to stick their changelogs in a Google Doc (or even Word) when they're writing them. This gives them better spelling and grammar checking than is available in most editors and also makes it easier for folks to improve it collaboratively. I find it a lot more efficient than sending 10 copies back and forth in email. The downside is that those fancy programs insert unicode willy nilly for stuff like this. You usually need to catch it with scripts because it's hard to spot visually. It might make a good checkpatch addition, if it's not already there.