From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 333D2C0218A for ; Tue, 28 Jan 2025 22:01:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6526528001D; Tue, 28 Jan 2025 17:01:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DA5328001C; Tue, 28 Jan 2025 17:01:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 453B128001D; Tue, 28 Jan 2025 17:01:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 253C828001C for ; Tue, 28 Jan 2025 17:01:15 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D770FADFF6 for ; Tue, 28 Jan 2025 22:01:13 +0000 (UTC) X-FDA: 83058232026.10.71D1FB2 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf01.hostedemail.com (Postfix) with ESMTP id 874D640009 for ; Tue, 28 Jan 2025 22:01:10 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738101671; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KG6p1wuNI7XP4l80I+mbqx2T10m/bIalTciJat6iZHc=; b=m7AqF8xaWDbOBqwp02G4sZ7sPSMRyVfnQqeS7cPcGkYT0nhuv3mGOkp4BNDfL53kpXJ3v6 AC9kDQ2tt45j+Hh8HoGTcnHgeMzdcXC1OfH/OuY4lsSwJpagDVsIa64DMNckVrzS5ldZN2 MtEsoNgLSKo9XSY9NkWPVzqs6pp6/M8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738101671; a=rsa-sha256; cv=none; b=1fYfHYRb9cqxqhDtdLL2j45fagcu2v1CY3/Sh+fIArOORKgY2n8kykA+AJKYMuPMMRMswD Pb8fvR2QYUqfaf5tC5yva7eY5CdAxuc7o6armJwdFvV0yN8q7O3c4w8F2dRhHKrhltRD89 K7x5lGAVRMKEa1my/k4EpJqZ4cNVeF8= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tctdm-000000008HL-3rK1; Tue, 28 Jan 2025 17:01:02 -0500 Message-ID: <62c945d75e2cd29f27d2f62b2a7d31fa1b2461ae.camel@surriel.com> Subject: Re: [PATCH] mm: Optimize TLB flushes during page reclaim From: Rik van Riel To: Vinay Banakar Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, willy@infradead.org, mgorman@suse.de, Wei Xu , Greg Thelen Date: Tue, 28 Jan 2025 17:01:02 -0500 In-Reply-To: References: <135b6d6fad6083bfd11a9dc98fad69756b51c59d.camel@surriel.com> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) MIME-Version: 1.0 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 874D640009 X-Stat-Signature: pt6exhezzr5bmyikfydmq63xiqwq4cb5 X-Rspam-User: X-HE-Tag: 1738101670-409842 X-HE-Meta: U2FsdGVkX1/hZ9Brl11ISnakYo96YBeH3fsg+7T/cl8/3JGnNYUGbUjSLrV22IY5uIl09WUaL9SblZx3xB85RH7QhjgWBZZu8sgJdrdqrBVXE1vg/11AcbaSkpO0AjDvCBeCXjycutW97Z1yVh22XCtVZXmtyTy8wwN8L3zGpfevYh5ZW/K5wBpnBhbQXuIUV8rK9An8u4o8qhEKVaU/NN4B+08Xd6YBqXqIAtg0Kg/Q+q2skQJMUsVIXlJQrP7n5nDijI0LE2RlOXqXuTSro7o2DSOaGLD7SDc21ykQ647U5OWns5SX5uEASRA+ci55Do8q0rh7XiLjHm3wTirXsamGAAidyltAODcQ0rBrHP6VweU6hzdIvcBsDR9JCQyLZ4MAlg8foYMNfTU07E2w9YCTmgbfBkoPMN1eOC5ttEr6QBiXknM1GUF1eFkNi4zuTHRHFW7d7zf1JXSJ9XVMMj0roWLPahAePCq1S5csJz268kSVbUo0okPTkx9HQ+y8SNU594ucQtdfYZ1OWHZBqzJoGM43aT7WWnM42NklO8cb7kxPbSIqhJBldCfnSmD/mh4+kyeE+uTycucz1p8hlEn4J+5Bkg4ra5Y//GfOGf5xWgBzC6TFAUWTo9IVxiIRRfQTHM/qYXHGgsj/zu0KK8XjZh5pFqArfHTIG3stTxtcRoPvmMyz+B5/FM4WXKch1eKcJb0/hTwWVeVHjLYn/rtH8776Zo3EplnDAIlDRcasgruwMdj8iDuMXR0gwhUOQSxQGZO8wIotoQZFx8+F3vzS48XQEYu/AE5qw//SgyKndvxnGZB1lfxzTIqt1QSvcwf9+sYoCtoa5SLszukig+fREel3SKCkTHlVY73vkOucNY3bpA41WPiqxkTbOXClNfo/WLTUjLaXifMWG5sfEHt8PFn6RD5vkEW6paCKIHRfLzqIdfMgipQl6fRS10f6m4Eda2z3bRpmg+nqm4V grjI8C92 1x50uXSvXDbnu3ppa4yCGd4UkvPmNXnTuzxf045v9ZuA5tSQIHLh0Pfo5HOj+vPcSKh56Q/+jxheBaCvXuegjbWxdG6mLBfBcBxiH2yZKzs68OXz+wyVbMP2vn7NQUD4PI1MJZyeM2GNdHXzUCnEEgG/Quqhi9hLLYbe8y1gf8vyyg/DqwQkAxBV6yjFKtsJpjYDrwubUrPNj/rexiJNeom1HgnAvmD/9IS3vaJTvZUTWzyXRJWhxPXUknVmENTBClCd0lJHtpTStggI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 2025-01-23 at 13:16 -0600, Vinay Banakar wrote: >=20 > I initially assumed that all paths leading to shrink_folio_list() > submitted 512 pages at a time. Turns out this is only true for the > madvise path. > The other paths have different batch sizes: > - shrink_inactive_list(): Uses SWAP_CLUSTER_MAX (32 pages) > - evict_folios(): Varies between 64 and 4096 pages (MGLRU) > - damon_pa_pageout(): Variable size based on DAMON region > - reclaim_clean_pages_from_list(): Clean pages only, unaffected by > this patch >=20 > We have two options: > 1. Keep the current logic where TLB flush batching varies by caller > 2. Enforce consistent 512-page batching in shrink_folio_list() and > also convert to folio_batch as suggested by Matthew My preference would be to fix one thing at a time, and simply remove the comments that suggest everything is done at PMD level. I'll ACK the patch if the misleading comments and changelog text are removed or fixed up :) --=20 All Rights Reversed.