From: Dave Hansen <dave.hansen@intel.com>
To: Oscar Salvador <osalvador@suse.de>,
Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
Michal Hocko <mhocko@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] x86/vmemmap: Drop handling of 1GB vmemmap ranges
Date: Thu, 4 Mar 2021 10:42:59 -0800 [thread overview]
Message-ID: <62c5b490-353a-ca3a-d2c8-f02189210c32@intel.com> (raw)
In-Reply-To: <20210301083230.30924-3-osalvador@suse.de>
On 3/1/21 12:32 AM, Oscar Salvador wrote:
> We never get to allocate 1GB pages when mapping the vmemmap range.
> Drop the dead code both for the aligned and unaligned cases and leave
> only the direct map handling.
Could you elaborate a bit on why 1GB pages are never used? It is just
unlikely to have a 64GB contiguous area of memory that needs 1GB of
contiguous vmemmap? Or, does the fact that sections are smaller than
64GB keeps this from happening?
next prev parent reply other threads:[~2021-03-05 17:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 8:32 [PATCH v4 0/3] Cleanup and fixups for vmemmap handling Oscar Salvador
2021-03-01 8:32 ` [PATCH v4 1/3] x86/vmemmap: Drop handling of 4K unaligned vmemmap range Oscar Salvador
2021-03-04 15:50 ` Dave Hansen
2021-03-08 18:20 ` Oscar Salvador
2021-03-08 18:26 ` Dave Hansen
2021-03-01 8:32 ` [PATCH v4 2/3] x86/vmemmap: Drop handling of 1GB vmemmap ranges Oscar Salvador
2021-03-04 18:42 ` Dave Hansen [this message]
2021-03-08 18:48 ` Oscar Salvador
2021-03-08 19:25 ` David Hildenbrand
2021-03-01 8:32 ` [PATCH v4 3/3] x86/vmemmap: Handle unpopulated sub-pmd ranges Oscar Salvador
2021-03-04 17:02 ` Dave Hansen
2021-03-04 17:08 ` Dave Hansen
2021-03-05 18:26 ` David Hildenbrand
2021-03-08 18:43 ` Oscar Salvador
2021-03-09 8:25 ` Oscar Salvador
2021-03-09 14:50 ` Dave Hansen
2021-03-09 19:39 ` Zi Yan
2021-03-09 21:26 ` Oscar Salvador
2021-03-03 0:09 ` [PATCH v4 0/3] Cleanup and fixups for vmemmap handling Andrew Morton
2021-03-03 18:38 ` Borislav Petkov
2021-03-03 23:04 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62c5b490-353a-ca3a-d2c8-f02189210c32@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=osalvador@suse.de \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox