From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46A33C27C4F for ; Tue, 18 Jun 2024 08:00:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6A056B0328; Tue, 18 Jun 2024 04:00:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B19EC6B0329; Tue, 18 Jun 2024 04:00:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BB206B032A; Tue, 18 Jun 2024 04:00:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7DEE56B0328 for ; Tue, 18 Jun 2024 04:00:09 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 04A2FC0589 for ; Tue, 18 Jun 2024 08:00:08 +0000 (UTC) X-FDA: 82243261338.27.427DE7F Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) by imf01.hostedemail.com (Postfix) with ESMTP id 7F37C4001E for ; Tue, 18 Jun 2024 08:00:05 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=B6icuYVw; spf=pass (imf01.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718697600; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mc0QvhK9jGXMdPivHuSTCJOKTEtf+ZVQCpU53OOKO68=; b=2yy7kiWu/PHn7hND10SUj+3Rpgi9bECdwE7o9JMOl9UxypB1DD3cQwd9aZuB3OquAagqCV w5QgCo1Ai7ebrcwxff0fMRzmoAl6lSi1DXq7mx/f4uvYSD1EMgf6r5ARs3HXngwydudDIF CxblytQMjZF7FuIDcSmRofq/ZuO7eMw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718697600; a=rsa-sha256; cv=none; b=YFQSWAsInxFPUs2Ew6AdEcAOzs+9QwDcAl1T1roJIWHxEECXwPIyBd0cy6e2tSXa/HDxik 10HKjyhOclegIRVKajYSD0uh+3rOFmZ4VAP8NVwprmqJ9g+hO5B70S1hr6N0U7HTav4sRY J5Rf+XsqfzcVZ13Db/+x+kz+KoJn8es= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=B6icuYVw; spf=pass (imf01.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Envelope-To: yuzhao@google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1718697602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mc0QvhK9jGXMdPivHuSTCJOKTEtf+ZVQCpU53OOKO68=; b=B6icuYVwIyCgTukBQQOKSjE5ETZ0z78q/moqaK0yaAFnnPZw4DnkgQZ3GMSDW3Vq8KIA4F zHENAzUSbsKhk5rb4Thfs+ysB6QP4fSicmDvGJT7ho7kZVvqEQDihrC18pVBtA/ekjX3/7 0E9bePUrcLcXA7dozjfCBpGStx9B6fs= X-Envelope-To: minchan@kernel.org X-Envelope-To: senozhatsky@chromium.org X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: yosryahmed@google.com X-Envelope-To: nphamcs@gmail.com X-Envelope-To: flintglass@gmail.com X-Envelope-To: zhouchengming@bytedance.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org Message-ID: <62bf4a21-ae1a-4ed0-8b55-9b444d9ca0a7@linux.dev> Date: Tue, 18 Jun 2024 00:59:54 -0700 MIME-Version: 1.0 Subject: Re: [PATCH 2/2] mm/zswap: use only one pool in zswap To: Yu Zhao Cc: Minchan Kim , Sergey Senozhatsky , Andrew Morton , Johannes Weiner , Yosry Ahmed , Nhat Pham , Takero Funaki , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240617-zsmalloc-lock-mm-everything-v1-0-5e5081ea11b3@linux.dev> <20240617-zsmalloc-lock-mm-everything-v1-2-5e5081ea11b3@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 7F37C4001E X-Stat-Signature: ny58bckctaxb14tbx43x7xoo8g7fp4qg X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1718697605-167765 X-HE-Meta: U2FsdGVkX18RC8MZQmmUpT8DcFTq0Hd5BtFQwGB76vlCIBZk65orlvZkaHXTmZ0gerVXFpeCXj8IUgIAij2nlBTTScN/29HEFRMTyTZu1nw7s1PX00UbXtziBEY3RFhm0pG1RKV7sEF+XS8OSVgfp/wPjaYb6BadGixKoI3x+sIYWH17WOHe1n6C7k/mYqAn+q089gnlg/DFhxPuxEcKuQ/ZRRo3UR4Zkfbiw95KMxrxitE/kfa4oyrpjBa8tDsI82InDESNR8K8jkd6r9BbkAsxorjU/2jmCmNbCxArm5jZvim/o3HuTw9ziBXhk7gahB0KcCDiow+oYrwFjQqqnGiDG3M1Ep8Q2JzALube+R+0XVKu1vbH7E9SKxCIF4Kf0ZshITDu1p5+4MP+fkxJiYL4fdXJ3cLhjGDQZZL2fUtjlTWScpP8lm6x6AVBcr84h/+BdejMPgg0uylmnD9947BhmMMt111twIw6B/0MlODLvhGvvsY0mP1Vy/I2Kb78jEEy3cl438fBi2XyBWspDvVutDflpZFO6i1iyMYrnsvtarSK/bmpsEOwrvMZHwgEa0N22/nUisx4MkmVryn6jIV2XtjAO/u6OdqI0DFXrxXM3TC/fwHFkLz0y/OQiFbqFASYiOo/bXLbBBCUdrnh7ckdmKmo/FSX8hJpdyVKoI8n89DcyYmCjd30qjtqWxzZRQDslFRgGOoFSMSl+fRFgNjzGEEHA9qjFtIPfbbnhL4tBb0mvQk+2+Qibq7mRuFr406pdtHH8VyyLW8l4DTmQrXw7Vb5JqWj59Y9syGmodE4Va5D5jKa5KaC4l6tW2bVk91TSGsbw8e6YQDuCHZ/S1jRmn+cFDiDCcCFiJcsfZSLeUpdWn26K7C2EYOUtwwbGYCyOT6qaB5YrgfLbWPOcGpPx3T9wEjpLnlil8Ueg2DJ9f3F+6d16qOiqxZTYpcXvOwq5OrzBNQ7QePfY60 rHRG2D4n 540bT9VHGoDQf64G2sReFspBt+wA8KpnZxf7HJgHGo7RJqw7BEE1QZzSSVjB36mG6SuyfHCZK1dFTYgXrXd0hUP7buV2KtnMPAq74bdbKNO4NRWzQ5aHu8j9DEjiwzHXth9JeJpWimFblDysamLE3vP7wVRkCW5xX258iVluKLCxRuOUx3SmJq5ivJRQxZqGoPF8KTFI0QTnFaLU/VdXP7CTqT8VwWfey4Br6ec2aqosoScQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/17 13:16, Yu Zhao wrote: > On Mon, Jun 17, 2024 at 6:58 AM Chengming Zhou wrote: >> >> Zswap uses 32 pools to workaround the locking scalability problem in >> zsmalloc, > > Note that zpool can have other backends (zbud, z3fold), and the > original patch was developed (even before zswap could use zsmalloc) to > make sure it works for all the backend. > > This patch only makes sense now only because zsmalloc became a lot > more popular than other backends (even though some distros still > default to zbud). > Right, we mostly focus on zsmalloc, I just do the same testing using zbud: real user sys 6.10.0-rc3-zbud 138.23 1239.58 1430.09 6.10.0-rc3-onepool-zbud 139.64 1241.37 1516.59 Since we don't do any locking optimization for zbud, so performance is worse than 32 pools as expected. Actually Yosry did a great testing [1] to compare zsmalloc, zbud and z3flod, to support that we can just use zsmalloc in zswap, so we can drop zpool, zbud and z3flod. I will include this information in the changelog in the next version. [1] https://lore.kernel.org/lkml/CAJD7tkbRF6od-2x_L8-A1QL3=2Ww13sCj4S3i4bNndqF+3+_Vg@mail.gmail.com/ Thanks.