From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18BDAC54E65 for ; Wed, 21 May 2025 10:25:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB6BA6B0099; Wed, 21 May 2025 06:25:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A67076B009A; Wed, 21 May 2025 06:25:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92F6E6B009B; Wed, 21 May 2025 06:25:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7207C6B0099 for ; Wed, 21 May 2025 06:25:33 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 127E258571 for ; Wed, 21 May 2025 10:25:33 +0000 (UTC) X-FDA: 83466533346.12.E535AB8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 7BD1B100003 for ; Wed, 21 May 2025 10:25:30 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Go9oNXwe; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Go9oNXwe; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747823130; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OmRNDn9pMz2kvSgpRMSd6bVT5frXfvGrBhompz0Lfnw=; b=BQQw8hgfAl8IJPOpUcdYFMkWCSWtktBfRdQul79NEM1SimPnnhqJkygI1TEQmUxaYieOIb KCtyXkJmGY/uM5ia6lGkDQszrhRrtUduIzGZboVDzYZRaCxH46br319pWW2HsD5gIzlYxQ RrugbpJcF19zrFVhQeFCgXFH+QvmlvQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747823130; a=rsa-sha256; cv=none; b=GBcfUW+HlqKekv0soHWAlaFvG3HTupYFdGpn5qriLceSg7uJ+PYO6qBzeJliq0eoGPWBVK zNXegbBrui91t6Z6YOPOBrn1Da2PA6mhLXHK69PkY8jWDoY9qQM32EuewuDRTIdLpKyNEK 7+S5ew48tka0Gwp4AEA08Y5EQf9UJ+s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747823129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OmRNDn9pMz2kvSgpRMSd6bVT5frXfvGrBhompz0Lfnw=; b=Go9oNXweidOYu+EIyHhIE1I2bmc2tqFZd3sv/KGo0yJh4UxbtHOQU3kbXgQnn2IYoF78fZ XAMbJkslxuwzYUveBFUdzOn6nhktB1S3yXN0MrXd7m0rKQCAgKuFLYDVFD1u2xwwu3paXb s3s1pdaMZTn/QD8zhfT3L+O2nCCOlds= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-252-ckyNDDcENG6d8I04CsbN8g-1; Wed, 21 May 2025 06:25:28 -0400 X-MC-Unique: ckyNDDcENG6d8I04CsbN8g-1 X-Mimecast-MFC-AGG-ID: ckyNDDcENG6d8I04CsbN8g_1747823127 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-442e0e6eb84so41614165e9.0 for ; Wed, 21 May 2025 03:25:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747823127; x=1748427927; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=OmRNDn9pMz2kvSgpRMSd6bVT5frXfvGrBhompz0Lfnw=; b=p94ucq+SttrMPE6/KN/fkaZd5KP6krv7TlFclr8G7FbOp9UfarfaZHUT/qMGoInuSz 48DjzeO4+erhtVMNfOIMiUC4Zw/5m5pQfkUa0eLcz2FIPLpsSoH+sMyfxklHCb2xOeu+ zvSdf1qTXEmU7zGQqN7B1sUL+gH0HWA4/COzMauUGRwJorkA/aB707BkMy/i66kV9+c8 j/5Gpj/noFxdjUWkwfOtltEdgxZBXlZiWwOVg8L92SNeuLw+OcTh9/VTlg1/yefDJKpB 9My8e44XnyptDlP6qIiK9YWPGhUwxfCkGplZa6YCTpYGtMeNOlhXeD5TLvr3x5Z8P5AP CJ3A== X-Gm-Message-State: AOJu0Yx1elXJJQCGiEsNNya/MZT8hIY82HZrJOvKdwcIj0VbHq15ub7w yHRfKfwfmhDBkY/BUNozrC8HYEZS3FFzhP5efS4GXc5waygm9NduXRN7l7pC+bUOHKdvFNPigVB zzhAeo1n38x0TaYn6cuJaAAFB/0m5VFv7CctIm4Hu2jLvRw2x30GI X-Gm-Gg: ASbGncseo1hDCtpKgOP/lPoDfNPxq6G4AcmZgvS0MaSwraUshpYu6sor+y6tI7wlXyj ldi76F/lPEGM7dYpoHYUV3Qf4uvxQ6MEv62bhfI4ODLfp4H2CBwajRA/0sgVHn8LQh30r2hJ7MS P9Po+oiLxpQsbVZ59YHgLelQsms2H53NCnVjtbmE+vAE2Ij1HxgXCRe04Cw+BE46/Aa3lVmStVp B0VWsL2/SfpKQQtOGAuPhaXU5auMQPDfiOifwhG6Bh32I+f8GCYeeI6WyCTjl1qPIMftg16cPaF o1bxxZ9flVOOaJyVwSYWRsm0GoH/rvq/mjO/l8wWfCF15kmRJUHaVB10/sqNpJBWi3Fc6Pal7Rz EWXz4xgbq81ZzzTg0nWLBPI/9PyluxSArnqRZbdA= X-Received: by 2002:a05:600d:19:b0:442:f97f:8174 with SMTP id 5b1f17b1804b1-442fd6313f4mr138654675e9.18.1747823127367; Wed, 21 May 2025 03:25:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFK31hCOI4AspdeyWTmUBM6tm6OjfoTLQ56G1e4yH46eK8Cne2OwOfr7oe4xsHWdMwN9VP/Ig== X-Received: by 2002:a05:600d:19:b0:442:f97f:8174 with SMTP id 5b1f17b1804b1-442fd6313f4mr138654385e9.18.1747823126926; Wed, 21 May 2025 03:25:26 -0700 (PDT) Received: from ?IPV6:2003:d8:2f25:9c00:e2c7:6eb5:8a51:1c60? (p200300d82f259c00e2c76eb58a511c60.dip0.t-ipconnect.de. [2003:d8:2f25:9c00:e2c7:6eb5:8a51:1c60]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f6f0552esm63045705e9.11.2025.05.21.03.25.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 May 2025 03:25:26 -0700 (PDT) Message-ID: <62b5ccf5-f1cd-43c2-b0bc-f542f40c5bdf@redhat.com> Date: Wed, 21 May 2025 12:25:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm/mmap: Fix uprobe anon page be overwritten when expanding vma during mremap To: Pu Lehui , mhiramat@kernel.org, oleg@redhat.com, peterz@infradead.org, akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, pulehui@huawei.com References: <20250521092503.3116340-1-pulehui@huaweicloud.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250521092503.3116340-1-pulehui@huaweicloud.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: enYvuWQvCZN_KOCFtJ9cPrmzoIGV8udZLIxHKJ0eOUE_1747823127 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7BD1B100003 X-Stat-Signature: s43esja9a5maecz9nqn9d716bjki1o9s X-Rspam-User: X-HE-Tag: 1747823130-152317 X-HE-Meta: U2FsdGVkX1/lACB3v/ipy6nI+jM+Nhi7YUaVRsofkl55cDK8dVVCVEyWSmk+fEQfelh/yuXmJFxhOVmlBOCV8R94USUCRtZnD8VyKTqGvVYbQ6p7EmAsYNz1Te9buMDMZ78aWFN+JgLO+++NNoKmg9kKQX8XZExf6p95St6v9WkcN75Qp1XtoMGuw11rdiWu3UjiYWh3A2Loe2jei31mZojLL9e/wq4E+UgJCKg/LFO6Qe7boQP21f0VNkCYO8vG4AVzJW7Rv6TA500LoeldbgGI4tbrbyLXAJfwr+iYWTxl0wAJ5cU098/XMEYsCmKSQoVqagcQ86h0MJvtpuMKMJ2DbvDBc0r5uQgE5qCMHperdH3woVY+69/60r8SvRMxrDOA1VjTZxmZQ3APIVDWeAd0Ainp8luZVgRYVVF3nE3yp+mI2T71cFnfq6HYJnC6ivAOh673X4UC76oHZnlknI4ltbONSPZNaJrnoofeQ7NsdM0XTud/ll0D31Aqr0Voy2uiZyu/3exeJze6D1U+vy1rhUC7GV0pf5le2P+taiuhIA393Otgw4jX++4d9KZP5EAf/xwEKjlPh4thPS7kM3FTbY+ZiJmKYXJov2gy/DPC0NC4TDGNuZo77dG8iCF789dqagkRa4FdQcUeCaPHoyv9eKS+xmXOzf26GqIQmOG6p5hf9t0QpazQqXOi5pbfeyDJHFBMMViA2GfnJ3YxfyRUS+L/01zxPEz0aBF0oCVCR6ZkUktIcd5R5xen9s84HJd6+yYqgwjqwBan0vIxt4wf1TEohhZQfSo5K+VUhYHnmjQ2w3ZqZBxAN//WdYDNhmDDeZh6VWRhwNUIfkYbGO81aqLxkZM9g7gmv50P9Pu4OQVxkNAPNzZ5kmNiQY1MpWU7JmIeX8RNKBWwFSHOAK2hVO8tyjTG/hGAzBzdTnNRncyWpl2DxapAyfx6V/vH9gbxgZhYM2adIDcnjHL v6ilj8U9 UjU5ZqDmNzshd+O9p4a79ovMrb748Z6UqcoDToSgTTjBcW8BYD2l8ww1PVQ2vST+uSBcoKYGMCFzCrp6ZFIpPf/FwbjpdWUSO1rw117wZKcs5klrm4L7tb9UEq36frNbhIsnkW+rUmB0FMfgDcnNIMKYUSq6zdNP/YDftpv/O+0Weq2Vx8ajs25IfHBkQMNDxmFbBRMYFd5d66U36qvZZFvOM6c9otcX8gsiDgXW6aW5yDZpxIa+v5rZan2hZ6DIazBI2LO+IRSUDR8ZVm7PgPsehpZGedkjr24zD4bE1XJaRCG2zGN4Ag8niLqMOg7atJsw6Ihk5tFSgEaMjTz6p2ycrQ1xF7HYYRvGyDc/KHARM9BLaQ2lctoWiDSgOS/baOtH5n/wrQSeqCwpivlEqSMGeDyJhaNq5iX6xrB1YYwbEs/w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.05.25 11:25, Pu Lehui wrote: > From: Pu Lehui > > We encountered a BUG alert triggered by Syzkaller as follows: > BUG: Bad rss-counter state mm:00000000b4a60fca type:MM_ANONPAGES val:1 > > And we can reproduce it with the following steps: > 1. register uprobe on file at zero offset > 2. mmap the file at zero offset: > addr1 = mmap(NULL, 2 * 4096, PROT_NONE, MAP_PRIVATE, fd, 0); So, here we will install a uprobe. > 3. mremap part of vma1 to new vma2: > addr2 = mremap(addr1, 4096, 2 * 4096, MREMAP_MAYMOVE); Okay, so we'll essentially move the uprobe as we mremap. > 4. mremap back to orig addr1: > mremap(addr2, 4096, 4096, MREMAP_MAYMOVE | MREMAP_FIXED, addr1); And here, we would expect to move the uprobe again. > > In the step 3, the vma1 range [addr1, addr1 + 4096] will be remap to new > vma2 with range [addr2, addr2 + 8192], and remap uprobe anon page from > the vma1 to vma2, then unmap the vma1 range [addr1, addr1 + 4096]. > In tht step 4, the vma2 range [addr2, addr2 + 4096] will be remap back > to the addr range [addr1, addr1 + 4096]. Since the addr range [addr1 + > 4096, addr1 + 8192] still maps the file, it will take > vma_merge_new_range to merge these two addr ranges, and then do > uprobe_mmap in vma_complete. Since the merged vma pgoff is also zero > offset, it will install uprobe anon page to the merged vma. Oh, so we're installing the uprobe into the extended VMA before moving the page tables. Gah. > However, the > upcomming move_page_tables step, which use set_pte_at to remap the vma2 > uprobe anon page to the merged vma, will over map the old uprobe anon > page in the merged vma, and lead the old uprobe anon page to be orphan. Right, when moving page tables we don't expect there to already be something from the uprobe code. > > Since the uprobe anon page will be remapped to the merged vma, we can > remove the unnecessary uprobe_mmap at merged vma, that is, do not > perform uprobe_mmap when there is no vma in the addr range to be > expaned. Hmmm, I'll have to think about other corner cases .... -- Cheers, David / dhildenb