From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83C5ACF31B5 for ; Wed, 2 Oct 2024 11:28:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 023F84401A7; Wed, 2 Oct 2024 07:28:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F166544018A; Wed, 2 Oct 2024 07:28:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D90044401A7; Wed, 2 Oct 2024 07:28:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AAC5944018A for ; Wed, 2 Oct 2024 07:28:35 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4FCCDA1E4C for ; Wed, 2 Oct 2024 11:28:35 +0000 (UTC) X-FDA: 82628439390.22.FB40297 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by imf06.hostedemail.com (Postfix) with ESMTP id 5CBDD180004 for ; Wed, 2 Oct 2024 11:28:33 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="yrRDUHA/"; spf=pass (imf06.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.50 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727868448; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T3CsujielR0/Lj5Yt3DNTU+m+GpBohBJmAfQEZ4LT/A=; b=NGi/P/aYcUj3+7p+V3Ki3HRV7KXLrjFexZ+Tiek+/I9ARCWtuQQoaI7MOGx+kH8rp9RQIp 1X/oOiTB3uYBIert2alRy5q3RLbby+Ipou76onUM5CKkhmiisv68Ao/1CNDv2fSyBF3w2w Hci5haoVYo2mLY8JRwb7dBBZ8s9SsVU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="yrRDUHA/"; spf=pass (imf06.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.50 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727868448; a=rsa-sha256; cv=none; b=nGPOwDt2zlled/T+CSp68zawJMLms74OT+Eejlpt3RNCSgDuDge+v54zlqGa69wMIGKF8O GJEZyWMVl6joqgGZ4202Fk0ey0WBeD30R/zDeZVZmhWI4SpbzRf/kc63VbAFzuZ+FlQmb+ aYJhQGpUkLgRhsgioW3o4zjzGfE4PGU= Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-42ca6ba750eso4718545e9.0 for ; Wed, 02 Oct 2024 04:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727868512; x=1728473312; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=T3CsujielR0/Lj5Yt3DNTU+m+GpBohBJmAfQEZ4LT/A=; b=yrRDUHA/+0G1HoPZOLaAxSaK0UKwyWpdaYEqvtY32v6CTkZRltGRWiNQRtk9CXugS+ FkYOpeSAp/ToNMBqHiwiX5L98WHYm4u99C0WUI+PHCxbwn1DgJeRzcGdsM07viawI//O VxpT0HvXKDh/7P68agq/omBalEXluZGh5imSzxwCQpK2HZfwdqC3iLVcL/Hh9aiTdHgH RJQwRvzTQE+Pls2l9ifEmqlBbjkEERS6uqIQrAMu8bEoVL8zXKxnCLMbK097zHkkc+ft NdO5wagPYQpZ2IgthBy1eBSFf4qwOftetfu+1aBFlDXtPhwMfOFu97HVh0gDn+3dMVJ4 VOZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727868512; x=1728473312; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T3CsujielR0/Lj5Yt3DNTU+m+GpBohBJmAfQEZ4LT/A=; b=HDSli+83mq/wZLchP+MKzzwAmnhfSSAqfqRvEX0kHS8UHeQTYm9w9lUfnKBvMyZ5CT 9TjHFACFmD/NpsyL2mGHRZJmZafuM/gViIMLo+/2fdAbc/EpRx8K2hAYILhHwMS+aFnQ 9V4VXHyNSwetAyYIarTKPzXXfHey5jzNkL9u5AOCrDKSXNhghK2Z8WVoI4MFhD0RiwYR OMvQxEqjxN//28kcnx8h9aQHNxxz0qFyYQPmQFw30FDnOrIbWBhmNk44XV88keowETDA 10aIyzqN5Z8a3ycYGgPzahhiV8VVpqNNgTfyKbYWWf9oafns1du+H1+wT6mArEyeBs8p npYg== X-Forwarded-Encrypted: i=1; AJvYcCWM7wQ0aMMEjjRnwqb3awMhmhaDYtSIhsBwqyVgMr5yL/uIXEseBmuLX+N3LGbOpNm3/y/RH8xPMw==@kvack.org X-Gm-Message-State: AOJu0YwkubmswosrNOp1I8Kdp1PJcZcRtW1S+Wv7vOb7a/WCkEy5GOBZ WA8ImlBL3UfiJBpyiOAZ/qVXynj9tMohxFodYt5vKli++cznoeQwQ+zxQqSwksQ= X-Google-Smtp-Source: AGHT+IHWQoJyjFnm5vg1HmB7MSlkALHoLRiM0a0Cqaw736TMNSFThw8Yvva956argTiJOV0cwtJp7Q== X-Received: by 2002:a05:600c:4710:b0:426:64c1:8388 with SMTP id 5b1f17b1804b1-42f77720814mr15171335e9.17.1727868511844; Wed, 02 Oct 2024 04:28:31 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f79d8d693sm16276955e9.2.2024.10.02.04.28.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2024 04:28:21 -0700 (PDT) Date: Wed, 2 Oct 2024 14:28:15 +0300 From: Dan Carpenter To: Naresh Kamboju , Kairui Song Cc: open list , lkft-triage@lists.linaro.org, Linux Regressions , linux-mm , Andrew Morton , Arnd Bergmann , Anders Roxell Subject: Re: next-20241001: WARNING: at mm/list_lru.c:77 list_lru_del (mm/list_lru.c:212 mm/list_lru.c:200) Message-ID: <62a65418-2393-40ec-b462-151605a5efcf@stanley.mountain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 5CBDD180004 X-Stat-Signature: 7fjfh6gso5nygubw6tp866bfmb79wh6g X-HE-Tag: 1727868513-962746 X-HE-Meta: U2FsdGVkX1+DcaWA/mRDjv4jzroeocuf3AwreaTfWWUOuG/pQmReFk+4KbDaw3/txOHJBf81QRoibPyCs+jGb/HJlXga9xFvAkBVOfahjfHlscSKCNaHk+BLxtmrhMgojIImu5/+Rt27oFhBSPjpXXhKtm77dPLraWmd1qcOe2W7CaMGBKnPEzeJ/O1IVKTj/08Z4Vx8e/PH/3viBuWCt/z5q9UBnuK44jnKaCQwCioAgjTevw9/10uGDAnL7eAIlcAhOCWOmkb+zvuV7XB3i9mhWTlSxHak+nxI2yjNNEC/LPtqlKg/LYDq0kFBfGhdmI0rF76ijc5jhCu0gFvo9JBUA0PW7xQ3eQb1oaZSClbFOhLHfOj2GAWli16ujdNC61PYHlDco5IVX2FPhX2iBB9bxL8rx2HmV4VfGkOygBMikpbaG9zdo+vGVsuCQjPQEiSJkFgFiGTivxPVeg8W/svtA/gILuzDDuVpUBtU7P2nwumRiOZ5ZClBAd2W1ZSmM0Z16/KLUeS4G8xV358SbJmkWxEsX3I4JQ9cyeTIaZ+IxB4jqGxrzMMb6yHUM9s7mbCA0zs4OIEu+LQ+XSq4nSdwz9k+1Ev4F76pGzyHKjMHnn8Q0LKStiHbKgTL2ML62KGuQr7bcUe6jKijFsQ+312FYTVgSLagWn8o5vAjhl0+21VJA62hJC/Y3qJ7r86Ys17UTB1VULpKtp5M6jYtK06bs8q0HHx9yfaSEeT+Es7xbmxISzgB88i6TgPoosnUelaEjOvvaM08PHJ0Wpj+X2GV8oLbaol5qjV6L1XGM4kH9iRLbjGk5vqVZyzlw2DtxB6hTiJrB3D48XLyVrMRdI7UFi9NiV0R6McpklxNjV2bYjMUmCHEQhmap0+Rns25bXdFX4kpJHRE9uIp16SSN2o3QJlSpaHkNoxNP8hku+YzPbnIGMtrZnJ93da6Kyz519aZ32CAaPhQvNVYbBL RKQlR851 6mFtFpjdWEkigeOkBfAyB2o6UJNtwNK6sDqUZJa4Co2IvH9Ayd0mY96LUzuprWza9ZNI6ckv1kJvC19lkGui6LJSc0aFDfay82RYqPVFVlGp9CTJAQYhcPGniP0RWT2eEiWpXvcyeqceIO4SfRDUc+d848LvRQazrf7jRHDPspzjwxX0SJ4atdz2qgiFIcmNtSyb+ATJ/VHSjPfo5/8iEGo5jzmubuPjUD9SvQq+dKhVjxmFoJMgCdQy6wxT2g2Kd4pEUTwTGQ/SErgwtVVTfppORIIzO7VYit7P8QDiLuq1WQzFKOuSyCJxYTEm8+r8PDn15 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 02, 2024 at 02:25:34PM +0300, Dan Carpenter wrote: > On Wed, Oct 02, 2024 at 02:24:20PM +0300, Dan Carpenter wrote: > > Let's add Kairui Song to the CC list. > > > > One simple thing is that we should add a READ_ONCE() to the comparison. Naresh, > > could you test the attached diff? I don't know that it will fix it but it's > > worth checking the easy stuff first. > > > > Actually that's not right. Let me write a different patch. Try this one. regards, dan carpenter diff --git a/mm/list_lru.c b/mm/list_lru.c index 79c2d21504a2..2c429578ed31 100644 --- a/mm/list_lru.c +++ b/mm/list_lru.c @@ -65,6 +65,7 @@ lock_list_lru_of_memcg(struct list_lru *lru, int nid, struct mem_cgroup *memcg, bool irq, bool skip_empty) { struct list_lru_one *l; + long nr_items; rcu_read_lock(); again: l = list_lru_from_memcg_idx(lru, nid, memcg_kmem_id(memcg)); @@ -73,8 +74,9 @@ lock_list_lru_of_memcg(struct list_lru *lru, int nid, struct mem_cgroup *memcg, spin_lock_irq(&l->lock); else spin_lock(&l->lock); - if (likely(READ_ONCE(l->nr_items) != LONG_MIN)) { - WARN_ON(l->nr_items < 0); + nr_items = READ_ONCE(l->nr_items); + if (likely(nr_items != LONG_MIN)) { + WARN_ON(nr_items < 0); rcu_read_unlock(); return l; }