From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 776FCC433F5 for ; Thu, 11 Nov 2021 17:59:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AD81861284 for ; Thu, 11 Nov 2021 17:59:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AD81861284 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id D82266B006C; Thu, 11 Nov 2021 12:59:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D32D46B0071; Thu, 11 Nov 2021 12:59:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF94D6B0072; Thu, 11 Nov 2021 12:59:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id B0ABC6B006C for ; Thu, 11 Nov 2021 12:59:13 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5EDE884CFA for ; Thu, 11 Nov 2021 17:59:13 +0000 (UTC) X-FDA: 78797410986.20.8E8EF97 Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by imf15.hostedemail.com (Postfix) with ESMTP id 3AAACD0004A5 for ; Thu, 11 Nov 2021 17:58:57 +0000 (UTC) Received: by mail-io1-f46.google.com with SMTP id v23so7936354iom.12 for ; Thu, 11 Nov 2021 09:59:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=9wdeu4qIC+yfREjKTiwyWvTzajt12tvZegHkKd/EMSg=; b=PuTaajKNYQTz2Sbid6HOloefAWWzFBkmQaweOFAzYi7kcu5mKEPIKjpQykn0aAtUSM AQqxcu6qBk8oNLhoOJrde2pG86tJwDZCw3xTJi1wznfaqu/3587+QXZ8xitbsbV9pQfI tiY41a4zwP4kr6aedG8OZ9ll0ZLa+NqxsvngnjVIuIrMI6KiBw4mU+U6rlPdDwDn8QE8 4SJCOcR7ANbG62cf75MPM1Jdhu41RGfg6Ftt1YIvwneAWgpb1R260ao0C8nmkbB9hC9/ rFZdaZr443oAkk1jeBFquU+J7rosgxHeyWU5Iht/eEfomqngUqouQTfxC9ZBbT7nRZIy Cqlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9wdeu4qIC+yfREjKTiwyWvTzajt12tvZegHkKd/EMSg=; b=nSXFjud4HIpFWNsw9QHmyQHb4SRbC4pp+Q3zbjG8Kz8fUWeZHyVhGqLGt2+UEkZY7Y meX5GNMdD4JXqPyNFeHDXPyOuqAi1U8Is9Heox6ZeSwAoYM73yglqzurUs3MnXfuk1rI vzENDQ+Y94NIyfZ5hX+ICvynFqUf9r8cWTzrqrMPS02Fezxf+Ts5gueHwKllyCpUMkiO 8OuBp66KJ9KIeCXJ07GTB4+eGazp58ulPIHVWv6p6JMhMHmKhWRU05pLv4nURVD35G1r e8jZx8NW95/BptL1l7RYa02gPYEJs82nI04AnSfs8EKg7CRjl+iOLVos88zzg+5+BJlH mMsw== X-Gm-Message-State: AOAM531jiGkxSKwubP1Y56HLI+e1F2Kukz5bBk/BAMvv4CkKLzPUtoeZ 7rVB01n1tL5UbSf2jdv9f87VGA== X-Google-Smtp-Source: ABdhPJxeFXaFmjxc0tJdtkcMfg0691ruN0HVdCSB9akoHT6mzQpLhi63vd8NyzOS5M6GP9ZD9tsLGQ== X-Received: by 2002:a05:6602:1cc:: with SMTP id w12mr6054311iot.63.1636653550087; Thu, 11 Nov 2021 09:59:10 -0800 (PST) Received: from [192.168.1.30] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id m2sm1887818iob.21.2021.11.11.09.59.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Nov 2021 09:59:09 -0800 (PST) Subject: Re: [PATCH] mm: shmem: do not call PageHWPoison on a ERR-page To: Ajay Garg , hughd@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20211111084617.6746-1-ajaygargnsit@gmail.com> From: Jens Axboe Message-ID: <628a49dc-f6f7-5aa4-8a4d-4f2ed19b7f3f@kernel.dk> Date: Thu, 11 Nov 2021 10:59:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3AAACD0004A5 X-Stat-Signature: 6p9yn47n5x9eufri4pbgfgwsn57fmahw Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=PuTaajKN; spf=pass (imf15.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.46 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none X-HE-Tag: 1636653537-6140 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/11/21 10:45 AM, Ajay Garg wrote: > Another report of the issue (different call-flow, but the same error > at "shmem_read_mapping_page_gfp") at : > https://lore.kernel.org/lkml/6bb8c25c-cdcf-8bca-3db2-9871a90d518f@kernel.dk/T/#m52d98b6bdb05764524a118b15cec048b34e5ca76 > > with a tentative approval for the patch : > https://lore.kernel.org/lkml/6bb8c25c-cdcf-8bca-3db2-9871a90d518f@kernel.dk/T/#m24c2888a879d428cde5b34c43838301de544eb7e Andrew, I've hit this multiple times on resume on my laptop, and it's a very apparent bug in that b9d02f1bdd98 commit that it doesn't factor in error pointers. My oops clearly shows it being one too, with ...fff4 being the dereference address. Can we get this pushed upstream asap if you're fine with this patch? -- Jens Axboe