From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42CA8C25B76 for ; Thu, 6 Jun 2024 02:28:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8F5D6B00A4; Wed, 5 Jun 2024 22:28:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3E706B00A5; Wed, 5 Jun 2024 22:28:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B07006B00A6; Wed, 5 Jun 2024 22:28:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 851576B00A5 for ; Wed, 5 Jun 2024 22:28:28 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 258A9A135E for ; Thu, 6 Jun 2024 02:28:28 +0000 (UTC) X-FDA: 82198879896.18.2E82A9B Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf25.hostedemail.com (Postfix) with ESMTP id 56BB3A0004; Thu, 6 Jun 2024 02:28:25 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717640906; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6ncrssdRttalH2BSyc6mhpZ9Opxjb8hT42/0leQCs24=; b=spSqveQD8qu+BdLO6FodZ/3Pkx2P7xRQCfKCGyxxBobgSV1nY4iAFqh+o/OEzhYW+JhJz3 Vj/k1ZSfDBJ5bIb2P2pKTRwIqOJx8voyCcUhbCX3ljOWshxwLAO5yKLtUxprevG5gpJ5aw cS8H7X/MCu90ZOKQn6E8IlfXW8dNoo0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717640906; a=rsa-sha256; cv=none; b=Qmlp96xxAVDaTLxtCKMNO+Gv5h44giDJnAkTavhsxDIjmEiE31rvKj29ej2U9O939h94mn /uOms9poj0gt4XAhqApWaqhlds6lVtjfl7+8SlDzEB5hBI8ZtxZSqrqGaKOBt1nzQpLMf3 Rz7FFHgmVNY0l9gPkVv+evdnP8XWVhg= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Vvp7z5VqkzPp4B; Thu, 6 Jun 2024 10:25:03 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id D419D180085; Thu, 6 Jun 2024 10:28:21 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 6 Jun 2024 10:28:21 +0800 Subject: Re: [PATCH v4 1/6] mm: move memory_failure_queue() into copy_mc_[user]_highpage() To: Kefeng Wang , , CC: Tony Luck , , Matthew Wilcox , David Hildenbrand , Muchun Song , Benjamin LaHaise , , Jiaqi Yan , Hugh Dickins , Vishal Moola , Alistair Popple , Jane Chu , Oscar Salvador , Lance Yang References: <20240603092439.3360652-1-wangkefeng.wang@huawei.com> <20240603092439.3360652-2-wangkefeng.wang@huawei.com> From: Miaohe Lin Message-ID: <628018e2-9a47-ff17-cd97-95085e7b6714@huawei.com> Date: Thu, 6 Jun 2024 10:28:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240603092439.3360652-2-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspam-User: X-Stat-Signature: rtyu3now4u7okj95zdgyg1f83bqcn8wc X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 56BB3A0004 X-HE-Tag: 1717640905-92302 X-HE-Meta: U2FsdGVkX19kuTmOkwLzq90YhJ67ZAohWZLv9D7FDdAAbd7P95fBsUA42M0bICpe6ZhyJvagrHcs3h8837IqPBILxp9raXENGmdJ3mFgOabqEemEeOg8AQf6QW0jB+70QXTWwPAsZ44F7pCR9JDXUnV+LmcIcQnmqUSbCg02sZmD8NPq9WVkyL5oRLwYgSjaDDaA7rvHlfHgXpSZbET1iYX3QdxW+w2PppcnDpkGRcuVKmcchg1Wax+Pq5uq7QLxdvhEiyn2KlLJ8K4WtcKpfQZdPv4g1x9X5gPR6Uy6a+uGCXlBDppoVsf+WW25+NrZiRTiEHNmV/mELvTLqkv5wUlXo+P5E8rtSWTU/PpZkPQiwFSIHUGEHaPP3z0shjmjpRBdWtRHqiEF8wjNG0CokoR9LNaIUxgEU2nNqWCdfx8Y40UleIG5Tosms2gU4npdzP5eJ6NhwOthwITwIHAVc9jtqa/wJgFhlKz66obCVC05z8hJWkoCGWjo5IGPDph3W01j9gO1Ll27Jpgoqwv0mGkCIQRDiwHHSDbUpygC4+oUC2Te6p35p9HybNtT6DCHi+Dr4Kq1QQr4mo8Hg7OYear0CpAtPFkwVZpJJV0L1TVpIOvCB4TTHQg+Jj7aSqfyMypcAUVgWv/kyGSFV8pz0U9m14tAsTTzjb+slbXYqhpbFKYl9+69Gjyf9uClIJanE0Jq6STckwarM50jTtGNWmyizF+VdvovPinPc989AUB/dS7yjEvOrc4OzkL3umWFI1+fS5sIWsCB+rfa9jOKddGHbjs7JF8n0L8MLl7qHdDbfTNOmAIKZqJUQDXfyLHS/QGthR67bG735lng1m4TrbmeLExxNHWZnkfCHNQVBpJP/wOo63v9vVEDGGue4EFnBFK+PwsxDZlJCTS/h5sthm7cjy6pQ4LEbCCzXYHRxLw4zsM910z/M2tQvPYAPI7lyaqcoCpfyW30JGjt7UP iVBpWr4w tAiv25ki3gIvXprO0+PINXkrS23/UAl5ZDFGz6kr1XI7cEUIhhFepGLVVzNop9hTlwWvJwMvEqD8UBc+OKmS7pqhOxweFwkNmPwKvIE1d6NgPufiNISTtIC5OLqywwm3k9Dk+QuqaSa73EkThQxYhwT69T7bdfNCQqkJzUuYHzWZHKRiVFeWmIVTOtFM3bGZ7f7aIv6STv+D2VLwiw3UaEGVsKzdBDZ9fdG7pz/OG7I7eFiiBl5QBA+BZLhxiyiq1u1PoyL5Kw6NwJsx0Pn+DOd7QbA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/3 17:24, Kefeng Wang wrote: > There is a memory_failure_queue() call after copy_mc_[user]_highpage(), > see callers, eg, CoW/KSM page copy, it is used to mark the source page > as h/w poisoned and unmap it from other tasks, and the upcomming poison > recover from migrate folio will do the similar thing, so let's move the > memory_failure_queue() into the copy_mc_[user]_highpage() instead of > adding it into each user, this should also enhance the handling of > poisoned page in khugepaged. > > Signed-off-by: Kefeng Wang LGTM. Thanks. Reviewed-by: Miaohe Lin Thanks. .