From: Miaohe Lin <linmiaohe@huawei.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>,
<akpm@linux-foundation.org>, <linux-mm@kvack.org>
Cc: Tony Luck <tony.luck@intel.com>, <nao.horiguchi@gmail.com>,
Matthew Wilcox <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
Muchun Song <muchun.song@linux.dev>,
Benjamin LaHaise <bcrl@kvack.org>, <jglisse@redhat.com>,
Jiaqi Yan <jiaqiyan@google.com>, Hugh Dickins <hughd@google.com>,
Vishal Moola <vishal.moola@gmail.com>,
Alistair Popple <apopple@nvidia.com>,
Jane Chu <jane.chu@oracle.com>,
Oscar Salvador <osalvador@suse.de>,
Lance Yang <ioworker0@gmail.com>
Subject: Re: [PATCH v4 1/6] mm: move memory_failure_queue() into copy_mc_[user]_highpage()
Date: Thu, 6 Jun 2024 10:28:20 +0800 [thread overview]
Message-ID: <628018e2-9a47-ff17-cd97-95085e7b6714@huawei.com> (raw)
In-Reply-To: <20240603092439.3360652-2-wangkefeng.wang@huawei.com>
On 2024/6/3 17:24, Kefeng Wang wrote:
> There is a memory_failure_queue() call after copy_mc_[user]_highpage(),
> see callers, eg, CoW/KSM page copy, it is used to mark the source page
> as h/w poisoned and unmap it from other tasks, and the upcomming poison
> recover from migrate folio will do the similar thing, so let's move the
> memory_failure_queue() into the copy_mc_[user]_highpage() instead of
> adding it into each user, this should also enhance the handling of
> poisoned page in khugepaged.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
LGTM. Thanks.
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Thanks.
.
next prev parent reply other threads:[~2024-06-06 2:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 9:24 [PATCH v4 0/6] mm: migrate: support poison recover from migrate folio Kefeng Wang
2024-06-03 9:24 ` [PATCH v4 1/6] mm: move memory_failure_queue() into copy_mc_[user]_highpage() Kefeng Wang
2024-06-04 19:38 ` Jane Chu
2024-06-06 2:28 ` Miaohe Lin [this message]
2024-06-03 9:24 ` [PATCH v4 2/6] mm: add folio_mc_copy() Kefeng Wang
2024-06-04 19:41 ` Jane Chu
2024-06-05 3:31 ` Andrew Morton
2024-06-05 7:15 ` Kefeng Wang
2024-06-06 2:36 ` Miaohe Lin
2024-06-03 9:24 ` [PATCH v4 3/6] mm: migrate: split folio_migrate_mapping() Kefeng Wang
2024-06-06 0:54 ` Jane Chu
2024-06-06 1:24 ` Kefeng Wang
2024-06-06 1:55 ` Matthew Wilcox
2024-06-06 2:24 ` Kefeng Wang
2024-06-06 18:28 ` Jane Chu
2024-06-03 9:24 ` [PATCH v4 4/6] mm: migrate: support poisoned recover from migrate folio Kefeng Wang
2024-06-06 21:27 ` Jane Chu
2024-06-06 22:28 ` Jane Chu
2024-06-06 22:31 ` Jane Chu
2024-06-07 4:01 ` Kefeng Wang
2024-06-07 15:59 ` Jane Chu
2024-06-03 9:24 ` [PATCH v4 5/6] fs: hugetlbfs: support poison recover from hugetlbfs_migrate_folio() Kefeng Wang
2024-06-06 23:30 ` Jane Chu
2024-06-03 9:24 ` [PATCH v4 6/6] mm: migrate: remove folio_migrate_copy() Kefeng Wang
2024-06-06 23:46 ` Jane Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=628018e2-9a47-ff17-cd97-95085e7b6714@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=bcrl@kvack.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=ioworker0@gmail.com \
--cc=jane.chu@oracle.com \
--cc=jglisse@redhat.com \
--cc=jiaqiyan@google.com \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=nao.horiguchi@gmail.com \
--cc=osalvador@suse.de \
--cc=tony.luck@intel.com \
--cc=vishal.moola@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox