From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49360C369DC for ; Wed, 7 May 2025 04:09:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B27326B0085; Wed, 7 May 2025 00:09:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD5896B0088; Wed, 7 May 2025 00:09:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99C226B0089; Wed, 7 May 2025 00:09:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7B14D6B0085 for ; Wed, 7 May 2025 00:09:45 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E471780FFE for ; Wed, 7 May 2025 04:09:46 +0000 (UTC) X-FDA: 83414783172.22.6456D38 Received: from smtpbg151.qq.com (smtpbg151.qq.com [18.169.211.239]) by imf09.hostedemail.com (Postfix) with ESMTP id C475F140002 for ; Wed, 7 May 2025 04:09:43 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=uniontech.com header.s=onoh2408 header.b=LoVqvPim; dmarc=pass (policy=none) header.from=uniontech.com; spf=pass (imf09.hostedemail.com: domain of wangyuli@uniontech.com designates 18.169.211.239 as permitted sender) smtp.mailfrom=wangyuli@uniontech.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746590985; a=rsa-sha256; cv=none; b=H7pDP07kvdegs18PFE50iNGP7ziFWejH2/92j+bJlrY2FbhJvSLW1b1FO5XLvcwAYTU9Fq C+QweBPVUbgmFolnJCNs6+8FkO/qIDPpT72bIpiyTmThwmUBkHZ0Rw8ppXgLR5GogcQMca l5oOz7/AIp30MyUlGkWySCk0SoMg8no= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=uniontech.com header.s=onoh2408 header.b=LoVqvPim; dmarc=pass (policy=none) header.from=uniontech.com; spf=pass (imf09.hostedemail.com: domain of wangyuli@uniontech.com designates 18.169.211.239 as permitted sender) smtp.mailfrom=wangyuli@uniontech.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746590985; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=0UBymo+iMIc663dB1EDx9nPxjNeHkJAjxl2DM+9FhmA=; b=njqJDQskInzjW9J2/zNC/1V3tiV66g611hlfkm7VE0hGjt7nKfcES2CPW0KrFtuoIjeAHU hAc0k9lFcgAaKQOz/ji3xY//iThnqFtwUtR7AOcKaEiKs5XLZCLQiOSSR30o3XXEW/EpRU NzZbGf84ebir2SqRZB75Lso10V2gLcY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uniontech.com; s=onoh2408; t=1746590947; bh=0UBymo+iMIc663dB1EDx9nPxjNeHkJAjxl2DM+9FhmA=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=LoVqvPim+VCjow7Tkm2+6OabOztpLuIBTcrkwQSuTk2pE354Z1i/GxWIBe4Z/BgCK vW42U5fmHEummChaENoGMHS3KGjGTKsRS060r+Lntkgn7P3eVNj6xhqMqCxqkhAVY2 zihkFc/fr/cKVpVPXmChOoM8IF6pa1GAF2+wyXSI= X-QQ-mid: zesmtpip4t1746590937t0e9125dd X-QQ-Originating-IP: CFL0yyIMidvb1K9q1fi7a3G0oTrOrKkYM2TbwA5kxo0= Received: from localhost.localdomain ( [localhost]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 07 May 2025 12:08:55 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 1 X-BIZMAIL-ID: 1585881770139576930 EX-QQ-RecipientCnt: 11 From: WangYuli To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, yuzhao@google.com, stevensd@chromium.org, kaleshsingh@google.com, zhanjun@uniontech.com, niecheng1@uniontech.com, guanwentao@uniontech.com, WangYuli , Matthew Wilcox Subject: [PATCH v2] mm: vmscan: Avoid signedness error for GCC 5.4 Date: Wed, 7 May 2025 12:08:27 +0800 Message-ID: <62726950F697595A+20250507040827.1147510-1-wangyuli@uniontech.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpip:uniontech.com:qybglogicsvrgz:qybglogicsvrgz8a-1 X-QQ-XMAILINFO: MyIXMys/8kCtiHRYgmzCZg4Yg61lnJO9jtV35WWd/JK2V1thZpQ3bc1j ZNKp+VmeEOuqowEAOHhUeZ1ff1uy+jLR9cPMT5g2ZPvIOyBjb7G8hLwvBtruBDlwtMVIvn2 6hkIbyKHbhsCa81V6toWeugh+qZei4t5XDATLKGDiLu8I/gVN3nVp6AaSGXxr7exVgQxlIy UMlI8yC/gNjNYntVUF09c0G3Xb3ne6SUBr761+o7qfiXRiC7GXc/jcgWZ/VZ6qr9RBMtOrg cUsqk6tbZrx1kV8xZ20xb0KfFEn1zovPMkOOb4S+8WoUva2gxbf6ULjLx+mONa7zMN2ONda lL8VMlouPMUCN17uGAdOkEW3UvWS/RJkhLctrZSNXZTM0ePS2BjSvoZm35lIsc324hdJqA6 oEc8icIm72WBokJBDOERu25T70zq37Vit1hZX+cdo1yggxESjCi97g7RGsGmnykd1EJrLBp FDnpKgUGQ7xfngnesgx7Y1PkaRkEPiFCX7LpTUexJWqQEfdF/QFROj2M86pNe2S1vmYGXN9 jjm9QxK2cRIVcFQKJTBgEJFF+unSt3mizY3PQrFFMzb8OI1+t1QXrdrwEZIYmgK1HAEzCAk /oajbHTfaCtOM7TiE3fym4Vt9OGJHy0+jznG5A7aWd54+5TJjGHk5pF2DZKIJSj8Z8aDGym RZ63+JjyXGWnecs7OUUAvYHuexFlZTNkG/sieGUQsKWXZGLYNdu7e+0Zrualf8qi5I/Rn2g AFXDYoXcySXn4qMArA8qWyUI20o0xVN4dz4uRwJmivL+zg6HafDO1SqeOuquy3Wn5uKDQC3 VqV+MK5JVFuBWh3SsqznRKMxoHLMl8fd6v/1jnxYqIp9t5m4KFBtQwz7N73BA/xF8xyL3Jh AC5fr96kOfF6Rzj/licoMtYSSPaBhCGQnJTZmTwGK5ebyUpOdEgueWRaD9Lakfib6aluljC Rrc08F5Imu8nFmDtaYNxTHU8CLIl8kpf0JZr/2Pr1sFmacjhn4k6b7PVp2Ku9f29DxyGjGF etQrihm60XnhsF9F2WCredFN68YWRewFxc+8EHUQ== X-QQ-XMRINFO: NS+P29fieYNw95Bth2bWPxk= X-QQ-RECHKSPAM: 0 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: C475F140002 X-Stat-Signature: mkso3511qh35g9gs8cjoorj8do1cjdme X-Rspam-User: X-HE-Tag: 1746590983-878996 X-HE-Meta: U2FsdGVkX19XRPalmGIdw4ffGVvxRXRyVA4Hn7hR77Yv457cOL92sSrdt2WtID2dAnffMTs2tCQn1Tmc2RNm/92pzirWvpZ91MQM+UY3pAsquwt0a4Z81EcgnPfTIUf++YgcyuHhj5gEnuzyTSGkBaQNRsAfB1VcuDi8mBfBJhkq54pbL9XwMGiiP8LDAZKXuZGmssapkfNLHxQedx9v+wczQsZs8OUfAEENqqJzK74QGuoI2EH7BHek/Q2DNiOYlTQCiPK40078nLdE7VAsGoA4ufNKb95q83TGxjkfQ2FvodGngRYIJOjtc38nJ5k5C18psueKonHQ1xTUVM+7dwhl9mubgv2ABshSmIDXkKS0wDuviYWdD85lKa6zA7TPOmChlzuRBYf4raP9o1mSGHJZV4x2pdn0toaHI1ARirgxb4X5ndMIQWzOt+mJpj43GV88L61TD1E8isl40+bQNXe3MAIY10KMAGecRnvvTUld1Doa5cLCwcwWcNZOq3u0eUNT7XRd+6XOe1cyGUjBap/iYwtwpUFeIYjSgkSrhkuvDz4BWm0zawrV2PKGBHPCA/U5/Ca9Fl1wGf6FbACAMijh4fQeG9280RGzK1IoisJVrBTRIi0M0gKmono3S9c15BWMlxFeHLKxYXaBEupj5mYCI+7pN0elFay2cqdwFObwsW4WjAHSbZ1LSVUDIVcuPyx5aXphJr7mFhtMrEWY16GCOnp4C+wExx7w96gOwYPRLTPHDSM8QcMg/WuDQgm4e5ux2gZeqyDCBjdR//dzlgpbgp+8ohOskVNuGH5EK0flmVfep42//6lt+ziRyu8Wdywr6hJM5xi7+2fv2foam+2WDlBSk9EpwgBddi6idsGbDsPmPaua9XGIFCL+0R1tg9ZWbtEqBiqalsoH+GuARmzv9AyZ2knW5rqt37bjcyL9IbC2Fxgc2H22KJ0w2cVri4GdK30OPMofKSvtB2V V6vLHjre kE/VrSKlpr0zvLVFjrcnuPtANZvEDPx8ozP323STQx2AI5PkgbFuSIaGk91+PwpDVcW05Atlw1P3YLS2XrlBU7i31UBGN8/56DklzBObP6/e4j273N9HKMcdMZ7BnlVhRy0qSB2ESYlWoABT1jCS9z3x3LjKWvLHxb1i4v2A53rJCt08nFfeqXOrlVUxkNonNRczQE4jHSoSWuajN4rCR/S+wInJax1Nj3rTOSEcspzU9ek1v16KW+9LNG9eaCmNxOXKRJmZWKmic3brpzMEJQcvgsaOa3C/DK0O+ElUrF9tWtWnLp2HGdWNFvvT2YZES85tdICsN21gPlEhERlxR8jeqmnv3Ev1bCrNFgH99OelTh0hFZd45VQ4teh/5VtuIyBGqyCeZUuTzDbVP2RChR2TttQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: To the GCC 5.4 compiler, (MAX_NR_TIERS - 1) (i.e., (4U - 1)) is unsigned, whereas tier is a signed integer. Then, the __types_ok check within the __careful_cmp_once macro failed, triggered BUILD_BUG_ON. Use min_t instead of min to circumvent this compiler error. Fix follow error with gcc 5.4: mm/vmscan.c: In function ‘read_ctrl_pos’: mm/vmscan.c:3166:728: error: call to ‘__compiletime_assert_887’ declared with attribute error: min(tier, 4U - 1) signedness error Cc: Matthew Wilcox Fixes: 37a260870f2c ("mm/mglru: rework type selection") Signed-off-by: WangYuli --- Changelog: *v1->v2: 1. Fix commit msg. 2. Use min_t instead of min. --- mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 3783e45bfc92..8d9a82621c4f 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3163,7 +3163,7 @@ static void read_ctrl_pos(struct lruvec *lruvec, int type, int tier, int gain, pos->gain = gain; pos->refaulted = pos->total = 0; - for (i = tier % MAX_NR_TIERS; i <= min(tier, MAX_NR_TIERS - 1); i++) { + for (i = tier % MAX_NR_TIERS; i <= min_t(int, tier, MAX_NR_TIERS - 1); i++) { pos->refaulted += lrugen->avg_refaulted[type][i] + atomic_long_read(&lrugen->refaulted[hist][type][i]); pos->total += lrugen->avg_total[type][i] + -- 2.49.0