From: WangYuli <wangyuli@uniontech.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
yuzhao@google.com, stevensd@chromium.org, kaleshsingh@google.com,
zhanjun@uniontech.com, niecheng1@uniontech.com,
guanwentao@uniontech.com, WangYuli <wangyuli@uniontech.com>,
Matthew Wilcox <willy@infradead.org>
Subject: [PATCH v2] mm: vmscan: Avoid signedness error for GCC 5.4
Date: Wed, 7 May 2025 12:08:27 +0800 [thread overview]
Message-ID: <62726950F697595A+20250507040827.1147510-1-wangyuli@uniontech.com> (raw)
To the GCC 5.4 compiler, (MAX_NR_TIERS - 1) (i.e., (4U - 1)) is
unsigned, whereas tier is a signed integer.
Then, the __types_ok check within the __careful_cmp_once macro failed,
triggered BUILD_BUG_ON.
Use min_t instead of min to circumvent this compiler error.
Fix follow error with gcc 5.4:
mm/vmscan.c: In function ‘read_ctrl_pos’:
mm/vmscan.c:3166:728: error: call to ‘__compiletime_assert_887’ declared with attribute error: min(tier, 4U - 1) signedness error
Cc: Matthew Wilcox <willy@infradead.org>
Fixes: 37a260870f2c ("mm/mglru: rework type selection")
Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
Changelog:
*v1->v2:
1. Fix commit msg.
2. Use min_t instead of min.
---
mm/vmscan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 3783e45bfc92..8d9a82621c4f 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -3163,7 +3163,7 @@ static void read_ctrl_pos(struct lruvec *lruvec, int type, int tier, int gain,
pos->gain = gain;
pos->refaulted = pos->total = 0;
- for (i = tier % MAX_NR_TIERS; i <= min(tier, MAX_NR_TIERS - 1); i++) {
+ for (i = tier % MAX_NR_TIERS; i <= min_t(int, tier, MAX_NR_TIERS - 1); i++) {
pos->refaulted += lrugen->avg_refaulted[type][i] +
atomic_long_read(&lrugen->refaulted[hist][type][i]);
pos->total += lrugen->avg_total[type][i] +
--
2.49.0
next reply other threads:[~2025-05-07 4:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 4:08 WangYuli [this message]
2025-05-07 20:40 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62726950F697595A+20250507040827.1147510-1-wangyuli@uniontech.com \
--to=wangyuli@uniontech.com \
--cc=akpm@linux-foundation.org \
--cc=guanwentao@uniontech.com \
--cc=kaleshsingh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=niecheng1@uniontech.com \
--cc=stevensd@chromium.org \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox