From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 902B0C369A0 for ; Wed, 25 Sep 2024 06:51:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDC2E6B007B; Wed, 25 Sep 2024 02:51:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8C976B0082; Wed, 25 Sep 2024 02:51:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C53386B0083; Wed, 25 Sep 2024 02:51:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id ADAA26B007B for ; Wed, 25 Sep 2024 02:51:06 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 308F2120994 for ; Wed, 25 Sep 2024 06:51:06 +0000 (UTC) X-FDA: 82602338532.25.6F56A95 Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf13.hostedemail.com (Postfix) with ESMTP id 26D5920003 for ; Wed, 25 Sep 2024 06:51:02 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=csgroup.eu; spf=pass (imf13.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727246975; a=rsa-sha256; cv=none; b=qdb0OR2TQYCGXkroJx2WIHE9Z6QBAcjTqYmc2mEfNxqU15zZxLRiUyzqfRCwcA8hQpSHqB 8MnxnfWuKeVtMmhltjdtqM+o0OITcYZkce6hPH4STwye4VTkCCfVd/4/XJTfVh7vwDQ64t ZaygWTwyIOWLD48K9Ax/gLZyKxlIhRw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=csgroup.eu; spf=pass (imf13.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727246975; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wFV+tDwt3ETJ5tvYgo/j+xGJT0xQ3fcCPT4Lpi1UAMQ=; b=70tQskjhjmtTcQbdrPYx0IXXu0EOgGi/qDKvD15wysIj/ir6gGNLI2FYKQo+96YkEt2gdt 0mpOY9T3nYrKt7m92AZLVSgCNBx2xRf/HjRtpKXbSQzaVDiIAIKVd52BMOiukOvPjBThUi PTZAEdEAYm9cGt0oin2txe4tqh5CgmE= Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4XD6nd28lPz9sSK; Wed, 25 Sep 2024 08:51:01 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wiveKoQOCT17; Wed, 25 Sep 2024 08:51:01 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4XD6nd1JXyz9sRs; Wed, 25 Sep 2024 08:51:01 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 1A0E88B76E; Wed, 25 Sep 2024 08:51:01 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id qdW7TkhX9VjY; Wed, 25 Sep 2024 08:51:01 +0200 (CEST) Received: from [192.168.232.90] (PO27091.IDSI0.si.c-s.fr [192.168.232.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 4444C8B763; Wed, 25 Sep 2024 08:51:00 +0200 (CEST) Message-ID: <626baa55-ca84-49ba-9131-c1657e0c0454@csgroup.eu> Date: Wed, 25 Sep 2024 08:51:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/8] x86: vdso: Introduce asm/vdso/mman.h To: Vincenzo Frascino , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Cc: Andy Lutomirski , Thomas Gleixner , "Jason A . Donenfeld" , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Theodore Ts'o , Arnd Bergmann , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers References: <20240923141943.133551-1-vincenzo.frascino@arm.com> <20240923141943.133551-2-vincenzo.frascino@arm.com> Content-Language: fr-FR From: Christophe Leroy In-Reply-To: <20240923141943.133551-2-vincenzo.frascino@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 26D5920003 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 6twdgw43u5hrup6wyuskyo1ap4hese35 X-HE-Tag: 1727247062-648782 X-HE-Meta: U2FsdGVkX19zcuPEqQUPT2+9pXvbboLkznn0p7FQq8aBfey1x+zFc3+5BiMa1XxNlDQ5BA7VJZ5ccQH5cjRPGQNv3iqRR8lQoau5fmvQpSdp2Zz9GopRRX/ApBqdvzz3VM8s03hs9ANV6fW0xtrrC7Ln51eJap7Th0xGhd42rfqMjOG6qW5Gpo7acOJj9yezkxcOiUIkj0Moo65s8WJzUXqslj4MePpg/2nfZ8C4wm/H+hEuwkZznONsBoMIiSXzDPIiUYyiex5dmGVgXvbOHZlrkIC5pJ2vibrSEgjc9zAGE0FnBtbtbhGFLfAAYK3bbSrJM4WeefScaGj90JRhdYPDFz/SXq63PfiMYelK2StyR2SKfWte4B8R3TW3Hs3Yskh8xkpz3C8ezZY/KC8hFJDX0677CTBzm1MAgZ9cfUFR3Kaf8vj8elERwzkT00oIlg83kILKXGXjqWQ6rk+PP4wlLfuanmRP2PImbIRMCN4HZVZhBBM7LK1P05j2av/TNp4NxxVoQv4J66jKdzsX5foXsC+Wnj7hUm0f3uV8Kx6aZsGb0hYIwZez4q5QaYAsR1EJudo/GJ7LE2FAg8/jOcJbCLPPwQNI00PaQW/dk9VlW29ekG7/JppI7p0zOei19RZPw6RDEW6XWkD1AcKEbAv0ojJoFa6SqWjEc7+MInm7IsvY6kHFNXQbqMMmDhlXA2Y3z2uC2cCIihmco9WhgZgse5nqDZPaPF4d4C1/yvLjaLi9YE9nlr6jPtVcGcJqKCfbk6TGGRBd4tLK17h2ubJ/WAm0FnbPUmoh6ThXP9fKq+5KJxSoOlZzC8WAKX17+2KoXAYQIpDwnZ//3v+RtaXhWvWSqgPybTBab88mNfUb1DWKQAIPs0QdHAqiB0Zk0W12alU+ZEv/yvbqetpFdwgvIc1a+MqnU3xekkZiuYiELmhvz6k6VjWif8jAfvpqf9LhgDU+lCvPnxkITHP ZREM5tjc IVH5k8ShXFgi0FAZTvwxsYMmgzz1Oy6o1kXk9zH1xek4flB0iwoKWNkj4d/7d58OAsr5q01/Xo03R4cbVE4Ysh/Lnnc5xKc0ctYkTqELjZ0MYIrHKk8MC8k7FFBU2CeZUKxbs611zNssJ/El6zWieOporLrALIutCar29ObNCZUXGxdJWBzW0qWjF12/qBayUz0wjrfdGVK9TGk8Z4LiO/9ieWe4l6NaQ7WR3GCZ0Iwi6TCRPLwic63EtKHzr9cNVMoCNd44YBoTCbdu5xRdtq+XSbvj4yAw8joTx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Le 23/09/2024 à 16:19, Vincenzo Frascino a écrit : > The VDSO implementation includes headers from outside of the > vdso/ namespace. > > Introduce asm/vdso/mman.h to make sure that the generic library > uses only the allowed namespace. > > Cc: Andy Lutomirski > Cc: Thomas Gleixner > Cc: Jason A. Donenfeld > Signed-off-by: Vincenzo Frascino > --- > arch/x86/include/asm/vdso/mman.h | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 arch/x86/include/asm/vdso/mman.h > > diff --git a/arch/x86/include/asm/vdso/mman.h b/arch/x86/include/asm/vdso/mman.h > new file mode 100644 > index 000000000000..4c936c9d11ab > --- /dev/null > +++ b/arch/x86/include/asm/vdso/mman.h > @@ -0,0 +1,15 @@ > + > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef __ASM_VDSO_MMAN_H > +#define __ASM_VDSO_MMAN_H > + > +#ifndef __ASSEMBLY__ > + > +#include > + > +#define VDSO_MMAP_PROT PROT_READ | PROT_WRITE > +#define VDSO_MMAP_FLAGS MAP_DROPPABLE | MAP_ANONYMOUS I still can't see the point with that change. Today 4 architectures implement getrandom and none of them require that indirection. Please leave prot and flags as they are in the code. Then this file is totally pointless, VDSO code can include uapi/linux/mman.h directly. VDSO is userland code, it should be safe to include any UAPI file there. Christophe > + > +#endif /* !__ASSEMBLY__ */ > + > +#endif /* __ASM_VDSO_MMAN_H */