From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48448C02198 for ; Mon, 10 Feb 2025 09:24:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 747B46B0085; Mon, 10 Feb 2025 04:24:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F8476B0088; Mon, 10 Feb 2025 04:24:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 599006B0089; Mon, 10 Feb 2025 04:24:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3DE246B0085 for ; Mon, 10 Feb 2025 04:24:05 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E0F2D1A088D for ; Mon, 10 Feb 2025 09:24:04 +0000 (UTC) X-FDA: 83103498408.11.659CFF4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 815481C000F for ; Mon, 10 Feb 2025 09:24:02 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Eb/brCx1"; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739179442; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UwcXqeIhV/s1vnE/HqxmZgkHKfi+VWdlt1zliVHj5TQ=; b=W9ssoUjWZJvNF8DmCLIvABg6DIH8k1NTpuipT5qz8z5sv8TGiPVODQWM81KK7LnZZYTtpJ Tmuzk72y2diF60xiBsAoafTQfIi4jYuwMDD09xPF7p+C2F4UlVQujkFNitB9Kk7Fx1EjP1 iwRIjuivlMPM8XHvAzhrRUjxrr3jixc= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Eb/brCx1"; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739179442; a=rsa-sha256; cv=none; b=8IArzNg5Kfrt786empYotkT5o0kZFQ4YRmPWb87GfSdNrdhBOqJISE+jx5dZyXPg/zGpsz m+oHcH2zcH3ZXYrHzY1+tPKUO9WeGn0oSZ4maGunQLY1VrgmFACQ6UwDxYVCz6+H23q/Eh iBBAuK6nXGxYw+J8kbK6CFbYM/P6fcI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739179441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UwcXqeIhV/s1vnE/HqxmZgkHKfi+VWdlt1zliVHj5TQ=; b=Eb/brCx1+a3qa0yqgV1hXwhOJE7AXdzvjnC3+OYI3xtG8EjE2wea7PyCPkzMNoXWeQZg1J 2fGyvRTKfxQJxpToOS/IFgpYbxrrZjSiPkNOkClnrpkQWbb5P1KmaAo/C1ClbF1Ngdz0em tyAev9fR3YwpusW63hAY9dpg1a/Es2E= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-570-JcvayGZBOlSjPogpksXC0Q-1; Mon, 10 Feb 2025 04:23:59 -0500 X-MC-Unique: JcvayGZBOlSjPogpksXC0Q-1 X-Mimecast-MFC-AGG-ID: JcvayGZBOlSjPogpksXC0Q Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-38dc6aad9f8so1501287f8f.1 for ; Mon, 10 Feb 2025 01:23:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739179438; x=1739784238; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UwcXqeIhV/s1vnE/HqxmZgkHKfi+VWdlt1zliVHj5TQ=; b=TcM7QkjR39vZ+XaekIn28SGq7+oowLjk+noqb0WlspPPOsotFF8HNS7Wt8MYv+w5T0 q2NUulT7GiWoar9XgvWk730uCYp+leT1B/ZkkB5UUoqPuVuaFu0JBXf4Y6zIRPb7EZ6y 3sgbO5etvUAgTE8uHWj3g2Yue9glf1JceBUzRujirWbS3VNuUNn0b1v9meB4O/dXUzoD pCrQIdI9wjkQ4WSvs0XkHWXGit1b5C7JiJkjrvS6+roY/fMImO7xPyiuFlCYH4hnifKQ O1FaqUTKbelgX7llY7nTUAnA+yJHfO7g5YkbxHwYcBK0R0INks1bX3NQcNTh85pNo9ri tpGA== X-Forwarded-Encrypted: i=1; AJvYcCUddBA3VyIgc6K/3UdFavp3FkqxHacPlCK+7zW7BtxN5j8N7Oj5uPGj7CIhQcWAFLkDNy8XqRfkmQ==@kvack.org X-Gm-Message-State: AOJu0Yye5sjGd37EatlqGBz+apRNM9TLc4vNGDOHxLHmTDNbCp5Bao+e uF23adzQhd6MaaMtt/pu5bmTEzsEOTrzn47DaF64RZS7med6JPphMpUkW8uIxgwpElw8nGKHw/d Dru9xJBJ8hebpJSBPOxl+9Jy2XasPd+xMKmVfheKDia/iDdEE X-Gm-Gg: ASbGncvCs3RFb0p39qEtOWg0ZF9DpNvBFG8G73/v3dexWmlx6uckbCrJD4bCzXL+oXz mXnzcaSqWrzwVC6rMSTVtQIDF4PYpxVakfUZRnW3yu5tucOc535VgsTUzBiavuWQJ2UeJdu9+qO dZkh52C/AEI1hysBtdgiXpc26iDQPDPiAnewHG62t6PCidJ9Ob0fyYdZe4N7f8DU2z0HxSHTthw euLFyo7XY5Ss484EQriu9WAPjw1mbKiJxdCPbUcr+veKk+MtaIpkwGsonNwcQ+Vn1vFb2HJWVEk Kg9IcXFLU7Zbdjbm5QMcXDLZPyabKkHntcKgclID4Mhcuu+7cwvt/wdl0KpYLOPr/gZ+anS1d+O WpIfo0UKPek2ryXSuRNowk4gXENII55mG X-Received: by 2002:a7b:c342:0:b0:42c:baf1:4c7 with SMTP id 5b1f17b1804b1-43912d150bbmr123252355e9.4.1739179438643; Mon, 10 Feb 2025 01:23:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IGhk3Pqop723/zySAwaM52VQqdPHjX/5n23EiWoaPZW+xlAIpKvjvjpgkMUmyvTjM1fIJmzbQ== X-Received: by 2002:a7b:c342:0:b0:42c:baf1:4c7 with SMTP id 5b1f17b1804b1-43912d150bbmr123251975e9.4.1739179438057; Mon, 10 Feb 2025 01:23:58 -0800 (PST) Received: from ?IPV6:2003:cb:c734:b800:12c4:65cd:348a:aee6? (p200300cbc734b80012c465cd348aaee6.dip0.t-ipconnect.de. [2003:cb:c734:b800:12c4:65cd:348a:aee6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4390db10b17sm172224995e9.34.2025.02.10.01.23.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Feb 2025 01:23:56 -0800 (PST) Message-ID: <62670dc0-216a-4e59-a6c1-889065efb529@redhat.com> Date: Mon, 10 Feb 2025 10:23:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm: Remove the access_ok() call from gup_fast_fallback(). To: David Laight , Andrew Morton , Linus Torvalds , linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org Cc: Jason Gunthorpe , Jan Kara , John Hubbard , Peter Xu , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov References: <20250209174711.60889-1-david.laight.linux@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250209174711.60889-1-david.laight.linux@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Nk7g34L_AC8XYeo52tqBglhafMGyBhb9hgmbzciiSIo_1739179439 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 815481C000F X-Stat-Signature: ui8echhckrqnt7w4dr3tf8eyizzfqm4z X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1739179442-748758 X-HE-Meta: U2FsdGVkX19M1w5qt81cnhYapZXnRVDkL7kTi07ZETRSpOBo13Rvxw6DS1n0BAslGPV4uHqby9xKmkmJaYXiIkzRQBEJSfZqT++0gFQ68r67yHkmLAjvruxPFDR8JwNzBjbsCsrvCb9cyyLAuHRHoFhQJXHfxadHNx80hiW4nMobR/vAJ2VdA4GNJFxiyTrWwB+0ENm1HnVVExWDlQXO4+Ip9NBCDBfWxyW9Oi421C8in8r3ULrenytrh9pmHgcFc13PNk8fpPht7s/mlWiFTnWkl/F5wNJD5m3Mlkr0q4P2FLC9dBMm0LBkQScsNBAoeRFmtmtB03+Ehr8sZKxQ2eXORnnWwaoznb4gQNcO5E0Mxy93XKjwMsct1+0Ly0Wm+k7eb5qi8X1ct+9uP+cL9L48agf/MXKBYmsTAh0H3OtYK+s2m9asLoUFldsxM3lmPdJd1UCRBm24y+gGVQ0XOev5Ky5I8cf3saas7WtfmNwhhd+KrzNamIyjM3VzYdikz4MihGCQRYAF8pCv5tCDf3PCjnLOLIh+7I9vG466CqRevPuS7MQPpC3tkohuQTDl2GDglaKYyjQAPABvg6mZCdaQ1+Bppkq7N6mxtUY1OCPo8DsEOArhaTo7ASYK/U0CbgIxuDKZeSUHm0AtzXkD+QcOX5QmiboQFHWfGXSeTTK1zKkj/7wvXXNC+I2bJaoy6tF0M9lNTQS0M5LXlktp+DWZBA91m+4MRkCkSh22pIcNNDRFna22EinbE6fSQC9oxVt8ccC9CEU52l//86raZmsoen9b9874WzEZvCDklAneSwD9JWv07f+5WM1XLwL9+hNprtl5E7Z1Q+Q/CWTl22JZdt8IQvLvxKJGuUuQ/fMn0YiUt/gkU686FJQo1xRs3d6kxUu7rQMfV70Xyt5nhpVzhn9J2Mv39VERkqBNRXD0HO9E3eYm7hwZGsGQaecV9H1r5Y3tvQuNbEXIwb0 60ahiceL V2SlP+9dPREW96UF4mtVX/kDErqtOCwxRxoceYcjY3gdNPrCiB4D3eMWuIqIqko8BG6AX/2c0Dmvuh6ZmO1F+x1+LzQYJwhX6pD6agwzBbbcdQWuuEt/I9TXMhzxHrmrV2tw8+RGHpnyM9rqT4KxXg6uwyqu86GgeL9r9gXgvQ5TdoErEyhlLRmUerVI98eYj9u6FrL31IlnKI7zfEABMhXh0DHsh5R460F6sOrIYq2DwWjFoM6PDYW4oi72Gly6jEIXzyXIRSiPi+BYFm4rLfnfvLUo/b1+AzbW5ZcDmE3kS4nf2H+M2kq/xynDPXYhoNPEh038G5DZvL1cpsq5l5NXsVtXRlUN81BVpAAMu8YAcPntx2VOdM+54cV4e97ZUiS9UJWSeW0RdmtlY3XSQX+hg8coNADsDSY98VS+Lk4b6Q8OxSGxPNgGPtvp1ZF5DxEbBXxUP6vQzFcQurE1+6aXtL7I5+JhrqIKNMjtn82MQmnZXf5Pp4mKY4YE/V2ou8tv1v8jVjbEqii5fclCENyXWtL69Mg43q8aJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.02.25 18:47, David Laight wrote: > Historiaclly the code relied on access_ok() to validate the address range. > Commit 26f4c328079d7 added an explicit wrap check before access_ok(). > Commit c28b1fc70390d then changed the wrap test to use check_add_overflow(). > Commit 6014bc27561f2 relaxed the checks in x86-64's access_ok() and added checkpatch.pl will correctly tell you about the wrongly quoted commit ids. E.g., ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("")' - ie: 'Commit 26f4c328079d ("mm: simplify gup_fast_permitted")' Apart from that Acked-by: David Hildenbrand <david@redhat.com> -- Cheers, David / dhildenb